36352 2010-03-19 01:28:29 -0700 Add basic "who-broke-it" command and revision -> broken builder association code 2010-03-19 01:42:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned oldest_to_newest 201778 0 eric 2010-03-19 01:28:29 -0700 Add basic "who-broke-it" command and revision -> broken builder association code 201779 1 51137 eric 2010-03-19 01:30:47 -0700 Created attachment 51137 Patch 201781 2 51137 abarth 2010-03-19 01:39:05 -0700 Comment on attachment 51137 Patch LGTM, except for the typo. Would be nice to have more testing. We need a model of the builder to work with. 201783 3 eric 2010-03-19 01:42:35 -0700 Committed r56231: <http://trac.webkit.org/changeset/56231> 51137 2010-03-19 01:30:47 -0700 2010-03-19 01:39:05 -0700 Patch bug-36352-20100319013046.patch text/plain 7157 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YWYzODEwLi41ODI2OTRlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTAtMDMt MTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBiYXNpYyAid2hvLWJyb2tlLWl0IiBjb21t YW5kIGFuZCByZXZpc2lvbiAtPiBicm9rZW4gYnVpbGRlciBhc3NvY2lhdGlvbiBjb2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjM1MgorCisgICAg ICAgIFRoZSAid2hhdC1icm9rZSIgY29tbWFuZCBwcmludHMgYnVpbGRlcnMgYW5kIHdoYXQgcmV2 aXNpb25zIHdlIHN1c3BlY3QKKyAgICAgICAgYnJva2UgdGhlbS4gIHdoby1icm9rZS1pdCBwcmlu dHMgcmV2aXNpb25zIGFuZCB3aGF0IGJ1aWxkZXJzIHdlIHN1c3BlY3QKKyAgICAgICAgdGhleSBi cm9rZS4gIFRoZSBzaGVyaWZmLWJvdCBuZWVkcyB0aGlzIHJldmlzaW9uIHRvIGJyb2tlbiBidWls ZGVyIG1hcHBpbmcKKyAgICAgICAgc28gdGhpcyBjaGFuZ2UgYWRkcyBpdCEKKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvYnVpbGRib3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tYW5kcy9xdWVyaWVzLnB5OgorCisyMDEwLTAzLTE5ICBFcmljIFNlaWRlbCAgPGVyaWNA d2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAg IFNpbXBsaWZ5IEJ1aWxkQm90IGNvcmUgYnVpbGRlciBjb2RlIGZvciBlYXNpZXIgcmUtdXNlCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1aWxkYm90LnB5IGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdC5weQppbmRleCBkNDQzZjhhLi43NDk0 NzhhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1aWxkYm90LnB5 CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnVpbGRib3QucHkKQEAgLTg3LDYg Kzg3LDE0IEBAIGNsYXNzIEJ1aWxkZXIob2JqZWN0KToKICAgICAgICAgICAgIGxvb2tfYmFja19j b3VudCArPSAxCiAgICAgICAgIHJldHVybiAoZ3JlZW5fYnVpbGQsIHJlZF9idWlsZCkKIAorICAg IGRlZiBzdXNwZWN0X3JldmlzaW9uc19mb3JfZ3JlZW5fdG9fcmVkX3RyYW5zaXRpb24oc2VsZiwg cmVkX2J1aWxkX251bWJlciwgbG9va19iYWNrX2xpbWl0PTMwKToKKyAgICAgICAgKGxhc3RfZ3Jl ZW5fYnVpbGQsIGZpcnN0X3JlZF9idWlsZCkgPSBzZWxmLmZpbmRfZ3JlZW5fdG9fcmVkX3RyYW5z aXRpb24ocmVkX2J1aWxkX251bWJlciwgbG9va19iYWNrX2xpbWl0KQorICAgICAgICBpZiBub3Qg bGFzdF9ncmVlbl9idWlsZDoKKyAgICAgICAgICAgIHJldHVybiBbXSAjIFdlIHJhbiBvZmYgdGhl IGxpbWl0IG9mIG91ciBzZWFyY2gKKyAgICAgICAgc3VzcGVjdF9yZXZpc2lvbnMgPSByYW5nZShm aXJzdF9yZWRfYnVpbGQucmV2aXNpb24oKSwgbGFzdF9ncmVlbl9idWlsZC5yZXZpc2lvbigpLCAt MSkKKyAgICAgICAgc3VzcGVjdF9yZXZpc2lvbnMucmV2ZXJzZSgpCisgICAgICAgIHJldHVybiBz dXNwZWN0X3JldmlzaW9ucworCiAKIGNsYXNzIEJ1aWxkKG9iamVjdCk6CiAgICAgZGVmIF9faW5p dF9fKHNlbGYsIGJ1aWxkX2RpY3Rpb25hcnksIGJ1aWxkZXIpOgpAQCAtMTg2LDExICsxOTQsMTAg QEAgY2xhc3MgQnVpbGRCb3Qob2JqZWN0KToKICAgICAgICAgcmV0dXJuIFtidWlsZGVyIGZvciBi dWlsZGVyIGluIGJ1aWxkZXJfc3RhdHVzZXMgaWYgc2VsZi5fbWF0Y2hlc19yZWdleHBzKGJ1aWxk ZXJbIm5hbWUiXSwgbmFtZV9yZWdleHBzKV0KIAogICAgIGRlZiByZWRfY29yZV9idWlsZGVycyhz ZWxmKToKLSAgICAgICAgcmV0dXJuIFtidWlsZGVyIGZvciBidWlsZGVyIGluIHNlbGYuYnVpbGRl cl9zdGF0dXNlcygpIGlmIG5vdCBidWlsZGVyWyJpc19ncmVlbiJdIGFuZCBzZWxmLl9pc19jb3Jl X2J1aWxkZXIoYnVpbGRlclsibmFtZSJdKV0KKyAgICAgICAgcmV0dXJuIFtidWlsZGVyIGZvciBi dWlsZGVyIGluIHNlbGYuY29yZV9idWlsZGVyX3N0YXR1c2VzKCkgaWYgbm90IGJ1aWxkZXJbImlz X2dyZWVuIl1dCiAKICAgICBkZWYgcmVkX2NvcmVfYnVpbGRlcnNfbmFtZXMoc2VsZik6Ci0gICAg ICAgIHJlZF9idWlsZGVycyA9IHNlbGYucmVkX2NvcmVfYnVpbGRlcnMoKQotICAgICAgICByZXR1 cm4gbWFwKGxhbWJkYSBidWlsZGVyOiBidWlsZGVyWyduYW1lJ10sIHJlZF9idWlsZGVycykKKyAg ICAgICAgcmV0dXJuIFtidWlsZGVyWyJuYW1lIl0gZm9yIGJ1aWxkZXIgaW4gc2VsZi5yZWRfY29y ZV9idWlsZGVycygpXQogCiAgICAgZGVmIGNvcmVfYnVpbGRlcnNfYXJlX2dyZWVuKHNlbGYpOgog ICAgICAgICByZXR1cm4gbm90IHNlbGYucmVkX2NvcmVfYnVpbGRlcnMoKQpAQCAtMjEyLDEzICsy MTksMjUgQEAgY2xhc3MgQnVpbGRCb3Qob2JqZWN0KToKICAgICAgICAgcmV0dXJuIHVybGxpYjIu dXJsb3BlbihidWlsZF9zdGF0dXNfdXJsKQogCiAgICAgZGVmIGJ1aWxkZXJfc3RhdHVzZXMoc2Vs Zik6Ci0gICAgICAgIGJ1aWxkZXJzID0gW10KICAgICAgICAgc291cCA9IEJlYXV0aWZ1bFNvdXAo c2VsZi5fZmV0Y2hfb25lX2JveF9wZXJfYnVpbGRlcigpKQotICAgICAgICBzdGF0dXNfdGFibGUg PSBzb3VwLmZpbmQoJ3RhYmxlJykKLSAgICAgICAgZm9yIHN0YXR1c19yb3cgaW4gc3RhdHVzX3Rh YmxlLmZpbmRBbGwoJ3RyJyk6Ci0gICAgICAgICAgICBidWlsZGVyID0gc2VsZi5fcGFyc2VfYnVp bGRlcl9zdGF0dXNfZnJvbV9yb3coc3RhdHVzX3JvdykKLSAgICAgICAgICAgIGJ1aWxkZXJzLmFw cGVuZChidWlsZGVyKQotICAgICAgICByZXR1cm4gYnVpbGRlcnMKKyAgICAgICAgcmV0dXJuIFtz ZWxmLl9wYXJzZV9idWlsZGVyX3N0YXR1c19mcm9tX3JvdyhzdGF0dXNfcm93KSBmb3Igc3RhdHVz X3JvdyBpbiBzb3VwLmZpbmQoJ3RhYmxlJykuZmluZEFsbCgndHInKV0KKworICAgIGRlZiBjb3Jl X2J1aWxkZXJfc3RhdHVzZXMoc2VsZik6CisgICAgICAgIHJldHVybiBbYnVpbGRlciBmb3IgYnVp bGRlciBpbiBzZWxmLmJ1aWxkZXJfc3RhdHVzZXMoKSBpZiBzZWxmLl9pc19jb3JlX2J1aWxkZXIo YnVpbGRlclsibmFtZSJdKV0KIAogICAgIGRlZiBidWlsZGVyX3dpdGhfbmFtZShzZWxmLCBuYW1l KToKICAgICAgICAgcmV0dXJuIEJ1aWxkZXIobmFtZSwgc2VsZikKKworICAgIGRlZiByZXZpc2lv bnNfY2F1c2luZ19mYWlsdXJlcyhzZWxmLCBvbmx5X2NvcmVfYnVpbGRlcnM9VHJ1ZSk6CisgICAg ICAgIGJ1aWxkZXJfc3RhdHVzZXMgPSBzZWxmLmNvcmVfYnVpbGRlcl9zdGF0dXNlcygpIGlmIG9u bHlfY29yZV9idWlsZGVycyBlbHNlIHNlbGYuYnVpbGRlcl9zdGF0dXNlcygpCisgICAgICAgIHJl dmlzaW9uX3RvX2ZhaWxpbmdfYm90cyA9IHt9CisgICAgICAgIGZvciBidWlsZGVyX3N0YXR1cyBp biBidWlsZGVyX3N0YXR1c2VzOgorICAgICAgICAgICAgaWYgYnVpbGRlcl9zdGF0dXNbImlzX2dy ZWVuIl06CisgICAgICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgICAgIGJ1aWxkZXIgPSBz ZWxmLmJ1aWxkZXJfd2l0aF9uYW1lKGJ1aWxkZXJfc3RhdHVzWyJuYW1lIl0pCisgICAgICAgICAg ICByZXZpc2lvbnMgPSBidWlsZGVyLnN1c3BlY3RfcmV2aXNpb25zX2Zvcl9ncmVlbl90b19yZWRf dHJhbnNpdGlvbihidWlsZGVyX3N0YXR1c1siYnVpbGRfbnVtYmVyIl0pCisgICAgICAgICAgICBm b3IgcmV2aXNpb24gaW4gcmV2aXNpb25zOgorICAgICAgICAgICAgICAgIGZhaWxpbmdfYm90cyA9 IHJldmlzaW9uX3RvX2ZhaWxpbmdfYm90cy5nZXQocmV2aXNpb24sIFtdKQorICAgICAgICAgICAg ICAgIGZhaWxpbmdfYm90cy5hcHBlbmQoYnVpbGRlcikKKyAgICAgICAgICAgICAgICByZXZpc2lv bl90b19mYWlsaW5nX2JvdHNbcmV2aXNpb25dID0gZmFpbGluZ19ib3RzCisgICAgICAgIHJldHVy biByZXZpc2lvbl90b19mYWlsaW5nX2JvdHMKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbWFuZHMvcXVlcmllcy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbWFuZHMvcXVlcmllcy5weQppbmRleCA4ZDg3ZmZjLi4yNWU1OTk2IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CkBAIC0x MDgsOSArMTA4LDcgQEAgY2xhc3MgUGF0Y2hlc1RvUmV2aWV3KEFic3RyYWN0RGVjbGFyYXRpdmVD b21tYW5kKToKIAogY2xhc3MgV2hhdEJyb2tlKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tYW5kKToK ICAgICBuYW1lID0gIndoYXQtYnJva2UiCi0gICAgaGVscF90ZXh0ID0gIlByaW50IHRoZSBzdGF0 dXMgb2YgdGhlICVzIGJ1aWxkYm90cyIgJSBCdWlsZEJvdC5kZWZhdWx0X2hvc3QKLSAgICBsb25n X2hlbHAgPSAiIiJGZXRjaGVzIGJ1aWxkIHN0YXR1cyBmcm9tIGh0dHA6Ly9idWlsZC53ZWJraXQu b3JnL29uZV9ib3hfcGVyX2J1aWxkZXIKLWFuZCBkaXNwbGF5ZXMgdGhlIHN0YXR1cyBvZiBlYWNo IGJ1aWxkZXIuIiIiCisgICAgaGVscF90ZXh0ID0gIlByaW50IGZhaWxpbmcgYnVpbGRib3RzICgl cykgYW5kIHdoYXQgcmV2aXNpb25zIGJyb2tlIHRoZW0iICUgQnVpbGRCb3QuZGVmYXVsdF9ob3N0 CiAKICAgICBkZWYgX2xvbmdlc3RfYnVpbGRlcl9uYW1lKHNlbGYsIGJ1aWxkZXJzKToKICAgICAg ICAgcmV0dXJuIG1heChtYXAobGFtYmRhIGJ1aWxkZXI6IGxlbihidWlsZGVyWyJuYW1lIl0pLCBi dWlsZGVycykpCkBAIC0xMjcsNiArMTI1LDggQEAgYW5kIGRpc3BsYXllcyB0aGUgc3RhdHVzIG9m IGVhY2ggYnVpbGRlci4iIiIKICAgICAgICAgcHJpbnQgIiAgUmV2aWV3ZXI6ICVzIiAlIChjb21t aXRfaW5mby5yZXZpZXdlcigpIG9yIGNvbW1pdF9pbmZvLnJldmlld2VyX3RleHQoKSkKICAgICAg ICAgcHJpbnQgIiAgQ29tbWl0dGVyOiAlcyIgJSBjb21taXRfaW5mby5jb21taXR0ZXIoKQogCisg ICAgIyBGSVhNRTogVGhpcyBpcyBzbGlnaHRseSBkaWZmZXJlbnQgZnJvbSBCdWlsZGVyLnN1c3Bl Y3RfcmV2aXNpb25zX2Zvcl9ncmVlbl90b19yZWRfdHJhbnNpdGlvbgorICAgICMgZHVlIHRvIG5l ZWRpbmcgdG8gZGV0ZWN0IHRoZSAiaGl0IHRoZSBsaW1pdCIgY2FzZSBhbiBwcmludCBhIHNwZWNp YWwgbWVzc2FnZS4KICAgICBkZWYgX3ByaW50X2JsYW1lX2luZm9ybWF0aW9uX2Zvcl9idWlsZGVy KHNlbGYsIGJ1aWxkZXJfc3RhdHVzLCBuYW1lX3dpZHRoKToKICAgICAgICAgYnVpbGRlciA9IHNl bGYudG9vbC5idWlsZGJvdC5idWlsZGVyX3dpdGhfbmFtZShidWlsZGVyX3N0YXR1c1sibmFtZSJd KQogICAgICAgICAobGFzdF9ncmVlbl9idWlsZCwgZmlyc3RfcmVkX2J1aWxkKSA9IGJ1aWxkZXIu ZmluZF9ncmVlbl90b19yZWRfdHJhbnNpdGlvbihidWlsZGVyX3N0YXR1c1siYnVpbGRfbnVtYmVy Il0pCkBAIC0xMzYsMTUgKzEzNiwxMSBAQCBhbmQgZGlzcGxheWVzIHRoZSBzdGF0dXMgb2YgZWFj aCBidWlsZGVyLiIiIgogCiAgICAgICAgIHN1c3BlY3RfcmV2aXNpb25zID0gcmFuZ2UoZmlyc3Rf cmVkX2J1aWxkLnJldmlzaW9uKCksIGxhc3RfZ3JlZW5fYnVpbGQucmV2aXNpb24oKSwgLTEpCiAg ICAgICAgIHN1c3BlY3RfcmV2aXNpb25zLnJldmVyc2UoKQotICAgICAgICAjIEZJWE1FOiBQYXJz ZSByZXZpZXdlciBhbmQgY29tbWl0dGVyIGZyb20gcmVkIGNoZWNraW4KICAgICAgICAgc2VsZi5f cHJpbnRfYnVpbGRlcl9saW5lKGJ1aWxkZXIubmFtZSgpLCBuYW1lX3dpZHRoLCAiRkFJTCAoYmxh bWUtbGlzdDogJXMpIiAlIHN1c3BlY3RfcmV2aXNpb25zKQogICAgICAgICBmb3IgcmV2aXNpb24g aW4gc3VzcGVjdF9yZXZpc2lvbnM6CiAgICAgICAgICAgICBjb21taXRfaW5mbyA9IENvbW1pdElu Zm8uY29tbWl0X2luZm9fZm9yX3JldmlzaW9uKHNlbGYudG9vbC5zY20oKSwgcmV2aXNpb24pCiAg ICAgICAgICAgICBzZWxmLl9wcmludF9ibGFtZV9pbmZvcm1hdGlvbl9mb3JfY29tbWl0KGNvbW1p dF9pbmZvKQogCi0gICAgZGVmIHJldmlzaW9uc19jYXVzaW5nX2ZhaWx1cmVzKHNlbGYsIG9ubHlf Y29yZV9idWlsZGVycz1UcnVlKToKLSAgICAgICAgYnVpbGRlcl9zdGF0dXNlcyA9IHRvb2wuYnVp bGRib3QuYnVpbGRlcl9zdGF0dXNlcygpCi0KICAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25z LCBhcmdzLCB0b29sKToKICAgICAgICAgYnVpbGRlcl9zdGF0dXNlcyA9IHRvb2wuYnVpbGRib3Qu YnVpbGRlcl9zdGF0dXNlcygpCiAgICAgICAgIGxvbmdlc3RfYnVpbGRlcl9uYW1lID0gc2VsZi5f bG9uZ2VzdF9idWlsZGVyX25hbWUoYnVpbGRlcl9zdGF0dXNlcykKQEAgLTE2MCw2ICsxNTYsMTMg QEAgYW5kIGRpc3BsYXllcyB0aGUgc3RhdHVzIG9mIGVhY2ggYnVpbGRlci4iIiIKICAgICAgICAg ZWxzZToKICAgICAgICAgICAgIHByaW50ICJBbGwgYnVpbGRlcnMgYXJlIHBhc3NpbmchIgogCitj bGFzcyBXaGF0QnJva2UoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQpOgorICAgIG5hbWUgPSAi d2hvLWJyb2tlLWl0IgorICAgIGhlbHBfdGV4dCA9ICJQcmludCBhIGxpc3Qgb2YgcmV2aXNpb25z IGNhdXNpbmcgZmFpbHVyZXMgb24gJXMiICUgQnVpbGRCb3QuZGVmYXVsdF9ob3N0CisKKyAgICBk ZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKKyAgICAgICAgZm9yIHJldmlz aW9uLCBidWlsZGVycyBpbiBzZWxmLnRvb2wuYnVpbGRib3QucmV2aXNpb25zX2NhdXNpbmdfZmFp bHVyZXMoRmFsc2UpLml0ZW1zKCk6CisgICAgICAgICAgICBwcmludCAiciVzIGFwcGVhcnMgdG8g aGF2ZSBicm9rZW4gJXMiICUgKHJldmlzaW9uLCBbYnVpbGRlci5uYW1lKCkgZm9yIGJ1aWxkZXIg aW4gYnVpbGRlcnNdKQogCiBjbGFzcyBUcmVlU3RhdHVzKEFic3RyYWN0RGVjbGFyYXRpdmVDb21t YW5kKToKICAgICBuYW1lID0gInRyZWUtc3RhdHVzIgo=