36279 2010-03-17 20:24:46 -0700 CSS3 :nth-child selector and valid whitespace test fails 2011-01-04 19:51:55 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/ValidWhitespace.htm P2 Normal --- 1 simon.fraser simon.fraser abarth commit-queue darin eric jamesr simon.fraser vsvabe webkit.review.bot yael oldest_to_newest 201163 0 51005 simon.fraser 2010-03-17 20:24:46 -0700 Created attachment 51005 Testcase This test fails: http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/ValidWhitespace.htm 328865 1 77859 yael 2011-01-03 18:09:04 -0800 Created attachment 77859 Patch Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs. 328894 2 77859 darin 2011-01-03 21:39:25 -0800 Comment on attachment 77859 Patch Changing the tokenizer but not updating CSSSelector::RareData::parseNth is not going to work correctly. It seems the test case here was insufficient to detect that. Please work on a patch that changes both the tokenizer and the parser to allow spaces! 328986 3 yael 2011-01-04 07:19:38 -0800 (In reply to comment #2) > (From update of attachment 77859 [details]) > Changing the tokenizer but not updating CSSSelector::RareData::parseNth is not going to work correctly. It seems the test case here was insufficient to detect that. Please work on a patch that changes both the tokenizer and the parser to allow spaces! Thank you for your review, Darin. I was under the impression that CSSSelector::RareData::parseNth already allows the spaces, but I could be wrong. CSSSelector::RareData::parseNth uses String::find() to find the sign + or -, and does not assume that the sign follows immediately after n. CSSSelector::RareData::parseNth uses String::toInt() to find the value of b, and that already knows how to skip leading spaces. Do you have a specific case in mind that could fail ? 329117 4 simon.fraser 2011-01-04 12:13:59 -0800 RareData::parseNth() looks like it deals with whitespace OK. Darin, are you OK with the patch? 329158 5 darin 2011-01-04 13:07:14 -0800 (In reply to comment #3) > I was under the impression that CSSSelector::RareData::parseNth already allows the spaces You are right. Sorry, I was wrong! 329360 6 commit-queue 2011-01-04 18:19:24 -0800 The commit-queue encountered the following flaky tests while processing attachment 77859: http/tests/appcache/progress-counter.html bug 51913 (author: michaeln@google.com) The commit-queue is continuing to process your patch. 329362 7 77859 commit-queue 2011-01-04 18:21:25 -0800 Comment on attachment 77859 Patch Clearing flags on attachment: 77859 Committed r75039: <http://trac.webkit.org/changeset/75039> 329363 8 commit-queue 2011-01-04 18:21:32 -0800 All reviewed patches have been landed. Closing bug. 329389 9 webkit.review.bot 2011-01-04 19:51:55 -0800 http://trac.webkit.org/changeset/75039 might have broken Leopard Intel Debug (Tests) 51005 2010-03-17 20:24:46 -0700 2010-03-17 20:24:46 -0700 Testcase ValidWhitespace.htm text/html 1846 simon.fraser PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMCBTdHJpY3QvL0VOIj4N CjxodG1sPg0KPGhlYWQ+DQogICAgPHRpdGxlPkNTUyBUZXN0OiA6bnRoLWNoaWxkIHNlbGVjdG9y IGFuZCB2YWxpZCB3aGl0ZXNwYWNlPC90aXRsZT4NCiAgICAgICAgPHN0eWxlIHR5cGU9InRleHQv Y3NzIj4NCiAgICAgICAgZGl2IGRpdjpudGgtY2hpbGQoDQoybg0KKw0KMSkNCiAgICAgICAgew0K ICAgICAgICAgICAgY29sb3I6IGdyZWVuOw0KICAgICAgICB9DQo8L3N0eWxlPg0KPC9oZWFkPg0K PGJvZHk+DQogICAgPHA+VGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBvZGQgbnVtYmVyZWQgRElWcyBh cmUgZ3JlZW4uPC9wPg0KICAgICAgPGRpdiBpZD0idGVzdCI+DQogICAgICAgICAgPGRpdj5ESVYx PC9kaXY+DQogICAgICAgICAgPGRpdj5ESVYyPC9kaXY+DQogICAgICA8L2Rpdj4NCiAgICAgIDxk aXYgaWQ9InRlc3RyZXN1bHQiIHN0eWxlPSJjb2xvcjogYmx1ZSI+UnVubmluZzwvZGl2Pg0KICAg IDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCiAgICAgICAgICAgICAgICBmdW5jdGlv biBBcnJheUNvbnRhaW5zKGFycmF5LCB2YWx1ZSwgY2kpDQogICAgICAgICAgICAgICAgew0KICAg ICAgICAgICAgICAgICAgICBjaSA9IGNpID09IHRydWUgPyB0cnVlIDogZmFsc2U7DQogICAgICAg ICAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYXJyYXkubGVuZ3RoOyBpKyspDQogICAg ICAgICAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjaSAmJiBhcnJh eVtpXS50b0xvd2VyQ2FzZSgpID09IHZhbHVlLnRvTG93ZXJDYXNlKCkpDQogICAgICAgICAgICAg ICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7DQog ICAgICAgICAgICAgICAgICAgICAgICB9DQogICAgICAgICAgICAgICAgICAgICAgICBlbHNlIGlm IChhcnJheVtpXSA9PSB2YWx1ZSkNCiAgICAgICAgICAgICAgICAgICAgICAgIHsNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsNCiAgICAgICAgICAgICAgICAgICAgICAg IH0NCiAgICAgICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7DQogICAgICAgICAgICAgICAgfQ0KICAgICAgICBmdW5jdGlvbiBUZXN0Q2FzZSgpDQogICAg ICAgIHsNCiAgICAgICAgICAgIHRyeQ0KICAgICAgICAgICAgew0KICAgICAgICAgICAgICAgIHZh ciBncmVlblZhbHVlcyA9IG5ldyBBcnJheSgiZ3JlZW4iLCAiIzAwODAwMCIsICJyZ2IoMCwgMTI4 LCAwKSIpOw0KDQogICAgICAgICAgICAgICAgdmFyIGVsZW0gPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGVzdCIpOw0KICAgICAgICAgICAgICAgIHZhciB2YWwgPSBnZXRDb21wdXRlZFN0eWxl KGVsZW0uY2hpbGRyZW5bMF0sIG51bGwpLmdldFByb3BlcnR5VmFsdWUoImNvbG9yIik7DQogICAg ICAgICAgICAgICAgaWYgKEFycmF5Q29udGFpbnMoZ3JlZW5WYWx1ZXMsIHZhbCwgZmFsc2UpKQ0K ICAgICAgICAgICAgICAgIHsNCiAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInRlc3RyZXN1bHQiKS5pbm5lckhUTUwgPSAiUGFzcyI7DQogICAgICAgICAgICAgICAg ICAgIHJldHVybjsNCiAgICAgICAgICAgICAgICB9DQogICAgICAgICAgICB9Y2F0Y2goZSl7fQ0K ICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RyZXN1bHQiKS5pbm5lckhU TUwgPSAiRmFpbCI7DQogICAgICAgIH0NCiAgICAgICAgVGVzdENhc2UoKTsNCiAgICA8L3Njcmlw dD4NCjwvYm9keT4NCjwvaHRtbD4NCg== 77859 2011-01-03 18:09:04 -0800 2011-01-04 18:21:25 -0800 Patch 36279.patch text/plain 4489 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDk1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMDMgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENTUzMgOm50aC1jaGlsZCBzZWxlY3RvciBhbmQgdmFsaWQgd2hpdGVzcGFjZSB0ZXN0IGZhaWxz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjI3OQor CisgICAgICAgIFRlYWNoIHRoZSB0b2tlbml6ZXIgdG8gYWxsb3cgd2hpdGUgc3BhY2VzIGFyb3Vu ZCBbKy8tXSBzaWducyBpbiBudGggY29uc3RydWN0cy4KKworICAgICAgICBUZXN0OiBmYXN0L2Nz cy9jc3MzLW50aC1zcGFjZS5odG1sCisKKyAgICAgICAgKiBjc3MvdG9rZW5pemVyLmZsZXg6CisK IDIwMTEtMDEtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxl eAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkocmV2aXNpb24gNzQ4 MDgpCisrKyBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkod29ya2luZyBjb3B5KQpAQCAtMjMs NyArMjMsNyBAQCB1cmwgICAgICAgICAgICAgKFshIyQlJiotfl18e25vbmFzY2lpfXx7CiB3ICAg ICAgICAgICAgICAgWyBcdFxyXG5cZl0qCiBubCAgICAgICAgICAgICAgXG58XHJcbnxccnxcZgog cmFuZ2UgICAgICAgICAgIFw/ezEsNn18e2h9KFw/ezAsNX18e2h9KFw/ezAsNH18e2h9KFw/ezAs M318e2h9KFw/ezAsMn18e2h9KFw/P3x7aH0pKSkpKQotbnRoICAgICAgICAgICAgIFtcKy1dP3tp bnRudW19Km4oW1wrLV17aW50bnVtfSk/CitudGggICAgICAgICAgICAgW1wrLV0/e2ludG51bX0q bihbXHRcclxuIF0qW1wrLV1bXHRcclxuIF0qe2ludG51bX0pPwogCiAlJQogCkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiA3NDk1MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDExLTAxLTAzICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5v a2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDU1MzIDpudGgtY2hpbGQgc2VsZWN0b3IgYW5kIHZhbGlkIHdoaXRlc3BhY2UgdGVzdCBmYWls cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYyNzkK KworICAgICAgICAqIGZhc3QvY3NzL2NzczMtbnRoLXNwYWNlLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZmFzdC9jc3MvY3NzMy1udGgtc3BhY2UuaHRtbDogQWRkZWQuCisKIDIwMTEt MDEtMDMgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgQ2hyb21pdW0gdGVzdCBleHBlY3RhdGlvbiB1cGRhdGUuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Nzcy9jc3MzLW50aC1zcGFjZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3NzMy1udGgtc3BhY2UtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3NzMy1udGgtc3BhY2UtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRo ZSBudGgtb2YtdHlwZSgzbiArIDEpIGlzIHBhcnNlZCBjb3JyZWN0bHksIHJlZ2FyZGxlc3Mgb2Yg dGhlIHdoaXRlc3BhY2VzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBk b2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBudWxsKS5nZXRQcm9wZXJ0 eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykgaXMgJ3JnYigwLCAxMjgsIDApJworUEFTUyBkb2N1 bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBudWxsKS5nZXRQcm9wZXJ0eVZh bHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykgaXMgJ3JnYigyNTUsIDAsIDApJworUEFTUyBkb2N1bWVu dC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBudWxsKS5nZXRQcm9wZXJ0eVZhbHVl KCdiYWNrZ3JvdW5kLWNvbG9yJykgaXMgJ3JnYigyNTUsIDAsIDApJworUEFTUyBkb2N1bWVudC5k ZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBudWxsKS5nZXRQcm9wZXJ0eVZhbHVlKCdi YWNrZ3JvdW5kLWNvbG9yJykgaXMgJ3JnYigwLCAxMjgsIDApJworUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Y3NzL2NzczMtbnRoLXNwYWNlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9j c3MvY3NzMy1udGgtc3BhY2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv Y3NzL2NzczMtbnRoLXNwYWNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDEgQEAKKzwh RE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhl YWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzxzdHlsZT4KK2Rpdi5jbGFzcyB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsg fQorZGl2LmNsYXNzOm50aC1vZi10eXBlKDNuCisgKyAgIDEpIHtiYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjt9Cis8L3N0eWxlPgorCis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+ PC9wPgorPGRpdiB0YWJpbmRleD0xIiBpZD0iZmlyc3QiIGNsYXNzPSJjbGFzcyI+PC9kaXY+Cis8 ZGl2IHRhYmluZGV4PTIiIGlkPSJzZWNvbmQiIGNsYXNzPSJjbGFzcyI+PC9kaXY+Cis8ZGl2IHRh YmluZGV4PTMiIGlkPSJ0aGlyZCIgY2xhc3M9ImNsYXNzIj48L2Rpdj4KKzxkaXYgdGFiaW5kZXg9 NCIgaWQ9ImZvdXJ0aCIgY2xhc3M9ImNsYXNzIj48L2Rpdj4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBudGgt b2YtdHlwZSgzbiArIDEpIGlzIHBhcnNlZCBjb3JyZWN0bHksIHJlZ2FyZGxlc3Mgb2YgdGhlIHdo aXRlc3BhY2VzLicpOworCisKKworZWwgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZmlyc3Qi KTsKK3Nob3VsZEJlKCJkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBu dWxsKS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiJ3JnYigwLCAxMjgs IDApJyIpOworCitlbCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzZWNvbmQiKTsKK3Nob3Vs ZEJlKCJkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsLCBudWxsKS5nZXRQ cm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiJ3JnYigyNTUsIDAsIDApJyIpOwor CitlbCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0aGlyZCIpOworc2hvdWxkQmUoImRvY3Vt ZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZWwsIG51bGwpLmdldFByb3BlcnR5VmFs dWUoJ2JhY2tncm91bmQtY29sb3InKSIsICIncmdiKDI1NSwgMCwgMCknIik7CisKK2VsID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZvdXJ0aCIpOworc2hvdWxkQmUoImRvY3VtZW50LmRlZmF1 bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZWwsIG51bGwpLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tn cm91bmQtY29sb3InKSIsICIncmdiKDAsIDEyOCwgMCknIik7CisKK3ZhciBzdWNjZXNzZnVsbHlQ YXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==