36033 2010-03-11 14:33:01 -0800 layoutTestController.overridePreference() affects tests after the current test 2010-03-13 06:24:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 35905 1 simon.fraser webkit-unassigned ddkilzer dimich eric glen gwilson simon.fraser oldest_to_newest 198778 0 simon.fraser 2010-03-11 14:33:01 -0800 layoutTestController.overridePreference() changes the setting in [WebPreferences standardPreferences]. This affects both the current test, and all subsequent tests in the same DRT invocation. This is bad. 198938 1 eric 2010-03-11 22:46:57 -0800 I'm not sure what else it should do, but I'm certainly interested in any suggestions you have. 199063 2 simon.fraser 2010-03-12 08:11:50 -0800 This is really a problem with how WebPreferences work. You can't currently set a WebPreference without touching +standardPreferences. One option would be to save a list of prefs changed by overridePreference(), and then undo those changes at the end of the test. 199074 3 gwilson 2010-03-12 08:39:19 -0800 My original version of overridePreference kept a list of modified preferences in WebPreferences to revert to after each test. Others felt that this was too cumbersome. I still agree that this is necessary! This was scrapped in favor of letting DRT just reset relevant preferences itself before each test. See bug 20534. 199090 4 simon.fraser 2010-03-12 09:11:17 -0800 If we made WebPreferences copyable, we could just set prefs on a single WebView without affecting the global preferences. 199289 5 ap 2010-03-12 20:40:09 -0800 > This was scrapped in favor of letting DRT just reset relevant preferences > itself before each test. Everyone CC'ed here probably knows this, but I'll rephrase this to have all relevant information spelled out: the current design is to reset preferences in resetDefaultsToConsistentValues() function in DumpRenderTree.mm. 199293 6 simon.fraser 2010-03-12 21:04:55 -0800 (In reply to comment #5) > Everyone CC'ed here probably knows this, but I'll rephrase this to have all > relevant information spelled out: the current design is to reset preferences in > resetDefaultsToConsistentValues() function in DumpRenderTree.mm. I saw a number of tests overriding preferences (e.g. caret browsing stuff) without corresponding resets in DRT. It's unfortunate that someone can write a test to change a pref, but then also have to submit a code patch at the same time.