36011 2010-03-11 05:12:08 -0800 Add TextEncoding::usesBackslashAsCurrencySymbol() 2010-03-15 00:31:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 24906 1 hamaji webkit-unassigned oldest_to_newest 198556 0 hamaji 2010-03-11 05:12:08 -0800 This function will be used by Bug 24906 to implement transcoding based on both fonts and encodings. 198557 1 50488 hamaji 2010-03-11 05:14:13 -0800 Created attachment 50488 Patch v1 199095 2 50488 darin 2010-03-12 09:17:07 -0800 Comment on attachment 50488 Patch v1 The logic here is backwards. This changes some "==" to "!=". As a side note, I also personally don’t think this refactoring is an improvement. The old code seems clearer to me. 199565 3 hamaji 2010-03-15 00:31:08 -0700 > The logic here is backwards. This changes some "==" to "!=". Oops. Sorry for the mistake... > As a side note, I also personally don’t think this refactoring is an > improvement. The old code seems clearer to me. I see. So, I think I will make backslashAsCurrencySymbol() public when I will use. Making this issue WONTFIX... 50488 2010-03-11 05:14:13 -0800 2010-03-12 09:17:07 -0800 Patch v1 bug-36011-20100311051411.patch text/plain 1845 hamaji ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzUyZGJkYy4uMTM3NjRhOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMy0xMSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBUZXh0RW5jb2Rpbmc6OnVzZXNCYWNrc2xhc2hBc0N1 cnJlbmN5U3ltYm9sKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2MDExCisKKyAgICAgICAgUmVmYWN0b3Jpbmcgb25seSwgc28gbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmcuaDoKKyAgICAgICAgKFdl YkNvcmU6OlRleHRFbmNvZGluZzo6dXNlc0JhY2tzbGFzaEFzQ3VycmVuY3lTeW1ib2wpOgorICAg ICAgICAoV2ViQ29yZTo6VGV4dEVuY29kaW5nOjpkaXNwbGF5U3RyaW5nKToKKyAgICAgICAgKFdl YkNvcmU6OlRleHRFbmNvZGluZzo6ZGlzcGxheUJ1ZmZlcik6CisKIDIwMTAtMDMtMTAgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpl cmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2Rp bmcuaCBiL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmcuaAppbmRleCBhOTliZmM4 Li4xOTRhZWZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5n LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5oCkBAIC00NSwxNiAr NDUsMjEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBjb25zdCBjaGFyKiBkb21OYW1l KCkgY29uc3Q7IC8vIG5hbWUgZXhwb3NlZCB2aWEgRE9NCiAgICAgICAgIGJvb2wgdXNlc1Zpc3Vh bE9yZGVyaW5nKCkgY29uc3Q7CiAgICAgICAgIGJvb2wgaXNKYXBhbmVzZSgpIGNvbnN0OwotICAg ICAgICAKKworICAgICAgICBib29sIHVzZXNCYWNrc2xhc2hBc0N1cnJlbmN5U3ltYm9sKCkgY29u c3QKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIG1fYmFja3NsYXNoQXNDdXJyZW5jeVN5 bWJvbCAhPSAnXFwnOworICAgICAgICB9CisKICAgICAgICAgUGFzc1JlZlB0cjxTdHJpbmdJbXBs PiBkaXNwbGF5U3RyaW5nKFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gc3RyKSBjb25zdAogICAgICAg ICB7Ci0gICAgICAgICAgICBpZiAobV9iYWNrc2xhc2hBc0N1cnJlbmN5U3ltYm9sID09ICdcXCcg fHwgIXN0cikKKyAgICAgICAgICAgIGlmICh1c2VzQmFja3NsYXNoQXNDdXJyZW5jeVN5bWJvbCgp IHx8ICFzdHIpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHN0cjsKICAgICAgICAgICAgIHJldHVy biBzdHItPnJlcGxhY2UoJ1xcJywgbV9iYWNrc2xhc2hBc0N1cnJlbmN5U3ltYm9sKTsKICAgICAg ICAgfQogICAgICAgICB2b2lkIGRpc3BsYXlCdWZmZXIoVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2ln bmVkIGxlbikgY29uc3QKICAgICAgICAgewotICAgICAgICAgICAgaWYgKG1fYmFja3NsYXNoQXND dXJyZW5jeVN5bWJvbCA9PSAnXFwnKQorICAgICAgICAgICAgaWYgKHVzZXNCYWNrc2xhc2hBc0N1 cnJlbmN5U3ltYm9sKCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbjsgKytpKSB7CiAgICAgICAgICAgICAgICAgaWYgKGNo YXJhY3RlcnNbaV0gPT0gJ1xcJykK