35835 2010-03-06 16:42:30 -0800 test-webkitpy: Adjust logging code so that "side-effect" messages do not render to the screen 2010-03-13 15:50:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth cjerdonek eric hamaji levin oldest_to_newest 196949 0 cjerdonek 2010-03-06 16:42:30 -0800 Currently, if we configure logging in test-webkitpy, then spurious log messages will get logged to the screen as a side effect of the code that the unit tests are executing. We should suppress those spurious log messages. The solution here will involve something like setting the "propagate" attribute on any test loggers to False so that the log messages will not propagate up to the root logger and be logged. 197007 1 50173 cjerdonek 2010-03-07 08:39:00 -0800 Created attachment 50173 Proposed patch 199348 2 50173 abarth 2010-03-13 02:18:59 -0800 Comment on attachment 50173 Proposed patch Python's logging is much more awesome than what Eric cooked up on his own. Thanks for educating us in the ways of Python. 199422 3 cjerdonek 2010-03-13 15:50:36 -0800 Manually committed (via git svn dcommit): http://trac.webkit.org/changeset/55971 50173 2010-03-07 08:39:00 -0800 2010-03-13 02:18:59 -0800 Proposed patch _patch-35835-1.diff text/plain 2688 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMDI0OTgwLi5lNmRmZTU3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMt MDcgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0ZXN0LXdlYmtpdHB5 IHNvIHRoYXQgbWVzc2FnZXMgbG9nZ2VkIGFzIGEgc2lkZS1lZmZlY3QKKyAgICAgICAgb2YgdW5p dC10ZXN0aW5nIGNvZGUgZG8gbm90IGdldCBkaXNwbGF5ZWQgdG8gdGhlIHNjcmVlbi4gIFRoZXNl CisgICAgICAgIG1lc3NhZ2VzIGNsdXR0ZXIgdXAgdGhlIHVuaXQgdGVzdCByZXN1bHRzIGlmIG5v dCBmaWx0ZXJlZCBvdXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM1ODM1CisKKyAgICAgICAgKiBTY3JpcHRzL3Rlc3Qtd2Via2l0cHk6CisgICAg ICAgICAgLSBBZGp1c3RlZCB0aGUgY29uZmlndXJlX2xvZ2dpbmcoKSBtZXRob2QgdG8gZmlsdGVy IG91dCBhbnkKKyAgICAgICAgICAgIGxvZyBtZXNzYWdlcyBmcm9tIHdlYmtpdHB5LgorICAgICAg ICAgIC0gQWxzbyBhZGRlZCBhbiBJTkZPIG1lc3NhZ2Ugc3RhdGluZyB0aGF0IG1vc3QgY29uc29s ZSBsb2dnaW5nCisgICAgICAgICAgICBpcyBnZXR0aW5nIHN1cHByZXNzZWQuCisKIDIwMTAtMDMt MDYgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3Rlc3Qtd2Via2l0cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkKaW5kZXgg NzFiNmRlYy4uYjI0MjIwZiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy90ZXN0LXdl YmtpdHB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweQpAQCAtMzgsNyAr MzgsMTIgQEAgX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKCJ0ZXN0LXdlYmtpdHB5IikKIAogCiBk ZWYgY29uZmlndXJlX2xvZ2dpbmcoKToKLSAgICAiIiJDb25maWd1cmUgdGhlIHJvb3QgbG9nZ2Vy IHRvIGxvZyBpbmZvIG1lc3NhZ2VzIGFuZCBhYm92ZS4iIiIKKyAgICAiIiJDb25maWd1cmUgdGhl IHJvb3QgbG9nZ2VyLgorCisgICAgQ29uZmlndXJlIHRoZSByb290IGxvZ2dlciBub3QgdG8gbG9n IGFueSBtZXNzYWdlcyBmcm9tIHdlYmtpdHB5LAorICAgIGFuZCB0byBsb2cgYWxsIG90aGVyIG1l c3NhZ2VzIHRoYXQgYXJlIElORk8gYW5kIGFib3ZlLgorCisgICAgIiIiCiAgICAgaGFuZGxlciA9 IGxvZ2dpbmcuU3RyZWFtSGFuZGxlcihzeXMuc3RkZXJyKQogICAgIGZvcm1hdHRlciA9IGxvZ2dp bmcuRm9ybWF0dGVyKCJbJShsZXZlbG5hbWUpc10gJShuYW1lKXM6ICUobWVzc2FnZSlzIikKICAg ICBoYW5kbGVyLnNldEZvcm1hdHRlcihmb3JtYXR0ZXIpCkBAIC00Nyw2ICs1MiwyOCBAQCBkZWYg Y29uZmlndXJlX2xvZ2dpbmcoKToKICAgICBsb2dnZXIuc2V0TGV2ZWwobG9nZ2luZy5JTkZPKQog ICAgIGxvZ2dlci5hZGRIYW5kbGVyKGhhbmRsZXIpCiAKKyAgICAjIEZpbHRlciBvdXQgbW9zdCB3 ZWJraXRweSBtZXNzYWdlcy4KKyAgICAjCisgICAgIyBNZXNzYWdlcyBjYW4gYmUgc2VsZWN0aXZl bHkgcmUtZW5hYmxlZCBmb3IgdGhpcyBzY3JpcHQgYnkgdXBkYXRpbmcKKyAgICAjIHRoaXMgbWV0 aG9kIGFjY29yZGluZ2x5LgorICAgIGRlZiBmaWx0ZXIocmVjb3JkKToKKyAgICAgICAgIiIiRmls dGVyIG91dCBhdXRvaW5zdGFsbCBhbmQgbm9uLXRoaXJkLXBhcnR5IHdlYmtpdHB5IG1lc3NhZ2Vz LiIiIgorICAgICAgICAjIEZJWE1FOiBFbmFibGUgdGhlIGxvZ2dpbmcgb2YgYXV0b2luc3RhbGwg bWVzc2FnZXMgb25jZQorICAgICAgICAjICAgICAgICBhdXRvaW5zdGFsbCBpcyBhZGp1c3RlZC4g IEN1cnJlbnRseSwgYXV0b2luc3RhbGwgbG9ncworICAgICAgICAjICAgICAgICBJTkZPIG1lc3Nh Z2VzIHdoZW4gaW1wb3J0aW5nIGFscmVhZHktZG93bmxvYWRlZCBwYWNrYWdlcywKKyAgICAgICAg IyAgICAgICAgd2hpY2ggaXMgdG9vIHZlcmJvc2UuCisgICAgICAgIGlmIHJlY29yZC5uYW1lLnN0 YXJ0c3dpdGgoIndlYmtpdHB5Iik6CisgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAg cmV0dXJuIFRydWUKKworICAgIHRlc3RpbmdfZmlsdGVyID0gbG9nZ2luZy5GaWx0ZXIoKQorICAg IHRlc3RpbmdfZmlsdGVyLmZpbHRlciA9IGZpbHRlcgorCisgICAgIyBEaXNwbGF5IGEgbWVzc2Fn ZSBzbyBkZXZlbG9wZXJzIGFyZSBub3QgbXlzdGlmaWVkIGFzIHRvIHdoeQorICAgICMgbG9nZ2lu ZyBkb2VzIG5vdCB3b3JrIGluIHRoZSB1bml0IHRlc3RzLgorICAgIF9sb2cuaW5mbygiU3VwcHJl c3NpbmcgbW9zdCB3ZWJraXRweSBsb2dnaW5nIHdoaWxlIHJ1bm5pbmcgdW5pdCB0ZXN0cy4iKQor ICAgIGhhbmRsZXIuYWRkRmlsdGVyKHRlc3RpbmdfZmlsdGVyKQorCiAKIGRlZiBpbml0KCk6CiAg ICAgIiIiRXhlY3V0ZSBjb2RlIHByaW9yIHRvIGltcG9ydGluZyBmcm9tIHdlYmtpdHB5LnVuaXR0 ZXN0cy4iIiIK