35759 2010-03-04 11:49:45 -0800 When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix 2010-03-10 21:50:03 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin ap chinmaya darin simon.fraser oldest_to_newest 196167 0 cmarrin 2010-03-04 11:49:45 -0800 HW compositing was turned off for Leopard due to a Core Video bug. This caused crashes sometimes with Video on a HW compositing layer. We could turn it back on if WebGL is turned on. This would limit the exposure of the Core Video bug to those who have opted in to WebGL in a nightly build. This is related to: https://bugs.webkit.org/show_bug.cgi?id=35338. 197020 1 darin 2010-03-07 10:13:18 -0800 Seems fine. I would word this as: "When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix" Or something like that. 197323 2 50248 cmarrin 2010-03-08 14:34:34 -0800 Created attachment 50248 Patch 197329 3 cmarrin 2010-03-08 14:55:45 -0800 Landed in http://trac.webkit.org/changeset/55685 50248 2010-03-08 14:34:34 -0800 2010-03-08 14:36:06 -0800 Patch 35759.patch text/plain 3385 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTY4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMDggIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERp c2FsbG93IFdlYkdMIHdoZW4gSFcgY29tcCBpcyBub3QgdHVybmVkIG9uIGF0IHJ1bnRpbWUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NzU5CisKKyAg ICAgICAgV2hlbiBIVyBjb21wIGlzIHR1cm5lZCBvZmYgd2l0aCB0aGUgcnVudGltZSBmbGFnLCBX ZWJHTCB3b3VsZCBzdGlsbAorICAgICAgICBjcmVhdGUgYSBjb250ZXh0LCBidXQgc2lsZW50bHkg ZmFpbCB0byByZW5kZXIuIFRoaXMgcHJldmVudHMgdGhhdC4KKyAgICAgICAgTm93IGlmIEhXIGNv bXAgaXMgdHVybmVkIG9mZiBnZXRDb250ZXh0KCd3ZWJnbCcpIHdpbGwgcmV0dXJuIG51bGwuCisK KyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxDYW52YXNFbGVtZW50OjpnZXRDb250ZXh0KToKKwogMjAxMC0wMy0wOCAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9uIEhvbmV5Y3V0 dC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAkocmV2aXNpb24gNTU2NzUpCisr KyBXZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NjgsNyArMTY4LDcgQEAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dCogSFRNTENhbnZhc0VsZW1lbgog ICAgIH0KICNpZiBFTkFCTEUoM0RfQ0FOVkFTKSAgICAKICAgICBTZXR0aW5ncyogc2V0dGluZ3Mg PSBkb2N1bWVudCgpLT5zZXR0aW5ncygpOwotICAgIGlmIChzZXR0aW5ncyAmJiBzZXR0aW5ncy0+ d2ViR0xFbmFibGVkKCkpIHsKKyAgICBpZiAoc2V0dGluZ3MgJiYgc2V0dGluZ3MtPndlYkdMRW5h YmxlZCgpICYmIHNldHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpKSB7CiAg ICAgICAgIC8vIEFjY2VwdCB0aGUgbGVnYWN5ICJ3ZWJraXQtM2QiIG5hbWUgYXMgd2VsbCBhcyB0 aGUgcHJvdmlzaW9uYWwgImV4cGVyaW1lbnRhbC13ZWJnbCIgbmFtZS4KICAgICAgICAgLy8gT25j ZSByYXRpZmllZCwgd2Ugd2lsbCBhbHNvIGFjY2VwdCAid2ViZ2wiIGFzIHRoZSBjb250ZXh0IG5h bWUuCiAgICAgICAgIGlmICgodHlwZSA9PSAid2Via2l0LTNkIikgfHwKSW5kZXg6IFdlYktpdC9t YWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hhbmdlTG9nCShyZXZpc2lv biA1NTY4MikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTAtMDMtMDggIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb24g SFcgYWNjZWwgb24gTGVvcGFyZCBldmVuIGlmIGNvcmVWaWRlb0hhczcyMjg4MzZGaXgoKSBpcyBm YWxzZSwgd2hlbiBXZWJHTCBpcyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNTc1OQorCisgICAgICAgIFRoaXMgYWxsb3dzIFdlYkdMIHRv IHdvcmsgb24gTGVvcGFyZCB3aXRob3V0IHRoZSBmaXguIEl0IGV4cG9zZXMgdGhlc2UgdXNlcnMg dG8gdGhlIGNyYXNoCisgICAgICAgIHRoYXQgaGFwcGVucyBiZWNhdXNlIG9mIHRoZSBDb3JlVmlk ZW8gYnVnLCBidXQgaXQgbGltaXRzIHRoZSBleHBvc3VyZSB0byB0aG9zZSB3aG8gaGF2ZSAKKyAg ICAgICAgY2hvc2VuIHRvIGVuYWJsZSBXZWJHTC4KKworICAgICAgICAqIFdlYlZpZXcvV2ViVmll dy5tbToKKyAgICAgICAgKC1bV2ViVmlldyBfcHJlZmVyZW5jZXNDaGFuZ2VkTm90aWZpY2F0aW9u Ol0pOgorCiAyMDEwLTAzLTAyICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJW aWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZp c2lvbiA1NTY3NSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC0xMzQ1LDcgKzEzNDUsNyBAQCBzdGF0aWMgYm9vbCBmYXN0RG9jdW1lbnRUZWFyZG93 bkVuYWJsZWQoCiAgICAgc2V0dGluZ3MtPnNldFpvb21Nb2RlKFtwcmVmZXJlbmNlcyB6b29tc1Rl eHRPbmx5XSA/IFpvb21UZXh0T25seSA6IFpvb21QYWdlKTsKICAgICBzZXR0aW5ncy0+c2V0WFNT QXVkaXRvckVuYWJsZWQoW3ByZWZlcmVuY2VzIGlzWFNTQXVkaXRvckVuYWJsZWRdKTsKICAgICBz ZXR0aW5ncy0+c2V0RW5mb3JjZUNTU01JTUVUeXBlSW5TdHJpY3RNb2RlKCFXS0FwcFZlcnNpb25D aGVja0xlc3NUaGFuKEAiY29tLmFwcGxlLmlXZWIiLCAtMSwgMi4xKSk7Ci0gICAgc2V0dGluZ3Mt PnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKGNvcmVWaWRlb0hhczcyMjg4MzZGaXgo KSAmJiBbcHJlZmVyZW5jZXMgYWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWRdKTsKKyAgICBz ZXR0aW5ncy0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoKGNvcmVWaWRlb0hhczcy Mjg4MzZGaXgoKSB8fCBbcHJlZmVyZW5jZXMgd2ViR0xFbmFibGVkXSkgJiYgW3ByZWZlcmVuY2Vz IGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkXSk7CiAgICAgc2V0dGluZ3MtPnNldFNob3dE ZWJ1Z0JvcmRlcnMoW3ByZWZlcmVuY2VzIHNob3dEZWJ1Z0JvcmRlcnNdKTsKICAgICBzZXR0aW5n cy0+c2V0U2hvd1JlcGFpbnRDb3VudGVyKFtwcmVmZXJlbmNlcyBzaG93UmVwYWludENvdW50ZXJd KTsKICAgICBzZXR0aW5ncy0+c2V0UGx1Z2luQWxsb3dlZFJ1blRpbWUoW3ByZWZlcmVuY2VzIHBs dWdpbkFsbG93ZWRSdW5UaW1lXSk7Cg==