35726 2010-03-04 01:14:42 -0800 Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID 2010-03-04 07:03:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 d-r webkit-unassigned commit-queue fridrich.strba oldest_to_newest 195940 0 d-r 2010-03-04 01:14:42 -0800 WTF_USE_GLIB_ICU_UNICODE_HYBRID is not needed/used anymore. The leftover usage in ThreadGlobalData.h needs to go away. 195942 1 49996 d-r 2010-03-04 01:22:09 -0800 Created attachment 49996 removing the orphaned condition 195948 2 fridrich.strba 2010-03-04 01:34:28 -0800 There is one more instance of that define in that file and then there is the define in GNUMakefile.am 196017 3 50007 fridrich.strba 2010-03-04 05:48:44 -0800 Created attachment 50007 Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID 196020 4 fridrich.strba 2010-03-04 05:52:26 -0800 *** Bug 35704 has been marked as a duplicate of this bug. *** 196021 5 fridrich.strba 2010-03-04 05:53:17 -0800 OK, I went through the sources and removed the orphaned mentions. 196023 6 50007 zecke 2010-03-04 05:56:15 -0800 Comment on attachment 50007 Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID Seems to be fine. 196043 7 50007 commit-queue 2010-03-04 07:03:21 -0800 Comment on attachment 50007 Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID Clearing flags on attachment: 50007 Committed r55524: <http://trac.webkit.org/changeset/55524> 196044 8 commit-queue 2010-03-04 07:03:26 -0800 All reviewed patches have been landed. Closing bug. 49996 2010-03-04 01:22:09 -0800 2010-03-04 01:35:38 -0800 removing the orphaned condition remove_hybrid.patch text/plain 1172 d-r SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTUxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDQgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsu cm9ldHRzY2hlc0BhY2Nlc3MtY29tcGFueS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1NzI2CisgICAgICAgIFJlbW92ZSBvcnBoYW5lZCAjaWZkZWYgV1RGX1VTRV9HTElC X0lDVV9VTklDT0RFX0hZQlJJRAorCisgICAgICAgIFJlbW92aW5nIG9ycGhhbmVkICNpZiBVU0Uu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9UaHJlYWRHbG9iYWxEYXRhLmg6CisKIDIwMTAtMDMtMDQg IE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vVGhyZWFkR2xvYmFsRGF0 YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vVGhyZWFkR2xvYmFsRGF0YS5oCShy ZXZpc2lvbiA1NTUwOCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vVGhyZWFkR2xvYmFsRGF0YS5oCSh3 b3JraW5nIGNvcHkpCkBAIC01NSw3ICs1NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgSGFzaFNldDxTdHJpbmdJbXBsKj4mIGF0b21pY1N0cmluZ1RhYmxlKCkgeyByZXR1cm4gKm1f YXRvbWljU3RyaW5nVGFibGU7IH0KICAgICAgICAgVGhyZWFkVGltZXJzJiB0aHJlYWRUaW1lcnMo KSB7IHJldHVybiAqbV90aHJlYWRUaW1lcnM7IH0KIAotI2lmIFVTRShJQ1VfVU5JQ09ERSkgfHwg VVNFKEdMSUJfSUNVX1VOSUNPREVfSFlCUklEKQorI2lmIFVTRShJQ1VfVU5JQ09ERSkKICAgICAg ICAgSUNVQ29udmVydGVyV3JhcHBlciYgY2FjaGVkQ29udmVydGVySUNVKCkgeyByZXR1cm4gKm1f Y2FjaGVkQ29udmVydGVySUNVOyB9CiAjZW5kaWYKIAo= 50007 2010-03-04 05:48:44 -0800 2010-03-04 07:03:21 -0800 Patch to remove all orphaned occurences of GLIB_ICU_UNICODE_HYBRID bug-35726-20100304144841.patch text/plain 2772 fridrich.strba SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU1NTIw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMt MDQgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU3MjYKKyAgICAgICAgUmVtb3ZlIG9ycGhhbmVkICNp ZmRlZiBXVEZfVVNFX0dMSUJfSUNVX1VOSUNPREVfSFlCUklECisKKyAgICAgICAgUmVtb3Zpbmcg b3JwaGFuZWQgI2lmIFVTRS4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDEwLTAz LTA0ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KSW5kZXg6IEdOVW1ha2VmaWxlLmFt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEdOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiA1NTUyMCkKKysrIEdOVW1h a2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0yNzIsMTYgKzI3Miw4IEBAIGdsb2JhbF9jcHBm bGFncyArPSBcCiBlbmRpZgogCiBpZiBVU0VfR0xJQl9VTklDT0RFCi0jIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkxNAotIyBJbiBwYXRjaCAxLzQgd2UgYXJlIGNv bXBpbGluZyBhIGh5YnJpZCB2ZXJzaW9uIG9mIEdMaWIgV1RGIFVuaWNvZGUKLSMgZnVuY3Rpb25h bGl0eSBtaXhlZCB3aXRoIElDVS1iYXNlZCB0ZXh0IGNvZGVjcyBhbmQgVGV4dEJyZWFrSXRlcmF0 b3IuCi0jIEZvciB0aGUgdHJhbnNpdGlvbiwgaW50cm9kdWNpbmcgYW4gaW50ZXJpbSBIWUJSSUQg bWFjcm8uCi0jIFRoaXMgbWFjcm8gaXMgcmVxdWlyZWQgZm9yIGNvbXBpbGluZyBXVEYgd2l0aCBH TGliIFVuaWNvZGUgYmFja2VuZCwKLSMgYnV0IGF0IHRoZSBzYW1lIHRpbWUga2VlcGluZyBJQ1Ug ZGVwZW5kZW5jeSBmb3IgY29kZWNzIGFuZCBicmVhayBpdGVyYXRvci4KLSMgSXQgd2lsbCBiZSBy ZW1vdmVkIHdpdGggcGF0Y2ggMy80IG9mIHRoZSBhYm92ZSBidWcuCiBnbG9iYWxfY3BwZmxhZ3Mg Kz0gXAotCS1EV1RGX1VTRV9HTElCX1VOSUNPREU9MSBcCi0JLURXVEZfVVNFX0dMSUJfSUNVX1VO SUNPREVfSFlCUklEPTEKKwktRFdURl9VU0VfR0xJQl9VTklDT0RFPTEKIGVuZGlmCiAKIGlmICFF TkFCTEVfRkFTVF9NQUxMT0MKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NTUyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMDQgIEZyaWRyaWNoIFN0 cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzU3MjYKKyAgICAgICAgUmVtb3ZlIG9ycGhhbmVkICNpZmRlZiBXVEZfVVNFX0dM SUJfSUNVX1VOSUNPREVfSFlCUklECisKKyAgICAgICAgUmVtb3Zpbmcgb3JwaGFuZWQgI2lmIFVT RS4KKworICAgICAgICAqIHBsYXRmb3JtL1RocmVhZEdsb2JhbERhdGEuaDoKKwogMjAxMC0wMy0w NCAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCkluZGV4OiBXZWJDb3JlL3BsYXRmb3Jt L1RocmVhZEdsb2JhbERhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1RocmVh ZEdsb2JhbERhdGEuaAkocmV2aXNpb24gNTU1MjApCisrKyBXZWJDb3JlL3BsYXRmb3JtL1RocmVh ZEdsb2JhbERhdGEuaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgICAgIEhhc2hTZXQ8U3RyaW5nSW1wbCo+JiBhdG9taWNTdHJpbmdUYWJs ZSgpIHsgcmV0dXJuICptX2F0b21pY1N0cmluZ1RhYmxlOyB9CiAgICAgICAgIFRocmVhZFRpbWVy cyYgdGhyZWFkVGltZXJzKCkgeyByZXR1cm4gKm1fdGhyZWFkVGltZXJzOyB9CiAKLSNpZiBVU0Uo SUNVX1VOSUNPREUpIHx8IFVTRShHTElCX0lDVV9VTklDT0RFX0hZQlJJRCkKKyNpZiBVU0UoSUNV X1VOSUNPREUpCiAgICAgICAgIElDVUNvbnZlcnRlcldyYXBwZXImIGNhY2hlZENvbnZlcnRlcklD VSgpIHsgcmV0dXJuICptX2NhY2hlZENvbnZlcnRlcklDVTsgfQogI2VuZGlmCiAKQEAgLTczLDcg KzczLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIG1faXNNYWluVGhyZWFk OwogI2VuZGlmCiAKLSNpZiBVU0UoSUNVX1VOSUNPREUpIHx8IFVTRShHTElCX0lDVV9VTklDT0RF X0hZQlJJRCkKKyNpZiBVU0UoSUNVX1VOSUNPREUpCiAgICAgICAgIElDVUNvbnZlcnRlcldyYXBw ZXIqIG1fY2FjaGVkQ29udmVydGVySUNVOwogI2VuZGlmCiAK