35391 2010-02-25 09:40:37 -0800 diff_parser should not log to the root logger 2010-02-26 08:19:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth cjerdonek commit-queue eric hamaji levin oldest_to_newest 193771 0 cjerdonek 2010-02-25 09:40:37 -0800 See summary. See also the similar report for the Python layout test scripts: https://bugs.webkit.org/show_bug.cgi?id=35194 See the first comment there for more info. 193781 1 49502 cjerdonek 2010-02-25 09:59:36 -0800 Created attachment 49502 Proposed patch 193906 2 49502 eric 2010-02-25 16:00:04 -0800 Comment on attachment 49502 Proposed patch LGTM. 193969 3 cjerdonek 2010-02-25 17:58:18 -0800 (In reply to comment #2) > (From update of attachment 49502 [details]) > LGTM. Thanks, Eric! 194105 4 49502 commit-queue 2010-02-26 08:19:49 -0800 Comment on attachment 49502 Proposed patch Clearing flags on attachment: 49502 Committed r55284: <http://trac.webkit.org/changeset/55284> 194106 5 commit-queue 2010-02-26 08:19:53 -0800 All reviewed patches have been landed. Closing bug. 49502 2010-02-25 09:59:36 -0800 2010-02-26 08:19:48 -0800 Proposed patch _patch-35391-1.diff text/plain 2004 cjerdonek ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlMzU0YzNhLi4yM2E2NTE0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDIt MjUgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0aGUgZGlmZl9wYXJz ZXIgbW9kdWxlIHRvIGxvZyB0byBhIG1vZHVsZS1zcGVjaWZpYworICAgICAgICBsb2dnaW5nLmxv Z2dlciByYXRoZXIgdGhhbiB0aGUgcm9vdCBsb2dnZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MzkxCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2RpZmZfcGFyc2VyLnB5OgorCiAyMDEwLTAyLTI0ICBDaHJpcyBKZXJkb25layAgPGNq ZXJkb25la0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9kaWZmX3BhcnNlci5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvZGlmZl9wYXJzZXIucHkKaW5kZXggN2Rj ZTdlOC4uMDllNTRkYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9k aWZmX3BhcnNlci5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2RpZmZfcGFy c2VyLnB5CkBAIC0zMSw2ICszMSw3IEBACiBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IHJlCiAKK19s b2cgPSBsb2dnaW5nLmdldExvZ2dlcigid2Via2l0cHkuZGlmZl9wYXJzZXIiKQogCiBfcmVnZXhw X2NvbXBpbGVfY2FjaGUgPSB7fQogCkBAIC0xMzgsNyArMTM5LDggQEAgY2xhc3MgRGlmZlBhcnNl cjoKICAgICAgICAgICAgIGxpbmVzX2NoYW5nZWQgPSBtYXRjaChyIl5AQCAtKD9QPE9sZFN0YXJ0 TGluZT5cZCspKCxcZCspPyBcKyg/UDxOZXdTdGFydExpbmU+XGQrKSgsXGQrKT8gQEAiLCBsaW5l KQogICAgICAgICAgICAgaWYgbGluZXNfY2hhbmdlZDoKICAgICAgICAgICAgICAgICBpZiBzdGF0 ZSAhPSBfREVDTEFSRURfRklMRV9QQVRIIGFuZCBzdGF0ZSAhPSBfUFJPQ0VTU0lOR19DSFVOSzoK LSAgICAgICAgICAgICAgICAgICAgbG9nZ2luZy5lcnJvcignVW5leHBlY3RlZCBsaW5lIGNoYW5n ZSB3aXRob3V0IGZpbGUgcGF0aCBkZWNsYXJhdGlvbjogJXInICUgbGluZSkKKyAgICAgICAgICAg ICAgICAgICAgX2xvZy5lcnJvcignVW5leHBlY3RlZCBsaW5lIGNoYW5nZSB3aXRob3V0IGZpbGUg cGF0aCAnCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2RlY2xhcmF0aW9uOiAlcicg JSBsaW5lKQogICAgICAgICAgICAgICAgIG9sZF9kaWZmX2xpbmUgPSBpbnQobGluZXNfY2hhbmdl ZC5ncm91cCgnT2xkU3RhcnRMaW5lJykpCiAgICAgICAgICAgICAgICAgbmV3X2RpZmZfbGluZSA9 IGludChsaW5lc19jaGFuZ2VkLmdyb3VwKCdOZXdTdGFydExpbmUnKSkKICAgICAgICAgICAgICAg ICBzdGF0ZSA9IF9QUk9DRVNTSU5HX0NIVU5LCkBAIC0xNTksNCArMTYxLDUgQEAgY2xhc3MgRGlm ZlBhcnNlcjoKICAgICAgICAgICAgICAgICAgICAgIyBOb3RoaW5nIHRvIGRvLiAgV2UgbWF5IHN0 aWxsIGhhdmUgc29tZSBhZGRlZCBsaW5lcy4KICAgICAgICAgICAgICAgICAgICAgcGFzcwogICAg ICAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgICAgIGxvZ2dpbmcuZXJyb3IoJ1Vu ZXhwZWN0ZWQgZGlmZiBmb3JtYXQgd2hlbiBwYXJzaW5nIGEgY2h1bms6ICVyJyAlIGxpbmUpCisg ICAgICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1VuZXhwZWN0ZWQgZGlmZiBmb3JtYXQgd2hl biBwYXJzaW5nIGEgJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdjaHVuazogJXIn ICUgbGluZSkK