35382 2010-02-25 05:39:14 -0800 [Qt] GraphicsLayerQt: artifacts and wrong transformOrigin 2010-04-29 00:17:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED https://trac.webkit.org/raw-attachment/wiki/CssAnimationTestSuite/cssAnimTestSuite.html#autoScale-inlineText:30 Qt P2 Normal --- 35389 1 noam webkit-unassigned commit-queue hausmann oldest_to_newest 193691 0 noam 2010-02-25 05:39:14 -0800 Two issues with the above page: 1. the text scales from the corner and not from the middle 2. The un-transformed item remains in the background 193811 1 49511 noam 2010-02-25 11:15:56 -0800 Created attachment 49511 Fix a regression caused by some optimization to GraphicsLayerQt, and adjust the transformation This fixes a couple of smaller bugs in one go: that's the only way to test that the fix is correct as the test-cases are the same. 193814 2 49511 kenneth 2010-02-25 11:31:23 -0800 Comment on attachment 49511 Fix a regression caused by some optimization to GraphicsLayerQt, and adjust the transformation Thanks for the quick fix. It looks fine. 193816 3 noam 2010-02-25 11:37:24 -0800 *** Bug 35283 has been marked as a duplicate of this bug. *** 194398 4 49511 commit-queue 2010-02-26 19:00:02 -0800 Comment on attachment 49511 Fix a regression caused by some optimization to GraphicsLayerQt, and adjust the transformation Clearing flags on attachment: 49511 Committed r55334: <http://trac.webkit.org/changeset/55334> 194399 5 commit-queue 2010-02-26 19:00:07 -0800 All reviewed patches have been landed. Closing bug. 218869 6 hausmann 2010-04-29 00:16:54 -0700 Revision r55334 cherry-picked into qtwebkit-2.0 with commit 34e0178e2e498811c31375d7744582f667cd2ff5 49511 2010-02-25 11:15:56 -0800 2010-02-26 19:00:02 -0800 Fix a regression caused by some optimization to GraphicsLayerQt, and adjust the transformation patch-35382-1.diff text/plain 4109 noam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTI0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDItMjUgIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRo YWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gR3JhcGhpY3NMYXllclF0OiBhcnRpZmFjdHMgYW5kIHdyb25nIHRyYW5zZm9y bU9yaWdpbgorICAgICAgICBUaGlzIHdhcyBkdWUgdG8gd3Jvbmcgd2F5IG9mIGFwcGx5aW5nIGNh Y2hlLW1vZGUgYW5kIHRyYW5zZm9ybWF0aW9uCisgICAgICAgIG9uIGEgZ3JhcGhpY3MtaXRlbSB3 aXRoIEhUTUwuIENhY2hlLW1vZGUgc2hvdWxkIGJlIHVwZGF0ZWQKKyAgICAgICAgd2hlbiB0aGUg Y29udGVudCB0eXBlIHVwZGF0ZXMsIGV2ZW4gaWYgaXQgd2FzIHRoZSBzYW1lIGNhY2hlLW1vZGUK KyAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUz ODIKKworICAgICAgICBUZXN0IFVSTCBhdHRhY2hlZCB0byB0aGUgYnVnIG5vdyB3b3JrcyBjb3Jy ZWN0bHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0SW1wbDo6Y29tcHV0ZVRyYW5z Zm9ybSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpmbHVzaENoYW5n ZXMpOgorCiAyMDEwLTAyLTI1ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9u aGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFhhbiBMb3Bl ei4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHAJKHJldmlzaW9uIDU1MjQ4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0xheWVyUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDgsMjkgKzMwOCwyNiBA QCBRVHJhbnNmb3JtIEdyYXBoaWNzTGF5ZXJRdEltcGw6OmNvbXB1dGVUCiAgICAgLy8gdGhpcyBo YXMgdG8gZG8gd2l0aCBob3cgV2ViQ29yZSBpbXBsZW1lbnRzIC13ZWJraXQtcGVyc3BlY3RpdmUg YW5kIC13ZWJraXQtcGVyc3BlY3RpdmUtb3JpZ2luLCB3aGljaCBhcmUgdGhlIENTUwogICAgIC8v IGF0dHJpYnV0ZSB0aGF0IGNhbGwgc2V0Q2hpbGRyZW5UcmFuc2Zvcm0KICAgICBRUG9pbnRGIG9m ZnNldCA9IC1wb3MoKSAtIGJvdW5kaW5nUmVjdCgpLmJvdHRvbVJpZ2h0KCkgLyAyOwotICAgIGNv bnN0IEdyYXBoaWNzTGF5ZXJRdEltcGwqIGFuY2VzdG9yID0gdGhpczsKLSAgICB3aGlsZSAoKGFu Y2VzdG9yID0gcW9iamVjdF9jYXN0PEdyYXBoaWNzTGF5ZXJRdEltcGwqPihhbmNlc3Rvci0+cGFy ZW50T2JqZWN0KCkpKSkgeworCisgICAgZm9yIChjb25zdCBHcmFwaGljc0xheWVyUXRJbXBsKiBh bmNlc3RvciA9IHRoaXM7IChhbmNlc3RvciA9IHFvYmplY3RfY2FzdDxHcmFwaGljc0xheWVyUXRJ bXBsKj4oYW5jZXN0b3ItPnBhcmVudE9iamVjdCgpKSk7ICkgewogICAgICAgICBpZiAoIWFuY2Vz dG9yLT5tX3N0YXRlLmNoaWxkcmVuVHJhbnNmb3JtLmlzSWRlbnRpdHkoKSkgewotICAgICAgICAg ICAgb2Zmc2V0ICs9IGFuY2VzdG9yLT5ib3VuZGluZ1JlY3QoKS5ib3R0b21SaWdodCgpIC8gMjsK KyAgICAgICAgICAgIGNvbnN0IFFQb2ludEYgb2Zmc2V0ID0gbWFwRnJvbUl0ZW0oYW5jZXN0b3Is IFFQb2ludEYoYW5jZXN0b3ItPm1fc2l6ZS53aWR0aCgpIC8gMiwgYW5jZXN0b3ItPm1fc2l6ZS5o ZWlnaHQoKSAvIDIpKTsKICAgICAgICAgICAgIGNvbXB1dGVkVHJhbnNmb3JtCiAgICAgICAgICAg ICAgICAgLnRyYW5zbGF0ZShvZmZzZXQueCgpLCBvZmZzZXQueSgpKQogICAgICAgICAgICAgICAg IC5tdWx0TGVmdChhbmNlc3Rvci0+bV9zdGF0ZS5jaGlsZHJlblRyYW5zZm9ybSkKICAgICAgICAg ICAgICAgICAudHJhbnNsYXRlKC1vZmZzZXQueCgpLCAtb2Zmc2V0LnkoKSk7CiAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgfQotICAgICAgICBvZmZzZXQgLT0gYW5jZXN0b3ItPnBvcygpOwog ICAgIH0KIAotICAgIGNvbXB1dGVkVHJhbnNmb3JtLm11bHRMZWZ0KGJhc2VUcmFuc2Zvcm0pOwot CiAgICAgLy8gd2Via2l0IGhhcyByZWxhdGl2ZS10by1zaXplIG9yaWdpblBvaW50LCBncmFwaGlj cy12aWV3IGhhcyBhIHBpeGVsIG9yaWdpblBvaW50LCBoZXJlIHdlIGNvbnZlcnQKICAgICAvLyB3 ZSBoYXZlIHRvIG1hbmFnZSB0aGlzIG91cnNlbHZlcyBiZWNhdXNlIFFHcmFwaGljc1ZpZXcncyB0 cmFuc2Zvcm1PcmlnaW4gaXMgaW5jb21wYXRpYmxlCiAgICAgY29uc3QgcXJlYWwgb3JpZ2luWCA9 IG1fc3RhdGUuYW5jaG9yUG9pbnQueCgpICogbV9zaXplLndpZHRoKCk7CiAgICAgY29uc3QgcXJl YWwgb3JpZ2luWSA9IG1fc3RhdGUuYW5jaG9yUG9pbnQueSgpICogbV9zaXplLmhlaWdodCgpOwot ICAgIGNvbXB1dGVkVHJhbnNmb3JtID0gVHJhbnNmb3JtYXRpb25NYXRyaXgoKQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC50cmFuc2xhdGUob3JpZ2luWCwgb3JpZ2luWSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAubXVsdGlwbHkoY29tcHV0ZWRUcmFuc2Zvcm0pCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgLnRyYW5zbGF0ZSgtb3JpZ2luWCwgLW9yaWdpblkpOworICAg IGNvbXB1dGVkVHJhbnNmb3JtCisgICAgICAgICAgICAudHJhbnNsYXRlM2Qob3JpZ2luWCwgb3Jp Z2luWSwgbV9zdGF0ZS5hbmNob3JQb2ludC56KCkpCisgICAgICAgICAgICAubXVsdExlZnQoYmFz ZVRyYW5zZm9ybSkKKyAgICAgICAgICAgIC50cmFuc2xhdGUzZCgtb3JpZ2luWCwgLW9yaWdpblks IC1tX3N0YXRlLmFuY2hvclBvaW50LnooKSk7CiAKICAgICAvLyBub3cgd2UgcHJvamVjdCB0byAy RAogICAgIHJldHVybiBRVHJhbnNmb3JtKGNvbXB1dGVkVHJhbnNmb3JtKTsKQEAgLTUxMSwxMSAr NTA4LDcgQEAgdm9pZCBHcmFwaGljc0xheWVyUXRJbXBsOjpmbHVzaENoYW5nZXMoYgogICAgICAg ICAgICAgaWYgKCFtX3N0YXRlLmRyYXdzQ29udGVudCAmJiBtX2xheWVyLT5kcmF3c0NvbnRlbnQo KSkKICAgICAgICAgICAgICAgICB1cGRhdGUoKTsKICAgICAgICAgICAgICAgICBpZiAobV9sYXll ci0+ZHJhd3NDb250ZW50KCkgJiYgIW1fbWFza0VmZmVjdCkgewotICAgICAgICAgICAgICAgICAg ICBjb25zdCBRR3JhcGhpY3NJdGVtOjpDYWNoZU1vZGUgbWV3Q2FjaGVNb2RlID0gaXNUcmFuc2Zv cm1BbmltYXRpb25SdW5uaW5nKCkgPyBJdGVtQ29vcmRpbmF0ZUNhY2hlIDogRGV2aWNlQ29vcmRp bmF0ZUNhY2hlOwotCi0gICAgICAgICAgICAgICAgICAgIC8vIG9wdGltaXphdGlvbjogUUdyYXBo aWNzSXRlbSBkb2Vzbid0IGFsd2F5cyBwZXJmb3JtIHRoaXMgdGVzdAotICAgICAgICAgICAgICAg ICAgICBpZiAobWV3Q2FjaGVNb2RlICE9IGNhY2hlTW9kZSgpKQotICAgICAgICAgICAgICAgICAg ICAgICAgc2V0Q2FjaGVNb2RlKG1ld0NhY2hlTW9kZSk7CisgICAgICAgICAgICAgICAgICAgIHNl dENhY2hlTW9kZShpc1RyYW5zZm9ybUFuaW1hdGlvblJ1bm5pbmcoKSA/IEl0ZW1Db29yZGluYXRl Q2FjaGUgOiBEZXZpY2VDb29yZGluYXRlQ2FjaGUpOwogCiAgICAgICAgICAgICAgICAgICAgIC8v IEhUTUwgY29udGVudDogd2Ugd2FudCB0byB1c2UgZXhwb3NlZFJlY3Qgc28gd2UgZG9uJ3QgdXNl IFdlYkNvcmUgcmVuZGVyaW5nIGlmIHdlIGRvbid0IGhhdmUgdG8KICAgICAgICAgICAgICAgICAg ICAgc2V0RmxhZyhRR3JhcGhpY3NJdGVtOjpJdGVtVXNlc0V4dGVuZGVkU3R5bGVPcHRpb24sIHRy dWUpOwo=