35374 2010-02-24 18:13:47 -0800 MediaPlayer has no reliable method of accessing it's owning document 2010-02-25 07:44:31 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 35328 0 nicholas.young webkit-unassigned commit-queue eric.carlson oldest_to_newest 193588 0 nicholas.young 2010-02-24 18:13:47 -0800 It is sometimes desirable for the MediaPlayer to access information about its owning document. Currently there is a method MediaPlayer::frameView(), which returns the FrameView which renders the MediaPlayer. However, there are some situations where a renderer is not created for a Media element, and as such there is no way for the MediaPlayer to access its owning document. An example of one of these situations can be seen here: http://people.freedesktop.org/~company/stuff/video-demo.html (Credit goes to Bug 30679 for this link) In this demonstration, the video elements are never added to the DOM, so a renderer is never created. As discussed in Bug 35328, the proposed solution is to add a MediaPlayerClient::mediaPlayerOwningDocument(). A patch is coming. 193591 1 49458 nicholas.young 2010-02-24 18:19:02 -0800 Created attachment 49458 Initial Patch 193645 2 49458 commit-queue 2010-02-24 23:14:14 -0800 Comment on attachment 49458 Initial Patch Clearing flags on attachment: 49458 Committed r55225: <http://trac.webkit.org/changeset/55225> 193646 3 commit-queue 2010-02-24 23:14:18 -0800 All reviewed patches have been landed. Closing bug. 193721 4 49458 darin 2010-02-25 07:44:31 -0800 Comment on attachment 49458 Initial Patch > +Document* HTMLMediaElement::mediaPlayerOwningDocument() > +{ > + Document* d = document(); > + > + if (!d) > + d = ownerDocument(); > + > + return d; > +} The implementation of this function is needlessly complex. The Node::document() function never returns 0 for an element, and ownerDocument() always returns the same thing as document() except when ownerDocument() returns 0. 49458 2010-02-24 18:19:02 -0800 2010-02-25 07:44:31 -0800 Initial Patch webkit-owning-document.txt text/plain 2605 nicholas.young ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjYwNjc2MS4uZTBhNDc2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMi0yNCAgTmljaG9sYXMgWW91 bmcgIDxuaWNob2xhcy55b3VuZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1lZGlhUGxheWVyT3duaW5nRG9jdW1lbnQoKSB0 byBNZWRpYVBsYXllckNsaWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM1Mzc0CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGVzZSBhcmUgaW50 ZXJmYWNlIGNoYW5nZXMgb25seS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBsYXllck93bmlu Z0RvY3VtZW50KTogSW1wbGVtZW50YXRpb24gZm9yIG1lZGlhIGVsZW1lbnQuCisgICAgICAgICog aHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVk aWFQbGF5ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyQ2xpZW50OjptZWRpYVBs YXllck93bmluZ0RvY3VtZW50KTogTmV3IHZpcnR1YWwgbWV0aG9kLgorCiAyMDEwLTAyLTIzICBE bWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwIGIvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGEzZTRhNDguLmZl ZDAwOGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysg Yi9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTcwNiw2ICs3MDYsMTYgQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50OjpjYW5jZWxQZW5kaW5nRXZlbnRzQW5kQ2FsbGJhY2tzKCkK ICAgICB9CiB9CiAKK0RvY3VtZW50KiBIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBsYXllck93bmlu Z0RvY3VtZW50KCkKK3sKKyAgICBEb2N1bWVudCogZCA9IGRvY3VtZW50KCk7CisgICAgCisgICAg aWYgKCFkKQorICAgICAgICBkID0gb3duZXJEb2N1bWVudCgpOworICAgIAorICAgIHJldHVybiBk OworfQorCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyTmV0d29ya1N0YXRlQ2hh bmdlZChNZWRpYVBsYXllciopCiB7CiAgICAgYmVnaW5Qcm9jZXNzaW5nTWVkaWFQbGF5ZXJDYWxs YmFjaygpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXggMDc4MDFkYS4uYjBjZWMxNCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0xOTMsNiArMTkzLDcgQEAgcHJvdGVjdGVkOgogICAg IHZpcnR1YWwgdm9pZCBkaWRNb3ZlVG9OZXdPd25lckRvY3VtZW50KCk7CiAKIHByaXZhdGU6IC8v IE1lZGlhUGxheWVyQ2xpZW50CisgICAgdmlydHVhbCBEb2N1bWVudCogbWVkaWFQbGF5ZXJPd25p bmdEb2N1bWVudCgpOwogICAgIHZpcnR1YWwgdm9pZCBtZWRpYVBsYXllck5ldHdvcmtTdGF0ZUNo YW5nZWQoTWVkaWFQbGF5ZXIqKTsKICAgICB2aXJ0dWFsIHZvaWQgbWVkaWFQbGF5ZXJSZWFkeVN0 YXRlQ2hhbmdlZChNZWRpYVBsYXllciopOwogICAgIHZpcnR1YWwgdm9pZCBtZWRpYVBsYXllclRp bWVDaGFuZ2VkKE1lZGlhUGxheWVyKik7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL01lZGlhUGxheWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmgKaW5kZXggMWNhNDU3Ni4uNGU1OGU1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9NZWRpYVBsYXllci5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv TWVkaWFQbGF5ZXIuaApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIk1lZGlhUGxheWVyUHJv eHkuaCIKICNlbmRpZgogCisjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJJbnRSZWN0 LmgiCiAjaW5jbHVkZSAiU3RyaW5nSGFzaC5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CkBA IC03NSw2ICs3Niw5IEBAIGNsYXNzIE1lZGlhUGxheWVyQ2xpZW50IHsKIHB1YmxpYzoKICAgICB2 aXJ0dWFsIH5NZWRpYVBsYXllckNsaWVudCgpIHsgfQogCisgICAgLy8gR2V0IHRoZSBkb2N1bWVu dCB3aGljaCB0aGUgbWVkaWEgcGxheWVyIGlzIG93bmVkIGJ5CisgICAgdmlydHVhbCBEb2N1bWVu dCogbWVkaWFQbGF5ZXJPd25pbmdEb2N1bWVudCgpIHsgcmV0dXJuIDA7IH0KKwogICAgIC8vIHRo ZSBuZXR3b3JrIHN0YXRlIGhhcyBjaGFuZ2VkCiAgICAgdmlydHVhbCB2b2lkIG1lZGlhUGxheWVy TmV0d29ya1N0YXRlQ2hhbmdlZChNZWRpYVBsYXllciopIHsgfQogCg==