35346 2010-02-24 08:26:52 -0800 Add a convenient center() method to IntRect 2010-04-06 02:58:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 18662 1 tonikitoo tonikitoo hausmann simon.fraser oldest_to_newest 193370 0 tonikitoo 2010-02-24 08:26:52 -0800 FloatRect has the same and according to https://bugs.webkit.org/show_bug.cgi?id=18662#c63 that is something acceptable. "to make this code more readable. You could also add IntPoint IntRect::center() const if you like (FloatRect has one)." patch coming. 193376 1 49399 tonikitoo 2010-02-24 08:39:24 -0800 Created attachment 49399 patch 0.1 193390 2 49399 simon.fraser 2010-02-24 09:23:38 -0800 Comment on attachment 49399 patch 0.1 r=me, but perhaps note in a comment that the center point suffers from rounding. 193452 3 tonikitoo 2010-02-24 12:23:41 -0800 simon, would + // NOTE: The result is rounded to integer values, and thus can be not the exact + // center point. + IntPoint center() const { return IntPoint(x() + width() / 2, y() + height() / 2); } be ok ? 193459 4 simon.fraser 2010-02-24 12:39:03 -0800 I'd change: "can be not the exact center point" to "may not be the exact center point". 193670 5 tonikitoo 2010-02-25 03:49:44 -0800 (In reply to comment #4) > I'd change: "can be not the exact center point" to "may not be the exact center > point". landed in r55228 thx simon and kenneth 49399 2010-02-24 08:39:24 -0800 2010-02-24 09:23:38 -0800 patch 0.1 0001-Add-a-convenient-center-method-to-IntRect.patch text/plain 1937 tonikitoo RnJvbSA3MmY4NTdhYTg0ZjNjMzZkZDdhMjUyNDc4ZmU4MDE4MDA3YWJiZTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAyNCBGZWIgMjAxMCAxMjoyOTozMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEFk ZCBhIGNvbnZlbmllbnQgY2VudGVyKCkgbWV0aG9kIHRvIEludFJlY3QKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTM0NgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgoKQXMgaXQg aXMgYSBjb252ZW5pZW5jZSBtZXRob2QsIGFuZCBpbXBsZW1lbnRpb24gaXMKYmFzZWQgb24gRmxv YXRSZWN0J3Mgb25lLCBwYXRjaCBkb2VzIG5vdCBwcm92aWRlIGEKbGF5b3V0IHRlc3QuCgoqIHBs YXRmb3JtL2dyYXBoaWNzL0ludFJlY3QuaDoKKFdlYkNvcmU6OkludFJlY3Q6OmNlbnRlcik6Ci0t LQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysr KysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRSZWN0LmggfCAgICAyICsrCiAyIGZp bGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMGMxZGQ5Li41 NmY1M2U3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTAyLTI0ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtp dG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIFBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisg ICAgICAgIEFkZCBhIGNvbnZlbmllbnQgY2VudGVyKCkgbWV0aG9kIHRvIEludFJlY3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MzQ2CisKKyAgICAg ICAgQXMgaXQgaXMgYSBjb252ZW5pZW5jZSBtZXRob2QsIGFuZCBpbXBsZW1lbnRpb24gaXMKKyAg ICAgICAgYmFzZWQgb24gRmxvYXRSZWN0J3Mgb25lLCBwYXRjaCBkb2VzIG5vdCBwcm92aWRlIGEK KyAgICAgICAgbGF5b3V0IHRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRS ZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbnRSZWN0OjpjZW50ZXIpOgorCiAyMDEwLTAyLTIz ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lu dFJlY3QuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5oCmluZGV4IGUzNjMz ZGYuLmE5OTdjOGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVj dC5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5oCkBAIC0xMDUsNiAr MTA1LDggQEAgcHVibGljOgogICAgIGludCByaWdodCgpIGNvbnN0IHsgcmV0dXJuIHgoKSArIHdp ZHRoKCk7IH0KICAgICBpbnQgYm90dG9tKCkgY29uc3QgeyByZXR1cm4geSgpICsgaGVpZ2h0KCk7 IH0KIAorICAgIEludFBvaW50IGNlbnRlcigpIGNvbnN0IHsgcmV0dXJuIEludFBvaW50KHgoKSAr IHdpZHRoKCkgLyAyLCB5KCkgKyBoZWlnaHQoKSAvIDIpOyB9CisKICAgICB2b2lkIG1vdmUoY29u c3QgSW50U2l6ZSYgcykgeyBtX2xvY2F0aW9uICs9IHM7IH0gCiAgICAgdm9pZCBtb3ZlKGludCBk eCwgaW50IGR5KSB7IG1fbG9jYXRpb24ubW92ZShkeCwgZHkpOyB9IAogCi0tIAoxLjYuMC40Cgo=