35169 2010-02-19 12:08:08 -0800 [Gtk] Webkit crashes when using orca 2010-02-23 00:10:08 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 25531 0 jmillan webkit-unassigned commit-queue jdiggs yuntong.jin oldest_to_newest 192011 0 jmillan 2010-02-19 12:08:08 -0800 As commented in https://bugs.webkit.org/show_bug.cgi?id=34463#c5 , webkit_accessible_text_get_caret_offset crashes when Orca is open. To reproduce enter in any webpage and press tab until WebKit crashes. 192013 1 49099 jmillan 2010-02-19 12:17:29 -0800 Created attachment 49099 Check if end selection node is null This patch makes webkit_accessible_text_get_caret_offset check if end selection node is null, avoiding crashing. 192625 2 49099 eric 2010-02-22 14:18:02 -0800 Comment on attachment 49099 Check if end selection node is null I think this makes sense. 192804 3 49099 commit-queue 2010-02-23 00:09:59 -0800 Comment on attachment 49099 Check if end selection node is null Clearing flags on attachment: 49099 Committed r55124: <http://trac.webkit.org/changeset/55124> 192805 4 commit-queue 2010-02-23 00:10:08 -0800 All reviewed patches have been landed. Closing bug. 49099 2010-02-19 12:17:29 -0800 2010-02-23 00:09:59 -0800 Check if end selection node is null 20100219_a11ycrash_35169_1.patch text/plain 1845 jmillan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTAyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTkgIEpvc8OpIE1pbGzDoW4gU290byAgPGptaWxsYW5A aWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR3RrXSBXZWJraXQgY3Jhc2hlcyB3aGVuIHVzaW5nIG9yY2EKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MTY5CisKKyAgICAgICAgTWFkZSB3 ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF9jYXJldF9vZmZzZXQgY2hlY2sgaWYgZW5kIHNlbGVj dGlvbgorICAgICAgICBub2RlIGlzIG51bGwuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0 ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNj ZXNzaWJsZV90ZXh0X2dldF9jYXJldF9vZmZzZXQpOgorCiAyMDEwLTAyLTE5ICBOYXRlIENoYXBp biAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBH bGF6a292LgpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlckF0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0 ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAJKHJldmlzaW9uIDU1MDI1KQorKysg V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTk5Niw4ICs5OTYsMTMgQEAgc3RhdGljIGdpbnQgd2Via2l0 X2FjY2Vzc2libGVfdGV4dF9nZXRfYwogICAgIC8vIGNvcmVPYmplY3QgaXMgdGhlIHVuaWdub3Jl ZCBvYmplY3Qgd2hvc2Ugb2Zmc2V0IHRoZSBjYWxsZXIgaXMgcmVxdWVzdGluZy4KICAgICAvLyBm b2N1c2VkT2JqZWN0IGlzIHRoZSBvYmplY3Qgd2l0aCB0aGUgY2FyZXQuIEl0IGlzIGxpa2VseSBp Z25vcmVkIC0tIHVubGVzcyBpdCdzIGEgbGluay4KICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBj b3JlT2JqZWN0ID0gY29yZSh0ZXh0KTsKLSAgICBSZW5kZXJPYmplY3QqIGZvY3VzZWROb2RlID0g Y29yZU9iamVjdC0+c2VsZWN0aW9uKCkuZW5kKCkubm9kZSgpLT5yZW5kZXJlcigpOwotICAgIEFj Y2Vzc2liaWxpdHlPYmplY3QqIGZvY3VzZWRPYmplY3QgPSBjb3JlT2JqZWN0LT5kb2N1bWVudCgp LT5heE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRlKGZvY3VzZWROb2RlKTsKKyAgICBOb2RlKiBm b2N1c2VkTm9kZSA9IGNvcmVPYmplY3QtPnNlbGVjdGlvbigpLmVuZCgpLm5vZGUoKTsKKworICAg IGlmICghZm9jdXNlZE5vZGUpCisgICAgICAgIHJldHVybiAwOworCisgICAgUmVuZGVyT2JqZWN0 KiBmb2N1c2VkUmVuZGVyZXIgPSBmb2N1c2VkTm9kZS0+cmVuZGVyZXIoKTsKKyAgICBBY2Nlc3Np YmlsaXR5T2JqZWN0KiBmb2N1c2VkT2JqZWN0ID0gY29yZU9iamVjdC0+ZG9jdW1lbnQoKS0+YXhP YmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShmb2N1c2VkUmVuZGVyZXIpOwogCiAgICAgaW50IG9m ZnNldDsKICAgICAvLyBEb24ndCBpZ25vcmUgbGlua3MgaWYgdGhlIG9mZnNldCBpcyBiZWluZyBy ZXF1ZXN0ZWQgZm9yIGEgbGluay4K