35053 2010-02-17 13:28:10 -0800 run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree 2010-02-18 02:56:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 34984 1 eric webkit-unassigned commit-queue levin ojan oldest_to_newest 191177 0 eric 2010-02-17 13:28:10 -0800 run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree 191178 1 48931 eric 2010-02-17 13:30:28 -0800 Created attachment 48931 Patch 191188 2 ojan 2010-02-17 13:44:00 -0800 Not a reviewer, but r=me if I were. :) 191440 3 48931 abarth 2010-02-18 00:01:08 -0800 Comment on attachment 48931 Patch Lame that script_path isn't on the base class of WebKitPort. Why is it on SCM? More fodder for our webkitpy TODO wave. 191474 4 48931 commit-queue 2010-02-18 00:54:53 -0800 Comment on attachment 48931 Patch Clearing flags on attachment: 48931 Committed r54945: <http://trac.webkit.org/changeset/54945> 191475 5 commit-queue 2010-02-18 00:54:57 -0800 All reviewed patches have been landed. Closing bug. 191506 6 eric 2010-02-18 02:56:30 -0800 SCM is what knows where the base of the checkout is. Also, the idea of a "port" is very recent. :) scm.py was the 3rd python file bugzilla-tool ever had! 48931 2010-02-17 13:30:28 -0800 2010-02-18 00:54:52 -0800 Patch bug-35053-20100217133027.patch text/plain 4726 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2Y2ZmODgyLi5lOTM2YWM0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDIt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJ1bi1jaHJvbWl1bS13ZWJraXQtdGVzdHMgLS1w bGF0Zm9ybT1tYWMtbGVvcGFyZCBuZWVkcyB0byBydW4gYnVpbGQtZHVtcHJlbmRlcnRyZWUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDUzCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHk6IEFkZCBz Y3JpcHRfcGF0aCgpIGZ1bmN0aW9uIGZvciBmaW5kaW5nIHNjcmlwdHMuCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weTogUmVtb3ZlIHVudXNl ZCBhcmd1bWVudC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L21hYy5weToKKyAgICAgICAgIC0gTWFrZSBzdXJlIHRoYXQgY2FsbGluZyB3ZWJraXQtYnVpbGQt ZGlyZWN0b3J5IHdvcmtzIGV2ZW4gaWYgU2NyaXB0cy8gaXMgbm90IGluIHRoZSB1c2VyJ3MgcGF0 aC4KKyAgICAgICAgIC0gQ2FsbCBidWlsZC1kdW1wcmVuZGVydHJlZSAoYW5kIG1ha2Ugc3VyZSBp dCBzdWNjZWVkcykgYmVmb3JlIHJ1bm5pbmcgdGhlIHRlc3RzLgorCiAyMDEwLTAyLTE2ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9iYXNlLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9iYXNlLnB5CmluZGV4IGUwYzdhM2YuLjJiMjVlMjkgMTAwNjQ0Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKQEAg LTI2OSw2ICsyNjksNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHVzZWQgYnkgcnVu LWNocm9taXVtLXdlYmtpdC10ZXN0cy4iIiIKICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRF cnJvcignUG9ydC5udW1fY29yZXMnKQogCisgICAgIyBGSVhNRTogVGhpcyBjb3VsZCBiZSByZXBs YWNlZCBieSBmdW5jdGlvbnMgaW4gd2Via2l0cHkuc2NtLgogICAgIGRlZiBwYXRoX2Zyb21fd2Vi a2l0X2Jhc2Uoc2VsZiwgKmNvbXBzKToKICAgICAgICAgIiIiUmV0dXJucyB0aGUgZnVsbCBwYXRo IHRvIHBhdGggbWFkZSBieSBqb2luaW5nIHRoZSB0b3Agb2YgdGhlCiAgICAgICAgIFdlYktpdCBz b3VyY2UgdHJlZSBhbmQgdGhlIGxpc3Qgb2YgcGF0aCBjb21wb25lbnRzIGluIHwqY29tcHN8LiIi IgpAQCAtMjc3LDYgKzI3OCwxMCBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgICAgICBz ZWxmLl93ZWJraXRfYmFzZV9kaXIgPSBhYnNwYXRoWzA6YWJzcGF0aC5maW5kKCdXZWJLaXRUb29s cycpXQogICAgICAgICByZXR1cm4gb3MucGF0aC5qb2luKHNlbGYuX3dlYmtpdF9iYXNlX2Rpciwg KmNvbXBzKQogCisgICAgIyBGSVhNRTogQ2FsbGVycyBzaG91bGQgZXZlbnR1YWxseSBtb3ZlIHRv IHNjbS5zY3JpcHRfcGF0aC4KKyAgICBkZWYgc2NyaXB0X3BhdGgoc2VsZiwgc2NyaXB0X25hbWUp OgorICAgICAgICByZXR1cm4gc2VsZi5wYXRoX2Zyb21fd2Via2l0X2Jhc2UoIldlYktpdFRvb2xz IiwgIlNjcmlwdHMiLCBzY3JpcHRfbmFtZSkKKwogICAgIGRlZiBwYXRoX3RvX3Rlc3RfZXhwZWN0 YXRpb25zX2ZpbGUoc2VsZik6CiAgICAgICAgICIiIlVwZGF0ZSB0aGUgdGVzdCBleHBlY3RhdGlv bnMgdG8gdGhlIHBhc3NlZC1pbiBzdHJpbmcuCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IGEx NzUzNDMuLjExMjMzNzYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtMTMyLDcgKzEzMiw3IEBA IGNsYXNzIENocm9taXVtUG9ydChiYXNlLlBvcnQpOgogICAgIGRlZiB0ZXN0X2Jhc2VfcGxhdGZv cm1fbmFtZXMoc2VsZik6CiAgICAgICAgIHJldHVybiAoJ2xpbnV4JywgJ21hYycsICd3aW4nKQog Ci0gICAgZGVmIHRlc3RfZXhwZWN0YXRpb25zKHNlbGYsIG9wdGlvbnM9Tm9uZSk6CisgICAgZGVm IHRlc3RfZXhwZWN0YXRpb25zKHNlbGYpOgogICAgICAgICAiIiJSZXR1cm5zIHRoZSB0ZXN0IGV4 cGVjdGF0aW9ucyBmb3IgdGhpcyBwb3J0LgogCiAgICAgICAgIEJhc2ljYWxseSB0aGlzIHN0cmlu ZyBzaG91bGQgY29udGFpbiB0aGUgZXF1aXZhbGVudCBvZiBhCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CmluZGV4IDU4MDEy ZjguLmQzNTVmNjIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CkBAIC02Nyw4ICs2NywxNiBAQCBjbGFzcyBNYWNQb3J0 KGJhc2UuUG9ydCk6CiAgICAgICAgIHJldHVybiBkaXJzCiAKICAgICBkZWYgY2hlY2tfc3lzX2Rl cHMoc2VsZik6Ci0gICAgICAgICMgRklYTUU6IFRoaXMgc2hvdWxkIHJ1biBidWlsZC1kdW1wcmVu ZGVydHJlZS4KLSAgICAgICAgIyBUaGlzIHNob3VsZCBhbHNvIHZhbGlkYXRlIHRoYXQgYWxsIG9m IHRoZSB0b29sIHBhdGhzIGFyZSB2YWxpZC4KKyAgICAgICAgaWYgZXhlY3V0aXZlLnJ1bl9jb21t YW5kKFtzZWxmLnNjcmlwdF9wYXRoKCJidWlsZC1kdW1wcmVuZGVydHJlZSIpXSwgcmV0dXJuX2V4 aXRfY29kZT1UcnVlKSAhPSAwOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAg ZHJpdmVyX3BhdGggPSBzZWxmLl9wYXRoX3RvX2RyaXZlcigpCisgICAgICAgIGlmIG5vdCBvcy5w YXRoLmV4aXN0cyhkcml2ZXJfcGF0aCk6CisgICAgICAgICAgICBsb2dnaW5nLmVycm9yKCJEdW1w UmVuZGVyVHJlZSB3YXMgbm90IGZvdW5kIGF0ICVzIiAlIGRyaXZlcl9wYXRoKQorICAgICAgICAg ICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAgIyBUaGlzIHNob3VsZCBhbHNvIHZhbGlkYXRlIHRo YXQgdGhlIEltYWdlRGlmZiBwYXRoIGlzIHZhbGlkIChvbmNlIHRoaXMgc2NyaXB0IGtub3dzIGhv dyB0byB1c2UgSW1hZ2VEaWZmKS4KKyAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzQ4MjYKICAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRlZiBudW1f Y29yZXMoc2VsZik6CkBAIC0xMDQsNyArMTEyLDcgQEAgY2xhc3MgTWFjUG9ydChiYXNlLlBvcnQp OgogICAgICAgICByZXR1cm4gKCdtYWMnLCkKIAogICAgIGRlZiBfc2tpcHBlZF9maWxlX3BhdGhz KHNlbGYpOgotICAgICAgICAjIFRoaXMgbWV0aG9kIHdpbGwgbmVlZCB0byBiZSBtYWRlIHdvcmsg Zm9yIG5vbi1tYWMgcGxhdGZvcm1zIGFuZCBtb3ZlZCBpbnRvIGJhc2UuUG9ydC4KKyAgICAgICAg IyBGSVhNRTogVGhpcyBtZXRob2Qgd2lsbCBuZWVkIHRvIGJlIG1hZGUgd29yayBmb3Igbm9uLW1h YyBwbGF0Zm9ybXMgYW5kIG1vdmVkIGludG8gYmFzZS5Qb3J0LgogICAgICAgICBza2lwcGVkX2Zp bGVzID0gW10KICAgICAgICAgaWYgc2VsZi5fbmFtZSBpbiAoJ21hYy10aWdlcicsICdtYWMtbGVv cGFyZCcsICdtYWMtc25vd2xlb3BhcmQnKToKICAgICAgICAgICAgIHNraXBwZWRfZmlsZXMuYXBw ZW5kKG9zLnBhdGguam9pbigKQEAgLTIwNiw3ICsyMTQsNyBAQCBjbGFzcyBNYWNQb3J0KGJhc2Uu UG9ydCk6CiAKICAgICBkZWYgX2J1aWxkX3BhdGgoc2VsZiwgKmNvbXBzKToKICAgICAgICAgaWYg bm90IHNlbGYuX2NhY2hlZF9idWlsZF9yb290OgotICAgICAgICAgICAgc2VsZi5fY2FjaGVkX2J1 aWxkX3Jvb3QgPSBleGVjdXRpdmUucnVuX2NvbW1hbmQoWyJ3ZWJraXQtYnVpbGQtZGlyZWN0b3J5 IiwgIi0tdG9wLWxldmVsIl0pLnJzdHJpcCgpCisgICAgICAgICAgICBzZWxmLl9jYWNoZWRfYnVp bGRfcm9vdCA9IGV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbc2VsZi5zY3JpcHRfcGF0aCgid2Via2l0 LWJ1aWxkLWRpcmVjdG9yeSIpLCAiLS10b3AtbGV2ZWwiXSkucnN0cmlwKCkKICAgICAgICAgcmV0 dXJuIG9zLnBhdGguam9pbihzZWxmLl9jYWNoZWRfYnVpbGRfcm9vdCwgc2VsZi5fb3B0aW9ucy50 YXJnZXQsICpjb21wcykKIAogICAgIGRlZiBfa2lsbF9wcm9jZXNzKHNlbGYsIHBpZCk6Cg==