35005 2010-02-16 15:45:53 -0800 [Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html fails 2010-03-26 08:39:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All CLOSED FIXED Qt P3 Normal --- 35784 1 ossy qi.2.zhang ariya.hidayat commit-queue cshu hausmann kent.hansen laszlo.gombos noam oldest_to_newest 190798 0 ossy 2010-02-16 15:45:53 -0800 It needs more investingating. http://build.webkit.org/results/Qt%20Linux%20Release/r54839%20%287422%29/results.html : --- /home/webkitbuildbot/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/canvas/drawImage-with-negative-source-destination-expected.txt 2010-02-16 15:08:32.970217114 -0800 +++ /home/webkitbuildbot/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/canvas/drawImage-with-negative-source-destination-actual.txt 2010-02-16 15:08:32.970217114 -0800 @@ -4,7 +4,7 @@ PASS imgdata[4] is 0 -PASS imgdata[5] is 255 +FAIL imgdata[5] should be 255. Was 0. PASS imgdata[6] is 0 PASS successfullyParsed is true 190802 1 ossy 2010-02-16 15:57:18 -0800 fast/canvas/drawImage-with-negative-source-destination.html skipped until fix by http://trac.webkit.org/changeset/54842 . 203172 2 51450 qi.2.zhang 2010-03-23 13:38:31 -0700 Created attachment 51450 support negative width and height At HTML5 spec 4.8.10.1.11 Images, about context.drawImage: The source rectangle is the rectangle whose corners are the four points (sx, sy), (sx+sw, sy), (sx+sw, sy+sh), (sx,sy+sh). The destination rectangle is the rectangle whose corners are the four points (dx, dy), (dx+dw, dy), (dx+dw,dy+dh), (dx, dy+dh). In this case, the sw(width) or sh(height) could be negative. Based on the spec, as long as sx+sw > 0 or sy+sh, it is still legal. In Qt, QPainter don't support a negative width or height. Bascially, to support negative width or height, we need to reset the (sx,sy) to make width or heigh to positive. 204516 3 51450 laszlo.gombos 2010-03-26 05:34:01 -0700 Comment on attachment 51450 support negative width and height Looks good, r+. 204525 4 51450 commit-queue 2010-03-26 05:58:14 -0700 Comment on attachment 51450 support negative width and height Clearing flags on attachment: 51450 Committed r56619: <http://trac.webkit.org/changeset/56619> 204526 5 commit-queue 2010-03-26 05:58:20 -0700 All reviewed patches have been landed. Closing bug. 204591 6 hausmann 2010-03-26 08:39:05 -0700 Revision r56619 cherry-picked into qtwebkit-2.0 with commit fa2319915a2edd5b11c44b519e43d48b29f228c0 51450 2010-03-23 13:38:31 -0700 2010-03-26 05:58:14 -0700 support negative width and height bug35005.patch text/plain 3280 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjQxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMjMgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBmYXN0L2NhbnZhcy9kcmF3SW1hZ2Utd2l0aC1uZWdhdGl2ZS1zb3VyY2UtZGVzdGluYXRpb24u aHRtbCBmYWlsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1MDA1CisKKyAgICAgICAgVG8gc3VwcG9ydCBuZWdhdGl2ZSB3aWR0aCBvciBoZWlnaHQg YXQgY29udGV4dC5kcmF3SW1hZ2UKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1N0 aWxsSW1hZ2VRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdGlsbEltYWdlOjpkcmF3KToKKwog MjAxMC0wMy0yMyAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU3RpbGxJbWFnZVF0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5jcHAJKHJldmlz aW9uIDU2MzQ3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TdGlsbEltYWdlUXQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw4ICs1Nyw0MyBAQCB2b2lkIFN0aWxsSW1hZ2U6OmRy YXcoR3JhcGhpY3NDb250ZXh0KiBjCiAKICAgICBjdHh0LT5zYXZlKCk7CiAgICAgY3R4dC0+c2V0 Q29tcG9zaXRlT3BlcmF0aW9uKG9wKTsKKworICAgIC8vIFRvIHN1cHBvcnQgd2lkdGggb3IgaGVp Z2h0IGlzIG5lZ2F0aXZlCisgICAgZmxvYXQgc3ggPSBzcmMueCgpOworICAgIGZsb2F0IHN5ID0g c3JjLnkoKTsKKyAgICBmbG9hdCBzdyA9IHNyYy53aWR0aCgpOworICAgIGZsb2F0IHNoID0gc3Jj LmhlaWdodCgpOworCisgICAgaWYgKHN3IDwgMCkgeworICAgICAgICBzeCA9IHN4ICsgc3c7Cisg ICAgICAgIHN3ID0gLXN3OworICAgIH0KKworICAgIGlmIChzaCA8IDApIHsKKyAgICAgICAgc3kg PSBzeSArIHNoOworICAgICAgICBzaCA9IC1zaDsKKyAgICB9CisKKyAgICBmbG9hdCBkeCA9IGRz dC54KCk7CisgICAgZmxvYXQgZHkgPSBkc3QueSgpOworICAgIGZsb2F0IGR3ID0gZHN0LndpZHRo KCk7CisgICAgZmxvYXQgZGggPSBkc3QuaGVpZ2h0KCk7CisKKyAgICBpZiAoZHcgPCAwKSB7Cisg ICAgICAgIGR4ID0gZHggKyBkdzsKKyAgICAgICAgZHcgPSAtZHc7CisgICAgfQorCisgICAgaWYg KGRoIDwgMCkgeworICAgICAgICBkeSA9IGR5ICsgZGg7CisgICAgICAgIGRoID0gLWRoOworICAg IH0KKworICAgIEZsb2F0UmVjdCBzcmNNKHN4LCBzeSwgc3csIHNoKTsKKyAgICBGbG9hdFJlY3Qg ZHN0TShkeCwgZHksIGR3LCBkaCk7CiAgICAgUVBhaW50ZXIqIHBhaW50ZXIoY3R4dC0+cGxhdGZv cm1Db250ZXh0KCkpOwotICAgIHBhaW50ZXItPmRyYXdQaXhtYXAoZHN0LCBtX3BpeG1hcCwgc3Jj KTsKKworICAgIHBhaW50ZXItPmRyYXdQaXhtYXAoZHN0TSwgbV9waXhtYXAsIHNyY00pOwogICAg IGN0eHQtPnJlc3RvcmUoKTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTY0MTEpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0w My0yMyAgUWkgWmhhbmcgIDxxaS4yLnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIGZhc3QvY2FudmFzL2RyYXdJbWFn ZS13aXRoLW5lZ2F0aXZlLXNvdXJjZS1kZXN0aW5hdGlvbi5odG1sIGZhaWxlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwMDUKKworICAgICAgICBF bmFibGUgZmFzdC9jYW52YXMvZHJhd0ltYWdlLXdpdGgtbmVnYXRpdmUtc291cmNlLWRlc3RpbmF0 aW9uLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTAtMDMtMjMg IE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2 aXNpb24gNTYzNDcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5n IGNvcHkpCkBAIC01MDUzLDEwICs1MDUzLDYgQEAgZmFzdC9sb2FkZXIvY3Jhc2gtY29weWluZy1i YWNrZm9yd2FyZGxpcwogIyBCZWNhdXNlIEVOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0wIGlzIHRo ZSBkZWZhdWx0IG9wdGlvbi4gKEFwcGxlJ3MgZGFzaGJvYXJkIHN1cHBvcnQgaW4gT1MgWCkKIGZh c3QvY3NzL2Rhc2hib2FyZC1yZWdpb25zLWF0dHItY3Jhc2guaHRtbAogCi0jIFtRdF0gUkVHUkVT U0lPTihyNTQ4MTEpIGZhc3QvY2FudmFzL2RyYXdJbWFnZS13aXRoLW5lZ2F0aXZlLXNvdXJjZS1k ZXN0aW5hdGlvbi5odG1sIGZhaWxzCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNTAwNQotZmFzdC9jYW52YXMvZHJhd0ltYWdlLXdpdGgtbmVnYXRpdmUtc291cmNl LWRlc3RpbmF0aW9uLmh0bWwKLQogIyBRdCBtYXkgd2FudCB0byBmb2xsb3cgR1RLKyBpbiBhZGRp bmcgYSBkZWZhdWx0IEFjY2VwdCBoZWFkZXIgZm9yCiAjIHN1YnJlc291cmNlcy4gU2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzI0Mi4KIGh0dHAvdGVzdHMvbWlz Yy9pbWFnZS1jaGVja3MtZm9yLWFjY2VwdC5odG1sCg==