34984 2010-02-16 13:26:56 -0800 new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over 2014-02-06 07:52:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar, NRWT, ToolsHitList P2 Normal --- 34826 34983 34985 34986 35001 35006 35049 35053 35055 35265 35266 35358 35359 37007 37736 37738 37739 38063 38756 43565 55907 56047 56729 56730 56731 57640 58293 58625 59894 60162 62178 62194 62425 62497 63199 63494 63523 63549 63786 63791 63832 63838 63839 63845 63956 63973 63983 64071 64086 64092 64346 64347 64445 64514 64564 64812 65719 66227 66228 67216 67268 70416 71087 71173 71364 57310 1 eric webkit-unassigned abarth abecsi aroben darin dglazkov dpranke galpeter hayato joepeck kbalazs laszlo.gombos leandro mjs mrowe ossy rakuco rgabor rniwa tonyg vestbo webkit.review.bot zoltan oldest_to_newest 190711 0 eric 2010-02-16 13:26:56 -0800 MASTER BUG: Switch webkit.org to using new python run-webkit-tests There are a lot of blocking issues. This will be a multi-week or possibly multi-month project. But I'm creating this tracking bug to help keep tabs on all the blocking issues. 192121 1 mrowe 2010-02-19 17:12:46 -0800 Should there be bugs about making this work on each of the supported platforms? Mac OS X 10.4 in particular comes to mind as it has the oldest version of Python of the supported platforms. 193455 2 eric 2010-02-24 12:27:14 -0800 Perhaps. I figure we'll cross that bridge when we come to it. I have no insight into Apple's deprecation plans, but its also possible that Tiger support will be dropped from WebKit before this work is completed. :) 365635 3 dpranke 2011-03-10 16:29:00 -0800 Taking ownership ... I plan to start a push to actually get this done, hopefully starting as early as next week (I just need to wrap up another project first, which should happen today or tomorrow). 365639 4 abarth 2011-03-10 16:30:04 -0800 (In reply to comment #3) > Taking ownership ... I plan to start a push to actually get this done, hopefully starting as early as next week (I just need to wrap up another project first, which should happen today or tomorrow). That's exciting! 410650 5 aroben 2011-05-26 11:45:23 -0700 <rdar://problem/9509321> 425000 6 dpranke 2011-06-21 21:15:14 -0700 Eric, I'm punting this to you now :) 425396 7 eric 2011-06-22 11:15:40 -0700 (In reply to comment #6) > Eric, I'm punting this to you now :) Thank you again Dirk for all your hard work on this. I'll pick this up next week. 432655 8 eric 2011-07-06 00:00:58 -0700 NRWT is enabled for all bots on build.webkit.org except Windows and WebKit2 as of: http://trac.webkit.org/changeset/90440 Hopefully it will stick! 439036 9 eric 2011-07-19 01:32:18 -0700 The change stuck. All bots except for Apple Win, WebKit2 and --leaks are running NRWT. Fixes for the remaining bots are underway. I'm taking vacation the next two weeks, so the remaining bots are unlikely to switch until August. 448061 10 eric 2011-08-08 10:04:23 -0700 I'm back. My goal is to switch WebKit2 and --leaks this week. I'll coordinate with Adam Roben and other windows folks to make sure we're moving forward on Win32 support, but it's not on my immediate goal list for this week. A stretch goal is to move some/all the existing bots over to parallel execution (which is the real benefit of this work). 448320 11 kbalazs 2011-08-08 15:43:12 -0700 I have a good news on the topic: The Qt WebKit2 bot (hosted at http://build.webkit.sed.hu/) has already successfully switched. 451095 12 eric 2011-08-15 09:51:57 -0700 Update: Fixed a bunch of random bugs last week and switched the --leaks bot. WK2 works, but I've not switched the bots yet. Win and Lion theoretically work, but I've not tested. I will be working on bidi-isolate (bug 65617) this week. I will resume work on NRWT Aug. 22nd, with the gaol of switching the WK2 bots as soon as possible. WK2 (and a bunch of these other bugs) boil down to one issue that NRWT uses a ServerProcess abstraction which reads line-by-line only from stdout. stderr is collected in one long string and processed after the process is done. This means that we can't detect timeouts (since they're sent via #timeout over stderr) or WebProcess crashes (for wk2). I just need to redesign the ServerProcess abstraction to allow reading from both stdout and stderr in a line-by-line fashion. This will be the first thing I do when I resume NRWT work in a week. 458347 13 eric 2011-08-29 12:11:46 -0700 OK. My work on bug 65617 is basically done (just waiting for review). Back to working on NRWT full time. 492712 14 112919 eric 2011-10-28 15:17:36 -0700 Created attachment 112919 Use a blacklist of unsupported platforms instead of a whitelist 492717 15 eric 2011-10-28 15:24:44 -0700 Once this last patch lands, all ports will use NRWT by default, with two specific exceptions (win and qt-arm), and I think we should close this bug. I'm working my way through the polish bugs now. 492781 16 112919 webkit.review.bot 2011-10-28 16:32:00 -0700 Comment on attachment 112919 Use a blacklist of unsupported platforms instead of a whitelist Clearing flags on attachment: 112919 Committed r98780: <http://trac.webkit.org/changeset/98780> 492782 17 webkit.review.bot 2011-10-28 16:32:10 -0700 All reviewed patches have been landed. Closing bug. 492913 18 rniwa 2011-10-29 00:55:25 -0700 It appears that this patch broke Qt bots: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/39090/steps/layout-test/logs/stdio 492919 19 rniwa 2011-10-29 01:18:56 -0700 I'm going to rollout the patch since Qt port's losing 100% of the test coverage due to this bug. 492922 20 rniwa 2011-10-29 01:29:16 -0700 Reopen the bug since the patch was rolled out in r98801. 492923 21 ossy 2011-10-29 02:07:08 -0700 Thanks for rolling out and unbreak Qt bots. :) I checked this fail, it was only a typo: isArm() vs isARM() . 492924 22 rniwa 2011-10-29 02:09:20 -0700 (In reply to comment #21) > Thanks for rolling out and unbreak Qt bots. :) I checked this fail, it was only a typo: isArm() vs isARM() . Oh, could you reland the patch with that fix in that case? 492934 23 kbalazs 2011-10-29 07:46:05 -0700 (In reply to comment #22) > (In reply to comment #21) > > Thanks for rolling out and unbreak Qt bots. :) I checked this fail, it was only a typo: isArm() vs isARM() . > > Oh, could you reland the patch with that fix in that case? Relanded in r98804. 492949 24 eric 2011-10-29 11:25:09 -0700 Thank you arm. 622544 25 rakuco 2012-05-13 15:09:38 -0700 Can we close this one now? 622545 26 rniwa 2012-05-13 15:10:47 -0700 (In reply to comment #25) > Can we close this one now? Has Windows port moved to new-run-webkit-tests yet? 623169 27 dpranke 2012-05-14 11:54:59 -0700 Nope, the Apple win port is still running ORWT. I would like to fix it, but the Apple win port is generally pretty unhappy these days so it's hard to isolate which issues are NRWT-related and which are just broken. Hopefully that will be fixed soon. 977338 28 ossy 2014-02-06 07:52:49 -0800 All bots run new-run-webkit-tests now, which is simple run-webkit-tests :) 112919 2011-10-28 15:17:36 -0700 2011-10-28 16:32:00 -0700 Use a blacklist of unsupported platforms instead of a whitelist bug-34984-20111028151735.patch text/plain 3990 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3NTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWM0YTAyY2VjMjA4OTQ4MzNiYzk2MGIzOWNjZGMyOTRh NDFmYmM1Li44ZjJlMDQ1NjgzMzJjNjQwMTExZmI0Y2RmMzdhNmZiZmE2MzFhZWU4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTEtMTAtMjggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IG5ldy1ydW4td2Via2l0LXRlc3RzOiBNQVNURVIgQlVHOiBTd2l0Y2ggYWxsIHdlYmtpdC5vcmcg Ym90cyBvdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNDk4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1vdmUgcnVuLXdlYmtpdC10ZXN0cyBmcm9tIHVzaW5nIGEgd2hpdGUtbGlzdCBvZiBzdXBwb3J0 ZWQgTlJXVCBwb3J0cworICAgICAgICB0byBhIGJsYWNrbGlzdCBvZiBwb3J0cyByZXF1aXJpbmcg T1JXVC4KKworICAgICAgICBJJ3ZlIGFsc28gYWRkZWQgdGhlIGFiaWxpdHkgdG8gb3B0LWluIHRv IHBhcmFsbGVsIHRlc3Rpbmcgb24gYSBwZXItcG9ydCBiYXNpcy4KKworICAgICAgICBXaXRoIHRo ZXNlIGNoYW5nZXMgSSdtIGdvaW5nIHRvIG9mZmljaWFsbHkgZGVjbGFyZSB0aGlzIGJ1ZyBkZWFk IGFuZAorICAgICAgICB3b3JrIG9uIHJlbWFpbmluZyBwb2xpc2ggaXNzdWVzIGFuZCBpbmRpdmlk dWFsIGRldmVsb3BlciBjb21wbGFpbnRzLgorCisgICAgICAgICogU2NyaXB0cy9ydW4td2Via2l0 LXRlc3RzOgorICAgICAgICAodXNlTmV3UnVuV2ViS2l0VGVzdHMpOgorICAgICAgICAocGxhdGZv cm1Jc1JlYWR5Rm9yUGFyYWxsZWxUZXN0aW5nKToKKworMjAxMS0xMC0yOCAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgTlJXVCBjcmFzaGVzIHdoZW4gcGFyc2luZyBs ZWFrcyBvdXRwdXQgZHVlIHRvIFVURi04IGRlY29kaW5nIGVycm9yCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTExMgogCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKaW5kZXggMDY4Y2E5YTI3N2UyYTJkNDgxMjMxNjg1OTEzYjU3MTA3ZDVjYWRjZC4uYjM2MDgz MWUzYjYzMDBkZGM2MTU5MjI5MjExMmUxYjUxNWY4NTFiNiAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0 cwpAQCAtNTcsMjIgKzU3LDI3IEBAIHN1YiBydW5uaW5nT25CdWlsZEJvdCgpCiAKIHN1YiB1c2VO ZXdSdW5XZWJLaXRUZXN0cygpCiB7Ci0gICAgIyBDaGFuZ2UgdGhpcyBjaGVjayB0byBjb250cm9s IHdoaWNoIHBsYXRmb3JtcyB1c2UgbmV3LXJ1bi13ZWJraXQtdGVzdHMgYnkgZGVmYXVsdC4KLSAg ICAjIEV4YW1wbGU6IHJldHVybiBydW5uaW5nT25CdWlsZEJvdCgpICYmIGlzTGVvcGFyZCgpOwot ICAgICMgd291bGQgZW5hYmxlIG5ldy1ydW4td2Via2l0LXRlc3RzIG9uIG9ubHkgdGhlIGxlb3Bh cmQgYnVpbGRib3RzLgotCi0gICAgIyBOb3RlOiBXZSB1c2UgYSB3aGl0ZWxpc3QgaGVyZSB0byBh dm9pZCBjYWxsaW5nIGlzUE9SVCgpIGZvciBwb3J0cwotICAgICMgZm9yIHdoaWNoIHdlIGhhdmVu J3QgZXhwbGljaXRseSBhZGRlZCBzdXBwb3J0LiAgQ2FsbGluZyBpc1BPUlQoKQotICAgICMgd2ls bCByZW1vdmUgdGhlIC0tUE9SVCBhcmd1bWVudCBmcm9tIEBBUkdWLCBjYXVzaW5nIHVzIHRvIGZh aWwgdG8gcGFzcyBpdCB0byB0aGUgdGVzdCBoYXJuZXNzLgotCiAgICAgIyBOUldUIFdpbmRvd3Mg c3VwcG9ydCBzdGlsbCBuZWVkcyB3b3JrOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzg3NTYKKyAgICByZXR1cm4gMCBpZiBpc1dpbmRvd3MoKSBvciBpc0N5Z3dpbigp OworICAgICMgTlJXVCBkb2VzIG5vdCBzdXBwb3J0IHF0LWFybTogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDg2CisgICAgcmV0dXJuIDAgaWYgaXNRdCgpIGFuZCBp c0FybSgpOworICAgICMgQWxsIG90aGVyIHBsYXRmb3JtcyBzaG91bGQgdXNlIE5SV1QgYnkgZGVm YXVsdC4KKyAgICByZXR1cm4gMTsKK30KIAotICAgICMgTlJXVCBkb2Vzbid0IHN1cHBvcnQgcXQt YXJtIGFuZCBxdC00LjggcGxhdGZvcm1zIG5vdzogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY0MDcxIGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQwODYKLSAgICBpZiAoaXNRdCgpKSB7Ci0gICAgICAgIHJldHVybiAoIWlzQVJNKCkp OwotICAgIH0KLQotICAgIHJldHVybiAoaXNMZW9wYXJkKCkgb3IgaXNTbm93TGVvcGFyZCgpIG9y IGlzTGlvbigpIG9yIGlzR3RrKCkpOworc3ViIHBsYXRmb3JtSXNSZWFkeUZvclBhcmFsbGVsVGVz dGluZygpCit7CisgICAgIyBOUldUIGlzIGFibGUgdG8gcnVuIHRoZSB0ZXN0cyBpbiBwYXJhbGxl bCwgT1JXVCB3YXMgbm90LgorICAgICMgV2hlbiB3ZSBydW4gdGhlIHRlc3RzIGluIHBhcmFsbGVs LCB0ZXN0cyB3aGljaCAoaW5jb3JyZWN0bHkpCisgICAgIyBpbnRlcmFjdCB3aXRoIGVhY2ggb3Ro ZXIgY2FuIHN0YXJ0IGZhaWxpbmcuCisgICAgIyBUbyByZWR1Y2UgdGhlIGZhaWx1cmUgYnVyZGVu IGR1cmluZyB0aGUgdHJhbnNpdGlvbiBpbmRpdmlkdWFsCisgICAgIyBwbGF0Zm9ybXMgY2FuIG9w dC1pbiB0byBwYXJhbGxlbCB0ZXN0IGV4ZWN1dGlvbiBieSBkZWZhdWx0LgorCisgICAgIyBQbGF0 Zm9ybXMgaW50ZXJlc3RlZCBpbiBkb2ctZm9vZGluZyBmYXN0ZXIgdGVzdCBydW5zIG9uIHRoZWly IGJvdHMKKyAgICAjIHNob3VsZCBhZGQgdGhlbXNlbHZlcyB0byB0aGlzIGJsYWNrbGlzdCwgZS5n LjoKKyAgICAjIHJldHVybiBpc0d0aygpIG9yIGlzUXQoKTsKKyAgICAjIFRoaXMgd2lsbCBsaWtl bHkgcmVxdWlyZSBza2lwcGluZyB0ZXN0cyBvciBtYXJraW5nIHRlc3RzIGFzIGZsYWt5IGluIHRl c3RfZXhwZWN0YXRpb25zLnR4dAorICAgIHJldHVybiAwOwogfQogCiBteSAkaGFybmVzc05hbWUg PSAib2xkLXJ1bi13ZWJraXQtdGVzdHMiOwpAQCAtODAsNyArODUsNyBAQCBteSAkaGFybmVzc05h bWUgPSAib2xkLXJ1bi13ZWJraXQtdGVzdHMiOwogaWYgKHVzZU5ld1J1bldlYktpdFRlc3RzKCkp IHsKICAgICAkaGFybmVzc05hbWUgPSAibmV3LXJ1bi13ZWJraXQtdGVzdHMiOwogCi0gICAgaWYg KCFncmVwKC8tLWNoaWxkLXByb2Nlc3Nlcy8sIEBBUkdWKSkgeworICAgIGlmICghZ3JlcCgvLS1j aGlsZC1wcm9jZXNzZXMvLCBAQVJHVikgYW5kICFwbGF0Zm9ybUlzUmVhZHlGb3JQYXJhbGxlbFRl c3RpbmcoKSkgewogICAgICAgICBwdXNoKEBBUkdWLCAiLS1jaGlsZC1wcm9jZXNzZXM9MSIpOwog ICAgICAgICBwcmludCAiUnVubmluZyBuZXctcnVuLXdlYmtpdC10ZXN0cyB3aXRoIG9uZSBjaGls ZCBwcm9jZXNzLlxuIjsKICAgICAgICAgcHJpbnQgIkZvciBtb3JlIHBhcmFsbGVsaXNtLCBydW4g bmV3LXJ1bi13ZWJraXQtdGVzdHMgZGlyZWN0bHkuXG4iOwpAQCAtOTEsNyArOTYsNiBAQCBpZiAo dXNlTmV3UnVuV2ViS2l0VGVzdHMoKSkgewogICAgIH0KIH0KIAotIyBGSVhNRTogV2UgbmVlZCBh IGNsZWFuZXIgd2F5IHRvIGRvIC0tcGxhdGZvcm0gaGFuZGxpbmcuCiAjIHdlYmtpdGRpcnMucG0g c3RyaXBzIC0tcXQgYW5kIC0tZ3RrIGZyb20gQEFSR1Ygd2hlbiB3ZSBjYWxsIGlzUXQvaXNHdGsu CiAjIFdlIGhhdmUgdG8gYWRkIGJhY2sgYW55IC0tUE9SVCBhcmd1bWVudHMgd2hpY2ggbWF5IGhh dmUgYmVlbiByZW1vdmVkIGJ5IGlzUG9ydCgpIGNoZWNrcyBhYm92ZS4KIGlmIChpc1F0KCkpIHsK