34749 2010-02-09 06:56:18 -0800 [Qt] QScriptEngine should contain nullValue and undefinedValue methods 2010-02-09 18:53:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue oldest_to_newest 188987 0 jedrzej.nowacki 2010-02-09 06:56:18 -0800 Current implementation of QtScript's QScriptEngine is lacking nullValue() and undefinedValue() methods. The methods should return a null and an undefined QScriptValues. 188988 1 48410 jedrzej.nowacki 2010-02-09 07:01:42 -0800 Created attachment 48410 Fix v1 Implementation of the functions 189210 2 48410 commit-queue 2010-02-09 18:53:11 -0800 Comment on attachment 48410 Fix v1 Clearing flags on attachment: 48410 Committed r54580: <http://trac.webkit.org/changeset/54580> 189211 3 commit-queue 2010-02-09 18:53:16 -0800 All reviewed patches have been landed. Closing bug. 48410 2010-02-09 07:01:42 -0800 2010-02-09 18:53:10 -0800 Fix v1 nullundefValue.diff text/plain 3209 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA0YWQ4MjM0Li4wOTE5ZmJkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTAtMDItMDkgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3 IGZ1bmN0aW9ucyBudWxsVmFsdWUoKSBhbmQgdW5kZWZpbmVkVmFsdWUoKS4KKworICAgICAgICBb UXRdIFFTY3JpcHRFbmdpbmUgc2hvdWxkIGNvbnRhaW4gbnVsbFZhbHVlIGFuZCB1bmRlZmluZWRW YWx1ZSBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNDc0OQorCisgICAgICAgICogcXQvYXBpL3FzY3JpcHRlbmdpbmUuY3BwOgorICAgICAg ICAoUVNjcmlwdEVuZ2luZTo6bnVsbFZhbHVlKToKKyAgICAgICAgKFFTY3JpcHRFbmdpbmU6OnVu ZGVmaW5lZFZhbHVlKToKKyAgICAgICAgKiBxdC9hcGkvcXNjcmlwdGVuZ2luZS5oOgorICAgICAg ICAqIHF0L3Rlc3RzL3FzY3JpcHRlbmdpbmUvdHN0X3FzY3JpcHRlbmdpbmUuY3BwOgorICAgICAg ICAodHN0X1FTY3JpcHRFbmdpbmU6Om51bGxWYWx1ZSk6CisgICAgICAgICh0c3RfUVNjcmlwdEVu Z2luZTo6dW5kZWZpbmVkVmFsdWUpOgorCiAyMDEwLTAyLTA0ICBKZWRyemVqIE5vd2Fja2kgIDxq ZWRyemVqLm5vd2Fja2lAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmUu Y3BwIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmUuY3BwCmluZGV4IGYxMmY0 MTAuLmZiZWI5MDIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5n aW5lLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZS5jcHAKQEAg LTg2LDMgKzg2LDIzIEBAIHZvaWQgUVNjcmlwdEVuZ2luZTo6Y29sbGVjdEdhcmJhZ2UoKQogewog ICAgIGRfcHRyLT5jb2xsZWN0R2FyYmFnZSgpOwogfQorCisvKiEKKyAgUmV0dXJucyBhIFFTY3Jp cHRWYWx1ZSBvZiB0aGUgcHJpbWl0aXZlIHR5cGUgTnVsbC4KKworICBcc2EgdW5kZWZpbmVkVmFs dWUoKQorKi8KK1FTY3JpcHRWYWx1ZSBRU2NyaXB0RW5naW5lOjpudWxsVmFsdWUoKQoreworICAg IHJldHVybiBRU2NyaXB0VmFsdWUodGhpcywgUVNjcmlwdFZhbHVlOjpOdWxsVmFsdWUpOworfQor CisvKiEKKyAgUmV0dXJucyBhIFFTY3JpcHRWYWx1ZSBvZiB0aGUgcHJpbWl0aXZlIHR5cGUgVW5k ZWZpbmVkLgorCisgIFxzYSBudWxsVmFsdWUoKQorKi8KK1FTY3JpcHRWYWx1ZSBRU2NyaXB0RW5n aW5lOjp1bmRlZmluZWRWYWx1ZSgpCit7CisgICAgcmV0dXJuIFFTY3JpcHRWYWx1ZSh0aGlzLCBR U2NyaXB0VmFsdWU6OlVuZGVmaW5lZFZhbHVlKTsKK30KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRD b3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lLmggYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlw dGVuZ2luZS5oCmluZGV4IGNmNjFkMzUuLmI4YmQ1ZTYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD b3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fz Y3JpcHRlbmdpbmUuaApAQCAtMzgsNiArMzgsOCBAQCBwdWJsaWM6CiAgICAgUVNjcmlwdFZhbHVl IGV2YWx1YXRlKGNvbnN0IFFTdHJpbmcmIHByb2dyYW0sIGNvbnN0IFFTdHJpbmcmIGZpbGVOYW1l ID0gUVN0cmluZygpLCBpbnQgbGluZU51bWJlciA9IDEpOwogICAgIHZvaWQgY29sbGVjdEdhcmJh Z2UoKTsKIAorICAgIFFTY3JpcHRWYWx1ZSBudWxsVmFsdWUoKTsKKyAgICBRU2NyaXB0VmFsdWUg dW5kZWZpbmVkVmFsdWUoKTsKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIFFTY3JpcHRFbmdp bmVQcml2YXRlOwogCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0 ZW5naW5lL3RzdF9xc2NyaXB0ZW5naW5lLmNwcCBiL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3Fz Y3JpcHRlbmdpbmUvdHN0X3FzY3JpcHRlbmdpbmUuY3BwCmluZGV4IDM3ZjNkMTEuLmIzNmUzNjQg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHRlbmdpbmUvdHN0X3Fz Y3JpcHRlbmdpbmUuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHRlbmdp bmUvdHN0X3FzY3JpcHRlbmdpbmUuY3BwCkBAIC0zNSw2ICszNSw4IEBAIHB1YmxpYyBzbG90czoK IHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBldmFsdWF0ZSgpOwogICAgIHZvaWQgY29sbGVjdEdh cmJhZ2UoKTsKKyAgICB2b2lkIG51bGxWYWx1ZSgpOworICAgIHZvaWQgdW5kZWZpbmVkVmFsdWUo KTsKIH07CiAKIC8qIEV2YWx1YXRpbmcgYSBzY3JpcHQgdGhhdCB0aHJvdyBhbiB1bmhhbmRsZWQg ZXhjZXB0aW9uIHNob3VsZCByZXR1cm4gYW4gaW52YWxpZCB2YWx1ZS4gKi8KQEAgLTU0LDUgKzU2 LDIyIEBAIHZvaWQgdHN0X1FTY3JpcHRFbmdpbmU6OmNvbGxlY3RHYXJiYWdlKCkKICAgICBlbmdp bmUuY29sbGVjdEdhcmJhZ2UoKTsKICAgICBRQ09NUEFSRShmb28uY2FsbCgpLnRvU3RyaW5nKCks IFFTdHJpbmc6OmZyb21Bc2NpaSgicG9uZyIpKTsKIH0KKwordm9pZCB0c3RfUVNjcmlwdEVuZ2lu ZTo6bnVsbFZhbHVlKCkKK3sKKyAgICBRU2NyaXB0RW5naW5lIGVuZ2luZTsKKyAgICBRU2NyaXB0 VmFsdWUgdmFsdWUgPSBlbmdpbmUubnVsbFZhbHVlKCk7CisgICAgUVZFUklGWSh2YWx1ZS5pc1Zh bGlkKCkpOworICAgIFFWRVJJRlkodmFsdWUuaXNOdWxsKCkpOworfQorCit2b2lkIHRzdF9RU2Ny aXB0RW5naW5lOjp1bmRlZmluZWRWYWx1ZSgpCit7CisgICAgUVNjcmlwdEVuZ2luZSBlbmdpbmU7 CisgICAgUVNjcmlwdFZhbHVlIHZhbHVlID0gZW5naW5lLnVuZGVmaW5lZFZhbHVlKCk7CisgICAg UVZFUklGWSh2YWx1ZS5pc1ZhbGlkKCkpOworICAgIFFWRVJJRlkodmFsdWUuaXNVbmRlZmluZWQo KSk7Cit9CisKIFFURVNUX01BSU4odHN0X1FTY3JpcHRFbmdpbmUpCiAjaW5jbHVkZSAidHN0X3Fz Y3JpcHRlbmdpbmUubW9jIgo=