34742 2010-02-09 00:32:04 -0800 [Qt] Optimize getCPUTime for Symbian 2010-02-26 11:51:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Critical --- 27065 1 koshuin koshuin commit-queue hausmann laszlo.gombos webkit.review.bot oldest_to_newest 188917 0 koshuin 2010-02-09 00:32:04 -0800 Running tst_QWebPage::infiniteLoopJS() will never exit (testrun timeout is 1h) and unit test executable stops responding. In order to exit the phone has to be rebooted. When running the same test on emulator it will pass. So for some reason javascript execution on HW is not stopped. Implications of this test is , if failing, that any JS code getting stuck or taking long will block the running thread. Test was run on Nokia 5800 Express Music, Qt and QtWebkit built for armv5 urel using RVCT 2.2. 191047 1 koshuin 2010-02-17 08:11:54 -0800 This issue is caused by bug in Open C 1.6 implementation of gettimeofday(). gtod precision seems to vary from min. 1sec to several minutes i.e. calling gtod several times in a row will return the same value. This value is then used in TimeoutChecker getCPUTime() to calculate time spent running the script causing the script never to be interrupted. 192880 2 49276 koshuin 2010-02-23 04:46:59 -0800 Created attachment 49276 proposed fix for timeoutchecker.cpp Patch contains a proper implementation of getCPUTime for Symbian. It works from Symbian 9.1 onwards i.e. S60 3rd edition and up as that is when GetCpuTime function was introduced. Tested the the patch to run on Nokia N95 and Nokia 5800 Express Music. It is possible that some device doesn't implement the function or has it disabled, thus added assertion for debugging purposes to see if some device returns KErrNotSupported. Also reported the gettimeofday -issue to Open C guys, so that will be fixed in future releases. 192883 3 webkit.review.bot 2010-02-23 04:51:37 -0800 Attachment 49276 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/TimeoutChecker.cpp:92: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 192887 4 49278 koshuin 2010-02-23 05:01:10 -0800 Created attachment 49278 proposed fix for timeoutchecker.cpp style fixed fixed style issue with , 192972 5 laszlo.gombos 2010-02-23 08:48:25 -0800 I changed the title to better reflect what this patch does. Approach looks good to me I think Symbian specific code is justified here. 194189 6 49278 commit-queue 2010-02-26 11:50:59 -0800 Comment on attachment 49278 proposed fix for timeoutchecker.cpp style fixed Clearing flags on attachment: 49278 Committed r55296: <http://trac.webkit.org/changeset/55296> 194190 7 commit-queue 2010-02-26 11:51:04 -0800 All reviewed patches have been landed. Closing bug. 49276 2010-02-23 04:46:59 -0800 2010-02-23 05:01:10 -0800 proposed fix for timeoutchecker.cpp timeoutchecker.diff text/plain 1604 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxNmFlMGU2Li5iZTAyZWJiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDItMjMgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBTeW1iaWFuIHNwZWNpZmljIGdldENQVVRpbWUgaW1wbGVtZXRhdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3NDIKKworICAgICAgICBEZWZh dWx0IGltcGxlbWVudGF0aW9uIGRvZXNuJ3Qgd29yayBvbiBTeW1iaWFuIGRldmljZXMuCisgICAg ICAgIFRoaXMgY2hhbmdlIGFkZHMgYSBwcm9wZXIgaW1wbGVtZW50YXRpb24gYnkKKyAgICAgICAg YXNraW5nIHRocmVhZCBleGVjdXRpb24gdGltZSBmcm9tIHRoZSBjdXJyZW50IHRocmVhZC4KKwor ICAgICAgICAqIHJ1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwOgorICAgICAgICAoSlNDOjpnZXRD UFVUaW1lKToKKwogMjAxMC0wMi0yMiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwIGIvSmF2YVNjcmlwdENv cmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKaW5kZXggMjUwZmRhZi4uMjliYjQ3MSAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKKysrIGIv SmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKQEAgLTg0LDYgKzg0LDEz IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgZ2V0Q1BVVGltZSgpCiAgICAgR2V0VGhyZWFkVGlt ZXMoR2V0Q3VycmVudFRocmVhZCgpLCAmY3JlYXRpb25UaW1lLCAmZXhpdFRpbWUsICZrZXJuZWxU aW1lLmZpbGVUaW1lLCAmdXNlclRpbWUuZmlsZVRpbWUpOwogICAgIAogICAgIHJldHVybiB1c2Vy VGltZS5maWxlVGltZUFzTG9uZyAvIDEwMDAwICsga2VybmVsVGltZS5maWxlVGltZUFzTG9uZyAv IDEwMDAwOworI2VsaWYgT1MoU1lNQklBTikKKyAgICBSVGhyZWFkIGN1cnJlbnQ7CisgICAgVFRp bWVJbnRlcnZhbE1pY3JvU2Vjb25kcyBjcHVUaW1lOworCisgICAgVEludCBlcnIgPSBjdXJyZW50 LkdldENwdVRpbWUoY3B1VGltZSk7CisgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShlcnIgPT0gS0Vy ck5vbmUsIkdldENwdVRpbWUgZmFpbGVkIHdpdGggJWQiLGVycik7CisgICAgcmV0dXJuIGNwdVRp bWUuSW50NjQoKSAvIDEwMDA7CiAjZWxpZiBQTEFURk9STShCUkVXTVApCiAgICAgLy8gVGhpcyBm dW5jdGlvbiByZXR1cm5zIGEgY29udGludW91c2x5IGFuZCBsaW5lYXJseSBpbmNyZWFzaW5nIG1p bGxpc2Vjb25kCiAgICAgLy8gdGltZXIgZnJvbSB0aGUgdGltZSB0aGUgZGV2aWNlIHdhcyBwb3dl cmVkIG9uLgo= 49278 2010-02-23 05:01:10 -0800 2010-02-26 11:50:59 -0800 proposed fix for timeoutchecker.cpp style fixed timeoutchecker.diff text/plain 1606 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxNmFlMGU2Li5iZTAyZWJiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDItMjMgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBTeW1iaWFuIHNwZWNpZmljIGdldENQVVRpbWUgaW1wbGVtZXRhdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3NDIKKworICAgICAgICBEZWZh dWx0IGltcGxlbWVudGF0aW9uIGRvZXNuJ3Qgd29yayBvbiBTeW1iaWFuIGRldmljZXMuCisgICAg ICAgIFRoaXMgY2hhbmdlIGFkZHMgYSBwcm9wZXIgaW1wbGVtZW50YXRpb24gYnkKKyAgICAgICAg YXNraW5nIHRocmVhZCBleGVjdXRpb24gdGltZSBmcm9tIHRoZSBjdXJyZW50IHRocmVhZC4KKwor ICAgICAgICAqIHJ1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwOgorICAgICAgICAoSlNDOjpnZXRD UFVUaW1lKToKKwogMjAxMC0wMi0yMiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVGltZW91dENoZWNrZXIuY3BwIGIvSmF2YVNjcmlwdENv cmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKaW5kZXggMjUwZmRhZi4uMjliYjQ3MSAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKKysrIGIv SmF2YVNjcmlwdENvcmUvcnVudGltZS9UaW1lb3V0Q2hlY2tlci5jcHAKQEAgLTg0LDYgKzg0LDEz IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgZ2V0Q1BVVGltZSgpCiAgICAgR2V0VGhyZWFkVGlt ZXMoR2V0Q3VycmVudFRocmVhZCgpLCAmY3JlYXRpb25UaW1lLCAmZXhpdFRpbWUsICZrZXJuZWxU aW1lLmZpbGVUaW1lLCAmdXNlclRpbWUuZmlsZVRpbWUpOwogICAgIAogICAgIHJldHVybiB1c2Vy VGltZS5maWxlVGltZUFzTG9uZyAvIDEwMDAwICsga2VybmVsVGltZS5maWxlVGltZUFzTG9uZyAv IDEwMDAwOworI2VsaWYgT1MoU1lNQklBTikKKyAgICBSVGhyZWFkIGN1cnJlbnQ7CisgICAgVFRp bWVJbnRlcnZhbE1pY3JvU2Vjb25kcyBjcHVUaW1lOworCisgICAgVEludCBlcnIgPSBjdXJyZW50 LkdldENwdVRpbWUoY3B1VGltZSk7CisgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShlcnIgPT0gS0Vy ck5vbmUsICJHZXRDcHVUaW1lIGZhaWxlZCB3aXRoICVkIiwgZXJyKTsKKyAgICByZXR1cm4gY3B1 VGltZS5JbnQ2NCgpIC8gMTAwMDsKICNlbGlmIFBMQVRGT1JNKEJSRVdNUCkKICAgICAvLyBUaGlz IGZ1bmN0aW9uIHJldHVybnMgYSBjb250aW51b3VzbHkgYW5kIGxpbmVhcmx5IGluY3JlYXNpbmcg bWlsbGlzZWNvbmQKICAgICAvLyB0aW1lciBmcm9tIHRoZSB0aW1lIHRoZSBkZXZpY2Ugd2FzIHBv d2VyZWQgb24uCg==