34705 2010-02-08 08:02:50 -0800 [BREWMP] Add a function to create a BREW instance without local variable declarations. 2010-03-15 21:07:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned abarth beergun commit-queue darin eric oldest_to_newest 188627 0 skyul 2010-02-08 08:02:50 -0800 It is too verbose to create a BREW instance. For example, to create a IFileMgr instance, it takes three lines: IFileMgr* fileMgr; IShell* shell = reinterpret_cast<AEEApplet*>(GETAPPINSTANCE())->m_pIShell; ISHELL_CreateInstance(shell, AEECLSID_FILEMGR, reinterpret_cast<void**>(&fileMgr)); This pattern is repeated all over the code, so we need a shortcut here. Add a template function to create a BREW instance in one line. IFileMgr* fileMgr = createInstanceBrew<IFileMgr>(AEECLSID_FILEMGR); This can be nicely combined with OwnPtrBrew. OwnPtrBrew<IFileMgr> fileMgr(createInstanceBrew<IFileMgr>(AEECLSID_FILEMGR)); 188628 1 48333 skyul 2010-02-08 08:08:31 -0800 Created attachment 48333 Patch ShellUtilBrew.h is currently under wtf/brew, but I am not sure if this is the right place to put platform-specific utility functions. 188643 2 darin 2010-02-08 09:13:06 -0800 (In reply to comment #1) > ShellUtilBrew.h is currently under wtf/brew, but I am not sure if this is the > right place to put platform-specific utility functions. It’s the right directory for low-level functions of this type. But “utility” is not a word we ever use, and we certainly frown on “Util” in a file name. 188654 3 48338 skyul 2010-02-08 09:34:35 -0800 Created attachment 48338 Patch Remove Util from the filename and prefix the function with shell createInstanceBrew -> shellCreateInstanceBrew 188864 4 eric 2010-02-08 19:20:10 -0800 Should this return a PassOwnPtrBrew? 188869 5 skyul 2010-02-08 19:46:50 -0800 (In reply to comment #4) > Should this return a PassOwnPtrBrew? These is no PassOwnPtrBrew class. I just wanted to simplify the creation of a BREW instance. As OwnPtrBrew takes a raw pointer in the constructor, we can use an idiom like the following: OwnPtrBrew<IFileMgr> fileMgr(createInstanceBrew<IFileMgr>(AEECLSID_FILEMGR)); Do you suggest that this should return a PassOwnPtrBrew? 189128 6 abarth 2010-02-09 12:40:40 -0800 > Do you suggest that this should return a PassOwnPtrBrew? In general, createMumble methods return a PassFooBar object to ensure we don't leak the allocated memory. 191273 7 48338 eric 2010-02-17 15:54:47 -0800 Comment on attachment 48338 Patch Why would this be part of WTF? This seems like port-specific goop. We don't need to have PassOwnPtrBrew to approve this, but eventually it would be nice to have such a class to make leaking memory returned from this function impossible. 196994 8 50169 skyul 2010-03-07 01:34:28 -0800 Created attachment 50169 Patch Make the function return PassOwnPtr. This prevents memory leaking. 199922 9 50169 eric 2010-03-15 16:21:30 -0700 Comment on attachment 50169 Patch LGTM. 199976 10 50169 commit-queue 2010-03-15 21:07:06 -0700 Comment on attachment 50169 Patch Clearing flags on attachment: 50169 Committed r56031: <http://trac.webkit.org/changeset/56031> 199977 11 commit-queue 2010-03-15 21:07:13 -0700 All reviewed patches have been landed. Closing bug. 48333 2010-02-08 08:08:31 -0800 2010-02-08 09:34:35 -0800 Patch ShellUtil.patch text/plain 3124 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0NDg5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMDggIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBBZGQgYSB1dGlsaXR5IGZ1bmN0aW9uIHRv IGNyZWF0ZSBhIEJSRVcgaW5zdGFuY2Ugd2l0aG91dCBsb2NhbCB2YXJpYWJsZSBkZWNsYXJhdGlv bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDcw NQorCisgICAgICAgIEFkZCBhIHRlbXBsYXRlIGZ1bmN0aW9uIHRvIGNyZWF0ZSBhIEJSRVcgaW5z dGFuY2UgaW4gb25lIGxpbmUuCisKKyAgICAgICAgKiB3dGYvYnJldy9TaGVsbFV0aWxCcmV3Lmg6 IEFkZGVkLgorICAgICAgICAoV1RGOjpjcmVhdGVJbnN0YW5jZUJyZXcpOgorCiAyMDEwLTAyLTA4 ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVr PgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgbWFrZSBkaXN0Y2hlY2suCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS93dGYvYnJldy9TaGVsbFV0aWxCcmV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw dENvcmUvd3RmL2JyZXcvU2hlbGxVdGlsQnJldy5oCShyZXZpc2lvbiAwKQorKysgSmF2YVNjcmlw dENvcmUvd3RmL2JyZXcvU2hlbGxVdGlsQnJldy5oCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDU1 IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6 CisgKgorICogMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0 aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLiAKKyAqIDIuICBSZWRpc3RyaWJ1dGlvbnMg aW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lciBpbiB0aGUKKyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMg cHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLiAKKyAqIDMuICBOZWl0aGVyIHRoZSBuYW1l IG9mIEFwcGxlIENvbXB1dGVyLCBJbmMuICgiQXBwbGUiKSBub3IgdGhlIG5hbWVzIG9mCisgKiAg ICAgaXRzIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJv ZHVjdHMgZGVyaXZlZAorICogICAgIGZyb20gdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmlj IHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4gCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9W SURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKKyAqIEVY UFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBU TywgVEhFIElNUExJRUQKKyAqIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyAqIERJU0NMQUlNRUQuIElOIE5PIEVW RU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyAq IERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBS T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7CisgKiBMT1NTIE9GIFVT RSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQKKyAqIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRS QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YKKyAqIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCisgKi8KKworI2lmbmRlZiBTaGVsbFV0aWxCcmV3X2gKKyNkZWZpbmUgU2hlbGxVdGls QnJld19oCisKKyNpbmNsdWRlIDxBRUVBcHBHZW4uaD4KKyNpbmNsdWRlIDxBRUVTdGRMaWIuaD4K KworI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisKK25hbWVzcGFjZSBXVEYgeworCit0ZW1w bGF0ZSA8dHlwZW5hbWUgVD4KK3N0YXRpYyBpbmxpbmUgVCogY3JlYXRlSW5zdGFuY2VCcmV3KEFF RUNMU0lEIGNscykKK3sKKyAgICBUKiBpbnN0YW5jZSA9IDA7CisKKyAgICBJU2hlbGwqIHNoZWxs ID0gcmVpbnRlcnByZXRfY2FzdDxBRUVBcHBsZXQqPihHRVRBUFBJTlNUQU5DRSgpKS0+bV9wSVNo ZWxsOworICAgIElTSEVMTF9DcmVhdGVJbnN0YW5jZShzaGVsbCwgY2xzLCByZWludGVycHJldF9j YXN0PHZvaWQqKj4oJmluc3RhbmNlKSk7CisgICAgQVNTRVJUKGluc3RhbmNlKTsKKworICAgIHJl dHVybiBpbnN0YW5jZTsKK30KKworfSAvLyBuYW1lc3BhY2UgV1RGCisKK3VzaW5nIFdURjo6Y3Jl YXRlSW5zdGFuY2VCcmV3OworCisjZW5kaWYgLy8gU2hlbGxVdGlsQnJld19oCg== 48338 2010-02-08 09:34:35 -0800 2010-03-07 01:34:28 -0800 Patch Shell.patch text/plain 3103 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0NDkxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMDggIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBBZGQgYSBmdW5jdGlvbiB0byBjcmVhdGUg YSBCUkVXIGluc3RhbmNlIHdpdGhvdXQgbG9jYWwgdmFyaWFibGUgZGVjbGFyYXRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3MDUKKworICAg ICAgICBBZGQgYSB0ZW1wbGF0ZSBmdW5jdGlvbiB0byBjcmVhdGUgYSBCUkVXIGluc3RhbmNlIGlu IG9uZSBsaW5lLgorCisgICAgICAgICogd3RmL2JyZXcvU2hlbGxCcmV3Lmg6IEFkZGVkLgorICAg ICAgICAoV1RGOjpzaGVsbENyZWF0ZUluc3RhbmNlQnJldyk6CisKIDIwMTAtMDItMDggIEd1c3Rh dm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAg ICAgICAgQnVpbGQgZml4IGZvciBtYWtlIGRpc3RjaGVjay4KSW5kZXg6IEphdmFTY3JpcHRDb3Jl L3d0Zi9icmV3L1NoZWxsQnJldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9i cmV3L1NoZWxsQnJldy5oCShyZXZpc2lvbiAwKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL2JyZXcv U2hlbGxCcmV3LmgJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTUgQEAKKy8qCisgKiBDb3B5cmln aHQgKEMpIDIwMTAgQ29tcGFueSAxMDAsIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisg KiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRo IG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqCisgKiAxLiAgUmVkaXN0 cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIuIAorICogMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAg IGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBk aXN0cmlidXRpb24uIAorICogMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIs IEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKKyAqICAgICBpdHMgY29udHJpYnV0b3Jz IG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCisgKiAg ICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJt aXNzaW9uLiAKKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIEFORCBJ VFMgQ09OVFJJQlVUT1JTICJBUyBJUyIgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdB UlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICog V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRQorICogRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgT1Ig SVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQorICogRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMK KyAqIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyAqIExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORAorICogT04gQU5Z IFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgorICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZu ZGVmIFNoZWxsQnJld19oCisjZGVmaW5lIFNoZWxsQnJld19oCisKKyNpbmNsdWRlIDxBRUVBcHBH ZW4uaD4KKyNpbmNsdWRlIDxBRUVTdGRMaWIuaD4KKworI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25z Lmg+CisKK25hbWVzcGFjZSBXVEYgeworCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KK3N0YXRpYyBp bmxpbmUgVCogc2hlbGxDcmVhdGVJbnN0YW5jZUJyZXcoQUVFQ0xTSUQgY2xzKQoreworICAgIFQq IGluc3RhbmNlID0gMDsKKworICAgIElTaGVsbCogc2hlbGwgPSByZWludGVycHJldF9jYXN0PEFF RUFwcGxldCo+KEdFVEFQUElOU1RBTkNFKCkpLT5tX3BJU2hlbGw7CisgICAgSVNIRUxMX0NyZWF0 ZUluc3RhbmNlKHNoZWxsLCBjbHMsIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPigmaW5zdGFuY2Up KTsKKyAgICBBU1NFUlQoaW5zdGFuY2UpOworCisgICAgcmV0dXJuIGluc3RhbmNlOworfQorCit9 IC8vIG5hbWVzcGFjZSBXVEYKKwordXNpbmcgV1RGOjpzaGVsbENyZWF0ZUluc3RhbmNlQnJldzsK KworI2VuZGlmIC8vIFNoZWxsQnJld19oCg== 50169 2010-03-07 01:34:28 -0800 2010-03-15 21:07:06 -0700 Patch Shell.patch text/plain 3101 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU1NjM0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMDcgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBBZGQgYSBmdW5jdGlvbiB0byBjcmVhdGUg YSBCUkVXIGluc3RhbmNlIHdpdGhvdXQgbG9jYWwgdmFyaWFibGUgZGVjbGFyYXRpb25zLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ3MDUKKworICAg ICAgICBBZGQgYSB0ZW1wbGF0ZSBmdW5jdGlvbiB0byBjcmVhdGUgYSBCUkVXIGluc3RhbmNlIGlu IG9uZSBsaW5lLgorCisgICAgICAgICogd3RmL2JyZXcvU2hlbGxCcmV3Lmg6IEFkZGVkLgorICAg ICAgICAoV1RGOjpjcmVhdGVJbnN0YW5jZSk6CisKIDIwMTAtMDMtMDcgIEplZHJ6ZWogTm93YWNr aSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2lt b24gSGF1c21hbm4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvYnJldy9TaGVsbEJyZXcuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvYnJldy9TaGVsbEJyZXcuaAkocmV2aXNp b24gMCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9icmV3L1NoZWxsQnJldy5oCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDU2IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIENvbXBhbnkgMTAw IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cworICogYXJlIG1ldDoKKyAqCisgKiAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuIAorICogMi4gIFJl ZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29w eXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv bGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uIAorICogMy4gIE5l aXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIpIG5vciB0aGUg bmFtZXMgb2YKKyAqICAgICBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ug b3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCisgKiAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdp dGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKKyAqCisgKiBUSElTIFNP RlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIEFORCBJVFMgQ09OVFJJQlVUT1JTICJBUyBJUyIg QU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICogV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC SUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorICogRElTQ0xB SU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgT1IgSVRTIENPTlRSSUJVVE9SUyBCRSBMSUFC TEUgRk9SIEFOWQorICogRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhF TVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyAqIChJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsK KyAqIExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJ T04pIEhPV0VWRVIgQ0FVU0VEIEFORAorICogT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdI RVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJ TkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhF IFVTRSBPRgorICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZuZGVmIFNoZWxsQnJld19oCisjZGVmaW5l IFNoZWxsQnJld19oCisKKyNpbmNsdWRlIDxBRUVBcHBHZW4uaD4KKyNpbmNsdWRlIDxBRUVTdGRM aWIuaD4KKworI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVkZSA8d3RmL1Bhc3NP d25QdHIuaD4KKworbmFtZXNwYWNlIFdURiB7CisKK3RlbXBsYXRlIDx0eXBlbmFtZSBUPgorc3Rh dGljIGlubGluZSBQYXNzT3duUHRyPFQ+IGNyZWF0ZUluc3RhbmNlKEFFRUNMU0lEIGNscykKK3sK KyAgICBUKiBpbnN0YW5jZSA9IDA7CisKKyAgICBJU2hlbGwqIHNoZWxsID0gcmVpbnRlcnByZXRf Y2FzdDxBRUVBcHBsZXQqPihHRVRBUFBJTlNUQU5DRSgpKS0+bV9wSVNoZWxsOworICAgIElTSEVM TF9DcmVhdGVJbnN0YW5jZShzaGVsbCwgY2xzLCByZWludGVycHJldF9jYXN0PHZvaWQqKj4oJmlu c3RhbmNlKSk7CisgICAgQVNTRVJUKGluc3RhbmNlKTsKKworICAgIHJldHVybiBpbnN0YW5jZTsK K30KKworfSAvLyBuYW1lc3BhY2UgV1RGCisKK3VzaW5nIFdURjo6Y3JlYXRlSW5zdGFuY2U7CisK KyNlbmRpZiAvLyBTaGVsbEJyZXdfaAo=