34601 2010-02-04 09:56:27 -0800 [BREWMP] Port Heap::allocateBlock and Heap::freeBlock 2010-08-11 05:38:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED INVALID P2 Normal --- 33564 0 skyul webkit-unassigned oldest_to_newest 187843 0 skyul 2010-02-04 09:56:27 -0800 Use fastMalloc to allocate 64KB aligned memory because BREW has neither VirtualAlloc nor mmap. There is no way to allocate aligned memory in BREW. 187845 1 48154 skyul 2010-02-04 10:02:35 -0800 Created attachment 48154 Patch This is not a space-efficient way to allocate aligned memory. Any suggestion to improve this? 196663 2 48154 eric 2010-03-05 14:22:27 -0800 Comment on attachment 48154 Patch I don't understand why m_rawMemoryMap is needed. Isn't the conversion from requested address to real address always the same? 197569 3 48154 abarth 2010-03-09 07:32:51 -0800 Comment on attachment 48154 Patch I would have called addressAligned alignedAddress, but that's just a nit. To answer Eric's question, the two are different in the case were fastMalloc returns an unaligned address because + addressAligned &= BLOCK_MASK; changes the address. This patch is horribly memory inefficient. It seems to cause JavaScript use about twice as much memory as necessary. I'd recommend finding another strategy to allocate aligned addresses. 230875 4 57131 nlawrence 2010-05-26 13:58:59 -0700 Created attachment 57131 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. 230877 5 57131 nlawrence 2010-05-26 14:02:10 -0700 Comment on attachment 57131 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. sorry, wrong bug. 263203 6 skyul 2010-08-11 05:38:57 -0700 This patch is no longer necessary as Heap::allocateBlock and Heap::freeBlock are changed to use AlignedMemoryAllocator. 48154 2010-02-04 10:02:35 -0800 2010-05-26 13:58:59 -0700 Patch allocate.patch text/plain 3589 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MzQ4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDItMDQgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBQb3J0IEhlYXA6OmFsbG9jYXRlQmxvY2sg YW5kIEhlYXA6OmZyZWVCbG9jaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzQ2MDEKKworICAgICAgICBVc2UgZmFzdE1hbGxvYyB0byBhbGxvY2F0ZSA2 NEtCIGFsaWduZWQgbWVtb3J5IGFzIEJSRVcKKyAgICAgICAgZG9lcyBub3QgaGF2ZSBhbGlnbmVk IG1lbW9yeSBhbGxvY2F0b3IuCisKKyAgICAgICAgKiBydW50aW1lL0NvbGxlY3Rvci5jcHA6Cisg ICAgICAgIChKU0M6OkhlYXA6OmFsbG9jYXRlQmxvY2spOgorICAgICAgICAoSlNDOjpIZWFwOjpm cmVlQmxvY2tQdHIpOgorICAgICAgICAqIHJ1bnRpbWUvQ29sbGVjdG9yLmg6CisKIDIwMTAtMDIt MDQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbGxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9D b2xsZWN0b3IuY3BwCShyZXZpc2lvbiA1NDM0NCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q29sbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDcgQEAKIC8qCiAgKiAgQ29w eXJpZ2h0IChDKSAyMDAzLCAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqICBDb3B5cmlnaHQgKEMpIDIwMDcgRXJpYyBT ZWlkZWwgPGVyaWNAd2Via2l0Lm9yZz4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMTAgQ29tcGFueSAx MDAsIEluYy4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAgLTIzNSw2ICsyMzYsMjEgQEAgTkVWRVJf SU5MSU5FIENvbGxlY3RvckJsb2NrKiBIZWFwOjphbGxvYwogICAgIHZvaWQqIGFkZHJlc3MgPSBf YWxpZ25lZF9tYWxsb2MoQkxPQ0tfU0laRSwgQkxPQ0tfU0laRSk7CiAjZW5kaWYKICAgICBtZW1z ZXQoYWRkcmVzcywgMCwgQkxPQ0tfU0laRSk7CisjZWxpZiBQTEFURk9STShCUkVXTVApCisgICAg Ly8gRklYTUU6IE1ha2UgdGhlIGFkZHJlc3MgNjRLQiBhbGlnbmVkIHdpdGggZmFzdE1hbGxvYy4K KyAgICAvLyBUaGlzIHdhc3RlcyBtZW1vcnkgc3BhY2UgYmVjYXVzZSBpdCBhbGxvY2F0ZXMKKyAg ICAvLyBleHRyYSBtZW1vcnkgdG8gbWFrZSB0aGUgcG9pbnRlciBhbGlnbmVkLgorICAgIHZvaWQq IGJ1ZmZlciA9IGZhc3RNYWxsb2MoQkxPQ0tfU0laRSArIEJMT0NLX09GRlNFVF9NQVNLKTsKKyAg ICB1bnNpZ25lZCBhZGRyZXNzQWxpZ25lZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQ+KGJ1 ZmZlcik7CisgICAgYWRkcmVzc0FsaWduZWQgJj0gQkxPQ0tfTUFTSzsKKyAgICBpZiAoYWRkcmVz c0FsaWduZWQgPCByZWludGVycHJldF9jYXN0PHVuc2lnbmVkPihidWZmZXIpKQorICAgICAgICBh ZGRyZXNzQWxpZ25lZCArPSBCTE9DS19TSVpFOworCisgICAgbV9yYXdNZW1vcnlNYXAuYWRkKGFk ZHJlc3NBbGlnbmVkLCBidWZmZXIpOworCisgICAgdm9pZCogYWRkcmVzcyA9IHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KGFkZHJlc3NBbGlnbmVkKTsKKyAgICBtZW1zZXQoYWRkcmVzcywgMCwgQkxP Q0tfU0laRSk7CisKICNlbGlmIEhBVkUoUE9TSVhfTUVNQUxJR04pCiAgICAgdm9pZCogYWRkcmVz czsKICAgICBwb3NpeF9tZW1hbGlnbigmYWRkcmVzcywgQkxPQ0tfU0laRSwgQkxPQ0tfU0laRSk7 CkBAIC0zMTcsNiArMzMzLDkgQEAgTkVWRVJfSU5MSU5FIHZvaWQgSGVhcDo6ZnJlZUJsb2NrUHRy KENvbAogICAgIHZtX2RlYWxsb2NhdGUoY3VycmVudF90YXNrKCksIHJlaW50ZXJwcmV0X2Nhc3Q8 dm1fYWRkcmVzc190PihibG9jayksIEJMT0NLX1NJWkUpOwogI2VsaWYgT1MoU1lNQklBTikKICAg ICB1c2VyQ2h1bmstPkZyZWUocmVpbnRlcnByZXRfY2FzdDxUQW55Kj4oYmxvY2spKTsKKyNlbGlm IFBMQVRGT1JNKEJSRVdNUCkKKyAgICB2b2lkKiBidWZmZXIgPSBtX3Jhd01lbW9yeU1hcC50YWtl KHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQ+KGJsb2NrKSk7CisgICAgZmFzdEZyZWUoYnVmZmVy KTsKICNlbGlmIE9TKFdJTkNFKQogICAgIFZpcnR1YWxGcmVlKGJsb2NrLCAwLCBNRU1fUkVMRUFT RSk7CiAjZWxpZiBPUyhXSU5ET1dTKQpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xs ZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5o CShyZXZpc2lvbiA1NDM0NCkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI1LDYgKzI1LDcgQEAKICNpbmNsdWRlIDxzdGRkZWYuaD4KICNp bmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvSGFzaENvdW50ZWRTZXQuaD4KKyNpbmNs dWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5jbHVkZSA8 d3RmL05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgpAQCAtMTY4LDYgKzE2 OSwxMCBAQCBuYW1lc3BhY2UgSlNDIHsKICNlbmRpZgogCiAgICAgICAgIEpTR2xvYmFsRGF0YSog bV9nbG9iYWxEYXRhOworCisjaWYgUExBVEZPUk0oQlJFV01QKQorICAgICAgICBIYXNoTWFwPHVu c2lnbmVkLCB2b2lkKj4gbV9yYXdNZW1vcnlNYXA7CisjZW5kaWYKICAgICB9OwogCiAgICAgLy8g dHVuYWJsZSBwYXJhbWV0ZXJzCkBAIC0xODEsNyArMTg2LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAj ZW5kaWYKICAgICB0ZW1wbGF0ZTw+IHN0cnVjdCBDZWxsU2l6ZTxzaXplb2YodWludDY0X3QpPiB7 IHN0YXRpYyBjb25zdCBzaXplX3QgbV92YWx1ZSA9IDY0OyB9OwogCi0jaWYgT1MoV0lOQ0UpIHx8 IE9TKFNZTUJJQU4pCisjaWYgT1MoV0lOQ0UpIHx8IE9TKFNZTUJJQU4pIHx8IFBMQVRGT1JNKEJS RVdNUCkKICAgICBjb25zdCBzaXplX3QgQkxPQ0tfU0laRSA9IDY0ICogMTAyNDsgLy8gNjRrCiAj ZWxzZQogICAgIGNvbnN0IHNpemVfdCBCTE9DS19TSVpFID0gNjQgKiA0MDk2OyAvLyAyNTZrCg== 57131 2010-05-26 13:58:59 -0700 2010-05-26 14:02:10 -0700 Moved the advance logic from Heap::allocate to CollectorBitmap::advanceToNextPossibleFreeCell. nlawrence-jsc-wordalloc.patch text/plain 2166 nlawrence SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYwMjQ1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMjYgIE5hdGhhbiBM YXdyZW5jZSAgPG5sYXdyZW5jZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv ZmZyZXkgR2FyZW4uCisKKyAgICAgICAgU2VhcmNoIGZvciB0aGUgbmV3IGFsbG9jYXRpb24gb25l IHdvcmQgYXQgYSB0aW1lLiAgSW1wcm92ZXMKKyAgICAgICAgcGVyZm9ybWFuY2Ugb24gU3VuU3Bp ZGVyIGJ5IGFwcHJveGltYXRlbHkgMSUuCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM5NzU4CisKKyAgICAgICAgKiBydW50aW1lL0NvbGxlY3Rvci5jcHA6 CisgICAgICAgIChKU0M6OkhlYXA6OmFsbG9jYXRlKToKKyAgICAgICAgKiBydW50aW1lL0NvbGxl Y3Rvci5oOgorICAgICAgICAoSlNDOjpDb2xsZWN0b3JCaXRtYXA6OmFkdmFuY2VUb05leHRQb3Nz aWJsZUZyZWVDZWxsKToKKwogMjAxMC0wNS0yNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpeGVkIGJ1aWxkIGZhaWx1cmUgY2F1c2VkIGJ5IG1lcmdlLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcAkocmV2aXNpb24gNjAxNzYpCisr KyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM5NCw3ICszOTQsOCBAQCBhbGxvY2F0ZToKICAgICAgICAgICAgICAgICArK21faGVhcC5uZXh0 Q2VsbDsKICAgICAgICAgICAgICAgICByZXR1cm4gY2VsbDsKICAgICAgICAgICAgIH0KLSAgICAg ICAgfSB3aGlsZSAoKyttX2hlYXAubmV4dENlbGwgIT0gSGVhcENvbnN0YW50czo6Y2VsbHNQZXJC bG9jayk7CisgICAgICAgICAgICBibG9jay0+bWFya2VkLmFkdmFuY2VUb05leHRQb3NzaWJsZUZy ZWVDZWxsKG1faGVhcC5uZXh0Q2VsbCk7CisgICAgICAgIH0gd2hpbGUgKG1faGVhcC5uZXh0Q2Vs bCAhPSBIZWFwQ29uc3RhbnRzOjpjZWxsc1BlckJsb2NrKTsKICAgICAgICAgbV9oZWFwLm5leHRD ZWxsID0gMDsKICAgICB9IHdoaWxlICgrK21faGVhcC5uZXh0QmxvY2sgIT0gbV9oZWFwLnVzZWRC bG9ja3MpOwogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmgJKHJldmlzaW9uIDYw MTc2KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMjIwLDYgKzIyMCwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdm9pZCBzZXQo c2l6ZV90IG4pIHsgYml0c1tuID4+IDVdIHw9ICgxIDw8IChuICYgMHgxRikpOyB9IAogICAgICAg ICB2b2lkIGNsZWFyKHNpemVfdCBuKSB7IGJpdHNbbiA+PiA1XSAmPSB+KDEgPDwgKG4gJiAweDFG KSk7IH0gCiAgICAgICAgIHZvaWQgY2xlYXJBbGwoKSB7IG1lbXNldChiaXRzLCAwLCBzaXplb2Yo Yml0cykpOyB9CisgICAgICAgIEFMV0FZU19JTkxJTkUgdm9pZCBhZHZhbmNlVG9OZXh0UG9zc2li bGVGcmVlQ2VsbChzaXplX3QmIHN0YXJ0Q2VsbCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYg KCF+Yml0c1tzdGFydENlbGwgPj4gNV0pCisgICAgICAgICAgICAgICAgc3RhcnRDZWxsID0gKHN0 YXJ0Q2VsbCAmICh+MHgxRikpICsgMzI7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgKytzdGFydENlbGw7CisgICAgICAgIH0KICAgICAgICAgc2l6ZV90IGNvdW50KHNpemVfdCBz dGFydENlbGwgPSAwKQogICAgICAgICB7CiAgICAgICAgICAgICBzaXplX3QgcmVzdWx0ID0gMDsK