34575 2010-02-04 05:51:06 -0800 [Qt] QScriptValue::isNumber() returns an incorrect value 2010-02-09 18:19:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 34533 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue jedrzej.nowacki webkit.review.bot oldest_to_newest 187754 0 jedrzej.nowacki 2010-02-04 05:51:06 -0800 For these values: QScriptValue v1(0, 0.0); QScriptValue v2(0.0); QScriptValue v3(0, 0); QScriptValue v4(0); ::isNumber() returns false which is incorrect. 187757 1 48135 jedrzej.nowacki 2010-02-04 05:58:35 -0800 Created attachment 48135 Fix v1 187759 2 webkit.review.bot 2010-02-04 06:03:15 -0800 Attachment 48135 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Ignoring "JavaScriptCore/qt/api/qscriptvalue_p.h": this file is exempt from the style guide. JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:58: isNumber_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:100: isNumber_initData is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:101: isNumber_makeData is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue.h:102: isNumber_test is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 4 If any of these errors are false positives, please file a bug against check-webkit-style. 187966 3 48135 eric 2010-02-04 15:34:23 -0800 Comment on attachment 48135 Fix v1 So previously 0 and NaN were not "numbers"? (assuming m_number is a float here). Why? WebKit style is not to name arguments when their names add no value: 102 void isNumber_test(const char* expr, const QScriptValue& value); "value" there adds no value. I don't understand how this actually adds the test data: 371 newRow(expr) << isNumber.contains(expr); but I think I'm simply not familiar enough with Qt testing infrastructure. Looks like you'll need a Qt reviewer here. 188946 4 48399 jedrzej.nowacki 2010-02-09 02:49:28 -0800 Created attachment 48399 Fix v2 188955 5 jedrzej.nowacki 2010-02-09 03:49:09 -0800 (In reply to comment #3) > (From update of attachment 48135 [details]) > So previously 0 and NaN were not "numbers"? (assuming m_number is a float > here). Why? m_number is double and it was casted automatically to bool. (bool)0.0 and (bool)NaN is false. > WebKit style is not to name arguments when their names add no value: > 102 void isNumber_test(const char* expr, const QScriptValue& value); > > "value" there adds no value. fixed. > I don't understand how this actually adds the test data: > 371 newRow(expr) << isNumber.contains(expr); > but I think I'm simply not familiar enough with Qt testing infrastructure. Essentially, isNumber() method is called for each QScriptValue created in the initScriptValues() so it is about 100 different values. The line you mentioned provides expected results only which are passed to the isNumber_test() by QFETCH makro. 189200 6 48399 commit-queue 2010-02-09 18:19:35 -0800 Comment on attachment 48399 Fix v2 Clearing flags on attachment: 48399 Committed r54577: <http://trac.webkit.org/changeset/54577> 189201 7 commit-queue 2010-02-09 18:19:40 -0800 All reviewed patches have been landed. Closing bug. 48135 2010-02-04 05:58:35 -0800 2010-02-09 02:49:28 -0800 Fix v1 isnumber.diff text/plain 5518 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1NzhlMjgyLi5lY2ZhM2I3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTAtMDItMDQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IFFTY3JpcHRWYWx1ZTo6aXNOdW1iZXIoKS4KKworICAgICAgICBUaGUgaXNOdW1iZXIoKSBzaG91 bGQgcmV0dXJuICd0cnVlJyBpZiB0aGUgdmFsdWUgaXMgaW4gdGhlIENOdW1iZXIKKyAgICAgICAg c3RhdGUuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0VmFsdWU6OmlzTnVtYmVyKCkgcmV0dXJucyBh biBpbmNvcnJlY3QgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0NTc1CisKKyAgICAgICAgKiBxdC9hcGkvcXNjcmlwdHZhbHVlX3AuaDoKKyAg ICAgICAgKFFTY3JpcHRWYWx1ZVByaXZhdGU6OmlzTnVtYmVyKToKKyAgICAgICAgKiBxdC90ZXN0 cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5oOgorICAgICAgICAqIHF0L3Rlc3RzL3Fz Y3JpcHR2YWx1ZS90c3RfcXNjcmlwdHZhbHVlX2dlbmVyYXRlZC5jcHA6CisgICAgICAgICh0c3Rf UVNjcmlwdFZhbHVlOjppc051bWJlcl9pbml0RGF0YSk6CisgICAgICAgICh0c3RfUVNjcmlwdFZh bHVlOjppc051bWJlcl9tYWtlRGF0YSk6CisgICAgICAgICh0c3RfUVNjcmlwdFZhbHVlOjppc051 bWJlcl90ZXN0KToKKworMjAxMC0wMi0wNCAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dh Y2tpQG5va2lhLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KIAog ICAgICAgICBJbmNyZWFzZSB0ZXN0IGNvdmVyYWdlIGZvciB0aGUgUVNjcmlwdFZhbHVlLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZV9wLmggYi9KYXZhU2Ny aXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaAppbmRleCA2YTViMzg4Li5mMjY2YTRmIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaAorKysgYi9K YXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaApAQCAtMzM3LDcgKzMzNyw3IEBA IGJvb2wgUVNjcmlwdFZhbHVlUHJpdmF0ZTo6aXNOdW1iZXIoKQogewogICAgIHN3aXRjaCAobV9z dGF0ZSkgewogICAgIGNhc2UgQ051bWJlcjoKLSAgICAgICAgcmV0dXJuIG1fbnVtYmVyOworICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICBjYXNlIEpTVmFsdWU6CiAgICAgICAgIGlmIChpc09iamVj dCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9xc2NyaXB0dmFsdWUuaCBiL0phdmFTY3JpcHRD b3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1ZS90c3RfcXNjcmlwdHZhbHVlLmgKaW5kZXggYWU4MWM0 OS4uYzdjNjBjZCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZh bHVlL3RzdF9xc2NyaXB0dmFsdWUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2Ny aXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5oCkBAIC01NSw2ICs1NSw5IEBAIHByaXZhdGUgc2xv dHM6CiAgICAgdm9pZCBpc0Jvb2xlYW5fZGF0YSgpOwogICAgIHZvaWQgaXNCb29sZWFuKCk7CiAK KyAgICB2b2lkIGlzTnVtYmVyX2RhdGEoKTsKKyAgICB2b2lkIGlzTnVtYmVyKCk7CisKICAgICB2 b2lkIGlzRnVuY3Rpb25fZGF0YSgpOwogICAgIHZvaWQgaXNGdW5jdGlvbigpOwogCkBAIC05NCw2 ICs5NywxMCBAQCBwcml2YXRlOgogICAgIHZvaWQgaXNCb29sZWFuX21ha2VEYXRhKGNvbnN0IGNo YXIqIGV4cHIpOwogICAgIHZvaWQgaXNCb29sZWFuX3Rlc3QoY29uc3QgY2hhciogZXhwciwgY29u c3QgUVNjcmlwdFZhbHVlJiB2YWx1ZSk7CiAKKyAgICB2b2lkIGlzTnVtYmVyX2luaXREYXRhKCk7 CisgICAgdm9pZCBpc051bWJlcl9tYWtlRGF0YShjb25zdCBjaGFyKiBleHByKTsKKyAgICB2b2lk IGlzTnVtYmVyX3Rlc3QoY29uc3QgY2hhciogZXhwciwgY29uc3QgUVNjcmlwdFZhbHVlJiB2YWx1 ZSk7CisKICAgICB2b2lkIGlzRnVuY3Rpb25faW5pdERhdGEoKTsKICAgICB2b2lkIGlzRnVuY3Rp b25fbWFrZURhdGEoY29uc3QgY2hhciogZXhwcik7CiAgICAgdm9pZCBpc0Z1bmN0aW9uX3Rlc3Qo Y29uc3QgY2hhciogZXhwciwgY29uc3QgUVNjcmlwdFZhbHVlJiB2YWx1ZSk7CmRpZmYgLS1naXQg YS9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZV9n ZW5lcmF0ZWQuY3BwIGIvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9x c2NyaXB0dmFsdWVfZ2VuZXJhdGVkLmNwcAppbmRleCA2ZDhlZjQ4Li5jZDk1ODJjIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1 ZV9nZW5lcmF0ZWQuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1 ZS90c3RfcXNjcmlwdHZhbHVlX2dlbmVyYXRlZC5jcHAKQEAgLTMxNSw2ICszMTUsNzAgQEAgdm9p ZCB0c3RfUVNjcmlwdFZhbHVlOjppc0Jvb2xlYW5fdGVzdChjb25zdCBjaGFyKiwgY29uc3QgUVNj cmlwdFZhbHVlJiB2YWx1ZSkKIAogREVGSU5FX1RFU1RfRlVOQ1RJT04oaXNCb29sZWFuKQogCit2 b2lkIHRzdF9RU2NyaXB0VmFsdWU6OmlzTnVtYmVyX2luaXREYXRhKCkKK3sKKyAgICBRVGVzdDo6 YWRkQ29sdW1uPGJvb2w+KCJleHBlY3RlZCIpOworICAgIGluaXRTY3JpcHRWYWx1ZXMoKTsKK30K Kwordm9pZCB0c3RfUVNjcmlwdFZhbHVlOjppc051bWJlcl9tYWtlRGF0YShjb25zdCBjaGFyKiBl eHByKQoreworICAgIHN0YXRpYyBRU2V0PFFTdHJpbmc+IGlzTnVtYmVyOworICAgIGlmIChpc051 bWJlci5pc0VtcHR5KCkpIHsKKyAgICAgICAgaXNOdW1iZXIgPDwgIlFTY3JpcHRWYWx1ZShpbnQo MTIyKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZSh1aW50KDEyNCkpIgorICAg ICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCkiCisgICAgICAgICAgICAgICAgPDwgIlFT Y3JpcHRWYWx1ZSgwLjApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMTIzLjAp IgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoNi4zN2UtOCkiCisgICAgICAgICAg ICAgICAgPDwgIlFTY3JpcHRWYWx1ZSgtNi4zN2UtOCkiCisgICAgICAgICAgICAgICAgPDwgIlFT Y3JpcHRWYWx1ZSgweDQzMjExMjM0KSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVl KDB4MTAwMDApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMHgxMDAwMSkiCisg ICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShxU05hTigpKSIKKyAgICAgICAgICAgICAg ICA8PCAiUVNjcmlwdFZhbHVlKHFRTmFOKCkpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0 VmFsdWUocUluZigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKC1xSW5mKCkp IgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgaW50KDEyMikpIgorICAgICAg ICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgdWludCgxMjQpKSIKKyAgICAgICAgICAgICAg ICA8PCAiUVNjcmlwdFZhbHVlKDAsIDApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFs dWUoMCwgMC4wKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIDEyMy4wKSIK KyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIDYuMzdlLTgpIgorICAgICAgICAg ICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgLTYuMzdlLTgpIgorICAgICAgICAgICAgICAgIDw8 ICJRU2NyaXB0VmFsdWUoMCwgMHg0MzIxMTIzNCkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3Jp cHRWYWx1ZSgwLCAweDEwMDAwKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAs IDB4MTAwMDEpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgcVNOYU4oKSki CisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZSgwLCBxUU5hTigpKSIKKyAgICAgICAg ICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIHFJbmYoKSkiCisgICAgICAgICAgICAgICAgPDwg IlFTY3JpcHRWYWx1ZSgwLCAtcUluZigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZh bHVlKGVuZ2luZSwgaW50KDEyMikpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUo ZW5naW5lLCB1aW50KDEyNCkpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoZW5n aW5lLCAwKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgMC4wKSIK KyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgMTIzLjApIgorICAgICAg ICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoZW5naW5lLCA2LjM3ZS04KSIKKyAgICAgICAgICAg ICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgLTYuMzdlLTgpIgorICAgICAgICAgICAgICAg IDw8ICJRU2NyaXB0VmFsdWUoZW5naW5lLCAweDQzMjExMjM0KSIKKyAgICAgICAgICAgICAgICA8 PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgMHgxMDAwMCkiCisgICAgICAgICAgICAgICAgPDwgIlFT Y3JpcHRWYWx1ZShlbmdpbmUsIDB4MTAwMDEpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0 VmFsdWUoZW5naW5lLCBxU05hTigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVl KGVuZ2luZSwgcVFOYU4oKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShlbmdp bmUsIHFJbmYoKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShlbmdpbmUsIC1x SW5mKCkpIjsKKyAgICB9CisgICAgbmV3Um93KGV4cHIpIDw8IGlzTnVtYmVyLmNvbnRhaW5zKGV4 cHIpOworfQorCit2b2lkIHRzdF9RU2NyaXB0VmFsdWU6OmlzTnVtYmVyX3Rlc3QoY29uc3QgY2hh ciosIGNvbnN0IFFTY3JpcHRWYWx1ZSYgdmFsdWUpCit7CisgICAgUUZFVENIKGJvb2wsIGV4cGVj dGVkKTsKKyAgICBRQ09NUEFSRSh2YWx1ZS5pc051bWJlcigpLCBleHBlY3RlZCk7Cit9CisKK0RF RklORV9URVNUX0ZVTkNUSU9OKGlzTnVtYmVyKQorCiAKIHZvaWQgdHN0X1FTY3JpcHRWYWx1ZTo6 aXNGdW5jdGlvbl9pbml0RGF0YSgpCiB7CkBAIC00OTIsNCArNTU2LDMgQEAgdm9pZCB0c3RfUVNj cmlwdFZhbHVlOjppc09iamVjdF90ZXN0KGNvbnN0IGNoYXIqLCBjb25zdCBRU2NyaXB0VmFsdWUm IHZhbHVlKQogCiBERUZJTkVfVEVTVF9GVU5DVElPTihpc09iamVjdCkKIAotCg== 48399 2010-02-09 02:49:28 -0800 2010-02-09 18:19:34 -0800 Fix v2 isnumberV2.diff text/plain 5512 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1NzhlMjgyLi5lY2ZhM2I3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTAtMDItMDQgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IFFTY3JpcHRWYWx1ZTo6aXNOdW1iZXIoKS4KKworICAgICAgICBUaGUgaXNOdW1iZXIoKSBzaG91 bGQgcmV0dXJuICd0cnVlJyBpZiB0aGUgdmFsdWUgaXMgaW4gdGhlIENOdW1iZXIKKyAgICAgICAg c3RhdGUuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0VmFsdWU6OmlzTnVtYmVyKCkgcmV0dXJucyBh biBpbmNvcnJlY3QgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0NTc1CisKKyAgICAgICAgKiBxdC9hcGkvcXNjcmlwdHZhbHVlX3AuaDoKKyAg ICAgICAgKFFTY3JpcHRWYWx1ZVByaXZhdGU6OmlzTnVtYmVyKToKKyAgICAgICAgKiBxdC90ZXN0 cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5oOgorICAgICAgICAqIHF0L3Rlc3RzL3Fz Y3JpcHR2YWx1ZS90c3RfcXNjcmlwdHZhbHVlX2dlbmVyYXRlZC5jcHA6CisgICAgICAgICh0c3Rf UVNjcmlwdFZhbHVlOjppc051bWJlcl9pbml0RGF0YSk6CisgICAgICAgICh0c3RfUVNjcmlwdFZh bHVlOjppc051bWJlcl9tYWtlRGF0YSk6CisgICAgICAgICh0c3RfUVNjcmlwdFZhbHVlOjppc051 bWJlcl90ZXN0KToKKworMjAxMC0wMi0wNCAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dh Y2tpQG5va2lhLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KIAog ICAgICAgICBJbmNyZWFzZSB0ZXN0IGNvdmVyYWdlIGZvciB0aGUgUVNjcmlwdFZhbHVlLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZV9wLmggYi9KYXZhU2Ny aXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaAppbmRleCA2YTViMzg4Li5mMjY2YTRmIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaAorKysgYi9K YXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlX3AuaApAQCAtMzM3LDcgKzMzNyw3IEBA IGJvb2wgUVNjcmlwdFZhbHVlUHJpdmF0ZTo6aXNOdW1iZXIoKQogewogICAgIHN3aXRjaCAobV9z dGF0ZSkgewogICAgIGNhc2UgQ051bWJlcjoKLSAgICAgICAgcmV0dXJuIG1fbnVtYmVyOworICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICBjYXNlIEpTVmFsdWU6CiAgICAgICAgIGlmIChpc09iamVj dCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9xc2NyaXB0dmFsdWUuaCBiL0phdmFTY3JpcHRD b3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1ZS90c3RfcXNjcmlwdHZhbHVlLmgKaW5kZXggYWU4MWM0 OS4uYzdjNjBjZCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZh bHVlL3RzdF9xc2NyaXB0dmFsdWUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2Ny aXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5oCkBAIC01NSw2ICs1NSw5IEBAIHByaXZhdGUgc2xv dHM6CiAgICAgdm9pZCBpc0Jvb2xlYW5fZGF0YSgpOwogICAgIHZvaWQgaXNCb29sZWFuKCk7CiAK KyAgICB2b2lkIGlzTnVtYmVyX2RhdGEoKTsKKyAgICB2b2lkIGlzTnVtYmVyKCk7CisKICAgICB2 b2lkIGlzRnVuY3Rpb25fZGF0YSgpOwogICAgIHZvaWQgaXNGdW5jdGlvbigpOwogCkBAIC05NCw2 ICs5NywxMCBAQCBwcml2YXRlOgogICAgIHZvaWQgaXNCb29sZWFuX21ha2VEYXRhKGNvbnN0IGNo YXIqIGV4cHIpOwogICAgIHZvaWQgaXNCb29sZWFuX3Rlc3QoY29uc3QgY2hhciogZXhwciwgY29u c3QgUVNjcmlwdFZhbHVlJiB2YWx1ZSk7CiAKKyAgICB2b2lkIGlzTnVtYmVyX2luaXREYXRhKCk7 CisgICAgdm9pZCBpc051bWJlcl9tYWtlRGF0YShjb25zdCBjaGFyKiBleHByKTsKKyAgICB2b2lk IGlzTnVtYmVyX3Rlc3QoY29uc3QgY2hhciogZXhwciwgY29uc3QgUVNjcmlwdFZhbHVlJik7CisK ICAgICB2b2lkIGlzRnVuY3Rpb25faW5pdERhdGEoKTsKICAgICB2b2lkIGlzRnVuY3Rpb25fbWFr ZURhdGEoY29uc3QgY2hhciogZXhwcik7CiAgICAgdm9pZCBpc0Z1bmN0aW9uX3Rlc3QoY29uc3Qg Y2hhciogZXhwciwgY29uc3QgUVNjcmlwdFZhbHVlJiB2YWx1ZSk7CmRpZmYgLS1naXQgYS9KYXZh U2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZV9nZW5lcmF0 ZWQuY3BwIGIvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9xc2NyaXB0 dmFsdWVfZ2VuZXJhdGVkLmNwcAppbmRleCA2ZDhlZjQ4Li5jZDk1ODJjIDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZV9nZW5l cmF0ZWQuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1ZS90c3Rf cXNjcmlwdHZhbHVlX2dlbmVyYXRlZC5jcHAKQEAgLTMxNSw2ICszMTUsNzAgQEAgdm9pZCB0c3Rf UVNjcmlwdFZhbHVlOjppc0Jvb2xlYW5fdGVzdChjb25zdCBjaGFyKiwgY29uc3QgUVNjcmlwdFZh bHVlJiB2YWx1ZSkKIAogREVGSU5FX1RFU1RfRlVOQ1RJT04oaXNCb29sZWFuKQogCit2b2lkIHRz dF9RU2NyaXB0VmFsdWU6OmlzTnVtYmVyX2luaXREYXRhKCkKK3sKKyAgICBRVGVzdDo6YWRkQ29s dW1uPGJvb2w+KCJleHBlY3RlZCIpOworICAgIGluaXRTY3JpcHRWYWx1ZXMoKTsKK30KKwordm9p ZCB0c3RfUVNjcmlwdFZhbHVlOjppc051bWJlcl9tYWtlRGF0YShjb25zdCBjaGFyKiBleHByKQor eworICAgIHN0YXRpYyBRU2V0PFFTdHJpbmc+IGlzTnVtYmVyOworICAgIGlmIChpc051bWJlci5p c0VtcHR5KCkpIHsKKyAgICAgICAgaXNOdW1iZXIgPDwgIlFTY3JpcHRWYWx1ZShpbnQoMTIyKSki CisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZSh1aW50KDEyNCkpIgorICAgICAgICAg ICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRW YWx1ZSgwLjApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMTIzLjApIgorICAg ICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoNi4zN2UtOCkiCisgICAgICAgICAgICAgICAg PDwgIlFTY3JpcHRWYWx1ZSgtNi4zN2UtOCkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRW YWx1ZSgweDQzMjExMjM0KSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDB4MTAw MDApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMHgxMDAwMSkiCisgICAgICAg ICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShxU05hTigpKSIKKyAgICAgICAgICAgICAgICA8PCAi UVNjcmlwdFZhbHVlKHFRTmFOKCkpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUo cUluZigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKC1xSW5mKCkpIgorICAg ICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgaW50KDEyMikpIgorICAgICAgICAgICAg ICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgdWludCgxMjQpKSIKKyAgICAgICAgICAgICAgICA8PCAi UVNjcmlwdFZhbHVlKDAsIDApIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwg MC4wKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIDEyMy4wKSIKKyAgICAg ICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIDYuMzdlLTgpIgorICAgICAgICAgICAgICAg IDw8ICJRU2NyaXB0VmFsdWUoMCwgLTYuMzdlLTgpIgorICAgICAgICAgICAgICAgIDw8ICJRU2Ny aXB0VmFsdWUoMCwgMHg0MzIxMTIzNCkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1 ZSgwLCAweDEwMDAwKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKDAsIDB4MTAw MDEpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoMCwgcVNOYU4oKSkiCisgICAg ICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZSgwLCBxUU5hTigpKSIKKyAgICAgICAgICAgICAg ICA8PCAiUVNjcmlwdFZhbHVlKDAsIHFJbmYoKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3Jp cHRWYWx1ZSgwLCAtcUluZigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVu Z2luZSwgaW50KDEyMikpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoZW5naW5l LCB1aW50KDEyNCkpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUoZW5naW5lLCAw KSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgMC4wKSIKKyAgICAg ICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgMTIzLjApIgorICAgICAgICAgICAg ICAgIDw8ICJRU2NyaXB0VmFsdWUoZW5naW5lLCA2LjM3ZS04KSIKKyAgICAgICAgICAgICAgICA8 PCAiUVNjcmlwdFZhbHVlKGVuZ2luZSwgLTYuMzdlLTgpIgorICAgICAgICAgICAgICAgIDw8ICJR U2NyaXB0VmFsdWUoZW5naW5lLCAweDQzMjExMjM0KSIKKyAgICAgICAgICAgICAgICA8PCAiUVNj cmlwdFZhbHVlKGVuZ2luZSwgMHgxMDAwMCkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRW YWx1ZShlbmdpbmUsIDB4MTAwMDEpIgorICAgICAgICAgICAgICAgIDw8ICJRU2NyaXB0VmFsdWUo ZW5naW5lLCBxU05hTigpKSIKKyAgICAgICAgICAgICAgICA8PCAiUVNjcmlwdFZhbHVlKGVuZ2lu ZSwgcVFOYU4oKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShlbmdpbmUsIHFJ bmYoKSkiCisgICAgICAgICAgICAgICAgPDwgIlFTY3JpcHRWYWx1ZShlbmdpbmUsIC1xSW5mKCkp IjsKKyAgICB9CisgICAgbmV3Um93KGV4cHIpIDw8IGlzTnVtYmVyLmNvbnRhaW5zKGV4cHIpOwor fQorCit2b2lkIHRzdF9RU2NyaXB0VmFsdWU6OmlzTnVtYmVyX3Rlc3QoY29uc3QgY2hhciosIGNv bnN0IFFTY3JpcHRWYWx1ZSYgdmFsdWUpCit7CisgICAgUUZFVENIKGJvb2wsIGV4cGVjdGVkKTsK KyAgICBRQ09NUEFSRSh2YWx1ZS5pc051bWJlcigpLCBleHBlY3RlZCk7Cit9CisKK0RFRklORV9U RVNUX0ZVTkNUSU9OKGlzTnVtYmVyKQorCiAKIHZvaWQgdHN0X1FTY3JpcHRWYWx1ZTo6aXNGdW5j dGlvbl9pbml0RGF0YSgpCiB7CkBAIC00OTIsNCArNTU2LDMgQEAgdm9pZCB0c3RfUVNjcmlwdFZh bHVlOjppc09iamVjdF90ZXN0KGNvbnN0IGNoYXIqLCBjb25zdCBRU2NyaXB0VmFsdWUmIHZhbHVl KQogCiBERUZJTkVfVEVTVF9GVU5DVElPTihpc09iamVjdCkKIAotCg==