34572 2010-02-04 03:59:17 -0800 [Gtk] Implement layoutTestController.pageNumberForElementById 2010-02-05 21:38:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hamaji hamaji eric gustavo hayato webkit.review.bot yuzo oldest_to_newest 187725 0 hamaji 2010-02-04 03:59:17 -0800 This was added in Bug 33840. 187727 1 48131 hamaji 2010-02-04 04:01:06 -0800 Created attachment 48131 Patch v1 187728 2 webkit.review.bot 2010-02-04 04:04:33 -0800 Attachment 48131 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style. 187735 3 hamaji 2010-02-04 04:24:24 -0800 (In reply to comment #2) > Attachment 48131 [details] did not pass style-queue: > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > underscores in your identifier names. [readability/naming] [4] > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > [readability/null] [5] > Total errors found: 2 Looks like these files should be in the exception list of our style checker? 188139 4 48131 gustavo 2010-02-05 03:52:53 -0800 Comment on attachment 48131 Patch v1 I was going to say the function name lacked a 'get' somewhere, to be consistent, but I see we have previous cases of that; we might want to review all of them while exposing. Thanks for the patch! 188140 5 gustavo 2010-02-05 03:53:49 -0800 (In reply to comment #3) > (In reply to comment #2) > > Attachment 48131 [details] [details] did not pass style-queue: > > > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:58: > > webkit_web_frame_page_number_for_element_by_id is incorrectly named. Don't use > > underscores in your identifier names. [readability/naming] [4] > > WebKit/gtk/webkit/webkitwebframe.cpp:854: Use 0 instead of NULL. > > [readability/null] [5] > > Total errors found: 2 > > Looks like these files should be in the exception list of our style checker? Indeed. Rules here should be the same as for WebKit/gtk/ 188239 6 eric 2010-02-05 12:03:04 -0800 Attachment 48131 was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit. 188403 7 48131 hamaji 2010-02-05 21:38:11 -0800 Comment on attachment 48131 Patch v1 Clearing flags on attachment: 48131 Committed r54461: <http://trac.webkit.org/changeset/54461> 188404 8 hamaji 2010-02-05 21:38:21 -0800 All reviewed patches have been landed. Closing bug. 48131 2010-02-04 04:01:06 -0800 2010-02-05 21:38:11 -0800 Patch v1 bug-34572-20100204210104.patch text/plain 5621 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjQ1NGI0Li5jYzI0YzdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MDQgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBJbXBsZW1lbnQgbGF5 b3V0VGVzdENvbnRyb2xsZXIucGFnZU51bWJlckZvckVsZW1lbnRCeUlkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDU3MgorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMTAtMDItMDMgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXguCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9T a2lwcGVkCmluZGV4IDgwZmI2NjEuLmZjYTFiZjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVk CkBAIC01NzkyLDEwICs1NzkyLDYgQEAgZmFzdC9sb2FkZXIvY3Jhc2gtY29weWluZy1iYWNrZm9y d2FyZGxpc3QuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzQwODYKIG1lZGlhL3ZpZGVvLXJldmVyc2UtcGxheS1kdXJhdGlvbi5odG1sCiAKLSMgSW1wbGVt ZW50IExheW91dFRlc3RDb250cm9sbGVyOjpwYWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQoKS4KLXBy aW50aW5nL3BhZ2UtYnJlYWstYWx3YXlzLmh0bWwKLXByaW50aW5nL3BhZ2VOdW1lckZvckVsZW1l bnRCeUlkLmh0bWwKLQogIyBJbnRlcm1pdHRlbnRseSB0aW1pbmcgb3V0IG9uIEd0ayBEZWJ1ZyBC b3Q6CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzQ0NQogaHR0 cC90ZXN0cy9pbmNyZW1lbnRhbC9zcGxpdC1oZXgtZW50aXRpZXMucGwKZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOTJkZTdlNC4u ZGMwZDhmZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMi0wNCAgU2hpbmljaGlybyBIYW1h amkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtHdGtdIEltcGxlbWVudCBsYXlvdXRUZXN0Q29udHJvbGxlci5w YWdlTnVtYmVyRm9yRWxlbWVudEJ5SWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM0NTcyCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0cHJpdmF0ZS5o OgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHA6CisgICAgICAgICh3ZWJraXRf d2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9lbGVtZW50X2J5X2lkKToKKwogMjAxMC0wMi0wMiAg R3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2 YXRlLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmgKaW5kZXggZTlkNjFhNi4u NDRiNGQwYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5oCisr KyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuaApAQCAtMjk4LDYgKzI5OCw5IEBA IGV4dGVybiAiQyIgewogICAgIFdFQktJVF9BUEkgZ2NoYXIqCiAgICAgd2Via2l0X3dlYl9mcmFt ZV9jb3VudGVyX3ZhbHVlX2Zvcl9lbGVtZW50X2J5X2lkIChXZWJLaXRXZWJGcmFtZSogZnJhbWUs IGNvbnN0IGdjaGFyKiBpZCk7CiAKKyAgICBXRUJLSVRfQVBJIGludAorICAgIHdlYmtpdF93ZWJf ZnJhbWVfcGFnZV9udW1iZXJfZm9yX2VsZW1lbnRfYnlfaWQoV2ViS2l0V2ViRnJhbWUqIGZyYW1l LCBjb25zdCBnY2hhciogaWQsIGZsb2F0IHBhZ2VXaWR0aCwgZmxvYXQgcGFnZUhlaWdodCk7CisK ICAgICBXRUJLSVRfQVBJIGd1aW50CiAgICAgd2Via2l0X3dlYl9mcmFtZV9nZXRfcGVuZGluZ191 bmxvYWRfZXZlbnRfY291bnQoV2ViS2l0V2ViRnJhbWUqIGZyYW1lKTsKIApkaWZmIC0tZ2l0IGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2ViZnJhbWUuY3BwCmluZGV4IDM1ZDk1MjQuLmIwMzVlNDIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJmcmFtZS5jcHAKQEAgLTg0MSw2ICs4NDEsMjkgQEAgZ2NoYXIqIHdlYmtpdF93 ZWJfZnJhbWVfY291bnRlcl92YWx1ZV9mb3JfZWxlbWVudF9ieV9pZChXZWJLaXRXZWJGcmFtZSog ZnJhbWUsIGMKIH0KIAogLyoqCisgKiB3ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9l bGVtZW50X2J5X2lkCisgKiBAZnJhbWU6IGEgI1dlYktpdFdlYkZyYW1lCisgKiBAaWQ6IGFuIGVs ZW1lbnQgSUQgc3RyaW5nCisgKiBAcGFnZVdpZHRoOiB3aWR0aCBvZiBhIHBhZ2UKKyAqIEBwYWdl SGVpZ2h0OiBoZWlnaHQgb2YgYSBwYWdlCisgKgorICogUmV0dXJuIHZhbHVlOiBUaGUgbnVtYmVy IG9mIHBhZ2Ugd2hlcmUgdGhlIHNwZWNpZmllZCBlbGVtZW50IHdpbGwgYmUgcHV0CisgKi8KK2lu dCB3ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9lbGVtZW50X2J5X2lkKFdlYktpdFdl YkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGlkLCBmbG9hdCBwYWdlV2lkdGgsIGZsb2F0IHBh Z2VIZWlnaHQpCit7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9GUkFN RShmcmFtZSksIE5VTEwpOworCisgICAgRnJhbWUqIGNvcmVGcmFtZSA9IGNvcmUoZnJhbWUpOwor ICAgIGlmICghY29yZUZyYW1lKQorICAgICAgICByZXR1cm4gLTE7CisKKyAgICBFbGVtZW50KiBj b3JlRWxlbWVudCA9IGNvcmVGcmFtZS0+ZG9jdW1lbnQoKS0+Z2V0RWxlbWVudEJ5SWQoQXRvbWlj U3RyaW5nKGlkKSk7CisgICAgaWYgKCFjb3JlRWxlbWVudCkKKyAgICAgICAgcmV0dXJuIC0xOwor ICAgIHJldHVybiBQcmludENvbnRleHQ6OnBhZ2VOdW1iZXJGb3JFbGVtZW50KGNvcmVFbGVtZW50 LCBGbG9hdFNpemUocGFnZVdpZHRoLCBwYWdlSGVpZ2h0KSk7Cit9CisKKy8qKgogICogd2Via2l0 X3dlYl9mcmFtZV9nZXRfcGVuZGluZ191bmxvYWRfZXZlbnRfY291bnQ6CiAgKiBAZnJhbWU6IGEg I1dlYktpdFdlYkZyYW1lCiAgKgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDdjMGVkMzMuLjM5M2U1NDQgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMC0wMi0wNCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHdGtdIEltcGxlbWVudCBsYXlvdXRUZXN0Q29udHJvbGxlci5wYWdlTnVtYmVyRm9yRWxlbWVu dEJ5SWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0 NTcyCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJH dGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnBhZ2VOdW1iZXJGb3JFbGVt ZW50QnlJZCk6CisKIDIwMTAtMDItMDMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsu Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVy R3RrLmNwcAppbmRleCBiYWQwOWZiLi5lM2E4MmE5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwCisrKyBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKQEAg LTU1LDYgKzU1LDcgQEAgdm9pZCB3ZWJraXRfYXBwbGljYXRpb25fY2FjaGVfc2V0X21heGltdW1f c2l6ZSh1bnNpZ25lZCBsb25nIGxvbmcgc2l6ZSk7CiB1bnNpZ25lZCBpbnQgd2Via2l0X3dvcmtl cl90aHJlYWRfY291bnQodm9pZCk7CiB2b2lkIHdlYmtpdF93aGl0ZV9saXN0X2FjY2Vzc19mcm9t X29yaWdpbihjb25zdCBnY2hhciogc291cmNlT3JpZ2luLCBjb25zdCBnY2hhciogZGVzdGluYXRp b25Qcm90b2NvbCwgY29uc3QgZ2NoYXIqIGRlc3RpbmF0aW9uSG9zdCwgYm9vbCBhbGxvd0Rlc3Rp bmF0aW9uU3ViZG9tYWlucyk7CiBnY2hhciogd2Via2l0X3dlYl9mcmFtZV9jb3VudGVyX3ZhbHVl X2Zvcl9lbGVtZW50X2J5X2lkKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGlk KTsKK2ludCB3ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9lbGVtZW50X2J5X2lkKFdl YktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGlkLCBmbG9hdCBwYWdlV2lkdGgsIGZs b2F0IHBhZ2VIZWlnaHQpOwogdm9pZCB3ZWJraXRfd2ViX2luc3BlY3Rvcl9leGVjdXRlX3Njcmlw dChXZWJLaXRXZWJJbnNwZWN0b3IqIGluc3BlY3RvciwgbG9uZyBjYWxsSWQsIGNvbnN0IGdjaGFy KiBzY3JpcHQpOwogfQogCkBAIC0xNDAsMTAgKzE0MSwxMiBAQCB2b2lkIExheW91dFRlc3RDb250 cm9sbGVyOjprZWVwV2ViSGlzdG9yeSgpCiAgICAgLy8gRklYTUU6IGltcGxlbWVudAogfQogCi1p bnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChKU1N0cmlu Z1JlZiwgZmxvYXQsIGZsb2F0KQoraW50IExheW91dFRlc3RDb250cm9sbGVyOjpwYWdlTnVtYmVy Rm9yRWxlbWVudEJ5SWQoSlNTdHJpbmdSZWYgaWQsIGZsb2F0IHBhZ2VXaWR0aCwgZmxvYXQgcGFn ZUhlaWdodCkKIHsKLSAgICAvLyBGSVhNRTogaW1wbGVtZW50Ci0gICAgcmV0dXJuIC0xOworICAg IGdjaGFyKiBpZEdDaGFyID0gSlNTdHJpbmdDb3B5VVRGOENTdHJpbmcoaWQpOworICAgIGludCBw YWdlTnVtYmVyID0gd2Via2l0X3dlYl9mcmFtZV9wYWdlX251bWJlcl9mb3JfZWxlbWVudF9ieV9p ZChtYWluRnJhbWUsIGlkR0NoYXIsIHBhZ2VXaWR0aCwgcGFnZUhlaWdodCk7CisgICAgZ19mcmVl KGlkR0NoYXIpOworICAgIHJldHVybiBwYWdlTnVtYmVyOwogfQogCiBzaXplX3QgTGF5b3V0VGVz dENvbnRyb2xsZXI6OndlYkhpc3RvcnlJdGVtQ291bnQoKQo=