34551 2010-02-03 18:22:37 -0800 WorkerContext.close() does not work in the chromium port 2010-02-04 15:43:36 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue dimich levin oldest_to_newest 187582 0 atwilson 2010-02-03 18:22:37 -0800 We do not shutdown the Worker thread in the chromium port when the thread calls close(). This means that code like this: var worker = new Worker("worker.js"); worker.js: close(); Will leave the thread running until the parent window shuts down. There's code in Chromium to prevent further messages from being to/from the closing thread, but the thread itself still sits there. 187952 1 48172 atwilson 2010-02-04 15:09:39 -0800 Created attachment 48172 Patch 187977 2 48172 commit-queue 2010-02-04 15:43:30 -0800 Comment on attachment 48172 Patch Clearing flags on attachment: 48172 Committed r54380: <http://trac.webkit.org/changeset/54380> 187978 3 commit-queue 2010-02-04 15:43:36 -0800 All reviewed patches have been landed. Closing bug. 48172 2010-02-04 15:09:39 -0800 2010-02-04 15:43:30 -0800 Patch bug-34551-20100204150938.patch text/plain 1217 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDU4YzM3YTguLjlkZTI4MWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTAyLTA0ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3JrZXJD b250ZXh0LmNsb3NlKCkgZG9lcyBub3Qgd29yayBpbiB0aGUgY2hyb21pdW0gcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQ1NTEKKworICAgICAg ICBUZXN0OiBBZGRpbmcgbmV3IGRvd25zdHJlYW0gdGVzdC4KKworICAgICAgICAqIHNyYy9XZWJX b3JrZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViV29ya2VyQmFzZTo6d29ya2VyQ29u dGV4dENsb3NlZFRhc2spOgorICAgICAgICBOb3cgc2h1dHMgZG93biB0aGUgd29ya2VyIHRocmVh ZCB3aGVuIFdvcmtlckNvbnRleHQ6OmNsb3NlKCkgaXMgaW52b2tlZC4KKwogMjAxMC0wMi0wNCAg WXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLiBSZXZlcnQgNTQzMzMgd2hpY2ggYnJva2UgQ2hyb21pdW0gYnVpbGQuCmRpZmYgLS1naXQg YS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtlckJhc2UuY3BwIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJXb3JrZXJCYXNlLmNwcAppbmRleCA3ZmQzNzQ5Li40MDAxOWU4IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtlckJhc2UuY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViV29ya2VyQmFzZS5jcHAKQEAgLTI3MSw2ICsyNzEsOCBAQCB2b2lkIFdlYldv cmtlckJhc2U6OndvcmtlckNvbnRleHRDbG9zZWRUYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQsCiB7CiAgICAgaWYgKHRoaXNQdHItPmNvbW1vbkNsaWVudCgpKQogICAgICAgICB0 aGlzUHRyLT5jb21tb25DbGllbnQoKS0+d29ya2VyQ29udGV4dENsb3NlZCgpOworCisgICAgdGhp c1B0ci0+c3RvcFdvcmtlclRocmVhZCgpOwogfQogCiB2b2lkIFdlYldvcmtlckJhc2U6Ondvcmtl ckNvbnRleHREZXN0cm95ZWQoKQo=