<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>34514</bug_id>
          
          <creation_ts>2010-02-02 23:06:45 -0800</creation_ts>
          <short_desc>[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined</short_desc>
          <delta_ts>2010-02-03 18:53:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>33564</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Kwang Yul Seo">skyul</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>187277</commentid>
    <comment_count>0</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-02-02 23:06:45 -0800</bug_when>
    <thetext>WTF_PLATFORM_BREWMP_SIMULATOR is needed to make distinction between BREWMP and BREWMP simulator.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187278</commentid>
    <comment_count>1</comment_count>
      <attachid>47997</attachid>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-02-02 23:09:16 -0800</bug_when>
    <thetext>Created attachment 47997
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187540</commentid>
    <comment_count>2</comment_count>
      <attachid>47997</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-02-03 16:23:20 -0800</bug_when>
    <thetext>Comment on attachment 47997
Patch

Do you compile the binary differently to run inside the simulator?  I guess so.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187589</commentid>
    <comment_count>3</comment_count>
      <attachid>47997</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-02-03 18:49:36 -0800</bug_when>
    <thetext>Comment on attachment 47997
Patch

Clearing flags on attachment: 47997

Committed r54320: &lt;http://trac.webkit.org/changeset/54320&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187590</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-02-03 18:49:41 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187592</commentid>
    <comment_count>5</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-02-03 18:53:10 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 47997 [details])
&gt; Do you compile the binary differently to run inside the simulator?  I guess so.

Yes. there is some simulator specific code. For example, IDebugger interface is not available for simulator, so I use OS(WINDOWS) code to retrieve the stack base address in simulator.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47997</attachid>
            <date>2010-02-02 23:09:16 -0800</date>
            <delta_ts>2010-02-03 18:49:36 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>AEE_SIMULATOR.patch</filename>
            <type>text/plain</type>
            <size>1185</size>
            <attacher name="Kwang Yul Seo">skyul</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0Mjc0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMDIgIEt3YW5nIFl1
bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBEZWZpbmUgV1RGX1BMQVRGT1JNX0JSRVdN
UF9TSU1VTEFUT1Igd2hlbiBBRUVfU0lNVUxBVE9SIGlzIGRlZmluZWQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NTE0CisKKyAgICAgICAgUExBVEZP
Uk0oQlJFV01QX1NJTVVMQVRPUikgZ3VhcmQgaXMgbmVlZGVkIHRvIG1ha2UgZGlzdGluY3Rpb24g
YmV0d2VlbiBCUkVXTVAKKyAgICAgICAgYW5kIEJSRVdNUCBzaW11bGF0b3IuCisKKyAgICAgICAg
KiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxMC0wMi0wMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBw
bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgpJbmRleDogSmF2
YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv
d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDU0MjY4KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1Bs
YXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTQxNyw2ICs0MTcsMTEgQEAKICNkZWZpbmUgV1RG
X1BMQVRGT1JNX0hBSUtVIDEKICNlbGlmIGRlZmluZWQoQlVJTERJTkdfQlJFV01QX18pCiAjZGVm
aW5lIFdURl9QTEFURk9STV9CUkVXTVAgMQorI2lmIGRlZmluZWQoQUVFX1NJTVVMQVRPUikKKyNk
ZWZpbmUgV1RGX1BMQVRGT1JNX0JSRVdNUF9TSU1VTEFUT1IgMQorI2Vsc2UKKyNkZWZpbmUgV1RG
X1BMQVRGT1JNX0JSRVdNUF9TSU1VTEFUT1IgMAorI2VuZGlmCiAjZWxpZiBPUyhEQVJXSU4pCiAj
ZGVmaW5lIFdURl9QTEFURk9STV9NQUMgMQogI2VsaWYgT1MoV0lORE9XUykK
</data>

          </attachment>
      

    </bug>

</bugzilla>