34506 2010-02-02 17:44:14 -0800 LayoutTests/storage/database-lock-after-reload.html needs to be refactored and made less flaky 2010-03-03 17:21:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi michaeln oldest_to_newest 187219 0 dumi 2010-02-02 17:44:14 -0800 database-lock-after-reload.html has a few problems: 1. Uses the same 'errorFunction' as a statement error callback and transaction error callback. This is not OK, because the two error callbacks have different signatures. 2. Uses RANDOMBLOB which is disallowed by the authorizer. The fact that the test still passes sometimes shows how irrelevant/flaky some operations are. 3. It tries to insert a big enough BLOB in the database, to keep the database thread busy while the main thread navigates to a different page. A 0.5MB BLOB can hardly be considered big enough for this. 4. Some trailing whitespaces. 195351 1 49873 dumi 2010-03-02 18:25:06 -0800 Created attachment 49873 patch The flakiness of this test should be completely removed by the fix to bug 35624. 195726 2 49873 dglazkov 2010-03-03 13:08:16 -0800 Comment on attachment 49873 patch ok. 195827 3 dumi 2010-03-03 17:21:44 -0800 Landed as r55490. 49873 2010-03-02 18:25:06 -0800 2010-03-03 13:08:16 -0800 patch patch text/plain 5325 dumi SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NDQ2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMDIgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtpbmcgZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQuaHRtbCBhIGJp dCBtb3JlIHJvYnVzdCBhbmQKKyAgICAgICAgY2xlYW5pbmcgdXAgc29tZSBzdHlsZSBpc3N1ZXMu CisKKyAgICAgICAgKiBzdG9yYWdlL2RhdGFiYXNlLWxvY2stYWZ0ZXItcmVsb2FkLmh0bWw6Cisg ICAgICAgICogc3RvcmFnZS9yZXNvdXJjZXMvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQtMi5o dG1sOgorCiAyMDEwLTAzLTAyICBBcm5vIFJlbmV2aWVyICA8YXJub0ByZW5ldmllci5uZXQ+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpJbmRleDogTGF5b3V0 VGVzdHMvc3RvcmFnZS9kYXRhYmFzZS1sb2NrLWFmdGVyLXJlbG9hZC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3N0b3JhZ2UvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQuaHRtbAko cmV2aXNpb24gNTU0MzkpCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2RhdGFiYXNlLWxvY2stYWZ0 ZXItcmVsb2FkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsOCArMSw2IEBACiA8aHRtbD4KIDxo ZWFkPgogPHNjcmlwdD4KLXZhciBkYXRhYmFzZTsKLQogZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCiB7 CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5pbm5lckhUTUwgKz0gbWVz c2FnZSArICI8YnI+IjsKQEAgLTE1LDcgKzEzLDcgQEAgZnVuY3Rpb24gZmluaXNoVGVzdCgpCiAg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKIH0KIAotZnVuY3Rpb24g ZXJyb3JGdW5jdGlvbih0eCwgZXJyb3IpCitmdW5jdGlvbiBlcnJvckZ1bmN0aW9uKGVycm9yKQog ewogICAgIGxvZygiVGVzdCBmYWlsZWQgLSAiICsgZXJyb3IubWVzc2FnZSk7CiAgICAgZmluaXNo VGVzdCgpOwpAQCAtMjMsMTYgKzIxLDE2IEBAIGZ1bmN0aW9uIGVycm9yRnVuY3Rpb24odHgsIGVy cm9yKQogCiBmdW5jdGlvbiBhZGREYXRhKGRiKQogewotICAgIGRiLnRyYW5zYWN0aW9uKGZ1bmN0 aW9uKHR4KSB7IAorICAgIGRiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7CiAgICAgICAgIGxv ZygiSW5zZXJ0aW5nIHNvbWUgZGF0YSIpOwotICAgICAgICAvLyBJbnNlcnQgYSBsYXJnZSBhbW91 bnQgb2YgZGF0YSB0aGF0IHdpbGwgdGFrZSBhIGxpdHRsZSB3aGlsZSB0byBydW4uIFNjaGVkdWxl IGEgdGltb3V0IHRvIHJ1biB0aGF0IHdpbGwgbG9hZCBhIG5ldyBwYWdlCi0gICAgICAgIC8vIHdo aWxzdCB0aGUgdHJhbnNhY3Rpb24gaXMgc3RpbGwgaW4gcHJvZ3Jlc3MsIGludGVycnVwdGluZyB0 aGUgdHJhbnNhY3Rpb24uIFRoaXMgc2hvdWxkIG5vdCBsZWF2ZSB0aGUgZGF0YWJhc2UgbG9ja2Vk IGFuZCBvbgotICAgICAgICAvLyB0aGUgbmV4dCBwYWdlIHdlIHNob3VsZCBiZSBhYmxlIHRvIGlu c2VydCBzb21lIG1vcmUgZGF0YS4KLSAgICAgICAgdHguZXhlY3V0ZVNxbCgiSU5TRVJUIElOVE8g RGF0YVRlc3QgKHRlc3REYXRhKSBWQUxVRVMgKFpFUk9CTE9CKDUyNDIwMCkpIiwgW10sIGZ1bmN0 aW9uKHR4LCByZXN1bHQpIHsgfSwgZXJyb3JGdW5jdGlvbik7Ci0gICAgICAgIGxvY2F0aW9uLmhy ZWYgPSAiLi9yZXNvdXJjZXMvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQtMi5odG1sIjsKLSAg ICB9LCBlcnJvckZ1bmN0aW9uLCBmdW5jdGlvbigpIHsgCi0gICAgICAgIGZpbmlzaFRlc3QoKTsK LSAgICB9KTsKKyAgICAgICAgLy8gTG9hZCBhIG5ldyBwYWdlIHdoaWxlIHRoZSB0cmFuc2FjdGlv biBpcyBzdGlsbCBpbiBwcm9ncmVzcywgaW50ZXJydXB0aW5nIHRoZSB0cmFuc2FjdGlvbi4KKyAg ICAgICAgLy8gVGhpcyBzaG91bGQgbm90IGxlYXZlIHRoZSBkYXRhYmFzZSBsb2NrZWQgYW5kIG9u IHRoZSBuZXh0IHBhZ2Ugd2Ugc2hvdWxkIGJlIGFibGUgdG8gaW5zZXJ0CisgICAgICAgIC8vIHNv bWUgbW9yZSBkYXRhLgorICAgICAgICB0eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5UTyBEYXRhVGVz dCAodGVzdERhdGEpIFZBTFVFUyAoWkVST0JMT0IoNTI0MjAwKSkiLCBbXSwKKyAgICAgICAgICAg IGZ1bmN0aW9uKHR4LCByZXN1bHQpIHsgbG9jYXRpb24uaHJlZiA9ICIuL3Jlc291cmNlcy9kYXRh YmFzZS1sb2NrLWFmdGVyLXJlbG9hZC0yLmh0bWwiOyB9LAorICAgICAgICAgICAgZnVuY3Rpb24o dHgsIGVycm9yKSB7IGVycm9yRnVuY3Rpb24oZXJyb3IpOyB9KTsKKyAgICAgICAgdHguZXhlY3V0 ZVNxbCgiSU5TRVJUIElOVE8gRGF0YVRlc3QgKHRlc3REYXRhKSBWQUxVRVMgKFpFUk9CTE9CKDUy NDIwMCkpIik7CisgICAgfSwgZXJyb3JGdW5jdGlvbiwgZnVuY3Rpb24oKSB7IGZpbmlzaFRlc3Qo KTsgfSk7CiB9CiAKIGZ1bmN0aW9uIHJ1blRlc3QoKQpAQCAtNDIsMjAgKzQwLDIwIEBAIGZ1bmN0 aW9uIHJ1blRlc3QoKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKICAgICB9Ci0g ICAgCisKKyAgICB2YXIgZGF0YWJhc2U7CiAgICAgdHJ5IHsKICAgICAgICAgZGF0YWJhc2UgPSBv cGVuRGF0YWJhc2UoIkRhdGFiYXNlTG9ja1Rlc3QiLCAiMS4wIiwgIlRlc3QgZm9yIGRhdGFiYXNl IGxvY2tpbmciLCA1MjQyODgwKTsKICAgICB9IGNhdGNoIChlKSB7CiAgICAgICAgIGxvZygiRXJy b3IgLSBjb3VsZCBub3Qgb3BlbiBkYXRhYmFzZSIpOwogICAgICAgICBmaW5pc2hUZXN0KCk7CiAg ICAgfQotICAgIAorCiAgICAgZGF0YWJhc2UudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsKICAg ICAgICAgbG9nKCJBZGRpbmcgYSB0YWJsZSIpOwotICAgICAgICB0eC5leGVjdXRlU3FsKCJDUkVB VEUgVEFCTEUgRGF0YVRlc3QgKHRlc3REYXRhKSIsIFtdLCBmdW5jdGlvbih0eCwgcmVzdWx0KSB7 IH0sIGVycm9yRnVuY3Rpb24pOyAKLSAgICB9LCBlcnJvckZ1bmN0aW9uLCBmdW5jdGlvbigpIHsg Ci0gICAgICAgIGFkZERhdGEoZGF0YWJhc2UpOyAKLSAgICB9KTsKKyAgICAgICAgdHguZXhlY3V0 ZVNxbCgiQ1JFQVRFIFRBQkxFIERhdGFUZXN0ICh0ZXN0RGF0YSkiLCBbXSwgZnVuY3Rpb24odHgs IHJlc3VsdCkgeyB9LAorICAgICAgICAgICAgZnVuY3Rpb24odHgsIGVycm9yKSB7IGVycm9yRnVu Y3Rpb24oZXJyb3IpOyB9KTsKKyAgICB9LCBlcnJvckZ1bmN0aW9uLCBmdW5jdGlvbigpIHsgYWRk RGF0YShkYXRhYmFzZSk7IH0pOwogfQogCiA8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL3N0 b3JhZ2UvcmVzb3VyY2VzL2RhdGFiYXNlLWxvY2stYWZ0ZXItcmVsb2FkLTIuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL3Jlc291cmNlcy9kYXRhYmFzZS1sb2NrLWFmdGVy LXJlbG9hZC0yLmh0bWwJKHJldmlzaW9uIDU1NDM5KQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9y ZXNvdXJjZXMvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQtMi5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0xLDggKzEsNiBAQAogPGh0bWw+CiA8aGVhZD4KIDxzY3JpcHQ+Ci12YXIgZGF0YWJhc2U7 Ci0KIGZ1bmN0aW9uIGxvZyhtZXNzYWdlKQogewogICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJjb25zb2xlIikuaW5uZXJIVE1MICs9IG1lc3NhZ2UgKyAiPGJyPiI7CkBAIC0xNSw3ICsxMyw3 IEBAIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCk7CiB9CiAKLWZ1bmN0aW9uIGVycm9yRnVuY3Rpb24odHgsIGVycm9yKQorZnVu Y3Rpb24gZXJyb3JGdW5jdGlvbihlcnJvcikKIHsKICAgICBsb2coIlRlc3QgZmFpbGVkIC0gIiAr IGVycm9yLm1lc3NhZ2UpOwogICAgIGZpbmlzaFRlc3QoKTsKQEAgLTIzLDEzICsyMSwxMSBAQCBm dW5jdGlvbiBlcnJvckZ1bmN0aW9uKHR4LCBlcnJvcikKIAogZnVuY3Rpb24gYWRkRGF0YShkYikK IHsKLSAgICBkYi50cmFuc2FjdGlvbihmdW5jdGlvbih0eCkgeyAKKyAgICBkYi50cmFuc2FjdGlv bihmdW5jdGlvbih0eCkgewogICAgICAgICBsb2coIkluc2VydGluZyBzb21lIGRhdGEiKTsKLQot ICAgICAgICB0eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5UTyBEYXRhVGVzdCAodGVzdERhdGEpIFZB TFVFUyAoPykiLCBbIkEiXSwgZnVuY3Rpb24odHgsIHJlc3VsdCkgeyB9LCBlcnJvckZ1bmN0aW9u KTsKLSAgICB9LCBmdW5jdGlvbigpe30sIGZ1bmN0aW9uKCkgeyAKLSAgICAgICAgZmluaXNoVGVz dCgpOwotICAgIH0pOworICAgICAgICB0eC5leGVjdXRlU3FsKCJJTlNFUlQgSU5UTyBEYXRhVGVz dCAodGVzdERhdGEpIFZBTFVFUyAoPykiLCBbIkEiXSwKKyAgICAgICAgICAgIGZ1bmN0aW9uKHR4 LCByZXN1bHQpIHsgfSwgZnVuY3Rpb24odHgsIGVycm9yKSB7IGVycm9yRnVuY3Rpb24oZXJyb3Ip OyB9KTsKKyAgICB9LCBmdW5jdGlvbigpIHsgfSwgZnVuY3Rpb24oKSB7IGZpbmlzaFRlc3QoKTsg fSk7CiB9CiAKIGZ1bmN0aW9uIHJ1blRlc3QoKQpAQCAtMzgsOSArMzQsOSBAQCBmdW5jdGlvbiBy dW5UZXN0KCkKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgfQotICAgIAor CiAgICAgdHJ5IHsKLSAgICAgICAgZGF0YWJhc2UgPSBvcGVuRGF0YWJhc2UoIkRhdGFiYXNlTG9j a1Rlc3QiLCAiMS4wIiwgIlRlc3QgZm9yIGRhdGFiYXNlIGxvY2tpbmciLCA1MjQyODgwKTsKKyAg ICAgICAgdmFyIGRhdGFiYXNlID0gb3BlbkRhdGFiYXNlKCJEYXRhYmFzZUxvY2tUZXN0IiwgIjEu MCIsICJUZXN0IGZvciBkYXRhYmFzZSBsb2NraW5nIiwgNTI0Mjg4MCk7CiAgICAgICAgIGFkZERh dGEoZGF0YWJhc2UpOwogICAgIH0gY2F0Y2goZSkgewogICAgICAgICBsb2coIkVycm9yIC0gY291 bGQgbm90IG9wZW4gZGF0YWJhc2UiKTsK