34443 2010-02-01 12:15:09 -0800 [GTK] Crash on testwebbackforwardlist unit test 2010-02-01 13:24:51 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 34444 P2 Normal --- 1 gustavo webkit-unassigned beidson fishd oldest_to_newest 186510 0 47861 gustavo 2010-02-01 12:15:09 -0800 Created attachment 47861 Stack trace of the crash This is crashing since r53950 - reverting that revision fixes the crash. Trace attached. 186513 1 47862 gustavo 2010-02-01 12:19:20 -0800 Created attachment 47862 Add missing null-check 186521 2 47862 beidson 2010-02-01 12:33:09 -0800 Comment on attachment 47862 Add missing null-check Please hold off on this - we need a more complete fix. (This is not GTK-only) See https://bugs.webkit.org/show_bug.cgi?id=34444 186523 3 beidson 2010-02-01 12:33:58 -0800 Reverse duping because 34444 has a more complete fix. *** This bug has been marked as a duplicate of bug 34444 *** 186525 4 beidson 2010-02-01 12:35:13 -0800 Also, sorry for the reverse dupe. I'd actually been working on this crash for the last few hours (oh what fun adding DRT changes and tests for specific API usage...) and filed 34444 before I saw this existed. What a difference 10 minutes makes. 186544 5 gustavo 2010-02-01 13:24:51 -0800 (In reply to comment #4) > Also, sorry for the reverse dupe. I'd actually been working on this crash for > the last few hours (oh what fun adding DRT changes and tests for specific API > usage...) and filed 34444 before I saw this existed. What a difference 10 > minutes makes. Nevermind, I made a simple fix because this would hold up our release, I'm happy to see a much more solid fix landing, thanks! 47861 2010-02-01 12:15:09 -0800 2010-02-01 12:15:09 -0800 Stack trace of the crash stacktrace.log text/plain 4107 gustavo U3RhcnRpbmcgcHJvZ3JhbTogL2hvbWUva292L3NyYy9XZWJLaXQvV2ViS2l0QnVpbGQvRGVidWcv UHJvZ3JhbXMvdW5pdHRlc3RzL3Rlc3R3ZWJiYWNrZm9yd2FyZGxpc3QgCltUaHJlYWQgZGVidWdn aW5nIHVzaW5nIGxpYnRocmVhZF9kYiBlbmFibGVkXQpbTmV3IFRocmVhZCAweDdmZmZlOWIwYTkx MCAoTFdQIDMxNjA1KV0KW05ldyBUaHJlYWQgMHg3ZmZmZTkzMDk5MTAgKExXUCAzMTYwNildCltU aHJlYWQgMHg3ZmZmZTkzMDk5MTAgKExXUCAzMTYwNikgZXhpdGVkXQoKUHJvZ3JhbSByZWNlaXZl ZCBzaWduYWwgU0lHU0VHViwgU2VnbWVudGF0aW9uIGZhdWx0LgoweDAwMDA3ZmZmZjYyOGRmZWMg aW4gV2ViQ29yZTo6SGlzdG9yeUl0ZW06OmRvY3VtZW50U2VxdWVuY2VOdW1iZXIgKHRoaXM9MHgw KQogICAgYXQgLi4vLi4vV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmg6MTQwCjE0MAkgICAg bG9uZyBsb25nIGRvY3VtZW50U2VxdWVuY2VOdW1iZXIoKSBjb25zdCB7IHJldHVybiBtX2RvY3Vt ZW50U2VxdWVuY2VOdW1iZXI7IH0KQ3VycmVudCBsYW5ndWFnZTogIGF1dG8KVGhlIGN1cnJlbnQg c291cmNlIGxhbmd1YWdlIGlzICJhdXRvOyBjdXJyZW50bHkgYysrIi4KIzAgIDB4MDAwMDdmZmZm NjI4ZGZlYyBpbiBXZWJDb3JlOjpIaXN0b3J5SXRlbTo6ZG9jdW1lbnRTZXF1ZW5jZU51bWJlciAo CiAgICB0aGlzPTB4MCkgYXQgLi4vLi4vV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmg6MTQw Ck5vIGxvY2Fscy4KIzEgIDB4MDAwMDdmZmZmNjI4YzRmZCBpbiBXZWJDb3JlOjpGcmFtZUxvYWRl cjo6bG9hZEl0ZW0gKHRoaXM9MHg2ZDFjNTAsIAogICAgaXRlbT0weDY5MDE4MCwgbG9hZFR5cGU9 V2ViQ29yZTo6RnJhbWVMb2FkVHlwZUluZGV4ZWRCYWNrRm9yd2FyZCkKICAgIGF0IC4uLy4uL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDozODIxCiAgICAgICAgc2FtZURvY3VtZW50TmF2 aWdhdGlvbiA9IGZhbHNlCiMyICAweDAwMDA3ZmZmZjYyOTQyMmUgaW4gV2ViQ29yZTo6SGlzdG9y eUNvbnRyb2xsZXI6OnJlY3Vyc2l2ZUdvVG9JdGVtICgKICAgIHRoaXM9MHg2ZDFkYTAsIGl0ZW09 MHg2OTAxODAsIGZyb21JdGVtPTB4NzRiNmIwLCAKICAgIHR5cGU9V2ViQ29yZTo6RnJhbWVMb2Fk VHlwZUluZGV4ZWRCYWNrRm9yd2FyZCkKICAgIGF0IC4uLy4uL1dlYkNvcmUvbG9hZGVyL0hpc3Rv cnlDb250cm9sbGVyLmNwcDo1ODUKICAgICAgICBfX1BSRVRUWV9GVU5DVElPTl9fID0gInZvaWQg V2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnJlY3Vyc2l2ZUdvVG9JdGVtKFdlYkNvcmU6Okhp c3RvcnlJdGVtKiwgV2ViQ29yZTo6SGlzdG9yeUl0ZW0qLCBXZWJDb3JlOjpGcmFtZUxvYWRUeXBl KSIKICAgICAgICBpdGVtVVJMID0ge21fc3RyaW5nID0gewogICAgICAgICAgICBtX2ltcGwgPSB7 PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAgICAgICAgICAg IG1fcHRyID0gMHg3NGI2NTB9fSwgbV9pc1ZhbGlkID0gdHJ1ZSwgCiAgICAgICAgICBtX3Byb3Rv Y29sSW5IVFRQRmFtaWx5ID0gdHJ1ZSwgbV9zY2hlbWVFbmQgPSA0LCBtX3VzZXJTdGFydCA9IDcs IAogICAgICAgICAgbV91c2VyRW5kID0gNywgbV9wYXNzd29yZEVuZCA9IDcsIG1faG9zdEVuZCA9 IDE4LCBtX3BvcnRFbmQgPSAxOCwgCiAgICAgICAgICBtX3BhdGhBZnRlckxhc3RTbGFzaCA9IDE5 LCBtX3BhdGhFbmQgPSAxOSwgbV9xdWVyeUVuZCA9IDE5LCAKICAgICAgICAgIG1fZnJhZ21lbnRF bmQgPSAxOX0KICAgICAgICBjdXJyZW50VVJMID0ge21fc3RyaW5nID0gewogICAgICAgICAgICBt X2ltcGwgPSB7PFdURjo6RmFzdEFsbG9jQmFzZT4gPSB7PE5vIGRhdGEgZmllbGRzPn0sIAogICAg ICAgICAgICAgIG1fcHRyID0gMHg2NDNiMTB9fSwgbV9pc1ZhbGlkID0gZmFsc2UsIAogICAgICAg ICAgbV9wcm90b2NvbEluSFRUUEZhbWlseSA9IGZhbHNlLCBtX3NjaGVtZUVuZCA9IDAsIG1fdXNl clN0YXJ0ID0gMCwgCiAgICAgICAgICBtX3VzZXJFbmQgPSAwLCBtX3Bhc3N3b3JkRW5kID0gMCwg bV9ob3N0RW5kID0gMCwgbV9wb3J0RW5kID0gMCwgCiAgICAgICAgICBtX3BhdGhBZnRlckxhc3RT bGFzaCA9IDAsIG1fcGF0aEVuZCA9IDAsIG1fcXVlcnlFbmQgPSAwLCAKICAgICAgICAgIG1fZnJh Z21lbnRFbmQgPSAwfQojMyAgMHgwMDAwN2ZmZmY2MjkyM2RjIGluIFdlYkNvcmU6Okhpc3RvcnlD b250cm9sbGVyOjpnb1RvSXRlbSAodGhpcz0weDZkMWRhMCwgCiAgICB0YXJnZXRJdGVtPTB4Njkw MTgwLCB0eXBlPVdlYkNvcmU6OkZyYW1lTG9hZFR5cGVJbmRleGVkQmFja0ZvcndhcmQpCiAgICBh dCAuLi8uLi9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHA6MjI3CiAgICAgICAg X19QUkVUVFlfRlVOQ1RJT05fXyA9ICJ2b2lkIFdlYkNvcmU6Okhpc3RvcnlDb250cm9sbGVyOjpn b1RvSXRlbShXZWJDb3JlOjpIaXN0b3J5SXRlbSosIFdlYkNvcmU6OkZyYW1lTG9hZFR5cGUpIgog ICAgICAgIGJmTGlzdCA9IDB4NjcxNDcwCiAgICAgICAgcGFnZSA9IDB4NjU2NjAwCiAgICAgICAg Y3VycmVudEl0ZW0gPSAweDc0YjZiMAogICAgICAgIHNldHRpbmdzID0gMHg2NjM0ODAKIzQgIDB4 MDAwMDdmZmZmNjMwZTY3YyBpbiBXZWJDb3JlOjpQYWdlOjpnb1RvSXRlbSAodGhpcz0weDY1NjYw MCwgCiAgICBpdGVtPTB4NjkwMTgwLCB0eXBlPVdlYkNvcmU6OkZyYW1lTG9hZFR5cGVJbmRleGVk QmFja0ZvcndhcmQpCiAgICBhdCAuLi8uLi9XZWJDb3JlL3BhZ2UvUGFnZS5jcHA6MzA5Ck5vIGxv Y2Fscy4KIzUgIDB4MDAwMDdmZmZmNjc4ZjA3YSBpbiB3ZWJraXRfd2ViX3ZpZXdfZ29fdG9fYmFj a19mb3J3YXJkX2l0ZW0gKAogICAgd2ViVmlldz0weDY1NzAyMCwgaXRlbT0weDY4NDU0MCkKICAg IGF0IC4uLy4uL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOjI5NTEKICAgICAg ICBfX1BSRVRUWV9GVU5DVElPTl9fID0gImdib29sZWFuIHdlYmtpdF93ZWJfdmlld19nb190b19i YWNrX2ZvcndhcmRfaXRlbShXZWJLaXRXZWJWaWV3KiwgV2ViS2l0V2ViSGlzdG9yeUl0ZW0qKSIK ICAgICAgICBiYWNrRm9yd2FyZExpc3QgPSAweDY3ZjkwMAojNiAgMHgwMDAwMDAwMDAwNDAzNTg5 IGluIHRlc3Rfd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9hZGRfaXRlbSAoKQogICAgYXQg Li4vLi4vV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2ViYmFja2ZvcndhcmRsaXN0LmM6MjYwCiAgICAg ICAgd2ViVmlldyA9IDB4NjU3MDIwCiAgICAgICAgd2ViQmFja0ZvcndhcmRMaXN0ID0gMHg2N2Y5 MDAKICAgICAgICBhZGRJdGVtMSA9IDB4Njg0NTQwCiAgICAgICAgYWRkSXRlbTIgPSAweDY4NDVl MAogICAgICAgIGJhY2tJdGVtID0gMHg2ODQ1NDAKICAgICAgICBjdXJyZW50SXRlbSA9IDB4Njg0 NWUwCiAgICAgICAgX19QUkVUVFlfRlVOQ1RJT05fXyA9ICJ0ZXN0X3dlYmtpdF93ZWJfYmFja19m b3J3YXJkX2xpc3RfYWRkX2l0ZW0iCiM3ICAweDAwMDA3ZmZmZjJkYTQ3ZjMgaW4gPz8gKCkgZnJv bSAvbGliL2xpYmdsaWItMi4wLnNvLjAKTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxhYmxlLgoj OCAgMHgwMDAwN2ZmZmYyZGE0OTY2IGluID8/ICgpIGZyb20gL2xpYi9saWJnbGliLTIuMC5zby4w Ck5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4KIzkgIDB4MDAwMDdmZmZmMmRhNDk2NiBp biA/PyAoKSBmcm9tIC9saWIvbGliZ2xpYi0yLjAuc28uMApObyBzeW1ib2wgdGFibGUgaW5mbyBh dmFpbGFibGUuCiMxMCAweDAwMDA3ZmZmZjJkYTRjNGIgaW4gZ190ZXN0X3J1bl9zdWl0ZSAoKSBm cm9tIC9saWIvbGliZ2xpYi0yLjAuc28uMApObyBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUu CiMxMSAweDAwMDAwMDAwMDA0MDM3YTIgaW4gbWFpbiAoYXJnYz0xLCBhcmd2PTB4N2ZmZmZmZmZl MmE4KQogICAgYXQgLi4vLi4vV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2ViYmFja2ZvcndhcmRsaXN0 LmM6Mjc4Ck5vIGxvY2Fscy4KQSBkZWJ1Z2dpbmcgc2Vzc2lvbiBpcyBhY3RpdmUuCgoJSW5mZXJp b3IgMSBbcHJvY2VzcyAzMTU4Nl0gd2lsbCBiZSBraWxsZWQuCgpRdWl0IGFueXdheT8gKHkgb3Ig bikg 47862 2010-02-01 12:19:20 -0800 2010-02-01 12:33:08 -0800 Add missing null-check 0001-Fixes-crash-by-adding-a-missing-null-check.patch text/plain 2182 gustavo RnJvbSA5MzJjNGQ3NTRkMTQ3M2I3NDFmOThhZWIyZGE2YmU0Y2ZiNTk3YTQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgMSBGZWIgMjAxMCAxODoxNzo1NiAtMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eGVzIGNyYXNoIGJ5IGFkZGluZyBhIG1pc3NpbmcgbnVsbC1jaGVjawoKLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGMxYjI3ZjMuLjg3NTY5NjIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTAtMDItMDEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ3Jhc2ggb24g dGVzdHdlYmJhY2tmb3J3YXJkbGlzdCB1bml0IHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDQzCisKKyAgICAgICAgQ3Jhc2ggc2VlbXMgdG8g YmUgc3BlY2lmaWMgdG8gb3VyIEFQSSwgYW5kIGlzIGNvdmVyZWQgYnkKKyAgICAgICAgdGVzdHdl YmJhY2tmb3J3YXJkbGlzdC4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6bG9hZEl0ZW0pOgorCiAyMDEwLTAxLTI5ICBQ aGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNDQ3MWM5Ny4uZWEw OTgzNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzgxOCw3ICszODE4LDcgQEAgdm9pZCBG cmFtZUxvYWRlcjo6bG9hZEl0ZW0oSGlzdG9yeUl0ZW0qIGl0ZW0sIEZyYW1lTG9hZFR5cGUgbG9h ZFR5cGUpCiAgICAgLy8gLSBUaGUgSGlzdG9yeUl0ZW0gaGFzIGEgaGlzdG9yeSBzdGF0ZSBvYmpl Y3QKICAgICAvLyAtIE5hdmlnYXRpbmcgdG8gYW4gYW5jaG9yIHdpdGhpbiB0aGUgcGFnZSwgd2l0 aCBubyBmb3JtIGRhdGEgc3RvcmVkIG9uIHRoZSB0YXJnZXQgaXRlbSBvciB0aGUgY3VycmVudCBo aXN0b3J5IGVudHJ5LAogICAgIC8vICAgYW5kIHRoZSBVUkxzIGluIHRoZSBmcmFtZSB0cmVlIG1h dGNoIHRoZSBoaXN0b3J5IGl0ZW0gZm9yIGZyYWdtZW50IHNjcm9sbGluZy4KLSAgICBib29sIHNh bWVEb2N1bWVudE5hdmlnYXRpb24gPSAoIWl0ZW0tPmZvcm1EYXRhKCkgJiYgIShoaXN0b3J5KCkt PmN1cnJlbnRJdGVtKCkgJiYgaGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpLT5mb3JtRGF0YSgpKSAm JiBoaXN0b3J5KCktPnVybHNNYXRjaEl0ZW0oaXRlbSkpIHx8IGl0ZW0tPmRvY3VtZW50U2VxdWVu Y2VOdW1iZXIoKSA9PSBoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCktPmRvY3VtZW50U2VxdWVuY2VO dW1iZXIoKTsKKyAgICBib29sIHNhbWVEb2N1bWVudE5hdmlnYXRpb24gPSAoIWl0ZW0tPmZvcm1E YXRhKCkgJiYgIShoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkgJiYgaGlzdG9yeSgpLT5jdXJyZW50 SXRlbSgpLT5mb3JtRGF0YSgpKSAmJiBoaXN0b3J5KCktPnVybHNNYXRjaEl0ZW0oaXRlbSkpIHx8 IChoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkgJiYgKGl0ZW0tPmRvY3VtZW50U2VxdWVuY2VOdW1i ZXIoKSA9PSBoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCktPmRvY3VtZW50U2VxdWVuY2VOdW1iZXIo KSkpOwogCiAjaWYgRU5BQkxFKFdNTCkKICAgICAvLyBBbGwgV01MIGRlY2tzIHNob3VsZCBnbyB0 aHJvdWdoIHRoZSByZWFsIGxvYWQgbWVjaGFuaXNtLCBub3QgdGhlIHNjcm9sbC10by1hbmNob3Ig Y29kZQotLSAKMS42LjYKCg==