34336 2010-01-29 10:17:43 -0800 REGRESSION: run-webkit-httpd doesn't print requests to stdout 2010-02-01 16:08:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED P1 Normal --- 33153 1 ap abecsi abecsi eric oldest_to_newest 185907 0 ap 2010-01-29 10:17:43 -0800 run-webkit-httpd used to print responses to console. That's why it runs Apache in single process mode. It's a serious problem that you can't see what happens on Apache side when working on regression tests. 185960 1 47734 abecsi 2010-01-29 14:21:27 -0800 Created attachment 47734 Print requests to stdout if run-webkit-httpd is used 185976 2 47734 ap 2010-01-29 15:03:25 -0800 Comment on attachment 47734 Print requests to stdout if run-webkit-httpd is used It may be more elegant to just use ">&1" as the first argument to open2(). What do you think? 185985 3 47739 abecsi 2010-01-29 15:40:03 -0800 Created attachment 47739 simlified patch 185987 4 47739 commit-queue 2010-01-29 15:43:09 -0800 Comment on attachment 47739 simlified patch Rejecting patch 47739 from commit-queue. abecsi@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 185993 5 47739 ap 2010-01-29 15:54:12 -0800 Comment on attachment 47739 simlified patch Looks good. Please don't remove "close HTTPDIN" - I don't think it's a big deal, but changing this aspect of the code is probably not appropriate for this patch. 185994 6 47739 abecsi 2010-01-29 16:01:37 -0800 Comment on attachment 47739 simlified patch Patch committed in revision 54084. 186001 7 abecsi 2010-01-29 16:31:15 -0800 Patch has been landed. Closing bug. 186546 8 eric 2010-02-01 13:29:23 -0800 the commit-queue has been restarted and will now recognize Andras as a committer. 186637 9 abecsi 2010-02-01 16:08:53 -0800 (In reply to comment #8) > the commit-queue has been restarted and will now recognize Andras as a > committer. Thanks, Eric. 47734 2010-01-29 14:21:27 -0800 2010-01-29 15:40:03 -0800 Print requests to stdout if run-webkit-httpd is used patch.diff text/plain 1806 abecsi SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9odHRwZC5wbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQucG0JKHJldmlzaW9uIDU0 MDc0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtCSh3b3JraW5n IGNvcHkpCkBAIC01NCw2ICs1NCw4IEBACiBteSAkaHR0cGRQaWRGaWxlID0gRmlsZTo6U3BlYy0+ Y2F0ZmlsZSgkaHR0cGRQaWREaXIsICJodHRwZC5waWQiKTsKIG15ICRodHRwZFBpZDsKIG15ICR3 YWl0Rm9yVXNlckludGVycnVwdCA9IDA7CitteSAkSFRUUERJTjsKK215ICRIVFRQRE9VVDsKIAog JFNJR3snSU5UJ30gPSAnY2xlYW51cCc7CiAkU0lHeydURVJNJ30gPSAnY2xlYW51cCc7CkBAIC0x NDcsNyArMTQ5LDcgQEAKIAogICAgICRodHRwZFBhdGggPSAiL3Vzci9zYmluL2h0dHBkIiB1bmxl c3MgKCRodHRwZFBhdGgpOwogCi0gICAgb3BlbjIoXCpIVFRQRElOLCBcKkhUVFBET1VULCAkaHR0 cGRQYXRoLCBAYXJncyk7CisgICAgb3BlbjIoJEhUVFBET1VULCAkSFRUUERJTiwgJGh0dHBkUGF0 aCwgQGFyZ3MpOwogCiAgICAgbXkgJHJldHJ5Q291bnQgPSAyMDsKICAgICB3aGlsZSAoIS1mICRo dHRwZFBpZEZpbGUgJiYgJHJldHJ5Q291bnQpIHsKQEAgLTE2NCwxNSArMTY2LDE5IEBACiAgICAg Y2hvbXAgJGh0dHBkUGlkIGlmICRodHRwZFBpZDsKICAgICBjbG9zZSBQSURGSUxFOwogCi0gICAg d2FpdHBpZCgkaHR0cGRQaWQsIDApIGlmICgkd2FpdEZvclVzZXJJbnRlcnJ1cHQgJiYgJGh0dHBk UGlkKTsKKyAgICBpZiAoJHdhaXRGb3JVc2VySW50ZXJydXB0KSB7CisgICAgICAgIHdoaWxlICg8 JEhUVFBET1VUPikgeworICAgICAgICAgICAgcHJpbnQgU1RET1VUICIkXyI7CisgICAgICAgIH0K KyAgICB9CiAKICAgICByZXR1cm4gMTsKIH0KIAogc3ViIGNsb3NlSFRUUEQKIHsKLSAgICBjbG9z ZSBIVFRQRElOOwotICAgIGNsb3NlIEhUVFBET1VUOworICAgIGNsb3NlICRIVFRQRElOOworICAg IGNsb3NlICRIVFRQRE9VVDsKIAogICAgIGlmICgkaHR0cGRQaWQpIHsKICAgICAgICAga2lsbCAx NSwgJGh0dHBkUGlkOwpJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNTQwNzkpCisrKyBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMS0yOSAgQW5k cmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdCBvcGVuSFRUUEQoKSB0byBwcmludCByZXF1 ZXN0cyB0byBzdGRvdXQgaWYgcnVuLXdlYmtpdC1odHRwZCBpcyB1c2VkLgorICAgICAgICBUaGlz IGZpeGVzIGEgcmVncmVzc2lvbiBpbnRyb2R1Y2VkIGluIHI1MzU1OS4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQzMzYKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cGVybC9odHRwZC5wbToKKwogMjAxMC0wMS0yOCAgSm9uIEhvbmV5Y3V0dCAg PGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIE1TQUE6IENyYXNoIHdoZW4gcG9zdGlu ZyBhIG5vdGlmaWNhdGlvbiBmb3IgYSBkZXRhY2hlZCBvYmplY3QK 47739 2010-01-29 15:40:03 -0800 2010-01-29 16:01:36 -0800 simlified patch patch.diff text/plain 1312 abecsi SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9odHRwZC5wbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQucG0JKHJldmlzaW9uIDU0 MDc0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtCSh3b3JraW5n IGNvcHkpCkBAIC0xNDcsNyArMTQ3LDcgQEAKIAogICAgICRodHRwZFBhdGggPSAiL3Vzci9zYmlu L2h0dHBkIiB1bmxlc3MgKCRodHRwZFBhdGgpOwogCi0gICAgb3BlbjIoXCpIVFRQRElOLCBcKkhU VFBET1VULCAkaHR0cGRQYXRoLCBAYXJncyk7CisgICAgb3BlbjIoIj4mMSIsIFwqSFRUUERJTiwg JGh0dHBkUGF0aCwgQGFyZ3MpOwogCiAgICAgbXkgJHJldHJ5Q291bnQgPSAyMDsKICAgICB3aGls ZSAoIS1mICRodHRwZFBpZEZpbGUgJiYgJHJldHJ5Q291bnQpIHsKQEAgLTE3MSw5ICsxNzEsNiBA QAogCiBzdWIgY2xvc2VIVFRQRAogewotICAgIGNsb3NlIEhUVFBESU47Ci0gICAgY2xvc2UgSFRU UERPVVQ7Ci0KICAgICBpZiAoJGh0dHBkUGlkKSB7CiAgICAgICAgIGtpbGwgMTUsICRodHRwZFBp ZDsKICAgICAgICAgbXkgJHJldHJ5Q291bnQgPSAyMDsKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU0MDc5 KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDEtMjkgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3Qgb3BlbkhU VFBEKCkgdG8gcHJpbnQgcmVxdWVzdHMgdG8gc3Rkb3V0IGlmIHJ1bi13ZWJraXQtaHR0cGQgaXMg dXNlZC4KKyAgICAgICAgVGhpcyBmaXhlcyBhIHJlZ3Jlc3Npb24gaW50cm9kdWNlZCBpbiByNTM1 NTkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0 MzM2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQucG06CisKIDIwMTAtMDEt MjggIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNU0FB OiBDcmFzaCB3aGVuIHBvc3RpbmcgYSBub3RpZmljYXRpb24gZm9yIGEgZGV0YWNoZWQgb2JqZWN0 Cg==