34315 2010-01-29 01:27:07 -0800 Form serialization doesn't include a submit input whose onclick() handler calls form.submit() 2010-05-12 13:24:59 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All NEW P2 Normal --- 13012 39021 1 joy+webkit webkit-unassigned ap dglazkov oldest_to_newest 185773 0 joy+webkit 2010-01-29 01:27:07 -0800 Hi there. A user reported a problem with Chrome, which I reproduced with Midori, so I'm filing this on the WebKit library that my Midori package uses. The automatic platform detection has limited the version choices to some MacOSX set, which isn't really correct... My Midori and its WebKit library version 1.1.15.2 runs on Linux, while the user's browser identifies as "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.38 Safari/532.0". When a HTML form does this: <form method="post" name="statsFRM"> <script type="text/javascript"> <!-- function submitnormal(action) { document.statsFRM.action = "?id=something"; document.statsFRM.submit(); } --> </script> <input type="submit" value="Good stuff" name="ok" onclick="submitnormal()"> <input type="submit" value="Bad stuff" name="rej" onclick="submitnormal()"> ...the WebKit-based web browsers fail to POST an element named "ok" or "rej" to the web server. I could find no obvious explanation for this omission. http://www.w3.org/TR/html401/interact/forms.html says fairly clearly: 17.13.3 Processing form data When the user submits a form (e.g., by activating a submit button), the user agent processes it as follows. Step one: Identify the successful controls [...] 17.13.2 Successful controls A successful control is "valid" for submission. Every successful control has its control name paired with its current value as part of the submitted form data set. A successful control must be defined within a FORM element and must have a control name. [...] If a form contains more than one submit button, only the activated submit button is successful. [...] Hence, the activated submit button *is* supposed to be successful as well as submitted via POST. There seems to be no reason for the 'onclick' attribute to void the success of the activated submit button, at least not per 18.2.3 'Intrinsic events' which defines it. Please fix this. TIA. FWIW the workaround I had to use consists of passing the omitted name as submitnormal('ok') or submitnormal('rej') in the onclick attribute, and then constructing a new hidden input element just before submission: wanted_action.setAttribute('type', 'hidden'); wanted_action.setAttribute('name', action); wanted_action.setAttribute('value', action); document.statsFRM.appendChild(wanted_action); This is also http://bugs.debian.org/566981 186013 1 ap 2010-01-29 17:17:55 -0800 I think that this is technically a duplicate of bug 13012, but the symptom is so different that we should probably track it separately for now. This JavaScript code is clearly fragile - it makes no sense to call "document.statsFRM.submit();" given that the submission is going to happen anyway (and yes, even the change to action will take effect). Does this affect any sites in real life? That's usually the primary key to determine priority of fixing issues such as this. 186015 2 47748 ap 2010-01-29 17:18:21 -0800 Created attachment 47748 test case adapted for running locally 186108 3 joy+webkit 2010-01-30 03:53:24 -0800 Alexey, you're right, just losing the explicit submit() is a clean workaround, and it seems to do no harm to other browsers. Thanks. Feel free to merge. 47748 2010-01-29 17:18:21 -0800 2010-01-29 17:18:21 -0800 test case adapted for running locally form.html text/html 492 ap PGJvZHk+Cjxmb3JtIG1ldGhvZD0icG9zdCIgbmFtZT0ic3RhdHNGUk0iIGFjdGlvbj0iaHR0cDov LzEyNy4wLjAuMTo4MDAwL3htbGh0dHByZXF1ZXN0L3Jlc291cmNlcy9wb3N0LWVjaG8uY2dpIj4K CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4gIApmdW5jdGlvbiBzdWJtaXRub3JtYWwo YWN0aW9uKSB7CiAgICBkb2N1bWVudC5zdGF0c0ZSTS5hY3Rpb24gKz0gIj9pZD1zb21ldGhpbmci OwogICAgZG9jdW1lbnQuc3RhdHNGUk0uc3VibWl0KCk7Cn0KPC9zY3JpcHQ+Cgo8aW5wdXQgdHlw ZT0idGV4dCIgdmFsdWU9IlNvbWUgdGV4dCIgbmFtZT0idHh0Ij4KPGlucHV0IHR5cGU9InN1Ym1p dCIgdmFsdWU9Ikdvb2Qgc3R1ZmYiIG5hbWU9Im9rIiBvbmNsaWNrPSJzdWJtaXRub3JtYWwoKSI+ CjxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJCYWQgc3R1ZmYiIG5hbWU9InJlaiIgb25jbGlj az0ic3VibWl0bm9ybWFsKCkiPgo8L2Zvcm0+CjwvYm9keT4K