34285 2010-01-28 15:01:14 -0800 [GTK][WPE] Password field doesn't get input method 2020-01-16 06:45:15 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Linux RESOLVED FIXED InRadar P2 Normal --- 205605 1 jaroslav.klaus christian ap aroben bjt23 bugs-noreply cdumez cgarcia christian cjlhomeaddress dbates enrica esprehn+autocc ews-watchlist gyuyoung.kim mifenton simon webkit-bug-importer zan oldest_to_newest 185620 0 jaroslav.klaus 2010-01-28 15:01:14 -0800 Is it correct password field doesn't get input method? In FocusController::setFocusedNode there is m_page->editorClient()->setInputMethodState(node->shouldUseInputMethod()); while bool HTMLInputElement::shouldUseInputMethod() const { return m_type == TEXT || m_type == SEARCH || m_type == ISINDEX; } So for password field setInputMethodState is always called with false that is problem for on-screen-keyboard. Can you consider to extend shouldUseInputMethod to PASSWORD type? Thx 185652 1 ap 2010-01-28 17:12:50 -0800 What platform is this report about? WebKit on Mac completely ignores setInputMethodState() calls, so this cannot affect Safari. 185655 2 jaroslav.klaus 2010-01-28 17:15:25 -0800 PC/linux. I've jusr updated the bug record. 185657 3 jaroslav.klaus 2010-01-28 17:17:16 -0800 webkit gtk 190589 4 bjt23 2010-02-15 20:11:47 -0800 Yes, changing that line does indeed fix it for the gtk port: --- a/WebCore/html/HTMLInputElement.cpp +++ b/WebCore/html/HTMLInputElement.cpp @@ -523,7 +523,7 @@ void HTMLInputElement::aboutToUnload() bool HTMLInputElement::shouldUseInputMethod() const { - return m_type == TEXT || m_type == SEARCH || m_type == ISINDEX; + return m_type == TEXT || m_type == SEARCH || m_type == ISINDEX || m_type == PASSWORD; } void HTMLInputElement::handleFocusEvent() 190597 5 ap 2010-02-15 21:35:12 -0800 It's really confusing that cross-platform code in WebCore only affects some platforms, and is even against conventions of other ones. 348978 6 81956 christian 2011-02-10 05:22:20 -0800 Created attachment 81956 Allow input methods in password input elements This patch enables input methods in password entries. There may be security concerns, but it doesn't help if I want to use WebKit on a device without a physical way to type the password. If there is strong concern, I can modify the patch to make this a setting. 349124 7 ap 2011-02-10 09:21:39 -0800 This needs: #if PLATFORM(MAC) // Platform convention is to only allow Roman characters in passwords. ASSERT_NOT_REACHED(); #endif I would really prefer a deeper refactoring that wouldn't leave us with Gtk specific code in HTMLInputElement. + // Arguably insecure. In practise required if the password must be We normally use American spelling in WebKit (i.e. "practice"). 349752 8 82130 christian 2011-02-11 06:50:33 -0800 Created attachment 82130 Allow input methods in password input elements, #2 (In reply to comment #7) > #if PLATFORM(MAC) > // Platform convention is to only allow Roman characters in passwords. This is not just about non-Latin characters, but also virtual keyboards, thusly I made it: // Platform convention is to disallow input methods for passwords. > I would really prefer a deeper refactoring that wouldn't leave us with Gtk specific code in HTMLInputElement. I don't have a Mac and I'm probably not a good person to judge how it would need to be changed. From a quick look I didn't even see password handling at all, so I assume it relies on system behaviour to a good extend. > + // Arguably insecure. In practise required if the password must be > > We normally use American spelling in WebKit (i.e. "practice"). Corrected. 349790 9 ap 2011-02-11 08:43:54 -0800 > This is not just about non-Latin characters, but also virtual keyboards, thusly I made it: Please let me reiterate that virtual keyboard is not an input method on Mac, and works with password fields just great. Generally, it sounds more like an exception than a rule that on-screen keyboards would use input method machinery. Your new comment seems fine though. > I don't have a Mac I've just noticed that even though this function has no effect whatsoever on Mac, it does affect Safari for Windows, quite possibly in a bad way. Thus, deferring to Adam or Enrica for review. 349791 10 aroben 2011-02-11 08:46:39 -0800 I guess someone should test on Windows to see what the platform convention is. What do password fields in the OS do? What do other browsers do? I'm not familiar with input methods, so I don't know how to perform this testing myself. 353197 11 82130 mrobinson 2011-02-17 15:19:27 -0800 Comment on attachment 82130 Allow input methods in password input elements, #2 View in context: https://bugs.webkit.org/attachment.cgi?id=82130&action=review I believe that in Chromium, they only allow simple input method events. > Source/WebCore/html/PasswordInputType.cpp:67 > +#if PLATFORM(MAC) > + // Platform convention is to disallow input methods for passwords. > + ASSERT_NOT_REACHED(); > +#endif This seems wrong. Why should PLATFORM(MAC) ASSERT_NOT_REACHED() ? > Source/WebCore/html/PasswordInputType.cpp:70 > + return true; If we going to do this, we probably only want to do it for PLATFORM(GTK). 353493 12 christian 2011-02-18 02:13:51 -0800 (In reply to comment #11) > > Source/WebCore/html/PasswordInputType.cpp:67 > > +#if PLATFORM(MAC) > > + // Platform convention is to disallow input methods for passwords. > > + ASSERT_NOT_REACHED(); > > +#endif > > This seems wrong. Why should PLATFORM(MAC) ASSERT_NOT_REACHED() ? > > > Source/WebCore/html/PasswordInputType.cpp:70 > > + return true; > > If we going to do this, we probably only want to do it for PLATFORM(GTK). Please see the previous comments, I did exactly what you are suggesting originally and the feedback was to do it for all ports except Mac which has a different mechanism. 766812 13 simon 2012-11-14 06:14:33 -0800 Hmm, this one is important for OLPC (who uses webkitgtk). At the moment you can not log into any page that has a passoword field using the on screen keyboard. Can the patch provided on this ticket be revised another time and included in some form? There seem to have been mostly agreement and things seems stuck in the last 10% :/ For reference: http://bugs.sugarlabs.org/ticket/4069 770142 14 simon 2012-11-18 09:28:05 -0800 Actually, this affects Epiphany as well. So Sugar and Epiphany would both profit from a fix here. 1601616 15 cgarcia 2019-12-27 08:21:55 -0800 (In reply to Martin Robinson from comment #11) > Comment on attachment 82130 [details] > Allow input methods in password input elements, #2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=82130&action=review > > I believe that in Chromium, they only allow simple input method events. Both chromium and firefox allow input methods in password fields. 1601617 16 cgarcia 2019-12-27 08:25:00 -0800 After bug #205605 we will notify the input methods about the editable purpose, so for password fields we will set the purpose as WEBKIT_INPUT_PURPOSE_PASSWORD. That way the input methods (including virtual keyboards) can ensure the characters won't be visible and be prepared for a password input. 1601620 17 386446 cgarcia 2019-12-27 08:32:34 -0800 Created attachment 386446 Patch It won't apply, since it depends on bug #205605 1605076 18 387330 cgarcia 2020-01-10 05:25:32 -0800 Created attachment 387330 Rebased patch 1607445 19 cgarcia 2020-01-16 06:44:26 -0800 Committed r254675: <https://trac.webkit.org/changeset/254675> 1607446 20 webkit-bug-importer 2020-01-16 06:45:15 -0800 <rdar://problem/58642844> 81956 2011-02-10 05:22:20 -0800 2011-02-11 06:50:33 -0800 Allow input methods in password input elements 0001-Gtk-Password-field-doesn-t-get-input-method.diff text/plain 1889 christian RnJvbSBlOWJmZGY1YjdkMzlhZTAzMjcyYzYwNjUyNTZiMTYwNTQ4YTUxMzE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRHl3YW4gPGNocmlzdGlhbkB0d290b2FzdHMu ZGU+CkRhdGU6IFRodSwgMTAgRmViIDIwMTEgMTQ6MTU6MzQgKzAxMDAKU3ViamVjdDogW1BBVENI XSBbR3RrXSBQYXNzd29yZCBmaWVsZCBkb2Vzbid0IGdldCBpbnB1dCBtZXRob2QKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI4NQoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTKS4KCiogaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHA6IEFsbG93IGlucHV0IG1ldGhv ZHMgaW4gcGFzc3dvcmQKICAgIGlucHV0IGVsZW1lbnRzLgotLS0KIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBTb3VyY2UvV2ViQ29y ZS9odG1sL1Bhc3N3b3JkSW5wdXRUeXBlLmNwcCB8ICAgIDYgKysrLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDEzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU0ZDIy NjIuLmE5Y2NkMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0xMCAgQ2hy aXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQGxhbmVkby5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTKS4KKworICAgICAgICBbR3RrXSBQYXNzd29yZCBmaWVsZCBkb2Vzbid0 IGdldCBpbnB1dCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0Mjg1CisKKyAgICAgICAgKiBodG1sL1Bhc3N3b3JkSW5wdXRUeXBlLmNwcDog QWxsb3cgaW5wdXQgbWV0aG9kcyBpbiBwYXNzd29yZAorICAgICAgICAgICAgaW5wdXQgZWxlbWVu dHMuCisKIDIwMTEtMDItMDkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvUGFzc3dvcmRJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9QYXNzd29yZElucHV0VHlwZS5jcHAKaW5kZXggMmE5YWQwMi4uYzZiZDQ2OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHAKQEAgLTYxLDkgKzYxLDkgQEAgdm9p ZCBQYXNzd29yZElucHV0VHlwZTo6cmVzdG9yZUZvcm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5n JikgY29uc3QKIAogYm9vbCBQYXNzd29yZElucHV0VHlwZTo6c2hvdWxkVXNlSW5wdXRNZXRob2Qo KSBjb25zdAogewotICAgIC8vIElucHV0IG1ldGhvZHMgYXJlIGRpc2FibGVkIGZvciB0aGUgcGFz c3dvcmQgZmllbGQgYmVjYXVzZSBvdGhlcndpc2UKLSAgICAvLyBhbnlvbmUgY2FuIGFjY2VzcyB0 aGUgdW5kZXJseWluZyBwYXNzd29yZCBhbmQgZGlzcGxheSBpdCBpbiBjbGVhciB0ZXh0LgotICAg IHJldHVybiBmYWxzZTsKKyAgICAvLyBBcmd1YWJseSBpbnNlY3VyZS4gSW4gcHJhY3Rpc2UgcmVx dWlyZWQgaWYgdGhlIHBhc3N3b3JkIG11c3QgYmUKKyAgICAvLyB0eXBlZCB3aXRoIGZvciBleGFt cGxlIGFuIG9uLXNjcmVlbi1rZXlib2FyZC4KKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9vbCBQ YXNzd29yZElucHV0VHlwZTo6c2hvdWxkUmVzZXRPbkRvY3VtZW50QWN0aXZhdGlvbigpCi0tIAox LjcuMy41Cgo= 82130 2011-02-11 06:50:33 -0800 2019-12-27 08:32:34 -0800 Allow input methods in password input elements, #2 0001-Gtk-Password-field-doesn-t-get-input-method.diff text/plain 2047 christian RnJvbSBkYzZmNmM0MGJiNTg4NDgzYzBjZWI3NzY4Yjk0YjMwYWY4NjRhY2U4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRHl3YW4gPGNocmlzdGlhbkB0d290b2FzdHMu ZGU+CkRhdGU6IFRodSwgMTAgRmViIDIwMTEgMTQ6MTU6MzQgKzAxMDAKU3ViamVjdDogW1BBVENI XSBbR3RrXSBQYXNzd29yZCBmaWVsZCBkb2Vzbid0IGdldCBpbnB1dCBtZXRob2QKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI4NQoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTKS4KCiogaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHA6IEFsbG93IGlucHV0IG1ldGhv ZHMgaW4gcGFzc3dvcmQKICAgIGlucHV0IGVsZW1lbnRzLgotLS0KIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBTb3VyY2UvV2ViQ29y ZS9odG1sL1Bhc3N3b3JkSW5wdXRUeXBlLmNwcCB8ICAgMTAgKysrKysrKy0tLQogMiBmaWxlcyBj aGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBl YjRiY2Q5Li5lYzgyZWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTEg IENocmlzdGlhbiBEeXdhbiAgPGNocmlzdGlhbkBsYW5lZG8uY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUykuCisKKyAgICAgICAgW0d0a10gUGFzc3dvcmQgZmllbGQgZG9l c24ndCBnZXQgaW5wdXQgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNDI4NQorCisgICAgICAgICogaHRtbC9QYXNzd29yZElucHV0VHlwZS5j cHA6IEFsbG93IGlucHV0IG1ldGhvZHMgaW4gcGFzc3dvcmQKKyAgICAgICAgICAgIGlucHV0IGVs ZW1lbnRzLgorCiAyMDExLTAyLTExICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQWN0dWFsbHkgYWRkIENyeXB0by5jcHAgdG8gdGhlIFdpbmRvd3MgYnVpbGQuICBJ J20gdGVycmlibGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1Bhc3N3b3JkSW5w dXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvUGFzc3dvcmRJbnB1dFR5cGUuY3BwCmlu ZGV4IDJhOWFkMDIuLjBkODgzMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvUGFz c3dvcmRJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvUGFzc3dvcmRJbnB1 dFR5cGUuY3BwCkBAIC02MSw5ICs2MSwxMyBAQCB2b2lkIFBhc3N3b3JkSW5wdXRUeXBlOjpyZXN0 b3JlRm9ybUNvbnRyb2xTdGF0ZShjb25zdCBTdHJpbmcmKSBjb25zdAogCiBib29sIFBhc3N3b3Jk SW5wdXRUeXBlOjpzaG91bGRVc2VJbnB1dE1ldGhvZCgpIGNvbnN0CiB7Ci0gICAgLy8gSW5wdXQg bWV0aG9kcyBhcmUgZGlzYWJsZWQgZm9yIHRoZSBwYXNzd29yZCBmaWVsZCBiZWNhdXNlIG90aGVy d2lzZQotICAgIC8vIGFueW9uZSBjYW4gYWNjZXNzIHRoZSB1bmRlcmx5aW5nIHBhc3N3b3JkIGFu ZCBkaXNwbGF5IGl0IGluIGNsZWFyIHRleHQuCi0gICAgcmV0dXJuIGZhbHNlOworI2lmIFBMQVRG T1JNKE1BQykKKyAgICAvLyBQbGF0Zm9ybSBjb252ZW50aW9uIGlzIHRvIGRpc2FsbG93IGlucHV0 IG1ldGhvZHMgZm9yIHBhc3N3b3Jkcy4KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyNlbmRp ZgorICAgIC8vIEFyZ3VhYmx5IGluc2VjdXJlLiBJbiBwcmFjdGljZSByZXF1aXJlZCBpZiB0aGUg cGFzc3dvcmQgbXVzdCBiZQorICAgIC8vIHR5cGVkIHdpdGggZm9yIGV4YW1wbGUgYW4gb24tc2Ny ZWVuLWtleWJvYXJkLgorICAgIHJldHVybiB0cnVlOwogfQogCiBib29sIFBhc3N3b3JkSW5wdXRU eXBlOjpzaG91bGRSZXNldE9uRG9jdW1lbnRBY3RpdmF0aW9uKCkKLS0gCjEuNy4zLjUKCg== 386446 2019-12-27 08:32:34 -0800 2020-01-10 05:25:32 -0800 Patch wk2-ime-passwords.diff text/plain 3646 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NWY2Njc3NmY4MC4uZTJjZjI1MDhmYTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBQYXNzd29yZCBmaWVsZCBkb2Vzbid0IGdl dCBpbnB1dCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM0Mjg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsb3cgaW5wdXQgbWV0aG9kcyBpbiBwYXNzd29yZCBmaWVsZHMgZm9yIEdUSyBhbmQg V1BFIHBvcnRzLCBzaW5jZSB0aGUgaW5wdXQgbWV0aG9kcyBhcmUgbm90aWZpZWQgdGhhdCB0aGUK KyAgICAgICAgYWN0aXZlIGVkaXRhYmxlIGVsZW1lbnQgaXMgYSBwYXNzd29yZCBmaWVsZC4KKwor ICAgICAgICAqIGh0bWwvUGFzc3dvcmRJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGFzc3dvcmRJbnB1dFR5cGU6OnNob3VsZFVzZUlucHV0TWV0aG9kIGNvbnN0KToKKwogMjAxOS0x Mi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS11bV1BFXSBBZGQgQVBJIHRvIHNldCBwdXJwb3NlIGFuZCBoaW50cyBvZiBhY3RpdmUg ZWRpdGFibGUgZWxlbWVudCB0byBpbnB1dCBtZXRob2RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL1Bhc3N3b3JkSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvUGFz c3dvcmRJbnB1dFR5cGUuY3BwCmluZGV4IGY3Yjk3NWUxZDE5Li43YzhhOWIwNTQzMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9QYXNzd29yZElucHV0VHlwZS5jcHAKQEAgLTY0LDkgKzY0LDE2IEBA IHZvaWQgUGFzc3dvcmRJbnB1dFR5cGU6OnJlc3RvcmVGb3JtQ29udHJvbFN0YXRlKGNvbnN0IEZv cm1Db250cm9sU3RhdGUmKQogCiBib29sIFBhc3N3b3JkSW5wdXRUeXBlOjpzaG91bGRVc2VJbnB1 dE1ldGhvZCgpIGNvbnN0CiB7CisjaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCisg ICAgLy8gSW5wdXQgbWV0aG9kcyBhcmUgZW5hYmxlZCBmb3IgdGhlIHBhc3N3b3JkIGZpZWxkIGlu IEdUSyBhbmQgV1BFIHBvcnRzCisgICAgLy8gYmVjYXVzZSB0aGUgaW5wdXQgbWV0aG9kcyBhcmUg bm90aWZpZWQgdGhhdCB0aGUgYWN0aXZlIGVkaXRhYmxlIGVsZW1lbnQKKyAgICAvLyBpcyBhIHBh c3N3b3JkIGZpZWxkLgorICAgIHJldHVybiB0cnVlOworI2Vsc2UKICAgICAvLyBJbnB1dCBtZXRo b2RzIGFyZSBkaXNhYmxlZCBmb3IgdGhlIHBhc3N3b3JkIGZpZWxkIGJlY2F1c2Ugb3RoZXJ3aXNl CiAgICAgLy8gYW55b25lIGNhbiBhY2Nlc3MgdGhlIHVuZGVybHlpbmcgcGFzc3dvcmQgYW5kIGRp c3BsYXkgaXQgaW4gY2xlYXIgdGV4dC4KICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKIH0KIAog Ym9vbCBQYXNzd29yZElucHV0VHlwZTo6c2hvdWxkUmVzZXRPbkRvY3VtZW50QWN0aXZhdGlvbigp CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGY4 MDdkZDQ0Y2IuLmEyYTE3MmU1ZTg4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMTItMjcgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gUGFz c3dvcmQgZmllbGQgZG9lc24ndCBnZXQgaW5wdXQgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI4NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSB0aGUgdGVzdCBjYXNlIGZvciBwYXNz d29yZCBmaWVsZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9U ZXN0SW5wdXRNZXRob2RDb250ZXh0LmNwcDoKKyAgICAgICAgKHRlc3RXZWJLaXRJbnB1dE1ldGhv ZENvbnRleHRDb250ZW50VHlwZSk6CisKIDIwMTktMTItMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gQWRkIEFQSSB0byBz ZXQgcHVycG9zZSBhbmQgaGludHMgb2YgYWN0aXZlIGVkaXRhYmxlIGVsZW1lbnQgdG8gaW5wdXQg bWV0aG9kcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGli L1Rlc3RJbnB1dE1ldGhvZENvbnRleHQuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRHTGliL1Rlc3RJbnB1dE1ldGhvZENvbnRleHQuY3BwCmluZGV4IDUwODY2NzEyYzY4Li5l NGNkMzFmZTI1NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRH TGliL1Rlc3RJbnB1dE1ldGhvZENvbnRleHQuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0R0xpYi9UZXN0SW5wdXRNZXRob2RDb250ZXh0LmNwcApAQCAtNzczLDE1ICs3 NzMsMTIgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdElucHV0TWV0aG9kQ29udGV4dENvbnRlbnRU eXBlKElucHV0TWV0aG9kVGVzdCogdGVzdCwgZ2NvbnMKICAgICBnX2Fzc2VydF9jbXB1aW50KHRl c3QtPmhpbnRzKCksID09LCBXRUJLSVRfSU5QVVRfSElOVF9OT05FKTsKICAgICB0ZXN0LT51bmZv Y3VzRWRpdGFibGVBbmRXYWl0VW50aWxJbnB1dE1ldGhvZERpc2FibGVkKCk7CiAKLSNpZiAwCi0g ICAgLy8gRklYTUU6IFdlIHNob3VsZCBlbmFibGUgaW5wdXQgbWV0aG9kcyBpbiBwYXNzd29yZCBm aWVsZHMgdG9vLgotICAgIHRlc3QtPmxvYWRIdG1sKCI8aW5wdXQgaWQ9J2VkaXRhYmxlJyB0eXBl PSdwYXNzd29yZCc+IiwgbnVsbHB0cik7CisgICAgdGVzdC0+bG9hZEh0bWwoIjxpbnB1dCBpZD0n ZWRpdGFibGUnIHR5cGU9J3Bhc3N3b3JkJyBzcGVsbGNoZWNrPSdmYWxzZSc+IiwgbnVsbHB0cik7 CiAgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAgICAgdGVzdC0+Zm9jdXNFZGl0 YWJsZUFuZFdhaXRVbnRpbElucHV0TWV0aG9kRW5hYmxlZCgpOwogICAgIGdfYXNzZXJ0X2NtcHVp bnQodGVzdC0+cHVycG9zZSgpLCA9PSwgV0VCS0lUX0lOUFVUX1BVUlBPU0VfUEFTU1dPUkQpOwog ICAgIGdfYXNzZXJ0X2NtcHVpbnQodGVzdC0+aGludHMoKSwgPT0sIFdFQktJVF9JTlBVVF9ISU5U X05PTkUpOwogICAgIHRlc3QtPnVuZm9jdXNFZGl0YWJsZUFuZFdhaXRVbnRpbElucHV0TWV0aG9k RGlzYWJsZWQoKTsKLSNlbmRpZgogCiAgICAgdGVzdC0+bG9hZEh0bWwoIjxkaXYgY29udGVudGVk aXRhYmxlIGlkPSdlZGl0YWJsZScgaW5wdXRtb2RlPSd0ZXh0JyBzcGVsbGNoZWNrPSdmYWxzZSc+ PC9kaXY+IiwgbnVsbHB0cik7CiAgICAgdGVzdC0+d2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7Cg== 387330 2020-01-10 05:25:32 -0800 2020-01-15 03:33:43 -0800 Rebased patch wk2-ime-passwords.diff text/plain 3564 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZWFkNzY1NWE3NS4uMjRkYzUyZWFmMTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0xMi0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBQYXNzd29yZCBmaWVsZCBkb2Vzbid0IGdl dCBpbnB1dCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM0Mjg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsb3cgaW5wdXQgbWV0aG9kcyBpbiBwYXNzd29yZCBmaWVsZHMgZm9yIEdUSyBhbmQg V1BFIHBvcnRzLCBzaW5jZSB0aGUgaW5wdXQgbWV0aG9kcyBhcmUgbm90aWZpZWQgdGhhdCB0aGUK KyAgICAgICAgYWN0aXZlIGVkaXRhYmxlIGVsZW1lbnQgaXMgYSBwYXNzd29yZCBmaWVsZC4KKwor ICAgICAgICAqIGh0bWwvUGFzc3dvcmRJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGFzc3dvcmRJbnB1dFR5cGU6OnNob3VsZFVzZUlucHV0TWV0aG9kIGNvbnN0KToKKwogMjAyMC0w MS0xMCAgQ2hhcmxpZSBUdXJuZXIgIDxtYWlsQGNoYXJsZXMucGx1cz4KIAogICAgICAgICBbRU1F XVtDbGVhcktleV0gUmVmYWN0b3IgQ0RNSW5zdGFuY2VDbGVhcktleTo6dXBkYXRlTGljZW5zZSgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1Bhc3N3b3JkSW5wdXRUeXBlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvUGFzc3dvcmRJbnB1dFR5cGUuY3BwCmluZGV4IGY3Yjk3NWUx ZDE5Li43YzhhOWIwNTQzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9QYXNzd29y ZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9QYXNzd29yZElucHV0VHlw ZS5jcHAKQEAgLTY0LDkgKzY0LDE2IEBAIHZvaWQgUGFzc3dvcmRJbnB1dFR5cGU6OnJlc3RvcmVG b3JtQ29udHJvbFN0YXRlKGNvbnN0IEZvcm1Db250cm9sU3RhdGUmKQogCiBib29sIFBhc3N3b3Jk SW5wdXRUeXBlOjpzaG91bGRVc2VJbnB1dE1ldGhvZCgpIGNvbnN0CiB7CisjaWYgUExBVEZPUk0o R1RLKSB8fCBQTEFURk9STShXUEUpCisgICAgLy8gSW5wdXQgbWV0aG9kcyBhcmUgZW5hYmxlZCBm b3IgdGhlIHBhc3N3b3JkIGZpZWxkIGluIEdUSyBhbmQgV1BFIHBvcnRzCisgICAgLy8gYmVjYXVz ZSB0aGUgaW5wdXQgbWV0aG9kcyBhcmUgbm90aWZpZWQgdGhhdCB0aGUgYWN0aXZlIGVkaXRhYmxl IGVsZW1lbnQKKyAgICAvLyBpcyBhIHBhc3N3b3JkIGZpZWxkLgorICAgIHJldHVybiB0cnVlOwor I2Vsc2UKICAgICAvLyBJbnB1dCBtZXRob2RzIGFyZSBkaXNhYmxlZCBmb3IgdGhlIHBhc3N3b3Jk IGZpZWxkIGJlY2F1c2Ugb3RoZXJ3aXNlCiAgICAgLy8gYW55b25lIGNhbiBhY2Nlc3MgdGhlIHVu ZGVybHlpbmcgcGFzc3dvcmQgYW5kIGRpc3BsYXkgaXQgaW4gY2xlYXIgdGV4dC4KICAgICByZXR1 cm4gZmFsc2U7CisjZW5kaWYKIH0KIAogYm9vbCBQYXNzd29yZElucHV0VHlwZTo6c2hvdWxkUmVz ZXRPbkRvY3VtZW50QWN0aXZhdGlvbigpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggMjlmMTIyYzUzZjIuLjk1NzMyNTMzZjNhIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTktMTItMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdW1dQRV0gUGFzc3dvcmQgZmllbGQgZG9lc24ndCBnZXQgaW5wdXQgbWV0 aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDI4 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJs ZSB0aGUgdGVzdCBjYXNlIGZvciBwYXNzd29yZCBmaWVsZC4KKworICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0SW5wdXRNZXRob2RDb250ZXh0LmNwcDoKKyAgICAg ICAgKHRlc3RXZWJLaXRJbnB1dE1ldGhvZENvbnRleHRDb250ZW50VHlwZSk6CisKIDIwMjAtMDEt MTAgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbRmxhdHBha10gVXBkYXRlIEljZUNDIHRvIHZlcnNpb24gMS4yCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdElucHV0TWV0aG9kQ29udGV4dC5j cHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdElucHV0TWV0aG9k Q29udGV4dC5jcHAKaW5kZXggMmFjZGQyMTk0OWEuLmQzZGFiNmUwOWRlIDEwMDY0NAotLS0gYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdElucHV0TWV0aG9kQ29udGV4 dC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RJbnB1 dE1ldGhvZENvbnRleHQuY3BwCkBAIC04OTgsMTUgKzg5OCwxMiBAQCBzdGF0aWMgdm9pZCB0ZXN0 V2ViS2l0SW5wdXRNZXRob2RDb250ZXh0Q29udGVudFR5cGUoSW5wdXRNZXRob2RUZXN0KiB0ZXN0 LCBnY29ucwogICAgIGdfYXNzZXJ0X2NtcHVpbnQodGVzdC0+aGludHMoKSwgPT0sIFdFQktJVF9J TlBVVF9ISU5UX05PTkUpOwogICAgIHRlc3QtPnVuZm9jdXNFZGl0YWJsZUFuZFdhaXRVbnRpbElu cHV0TWV0aG9kRGlzYWJsZWQoKTsKIAotI2lmIDAKLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGVu YWJsZSBpbnB1dCBtZXRob2RzIGluIHBhc3N3b3JkIGZpZWxkcyB0b28uCi0gICAgdGVzdC0+bG9h ZEh0bWwoIjxpbnB1dCBpZD0nZWRpdGFibGUnIHR5cGU9J3Bhc3N3b3JkJz4iLCBudWxscHRyKTsK KyAgICB0ZXN0LT5sb2FkSHRtbCgiPGlucHV0IGlkPSdlZGl0YWJsZScgdHlwZT0ncGFzc3dvcmQn IHNwZWxsY2hlY2s9J2ZhbHNlJz4iLCBudWxscHRyKTsKICAgICB0ZXN0LT53YWl0VW50aWxMb2Fk RmluaXNoZWQoKTsKICAgICB0ZXN0LT5mb2N1c0VkaXRhYmxlQW5kV2FpdFVudGlsSW5wdXRNZXRo b2RFbmFibGVkKCk7CiAgICAgZ19hc3NlcnRfY21wdWludCh0ZXN0LT5wdXJwb3NlKCksID09LCBX RUJLSVRfSU5QVVRfUFVSUE9TRV9QQVNTV09SRCk7CiAgICAgZ19hc3NlcnRfY21wdWludCh0ZXN0 LT5oaW50cygpLCA9PSwgV0VCS0lUX0lOUFVUX0hJTlRfTk9ORSk7CiAgICAgdGVzdC0+dW5mb2N1 c0VkaXRhYmxlQW5kV2FpdFVudGlsSW5wdXRNZXRob2REaXNhYmxlZCgpOwotI2VuZGlmCiAKICAg ICB0ZXN0LT5sb2FkSHRtbCgiPGRpdiBjb250ZW50ZWRpdGFibGUgaWQ9J2VkaXRhYmxlJyBpbnB1 dG1vZGU9J3RleHQnIHNwZWxsY2hlY2s9J2ZhbHNlJz48L2Rpdj4iLCBudWxscHRyKTsKICAgICB0 ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsK