34281 2010-01-28 12:50:18 -0800 fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot 2011-05-24 10:22:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 eric webkit-unassigned atwilson commit-queue kling levin luiz ossy qi.2.zhang yael oldest_to_newest 185582 0 eric 2010-01-28 12:50:18 -0800 fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot Judging by the failure diff, i suspect the test just has a race: http://build.webkit.org/results/Qt%20Linux%20Release/r53992%20(6638)/fast/workers/shared-worker-frame-lifecycle-diffs.txt --- /home/webkit/buildslave/qt-linux-release/build/layout-test-results/fast/workers/shared-worker-frame-lifecycle-expected.txt 2010-01-28 01:25:03.000000000 -0800 +++ /home/webkit/buildslave/qt-linux-release/build/layout-test-results/fast/workers/shared-worker-frame-lifecycle-actual.txt 2010-01-28 01:25:03.000000000 -0800 @@ -1,12 +1,3 @@ -This test checks whether shared workers exit when the parent document closes - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS Frame1 closed, shared workers kept running -PASS Frame2 closed, shared worker2 exited -PASS Frame3 closed, shared worker3 exited -PASS Frame4 closed, all workers closed - -TEST COMPLETE +CONSOLE MESSAGE: line 19: TypeError: Result of expression 'document.getElementById("console")' [null] is not an object. +FAIL: Timed out waiting for notifyDone to be called Has been around 5 months: http://trac.webkit.org/browser/trunk/LayoutTests/fast/workers/shared-worker-frame-lifecycle.html 185604 1 atwilson 2010-01-28 14:15:21 -0800 I'm hard-pressed to understand how this happens - here's the body of the test: <head> <link rel="stylesheet" href="../js/resources/js-test-style.css"> <script src="../js/resources/js-test-pre.js"></script> </head> <body> <p id="description"></p> <div id="console"></div> <script src="resources/shared-worker-create-common.js"></script> <script src="resources/worker-util.js"></script> <script src="resources/shared-worker-lifecycle.js"></script> </body> The error is generated by line 19 of js-test-pre.js (the "debug()" method). Note that the "console" div is defined before any of the test code executes, so there's no way for debug() to get invoked before console is defined. If this keeps happening, we could move the loading of the js-test-pre.js script until after the console div is defined, but it shouldn't matter. 185674 2 eric 2010-01-28 18:08:30 -0800 I believe scripts execute as soon as they're loaded. So it's possible for js-test-pre.js to execute before <div id="console"> is hit. But looking at it, I don't see it using debug() anywhere in the global scope which could cause this error. 185680 3 atwilson 2010-01-28 18:19:41 -0800 Exactly. debug() has to get called, and I can't see how it would get called without actually running a test. 187708 4 ossy 2010-02-04 02:52:26 -0800 $WebKitTools/Scripts/run-webkit-tests fast/workers/shared-worker-frame-lifecycle.html --iterations 10000 --> always passed $WebKitTools/Scripts/run-webkit-tests fast/workers --iterations 100 --> failed 7 times, passed 93 times This strange bug might caused by another test, it can be a DRT sideeffect, but I can't reproduce it consistently yet. So I skipped it to make buildbot happy. ( http://trac.webkit.org/changeset/54338 ) 368285 5 ossy 2011-03-16 04:10:09 -0700 I skipped it again, because it still fails: http://trac.webkit.org/changeset/81226 100 runs, 14 fails 368289 6 ossy 2011-03-16 04:18:06 -0700 (In reply to comment #5) > I skipped it again, because it still fails: http://trac.webkit.org/changeset/81226 > > 100 runs, 14 fails pretty diff: http://build.webkit.org/results/Qt%20Linux%20Release/r81232%20%2829888%29/fast/workers/shared-worker-frame-lifecycle-pretty-diff.html 408788 7 qi.2.zhang 2011-05-24 05:58:27 -0700 It works for me on the r87070. I used "Tools/Scripts/run-webkit-tests fast/workers --iterations 100". Can we just unskip it? 408791 8 ossy 2011-05-24 06:00:57 -0700 (In reply to comment #7) > It works for me on the r87070. I used "Tools/Scripts/run-webkit-tests fast/workers --iterations 100". > > Can we just unskip it? Thanks for checking it. rs=me for unskipping it. We can skip it again if fail occurs again. :) 408804 9 94600 qi.2.zhang 2011-05-24 06:20:42 -0700 Created attachment 94600 patch Remove the test case from skip list. 408807 10 94600 kling 2011-05-24 06:22:26 -0700 Comment on attachment 94600 patch rs=me 408886 11 commit-queue 2011-05-24 08:43:16 -0700 The commit-queue encountered the following flaky tests while processing attachment 94600: animations/dynamic-stylesheet-loading.html bug 52669 (authors: cmarrin@apple.com and simon.fraser@apple.com) http/tests/websocket/tests/url-no-trailing-slash.html bug 60906 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 408888 12 94600 commit-queue 2011-05-24 08:45:02 -0700 Comment on attachment 94600 patch Clearing flags on attachment: 94600 Committed r87155: <http://trac.webkit.org/changeset/87155> 408889 13 commit-queue 2011-05-24 08:45:09 -0700 All reviewed patches have been landed. Closing bug. 408966 14 commit-queue 2011-05-24 10:22:57 -0700 The commit-queue encountered the following flaky tests while processing attachment 94600: java/lc3/JavaObject/JavaObjectToByte-006.html bug 60333 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 94600 2011-05-24 06:20:42 -0700 2011-05-24 08:45:02 -0700 patch 34281.patch text/plain 1203 qi.2.zhang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg3MTQ1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMjQgIFFpIFpoYW5nICA8cWkuMi56 aGFuZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBmYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1mcmFtZS1saWZlY3ljbGUu aHRtbCBmYWlsZWQgb24gUXQgQm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNDI4MQorCisgICAgICAgIFJlbW92ZSB0aGUgdGVzdCBjYXNlIGZyb20g c2tpcCBsaXN0LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMS0wNS0y MyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCShyZXZpc2lv biA4NzA3MCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHdvcmtpbmcgY29w eSkKQEAgLTQ3Niw5ICs0NzYsNiBAQCBmYXN0L2Zvcm1zL21lbnVsaXN0LXdpZHRoLWNoYW5nZS5o dG1sCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDE1MgogaHR0 cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvcmVsb2FkLWNyYXNoLmh0bWwKIAotIyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQyODEKLWZhc3Qvd29ya2Vycy9zaGFyZWQt d29ya2VyLWZyYW1lLWxpZmVjeWNsZS5odG1sCi0KICMgRmxha3kgVGVzdDogZmFzdC9ldmVudHMv dGFiaW5kZXgtZm9jdXMtYmx1ci1hbGwuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTIxMTUKIGZhc3QvZXZlbnRzL3RhYmluZGV4LWZvY3VzLWJsdXItYWxs Lmh0bWwK