34222 2010-01-27 12:01:27 -0800 http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot 2011-09-28 09:32:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 33292 1 eric tony abarth aroben ggaren mihaip ossy rniwa sam tony webkit.review.bot oldest_to_newest 185177 0 eric 2010-01-27 12:01:27 -0800 http/tests/navigation/anchor-basic.html timed out on Snow Leopard Release Bot http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r53938%20(4875)/results.html Been here for a long time: http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/navigation/anchor-basic.html 468779 1 rniwa 2011-09-16 13:34:10 -0700 See new diff: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r95284%20(33129)/http/tests/navigation/anchor-basic-pretty-diff.html This test fails every now and then on Snow Leopard bots. Note that this test is skipped on Leopard (see the bug 34222). 468783 2 eric 2011-09-16 13:37:45 -0700 Do we know what other test result its showing there? It seems like some other test might be polluting this one? 469455 3 rniwa 2011-09-19 09:43:17 -0700 (In reply to comment #2) > Do we know what other test result its showing there? It seems like some other test might be polluting this one? http/tests/multipart/stop-crash.html 469512 4 eric 2011-09-19 10:50:07 -0700 That test is even older. http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/multipart/stop-crash.html We obviously could disable one or both of these tests, but best would be to understand the interaction going on and fix the underlying bug in WebCore or DumpRenderTree. 474302 5 108918 tony 2011-09-27 15:38:25 -0700 Created attachment 108918 Patch 474367 6 108918 rniwa 2011-09-27 16:53:19 -0700 Comment on attachment 108918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108918&action=review > LayoutTests/ChangeLog:10 > + Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without > + it, the img onload handler doesn't always run. Also reduce the > + multipart timeout (should help to unblock other http requests). Could you re-format the comment so that it doesn't use double-space? Also it seems awkward for "it" to appear at the beginning of a line or "the" to appear at the end of a line. 474370 7 108935 tony 2011-09-27 16:56:21 -0700 Created attachment 108935 Patch for landing 474411 8 108935 webkit.review.bot 2011-09-27 18:01:06 -0700 Comment on attachment 108935 Patch for landing Clearing flags on attachment: 108935 Committed r96174: <http://trac.webkit.org/changeset/96174> 474412 9 webkit.review.bot 2011-09-27 18:01:11 -0700 All reviewed patches have been landed. Closing bug. 474542 10 ossy 2011-09-27 23:47:47 -0700 It make http/tests/multipart/stop-crash.html fail on the GTK and the Qt bots: --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/multipart/stop-crash-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/multipart/stop-crash-actual.txt @@ -1,6 +1,7 @@ +FAIL: Timed out waiting for notifyDone to be called Test for http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page. If WebKit does not assert or crash after the test, then it passed. -PASS + 474587 11 ossy 2011-09-28 01:06:33 -0700 It seems it is a bug somewhere in GTK and Qt port. New bug report filed: https://bugs.webkit.org/show_bug.cgi?id=68979 474771 12 tony 2011-09-28 09:32:15 -0700 http/tests/navigation/anchor-basic.html has passed every run after this patch landed. Looks like that was the problem. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fanchor-basic.html&group=%40ToT%20-%20webkit.org 108918 2011-09-27 15:38:25 -0700 2011-09-27 16:56:15 -0700 Patch bug-34222-20110927153704.patch text/plain 2763 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNjAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NDVjNjU3YTNiMmYxMzQzYzIwZjlm ODRhZWRmZjBhMTM4ZTM1Y2RjLi5kZWI5MTU5NjBkMGZjZmRhODE2MGMxNDE4NzUwMDI1NjcyNzE4 Y2I2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMjcgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL25hdmlnYXRpb24vYW5jaG9yLWJh c2ljLmh0bWwgaXMgZmxha3kgb24gU25vdyBMZW9wYXJkIFJlbGVhc2UgQm90CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB3YWl0VW50aWxEb25lL25v dGlmeURvbmUgdG8gZWxpbWluYXRlIGZsYWtpbmVzcyBvbiBtYWMuICBXaXRob3V0CisgICAgICAg IGl0LCB0aGUgaW1nIG9ubG9hZCBoYW5kbGVyIGRvZXNuJ3QgYWx3YXlzIHJ1bi4gIEFsc28gcmVk dWNlIHRoZQorICAgICAgICBtdWx0aXBhcnQgdGltZW91dCAoc2hvdWxkIGhlbHAgdG8gdW5ibG9j ayBvdGhlciBodHRwIHJlcXVlc3RzKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbXVsdGlwYXJ0 L3N0b3AtY3Jhc2gtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbXVsdGlwYXJ0 L3N0b3AtY3Jhc2guaHRtbDoKKwogMjAxMS0wOS0yNyAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhIG1lY2hhbmlzbSB0byB0ZXN0IGZvciB0aGUg Y29tcG9zaXRpbmcgdHJlZSBtdXRhdGVkIGR1cmluZyBwYWludGluZwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLWV4cGVjdGVkLnR4dApp bmRleCBkM2Q1ZjE5NDAxOTcxODAwNzRhODY4YWYxOWU3MjJhMGExOGZmYWJkLi5jYmIxZTI5NWYx MWEzNjQyMDVlYmVhYzlkMzBhYmViYzI3ZWY4NjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMywz ICszLDQgQEAgVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMzNjAgUkVHUkVTU0lPTjogQ3Jhc2ggY2xvc2luZwogSWYgV2ViS2l0IGRvZXMgbm90IGFzc2Vy dCBvciBjcmFzaCBhZnRlciB0aGUgdGVzdCwgdGhlbiBpdCBwYXNzZWQuCiAKIAorUEFTUwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1s IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5odG1sCmluZGV4 IDQwZDBlYzIwY2VhYjE2YTFlZjQ2NWU1NTZkOTUwYjA4ZjhlNjQ5ZmYuLjg3OTcxM2ZmOTA0YTZm M2JlYjMzNjFlZmJkNGUzYzI3YTFmNjEyZTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvbXVsdGlwYXJ0L3N0b3AtY3Jhc2guaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL211bHRpcGFydC9zdG9wLWNyYXNoLmh0bWwKQEAgLTEsMTIgKzEsMTcgQEAKIDxodG1sPgog PGhlYWQ+CiAgICAgPHNjcmlwdD4KLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgICAgICB9CiAKICAgICAgICAg ZnVuY3Rpb24gZmlyc3RQYXJ0TG9hZGVkKCkKICAgICAgICAgewogICAgICAgICAgICAgd2luZG93 LnN0b3AoKTsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIiku aW5uZXJIVE1MID0gIlBBU1MiOworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l KCk7CiAgICAgICAgIH0KICAgICA8L3NjcmlwdD4KIDwvaGVhZD4KQEAgLTE4LDYgKzIzLDcgQEAK ICAgICA8cD4KICAgICAgICAgSWYgV2ViS2l0IGRvZXMgbm90IGFzc2VydCBvciBjcmFzaCBhZnRl ciB0aGUgdGVzdCwgdGhlbiBpdCBwYXNzZWQuCiAgICAgPC9wPgotICAgIDxpbWcgd2lkdGg9MjQg aGVpZ2h0PTI0IHNyYz0icmVzb3VyY2VzL211bHRpcGFydC5waHA/aW50ZXJ2YWw9MCZpbWcxPTJ4 Mi1ncmVlbi5wbmcmaW1nMj0yeDItZ3JlZW4ucG5nJndhaXQ9MTAiIG9ubG9hZD0iZmlyc3RQYXJ0 TG9hZGVkKCkiPgorICAgIDxpbWcgd2lkdGg9MjQgaGVpZ2h0PTI0IHNyYz0icmVzb3VyY2VzL211 bHRpcGFydC5waHA/aW50ZXJ2YWw9MCZpbWcxPTJ4Mi1ncmVlbi5wbmcmaW1nMj0yeDItZ3JlZW4u cG5nJndhaXQ9MyIgb25sb2FkPSJmaXJzdFBhcnRMb2FkZWQoKSI+CisgICAgPHAgaWQ9InJlc3Vs dHMiPjwvcD4KIDwvYm9keT4KIDwvaHRtbD4K 108935 2011-09-27 16:56:21 -0700 2011-09-27 18:01:06 -0700 Patch for landing bug-34222-20110927165500.patch text/plain 2750 tony U3VidmVyc2lvbiBSZXZpc2lvbjogOTYxNjAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NDVjNjU3YTNiMmYxMzQzYzIwZjlm ODRhZWRmZjBhMTM4ZTM1Y2RjLi45NjY3MjkxZGJiMWIzZjJjNTY2NmE2MWU4NWY0YjNlOTMxOWYz NzFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMjcgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL25hdmlnYXRpb24vYW5jaG9yLWJh c2ljLmh0bWwgaXMgZmxha3kgb24gU25vdyBMZW9wYXJkIFJlbGVhc2UgQm90CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDIyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBBZGQgd2FpdFVudGlsRG9uZS9ub3Rp ZnlEb25lIHRvIGVsaW1pbmF0ZSBmbGFraW5lc3Mgb24gbWFjLiBXaXRob3V0IGl0LCB0aGUgaW1n IG9ubG9hZCBoYW5kbGVyCisgICAgICAgIGRvZXNuJ3QgYWx3YXlzIHJ1bi4gQWxzbyByZWR1Y2Ug dGhlIG11bHRpcGFydCB0aW1lb3V0IChzaG91bGQgaGVscCB0byB1bmJsb2NrIG90aGVyIGh0dHAg cmVxdWVzdHMpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC1l eHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0cy9tdWx0aXBhcnQvc3RvcC1jcmFzaC5o dG1sOgorCiAyMDExLTA5LTI3ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgQWRkIGEgbWVjaGFuaXNtIHRvIHRlc3QgZm9yIHRoZSBjb21wb3NpdGluZyB0 cmVlIG11dGF0ZWQgZHVyaW5nIHBhaW50aW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvbXVsdGlwYXJ0L3N0b3AtY3Jhc2gtZXhwZWN0ZWQudHh0CmluZGV4IGQzZDVmMTk0 MDE5NzE4MDA3NGE4NjhhZjE5ZTcyMmEwYTE4ZmZhYmQuLmNiYjFlMjk1ZjExYTM2NDIwNWViZWFj OWQzMGFiZWJjMjdlZjg2NzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbXVs dGlwYXJ0L3N0b3AtY3Jhc2gtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbXVsdGlwYXJ0L3N0b3AtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0zLDMgKzMsNCBAQCBUZXN0 IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2MCBSRUdSRVNT SU9OOiBDcmFzaCBjbG9zaW5nCiBJZiBXZWJLaXQgZG9lcyBub3QgYXNzZXJ0IG9yIGNyYXNoIGFm dGVyIHRoZSB0ZXN0LCB0aGVuIGl0IHBhc3NlZC4KIAogCitQQVNTCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL211bHRpcGFydC9zdG9wLWNyYXNoLmh0bWwKaW5kZXggNDBkMGVjMjBjZWFi MTZhMWVmNDY1ZTU1NmQ5NTBiMDhmOGU2NDlmZi4uODc5NzEzZmY5MDRhNmYzYmViMzM2MWVmYmQ0 ZTNjMjdhMWY2MTJlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBh cnQvc3RvcC1jcmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbXVsdGlwYXJ0 L3N0b3AtY3Jhc2guaHRtbApAQCAtMSwxMiArMSwxNyBAQAogPGh0bWw+CiA8aGVhZD4KICAgICA8 c2NyaXB0PgotICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAg ICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBmaXJz dFBhcnRMb2FkZWQoKQogICAgICAgICB7CiAgICAgICAgICAgICB3aW5kb3cuc3RvcCgpOworICAg ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdHMiKS5pbm5lckhUTUwgPSAi UEFTUyI7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICAgICAg fQogICAgIDwvc2NyaXB0PgogPC9oZWFkPgpAQCAtMTgsNiArMjMsNyBAQAogICAgIDxwPgogICAg ICAgICBJZiBXZWJLaXQgZG9lcyBub3QgYXNzZXJ0IG9yIGNyYXNoIGFmdGVyIHRoZSB0ZXN0LCB0 aGVuIGl0IHBhc3NlZC4KICAgICA8L3A+Ci0gICAgPGltZyB3aWR0aD0yNCBoZWlnaHQ9MjQgc3Jj PSJyZXNvdXJjZXMvbXVsdGlwYXJ0LnBocD9pbnRlcnZhbD0wJmltZzE9MngyLWdyZWVuLnBuZyZp bWcyPTJ4Mi1ncmVlbi5wbmcmd2FpdD0xMCIgb25sb2FkPSJmaXJzdFBhcnRMb2FkZWQoKSI+Cisg ICAgPGltZyB3aWR0aD0yNCBoZWlnaHQ9MjQgc3JjPSJyZXNvdXJjZXMvbXVsdGlwYXJ0LnBocD9p bnRlcnZhbD0wJmltZzE9MngyLWdyZWVuLnBuZyZpbWcyPTJ4Mi1ncmVlbi5wbmcmd2FpdD0zIiBv bmxvYWQ9ImZpcnN0UGFydExvYWRlZCgpIj4KKyAgICA8cCBpZD0icmVzdWx0cyI+PC9wPgogPC9i b2R5PgogPC9odG1sPgo=