34059 2010-01-24 11:40:43 -0800 Content with heavily nested residual style is so slow, it seems like a hang 2010-01-24 20:11:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned ap dglazkov eric gustavo webkit.review.bot xan.lopez oldest_to_newest 184089 0 mjs 2010-01-24 11:40:43 -0800 Content with heavily nested residual style is so slow, it seems like a hang 184090 1 47298 mjs 2010-01-24 11:47:53 -0800 Created attachment 47298 Patch 184091 2 mjs 2010-01-24 11:51:59 -0800 I wasn't sure whether to provide a test case for this. The only test case I can think of would be annoyingly slow when it passes, and an outright hang when it fails. This means it would probably be on the edge of timing out on the bots, which is not so great. 184092 3 eric 2010-01-24 11:52:58 -0800 Attachment 47298 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/208763 184093 4 webkit.review.bot 2010-01-24 11:59:50 -0800 Attachment 47298 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/208767 184095 5 47298 mitz 2010-01-24 12:28:03 -0800 Comment on attachment 47298 Patch > + while (!finished && (iterationCount++ < cResidualStyleIterationLimititerationLimit)) { Typo: cResidualStyleIterationLimititerationLimit and redundant parentheses, but otherwise r=me 184096 6 webkit.review.bot 2010-01-24 12:28:19 -0800 Attachment 47298 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/209685 184097 7 47298 ap 2010-01-24 12:31:53 -0800 Comment on attachment 47298 Patch > + Limit the number of iterations of the main loop to 5. <...> > + while (!finished && (iterationCount++ < cResidualStyleIterationLimititerationLimit)) { I think this actually limits the count to 6, not 5. It would be nice to attach a test case to this Bugzilla bug, so that people could verify that it didn't regress - if it's not possible to make an automated test, of course. 184098 8 webkit.review.bot 2010-01-24 12:32:24 -0800 Attachment 47298 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/208787 184126 9 mjs 2010-01-24 18:08:04 -0800 (In reply to comment #7) > (From update of attachment 47298 [details]) > > + Limit the number of iterations of the main loop to 5. > <...> > > + while (!finished && (iterationCount++ < cResidualStyleIterationLimititerationLimit)) { > > I think this actually limits the count to 6, not 5. I think it's 5. The value being compared on iterations through the loop will be: 0 1 2 3 4 5 ==> this breaks out of the loop before it executes. > > It would be nice to attach a test case to this Bugzilla bug, so that people > could verify that it didn't regress - if it's not possible to make an automated > test, of course. I'll see if I can make an automated test that hangs on release but reliably runs fast in debug. Regards, Maciej 184129 10 ap 2010-01-24 18:32:46 -0800 D'oh! 184144 11 mjs 2010-01-24 20:11:54 -0800 Committed r53790: <http://trac.webkit.org/changeset/53790> 47298 2010-01-24 11:47:53 -0800 2010-01-24 12:31:53 -0800 Patch bug-34059-20100124114752.patch text/plain 2353 mjs SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Mzc4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMDEtMjQgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD b250ZW50IHdpdGggaGVhdmlseSBuZXN0ZWQgcmVzaWR1YWwgc3R5bGUgaXMgc28gc2xvdywgaXQg c2VlbXMgbGlrZSBhIGhhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM0MDU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjkyOTA2PgorICAgICAg ICAKKyAgICAgICAgKiBodG1sL0hUTUxQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFBhcnNlcjo6aGFuZGxlUmVzaWR1YWxTdHlsZUNsb3NlVGFnQWNyb3NzQmxvY2tzKToKKyAgICAg ICAgTGltaXQgdGhlIG51bWJlciBvZiBpdGVyYXRpb25zIG9mIHRoZSBtYWluIGxvb3AgdG8gNS4K KyAgICAgICAgCisgICAgICAgIFRoZSByZWFzb24gdGhpcyBsaW1pdCBpcyBuZWNlc3NhcnkgaXMg dGhhdCBvdGhlcndpc2UsIE4gbWlzbmVzdGVkIG9wZW4gdGFncyBmb2xsb3dlZAorICAgICAgICBi eSBOIG1pc25lc3RlZCBjbG9zZSB0YWdzIHdpbGwgY2F1c2UgTyhOXjIpIG9mIHdvcmsgZHVlIHRv IGNsb25pbmcgYW5kIGF0dGFjaGluZyBzdWJ0cmVlczsKKyAgICAgICAgYXQgYSBmaXhlZCBsaW1p dCwgdGhlIGNvc3QgaXMgYXQgd29yc3QgTyhOKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBjb2Rl IHRoYXQgd2FzIGluIHRoZSBsb29wIG9yaWdpbmFsbHkgcmFuIGV4YWN0bHkgb25jZSAtIHRoZSBs b29wIHdhcyBhZGRlZCBpbgorICAgICAgICByMjE0NzIgdG8gZml4IDxodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MDM+LiBJIGhhdmUgdmVyaWZpZWQgdGhhdAorICAg ICAgICB3aXRoIHRoZSBpdGVyYXRpb24gbGltaXQsIHRoZSBidWcgaXMgc3RpbGwgZml4ZWQsIGJv dGggd2l0aCB0aGUgb3JpZ2luYWwgdGVzdCBjYXNlCisgICAgICAgIGFuZCB3aXRoIHRoZSBsYXlv dXQgdGVzdHMgdGh0IHdlcmUgYWRkZWQuCisKIDIwMTAtMDEtMjQgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2Vy LgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvaHRtbC9IVE1MUGFyc2VyLmNwcAkocmV2aXNpb24gNTM3NzMpCisrKyBXZWJDb3JlL2h0bWwv SFRNTFBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDggQEAgdXNpbmcgbmFt ZXNwYWNlIEhUTUxOYW1lczsKIAogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNNYXhSZWR1bmRhbnRU YWdEZXB0aCA9IDIwOwogc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNSZXNpZHVhbFN0eWxlTWF4RGVw dGggPSAyMDA7CitzdGF0aWMgY29uc3QgdW5zaWduZWQgY1Jlc2lkdWFsU3R5bGVJdGVyYXRpb25M aW1pdCA9IDU7CisKIAogc3RhdGljIGNvbnN0IGludCBtaW5CbG9ja0xldmVsVGFnUHJpb3JpdHkg PSAzOwogCkBAIC0xMTI4LDggKzExMzAsMTAgQEAgdm9pZCBIVE1MUGFyc2VyOjpoYW5kbGVSZXNp ZHVhbFN0eWxlQ2xvcwogICAgIGJvb2wgZmluaXNoZWQgPSBmYWxzZTsKICAgICBib29sIHN0cmF5 VGFibGVDb250ZW50ID0gZWxlbS0+c3RyYXlUYWJsZUNvbnRlbnQ7CiAKKyAgICBpbnQgaXRlcmF0 aW9uQ291bnQgPSAwOworCiAgICAgbV9oYW5kbGluZ1Jlc2lkdWFsU3R5bGVBY3Jvc3NCbG9ja3Mg PSB0cnVlOwotICAgIHdoaWxlICghZmluaXNoZWQpIHsKKyAgICB3aGlsZSAoIWZpbmlzaGVkICYm IChpdGVyYXRpb25Db3VudCsrIDwgY1Jlc2lkdWFsU3R5bGVJdGVyYXRpb25MaW1pdGl0ZXJhdGlv bkxpbWl0KSkgewogICAgICAgICAvLyBGaW5kIHRoZSBvdXRlcm1vc3QgZWxlbWVudCB0aGF0IGNy b3NzZXMgb3ZlciB0byBhIGhpZ2hlciBsZXZlbC4gSWYgdGhlcmUgZXhpc3RzIGFub3RoZXIgaGln aGVyLWxldmVsCiAgICAgICAgIC8vIGVsZW1lbnQsIHdlIHdpbGwgZG8gYW5vdGhlciBwYXNzLCB1 bnRpbCB3ZSBoYXZlIGNvcnJlY3RlZCB0aGUgaW5uZXJtb3N0IG9uZS4KICAgICAgICAgRXhjZXB0 aW9uQ29kZSBlYyA9IDA7Cg==