<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33959</bug_id>
          
          <creation_ts>2010-01-21 10:45:56 -0800</creation_ts>
          <short_desc>Don&apos;t call vgGetError()/eglGetError() repeatedly</short_desc>
          <delta_ts>2010-01-21 20:44:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>33405</blocked>
    
    <blocked>33987</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Jakob Petsovits">jpetsovits</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>manyoso</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>183240</commentid>
    <comment_count>0</comment_count>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2010-01-21 10:45:56 -0800</bug_when>
    <thetext>Don&apos;t call vgGetError()/eglGetError() repeatedly</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183243</commentid>
    <comment_count>1</comment_count>
      <attachid>47130</attachid>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2010-01-21 10:48:16 -0800</bug_when>
    <thetext>Created attachment 47130
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183248</commentid>
    <comment_count>2</comment_count>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2010-01-21 10:58:23 -0800</bug_when>
    <thetext>While changing the VG/EGL error macros to something that reviewer Niko liked better, I introduced a bug in there. I thought I could be smart and get rid of the temporary variable that holds the error code, and tested it with eglGetError() on the OpenVG reference implementation to make sure it works.

Turns out that wasn&apos;t the best idea. On the one hand, vgGetError() turns out to be specified differently than eglGetError() so it must only be called once in any case. On the other hand, eglGetError() turns out to be so vaguely specified that implementations and even EGL patron Khronos interprets the spec inconsistently.

On a more positive note, if I hadn&apos;t introduced the bug in the first place, the SurfaceOpenVG pbuffer constructor (and the related EGLDisplayOpenVG::createPbufferSurface()) would have suffered from a subtle bug which is being taken care of in this patch as well.

Please read the commit message too, and review. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183273</commentid>
    <comment_count>3</comment_count>
      <attachid>47130</attachid>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2010-01-21 12:10:13 -0800</bug_when>
    <thetext>Comment on attachment 47130
Patch

As discussed on irc, r=me with the removal of unused &apos;ASSERT_VG_NO_ERROR_VALUE&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183290</commentid>
    <comment_count>4</comment_count>
    <who name="Jakob Petsovits">jpetsovits</who>
    <bug_when>2010-01-21 12:56:49 -0800</bug_when>
    <thetext>Committed r53639: &lt;http://trac.webkit.org/changeset/53639&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47130</attachid>
            <date>2010-01-21 10:48:16 -0800</date>
            <delta_ts>2010-01-21 12:10:12 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-33959-20100121134815.patch</filename>
            <type>text/plain</type>
            <size>9733</size>
            <attacher name="Jakob Petsovits">jpetsovits</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZGZjZTA0ZS4uMTEwOWE4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSw0MCBAQAorMjAxMC0wMS0yMSAgSmFrb2IgUGV0c292
aXRzICA8anBldHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIERvbid0IGNhbGwgdmdHZXRFcnJvcigpL2VnbEdldEVycm9yKCkg
cmVwZWF0ZWRseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MzM5NTkKKworICAgICAgICBGb3IgdmdHZXRFcnJvcigpLCBJIG1pc3NlZCB0aGUgcGFydCBv
ZiB0aGUgc3BlYyB3aGVyZQorICAgICAgICBpdCBzYXlzIHRoYXQgY2FsbGluZyB0aGF0IGZ1bmN0
aW9uIGNsZWFycyB0aGUgZXJyb3IKKyAgICAgICAgYW5kIHN1YnNlcXVlbnQgY2FsbHMgd2lsbCBy
ZXR1cm4gVkdfTk9fRVJST1IgYWdhaW4uCisKKyAgICAgICAgRm9yIGVnbEdldEVycm9yKCksIHRo
ZSBzcGVjaWZpY2F0aW9uIGRvZXNuJ3QgbWVudGlvbgorICAgICAgICB0aGF0IGtpbmQgb2YgYmVo
YXZpb3IsIGFuZCBpbnRlcnByZXRhdGlvbnMgc2VlbSB0bworICAgICAgICBkaWZmZXIgYmV0d2Vl
biBFR0wgaW1wbGVtZW50YXRpb25zIChldmVuIHdpdGhpbgorICAgICAgICBLaHJvbm9zOiB0aGUg
T3BlblZHIHJlZmVyZW5jZSBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0CisgICAgICAgIHJlc2V0IHRo
ZSBlcnJvciBjb2RlIC0gYW5kIGV2ZW4gbWVudGlvbnMgdGhlIGRpZmZlcmVuY2UKKyAgICAgICAg
dG8gdmdHZXRFcnJvcigpIGluIGEgY29tbWVudCAtIHdoZXJlYXMgdGhlIG9ubGluZQorICAgICAg
ICBPcGVuR0wgRVMgQVBJIGRvY3VtZW50IGV4cGxpY2l0bHkgc3BlY2lmaWVzIGNsZWFyaW5nCisg
ICAgICAgIHRoZSBlcnJvciBjb2RlKS4KKworICAgICAgICBJdCB0aHVzIG1ha2VzIHNlbnNlIG5v
dCB0byBjYWxsIGVpdGhlciBvZiB0aGUgdHdvCisgICAgICAgIGVycm9yIGZ1bmN0aW9ucyBtb3Jl
IHRoYW4gb25jZSBmb3IgY2hlY2tpbmcgYSBzaW5nbGUKKyAgICAgICAgRUdML09wZW5WRyBjYWxs
LiBUaGlzIHBhdGNoIGFkYXB0cyBhc3NlcnRpb25zIHRvCisgICAgICAgIGFjY29tbW9kYXRlIGZv
ciB0aGlzIGJlaGF2aW9yLCBhbmQgYWxzbyBuZWVkcyB0bworICAgICAgICBjaGFuZ2Ugc3VyZmFj
ZSBjcmVhdGlvbiBtZXRob2RzIGFzIHRoZXkgcHJldmlvdXNseQorICAgICAgICByZWxpZWQgb24g
bXVsdGlwbGUgY2FsbHMgb2YgZWdsR2V0RXJyb3IoKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy
YXBoaWNzL29wZW52Zy9FR0xEaXNwbGF5T3BlblZHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVH
TERpc3BsYXlPcGVuVkc6OnNoYXJlZFBsYXRmb3JtU3VyZmFjZSk6CisgICAgICAgIChXZWJDb3Jl
OjpFR0xEaXNwbGF5T3BlblZHOjpjcmVhdGVQYnVmZmVyU3VyZmFjZSk6CisgICAgICAgICogcGxh
dGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL0VHTERpc3BsYXlPcGVuVkcuaDoKKyAgICAgICAgKiBwbGF0
Zm9ybS9ncmFwaGljcy9vcGVudmcvRUdMVXRpbHMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw
aGljcy9vcGVudmcvU3VyZmFjZU9wZW5WRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdXJmYWNl
T3BlblZHOjpTdXJmYWNlT3BlblZHKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVu
dmcvU3VyZmFjZU9wZW5WRy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9W
R1V0aWxzLmg6CisKIDIwMTAtMDEtMTkgIEpha29iIFBldHNvdml0cyAgPGpwZXRzb3ZpdHNAcmlt
LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1n
aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9FR0xEaXNwbGF5T3BlblZHLmNw
cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL0VHTERpc3BsYXlPcGVuVkcuY3Bw
CmluZGV4IDU3NmRjNWIuLjNjN2VhZjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3Mvb3BlbnZnL0VHTERpc3BsYXlPcGVuVkcuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3Mvb3BlbnZnL0VHTERpc3BsYXlPcGVuVkcuY3BwCkBAIC0yMjIsNyArMjIyLDYgQEAg
U3VyZmFjZU9wZW5WRyogRUdMRGlzcGxheU9wZW5WRzo6c2hhcmVkUGxhdGZvcm1TdXJmYWNlKCkK
ICAgICAgICAgLy8gV2UnbGwganVzdCBtYWtlIHRoZSBzaGFyZWQgc3VyZmFjZSBhcyBzbWFsbCBh
cyBwb3NzaWJsZTogMXgxIHBpeGVsLgogICAgICAgICBFR0xDb25maWcgY29uZmlnID0gZGVmYXVs
dFBidWZmZXJDb25maWcoKTsKICAgICAgICAgRUdMU3VyZmFjZSBzdXJmYWNlID0gY3JlYXRlUGJ1
ZmZlclN1cmZhY2UoSW50U2l6ZSgxLCAxKSwgY29uZmlnKTsKLSAgICAgICAgQVNTRVJUX0VHTF9O
T19FUlJPUigpOwogCiAgICAgICAgIEVHTENvbnRleHQgY29udGV4dCA9IGVnbENyZWF0ZUNvbnRl
eHQobV9kaXNwbGF5LCBjb25maWcsIEVHTF9OT19DT05URVhULCAwKTsKICAgICAgICAgQVNTRVJU
X0VHTF9OT19FUlJPUigpOwpAQCAtMjM3LDcgKzIzNiw3IEBAIFN1cmZhY2VPcGVuVkcqIEVHTERp
c3BsYXlPcGVuVkc6OnNoYXJlZFBsYXRmb3JtU3VyZmFjZSgpCiAgICAgcmV0dXJuIG1fc2hhcmVk
UGxhdGZvcm1TdXJmYWNlOwogfQogCi1FR0xTdXJmYWNlIEVHTERpc3BsYXlPcGVuVkc6OmNyZWF0
ZVBidWZmZXJTdXJmYWNlKGNvbnN0IEludFNpemUmIHNpemUsIGNvbnN0IEVHTENvbmZpZyYgY29u
ZmlnKQorRUdMU3VyZmFjZSBFR0xEaXNwbGF5T3BlblZHOjpjcmVhdGVQYnVmZmVyU3VyZmFjZShj
b25zdCBJbnRTaXplJiBzaXplLCBjb25zdCBFR0xDb25maWcmIGNvbmZpZywgRUdMaW50KiBlcnJv
ckNvZGUpCiB7CiAgICAgY29uc3QgRUdMaW50IGF0dHJpYkxpc3RbXSA9IHsKICAgICAgICAgRUdM
X1dJRFRILCBzaXplLndpZHRoKCksCkBAIC0yNDUsNyArMjQ0LDEzIEBAIEVHTFN1cmZhY2UgRUdM
RGlzcGxheU9wZW5WRzo6Y3JlYXRlUGJ1ZmZlclN1cmZhY2UoY29uc3QgSW50U2l6ZSYgc2l6ZSwg
Y29uc3QgRUdMCiAgICAgICAgIEVHTF9OT05FCiAgICAgfTsKICAgICBFR0xTdXJmYWNlIHN1cmZh
Y2UgPSBlZ2xDcmVhdGVQYnVmZmVyU3VyZmFjZShtX2Rpc3BsYXksIGNvbmZpZywgYXR0cmliTGlz
dCk7Ci0gICAgaWYgKGVnbEdldEVycm9yKCkgIT0gRUdMX1NVQ0NFU1MpCisKKyAgICBpZiAoZXJy
b3JDb2RlKQorICAgICAgICAqZXJyb3JDb2RlID0gZWdsR2V0RXJyb3IoKTsKKyAgICBlbHNlCisg
ICAgICAgIEFTU0VSVF9FR0xfTk9fRVJST1IoKTsKKworICAgIGlmIChzdXJmYWNlID09IEVHTF9O
T19TVVJGQUNFKQogICAgICAgICByZXR1cm4gRUdMX05PX1NVUkZBQ0U7CiAKICAgICBFR0xpbnQg
c3VyZmFjZUNvbmZpZ0lkOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v
cGVudmcvRUdMRGlzcGxheU9wZW5WRy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu
dmcvRUdMRGlzcGxheU9wZW5WRy5oCmluZGV4IDVkMzY3YzUuLmZkODM1M2QgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL0VHTERpc3BsYXlPcGVuVkcuaAorKysg
Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9FR0xEaXNwbGF5T3BlblZHLmgKQEAg
LTQ3LDggKzQ3LDEwIEBAIHB1YmxpYzoKIAogICAgIC8qKiBDcmVhdGVzIGEgcGJ1ZmZlciBzdXJm
YWNlIHVzaW5nIHRoZSBnaXZlbiBjb25maWcuIElmIG5vIHN1cmZhY2UKICAgICAgKiBjb3VsZCBi
ZSBjcmVhdGVkLCBFR0xfTk9fU1VSRkFDRSBpcyByZXR1cm5lZCBhbmQgZXJyb3JzIGNhbiBiZQot
ICAgICAqIGNhdWdodCB3aXRoIGVnbEdldEVycm9yKCkgKHJlc3BlY3RpdmVseSBBU1NFUlRfRUdM
X05PX0VSUk9SKCkpLiAqLwotICAgIEVHTFN1cmZhY2UgY3JlYXRlUGJ1ZmZlclN1cmZhY2UoY29u
c3QgSW50U2l6ZSYsIGNvbnN0IEVHTENvbmZpZyYpOworICAgICAqIGNoZWNrZWQgd2l0aCB0aGUg
dmFsdWUgdGhhdCBpcyB3cml0dGVuIHRvIHRoZSBlcnJvckNvZGUgcGFyYW1ldGVyCisgICAgICog
SWYgbm8gc3VyZmFjZSBjb3VsZCBiZSBjcmVhdGVkIGFuZCBlcnJvckNvZGUgaXMgemVybywgdGhp
cyBtZXRob2QKKyAgICAgKiB3aWxsIHRyaWdnZXIgYW4gYXNzZXJ0aW9uIGJ5IGl0c2VsZi4gKi8K
KyAgICBFR0xTdXJmYWNlIGNyZWF0ZVBidWZmZXJTdXJmYWNlKGNvbnN0IEludFNpemUmLCBjb25z
dCBFR0xDb25maWcmLCBFR0xpbnQqIGVycm9yQ29kZSA9IDApOwogCiAgICAgRUdMU3VyZmFjZSBz
dXJmYWNlRm9yV2luZG93KEVHTE5hdGl2ZVdpbmRvd1R5cGUsIGNvbnN0IEVHTENvbmZpZyYpOwog
CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9FR0xVdGlscy5o
IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudmcvRUdMVXRpbHMuaAppbmRleCA4NGUz
MThlLi5jZTQ4OTkzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52
Zy9FR0xVdGlscy5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL0VHTFV0
aWxzLmgKQEAgLTYxLDkgKzYxLDE1IEBAIHN0YXRpYyBpbmxpbmUgY29uc3QgY2hhciogdG9FR0xF
cnJvckNvbnN0YW50KEVHTGludCBlcnJvcikKIAogI2lmIEFTU0VSVF9ESVNBQkxFRAogI2RlZmlu
ZSBBU1NFUlRfRUdMX05PX0VSUk9SKCkgKCh2b2lkKTApCisjZGVmaW5lIEFTU0VSVF9FR0xfTk9f
RVJST1JfVkFMVUUoZWdsRXJyb3JDb2RlKSAoKHZvaWQpMCkKICNlbHNlCiAjZGVmaW5lIEFTU0VS
VF9FR0xfTk9fRVJST1IoKSBcCi0gICAgQVNTRVJUX1dJVEhfTUVTU0FHRShlZ2xHZXRFcnJvcigp
ID09IFZHX05PX0VSUk9SLCAiRm91bmQgJXMiLCB0b0VHTEVycm9yQ29uc3RhbnQoZWdsR2V0RXJy
b3IoKSkpCisgICAgeyBcCisgICAgRUdMaW50IGVnbEVycm9yQ29kZSA9IGVnbEdldEVycm9yKCk7
IFwKKyAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKGVnbEVycm9yQ29kZSA9PSBFR0xfU1VDQ0VTUywg
IkZvdW5kICVzIiwgdG9FR0xFcnJvckNvbnN0YW50KGVnbEVycm9yQ29kZSkpOyBcCisgICAgfQor
I2RlZmluZSBBU1NFUlRfRUdMX05PX0VSUk9SX1ZBTFVFKGVnbEVycm9yQ29kZSkgXAorICAgIEFT
U0VSVF9XSVRIX01FU1NBR0UoZWdsRXJyb3JDb2RlID09IEVHTF9TVUNDRVNTLCAiRm91bmQgJXMi
LCB0b0VHTEVycm9yQ29uc3RhbnQoZWdsRXJyb3JDb2RlKSkKICNlbmRpZgogCiAjZW5kaWYKZGlm
ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL1N1cmZhY2VPcGVuVkcu
Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudmcvU3VyZmFjZU9wZW5WRy5jcHAK
aW5kZXggODhhOGY5MS4uZGNiMjcwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9vcGVudmcvU3VyZmFjZU9wZW5WRy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9vcGVudmcvU3VyZmFjZU9wZW5WRy5jcHAKQEAgLTQ0LDcgKzQ0LDcgQEAgU3VyZmFjZU9w
ZW5WRyogU3VyZmFjZU9wZW5WRzo6Y3VycmVudFN1cmZhY2UoKQogfQogCiAjaWYgUExBVEZPUk0o
RUdMKQotU3VyZmFjZU9wZW5WRzo6U3VyZmFjZU9wZW5WRyhjb25zdCBJbnRTaXplJiBzaXplLCBj
b25zdCBFR0xEaXNwbGF5JiBkaXNwbGF5LCBFR0xDb25maWcqIGNvbmZQdHIpCitTdXJmYWNlT3Bl
blZHOjpTdXJmYWNlT3BlblZHKGNvbnN0IEludFNpemUmIHNpemUsIGNvbnN0IEVHTERpc3BsYXkm
IGRpc3BsYXksIEVHTENvbmZpZyogY29uZlB0ciwgRUdMaW50KiBlcnJvckNvZGUpCiAgICAgOiBt
X2VnbERpc3BsYXkoZGlzcGxheSkKICAgICAsIG1fZWdsU3VyZmFjZShFR0xfTk9fU1VSRkFDRSkK
ICAgICAsIG1fZWdsQ29udGV4dChFR0xfTk9fQ09OVEVYVCkKQEAgLTUzLDcgKzUzLDcgQEAgU3Vy
ZmFjZU9wZW5WRzo6U3VyZmFjZU9wZW5WRyhjb25zdCBJbnRTaXplJiBzaXplLCBjb25zdCBFR0xE
aXNwbGF5JiBkaXNwbGF5LCBFR0wKIAogICAgIEVHTERpc3BsYXlPcGVuVkcqIGRpc3BsYXlNYW5h
Z2VyID0gRUdMRGlzcGxheU9wZW5WRzo6Zm9yRGlzcGxheShtX2VnbERpc3BsYXkpOwogICAgIEVH
TENvbmZpZyBjb25maWcgPSBjb25mUHRyID8gKCpjb25mUHRyKSA6IGRpc3BsYXlNYW5hZ2VyLT5k
ZWZhdWx0UGJ1ZmZlckNvbmZpZygpOwotICAgIG1fZWdsU3VyZmFjZSA9IGRpc3BsYXlNYW5hZ2Vy
LT5jcmVhdGVQYnVmZmVyU3VyZmFjZShzaXplLCBjb25maWcpOworICAgIG1fZWdsU3VyZmFjZSA9
IGRpc3BsYXlNYW5hZ2VyLT5jcmVhdGVQYnVmZmVyU3VyZmFjZShzaXplLCBjb25maWcsIGVycm9y
Q29kZSk7CiAKICAgICBpZiAobV9lZ2xTdXJmYWNlID09IEVHTF9OT19TVVJGQUNFKQogICAgICAg
ICByZXR1cm47CkBAIC03Miw5ICs3Miw3IEBAIFN1cmZhY2VPcGVuVkc6OlN1cmZhY2VPcGVuVkco
RUdMTmF0aXZlV2luZG93VHlwZSB3aW5kb3csIGNvbnN0IEVHTERpc3BsYXkmIGRpc3BsCiAgICAg
RUdMRGlzcGxheU9wZW5WRyogZGlzcGxheU1hbmFnZXIgPSBFR0xEaXNwbGF5T3BlblZHOjpmb3JE
aXNwbGF5KG1fZWdsRGlzcGxheSk7CiAgICAgRUdMQ29uZmlnIGNvbmZpZyA9IGNvbmZQdHIgPyAo
KmNvbmZQdHIpIDogZGlzcGxheU1hbmFnZXItPmRlZmF1bHRXaW5kb3dDb25maWcoKTsKICAgICBt
X2VnbFN1cmZhY2UgPSBkaXNwbGF5TWFuYWdlci0+c3VyZmFjZUZvcldpbmRvdyh3aW5kb3csIGNv
bmZpZyk7Ci0KLSAgICBpZiAobV9lZ2xTdXJmYWNlID09IEVHTF9OT19TVVJGQUNFKQotICAgICAg
ICByZXR1cm47CisgICAgQVNTRVJUKG1fZWdsU3VyZmFjZSAhPSBFR0xfTk9fU1VSRkFDRSk7CiAK
ICAgICBtX2VnbENvbnRleHQgPSBkaXNwbGF5TWFuYWdlci0+Y29udGV4dEZvclN1cmZhY2UobV9l
Z2xTdXJmYWNlKTsKICAgICBFR0xEaXNwbGF5T3BlblZHOjpyZWdpc3RlclBsYXRmb3JtU3VyZmFj
ZSh0aGlzKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL1N1
cmZhY2VPcGVuVkcuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL1N1cmZhY2VP
cGVuVkcuaAppbmRleCAzN2IxN2U3Li43NTFjMTQzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL29wZW52Zy9TdXJmYWNlT3BlblZHLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9vcGVudmcvU3VyZmFjZU9wZW5WRy5oCkBAIC01NCwyMSArNTQsMTcgQEAgcHVi
bGljOgogICAgICAqIHRoZSBnaXZlbiBkaXNwbGF5LiBJZiBjb25maWcgaXMgbm90IHNwZWNpZmll
ZCwgdGhlIGRpc3BsYXkncyBkZWZhdWx0CiAgICAgICogcGJ1ZmZlciBjb25maWcgaXMgdXNlZC4K
ICAgICAgKgotICAgICAqIEZvciByZWFzb25zIG9mIHJlY292ZXJhYmlsaXR5IChlLmcuIEltYWdl
QnVmZmVyJ3MgImJvb2wgc3VjY2VzcyIKLSAgICAgKiByZXR1cm4gdmFsdWUpLCB0aGlzIGNvbnN0
cnVjdG9yIHdvbid0IGFzc2VydCBpZiBjcmVhdGlvbiBvZiB0aGUgc3VyZmFjZQotICAgICAqIGZh
aWxzLiBNYWtlIHN1cmUgdG8gY2hlY2sgc3VjY2Vzc2Z1bCBzdXJmYWNlIGNyZWF0aW9uIHdpdGgg
ZWl0aGVyCi0gICAgICogQVNTRVJUX0VHTF9OT19FUlJPUigpIG9yIHRoZSBzdXJmYWNlJ3MgaXNW
YWxpZCgpIG1ldGhvZC4KKyAgICAgKiBUaGlzIGNvbnN0cnVjdG9yIHdpbGwgdHJpZ2dlciBhbiBh
c3NlcnRpb24gaWYgY3JlYXRpb24gb2YgdGhlIHN1cmZhY2UKKyAgICAgKiBmYWlscywgdW5sZXNz
IHlvdSBwbGVkZ2UgdG8gbWFudWFsbHkgcHJvY2VzcyB0aGUgZXJyb3IgY29kZSBieSBwYXNzaW5n
CisgICAgICogYSBub24temVybyBwb2ludGVyIGFzIGVycm9yQ29kZSBwYXJhbWV0ZXIuIFRoZSBl
cnJvciBjb2RlIHJldHVybmVkIGJ5CisgICAgICogZWdsR2V0RXJyb3IoKSB3aWxsIGJlIHdyaXR0
ZW4gdG8gdGhhdCB2YXJpYWJsZS4KICAgICAgKi8KLSAgICBTdXJmYWNlT3BlblZHKGNvbnN0IElu
dFNpemUmIHNpemUsIGNvbnN0IEVHTERpc3BsYXkmIGRpc3BsYXksIEVHTENvbmZpZyogY29uZmln
ID0gMCk7CisgICAgU3VyZmFjZU9wZW5WRyhjb25zdCBJbnRTaXplJiBzaXplLCBjb25zdCBFR0xE
aXNwbGF5JiBkaXNwbGF5LCBFR0xDb25maWcqIGNvbmZpZyA9IDAsIEVHTGludCogZXJyb3JDb2Rl
ID0gMCk7CiAKICAgICAvKioKICAgICAgKiBDcmVhdGUgYSBuZXcgRUdMIHdpbmRvdyBzdXJmYWNl
IHdpdGggdGhlIHNwZWNpZmllZCBuYXRpdmUgd2luZG93IGhhbmRsZQogICAgICAqIGFuZCBjb25m
aWcgb24gdGhlIGdpdmVuIGRpc3BsYXkuIElmIGNvbmZpZyBpcyBub3Qgc3BlY2lmaWVkLCB0aGUK
ICAgICAgKiBkaXNwbGF5J3MgZGVmYXVsdCB3aW5kb3cgY29uZmlnIGlzIHVzZWQuCi0gICAgICoK
LSAgICAgKiBGb3IgcmVhc29ucyBvZiByZWNvdmVyYWJpbGl0eSwgdGhpcyBjb25zdHJ1Y3RvciB3
b24ndCBhc3NlcnQgaWYgY3JlYXRpb24KLSAgICAgKiBvZiB0aGUgc3VyZmFjZSBmYWlscy4gTWFr
ZSBzdXJlIHRvIGNoZWNrIHN1Y2Nlc3NmdWwgc3VyZmFjZSBjcmVhdGlvbgotICAgICAqIHdpdGgg
ZWl0aGVyIEFTU0VSVF9FR0xfTk9fRVJST1IoKSBvciB0aGUgc3VyZmFjZSdzIGlzVmFsaWQoKSBt
ZXRob2QuCiAgICAgICovCiAgICAgU3VyZmFjZU9wZW5WRyhFR0xOYXRpdmVXaW5kb3dUeXBlIHdp
bmRvdywgY29uc3QgRUdMRGlzcGxheSYgZGlzcGxheSwgRUdMQ29uZmlnKiBjb25maWcgPSAwKTsK
IApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudmcvVkdVdGlscy5o
IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudmcvVkdVdGlscy5oCmluZGV4IGYwOGUw
NmUuLmY4YjcxY2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZn
L1ZHVXRpbHMuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9WR1V0aWxz
LmgKQEAgLTQ5LDkgKzQ5LDE1IEBAIHN0YXRpYyBpbmxpbmUgY29uc3QgY2hhciogdG9WR0Vycm9y
Q29uc3RhbnQoVkdFcnJvckNvZGUgZXJyb3IpCiAKICNpZiBBU1NFUlRfRElTQUJMRUQKICNkZWZp
bmUgQVNTRVJUX1ZHX05PX0VSUk9SKCkgKCh2b2lkKTApCisjZGVmaW5lIEFTU0VSVF9WR19OT19F
UlJPUl9WQUxVRSh2Z0Vycm9yQ29kZSkgKCh2b2lkKTApCiAjZWxzZQogI2RlZmluZSBBU1NFUlRf
VkdfTk9fRVJST1IoKSBcCi0gICAgQVNTRVJUX1dJVEhfTUVTU0FHRSh2Z0dldEVycm9yKCkgPT0g
VkdfTk9fRVJST1IsICJGb3VuZCAlcyIsIHRvVkdFcnJvckNvbnN0YW50KHZnR2V0RXJyb3IoKSkp
CisgICAgeyBcCisgICAgVkdFcnJvckNvZGUgdmdFcnJvckNvZGUgPSB2Z0dldEVycm9yKCk7IFwK
KyAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKHZnRXJyb3JDb2RlID09IFZHX05PX0VSUk9SLCAiRm91
bmQgJXMiLCB0b1ZHRXJyb3JDb25zdGFudCh2Z0Vycm9yQ29kZSkpOyBcCisgICAgfQorI2RlZmlu
ZSBBU1NFUlRfVkdfTk9fRVJST1JfVkFMVUUodmdFcnJvckNvZGUpIFwKKyAgICBBU1NFUlRfV0lU
SF9NRVNTQUdFKHZnRXJyb3JDb2RlID09IFZHX05PX0VSUk9SLCAiRm91bmQgJXMiLCB0b1ZHRXJy
b3JDb25zdGFudCh2Z0Vycm9yQ29kZSkpCiAjZW5kaWYKIAogI2VuZGlmCg==
</data>
<flag name="review"
          id="29523"
          type_id="1"
          status="+"
          setter="manyoso"
    />
          </attachment>
      

    </bug>

</bugzilla>