33894 2010-01-20 04:18:54 -0800 Touch Events are not sent to iframes 2010-01-20 20:23:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32485 1 benm benm android-webkit-unforking commit-queue hausmann oldest_to_newest 182739 0 benm 2010-01-20 04:18:54 -0800 Touch events dispatched from the platform layer are sent to the main frame's event handler. However if the main frame does not use touch events but an embedded iframe does, the event is not propagated to the iframe. This is because we bail out early in EventHandler::handleTouchEvent if the frame's document has not registered for touch events. As it is the document inside the iframe and not the document on the main frame that has registered for the events, we bail out. We should instead check if the document that the target element belongs to has registered for touch events after the hit detection has taken place, as the hit detection descends into iframes. Patch and test case to follow. 182760 1 47014 benm 2010-01-20 06:01:33 -0800 Created attachment 47014 Proposed patch and test case. 183055 2 47014 commit-queue 2010-01-20 20:23:17 -0800 Comment on attachment 47014 Proposed patch and test case. Clearing flags on attachment: 47014 Committed r53597: <http://trac.webkit.org/changeset/53597> 183056 3 commit-queue 2010-01-20 20:23:22 -0800 All reviewed patches have been landed. Closing bug. 47014 2010-01-20 06:01:33 -0800 2010-01-20 20:23:17 -0800 Proposed patch and test case. 33894.txt text/plain 5741 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMjAgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvdWNo IEV2ZW50cyBhcmUgbm90IHNlbnQgdG8gaWZyYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4OTQKKworICAgICAgICBGaXggdGhlIHRvdWNoIGV2 ZW50IGhhbmRsZXIgc28gaXQgZG9lcyBub3QgYmFpbCBvdXQgZWFybHkgaWYgdGhlIG1haW4gZnJh bWUgZG9jdW1lbnQgZG9lcyBub3QgaGF2ZSBhbnkgdG91Y2ggbGlzdGVuZXJzIHJlZ2lzdGVyZWQs IGFzIHRoZXJlIG1heSBiZSBlbWJlZGRlZCBpZnJhbWVzIHRoYXQgaGF2ZSByZWdpc3RlcmVkIGZv ciB0b3VjaCBldmVudHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gt aW5zaWRlLWlmcmFtZS5odG1sCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZVRvdWNoRXZlbnQpOiBJbnN0ZWFk IG9mIGxvb2tpbmcgYXQgdGhlIGRvY3VtZW50IG9mIHRoZSBtYWluIGZyYW1lIHRvIHNlZSBpZiB0 b3VjaCBldmVudCBsaXN0ZW5lcnMgYXJlIHJlZ2lzdGVyZWQsIGxvb2sgYXQgdGhlIGRvY3VtZW50 IG9mIHRoZSB0YXJnZXQgZWxlbWVudCB0byBhY2NvdW50IGZvciBpZnJhbWVzLgorCiAyMDEwLTAx LTIwICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiA1 MzUzNikKKysrIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNTM3LDEzICsyNTM3LDYgQEAgdm9pZCBFdmVudEhhbmRsZXI6OnVwZGF0ZUxhc3RTY3JvbGxi YXJVbgogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxl VG91Y2hFdmVudChjb25zdCBQbGF0Zm9ybVRvdWNoRXZlbnQmIGV2ZW50KQogewotICAgIERvY3Vt ZW50KiBkb2MgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwotICAgIGlmICghZG9jKQotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAoIWRvYy0+aGFzTGlzdGVuZXJUeXBlKERvY3VtZW50OjpU T1VDSF9MSVNURU5FUikpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIFJlZlB0cjxUb3Vj aExpc3Q+IHRvdWNoZXMgPSBUb3VjaExpc3Q6OmNyZWF0ZSgpOwogICAgIFJlZlB0cjxUb3VjaExp c3Q+IHByZXNzZWRUb3VjaGVzID0gVG91Y2hMaXN0OjpjcmVhdGUoKTsKICAgICBSZWZQdHI8VG91 Y2hMaXN0PiByZWxlYXNlZFRvdWNoZXMgPSBUb3VjaExpc3Q6OmNyZWF0ZSgpOwpAQCAtMjU2Myw2 ICsyNTU2LDEyIEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVUb3VjaEV2ZW50KGNvbnMKICAg ICAgICAgaWYgKHRhcmdldCAmJiB0YXJnZXQtPmlzVGV4dE5vZGUoKSkKICAgICAgICAgICAgIHRh cmdldCA9IHRhcmdldC0+cGFyZW50Tm9kZSgpOwogCisgICAgICAgIERvY3VtZW50KiBkb2MgPSB0 YXJnZXQtPmRvY3VtZW50KCk7CisgICAgICAgIGlmICghZG9jKQorICAgICAgICAgICAgY29udGlu dWU7CisgICAgICAgIGlmICghZG9jLT5oYXNMaXN0ZW5lclR5cGUoRG9jdW1lbnQ6OlRPVUNIX0xJ U1RFTkVSKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIGludCBhZGp1c3RlZFBh Z2VYID0gbHJvdW5kZihmcmFtZVBvaW50LngoKSAvIG1fZnJhbWUtPnBhZ2Vab29tRmFjdG9yKCkp OwogICAgICAgICBpbnQgYWRqdXN0ZWRQYWdlWSA9IGxyb3VuZGYoZnJhbWVQb2ludC55KCkgLyBt X2ZyYW1lLT5wYWdlWm9vbUZhY3RvcigpKTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTM1NDQpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAor MjAxMC0wMS0yMCAgQmVuIE11cmRvY2ggIDxiZW5tQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG91Y2ggRXZlbnRzIGFyZSBub3Qg c2VudCB0byBpZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMzg5NAorCisgICAgICAgIFRlc3RjYXNlIHRvIHZlcmlmeSB0aGF0IHRvdWNoIGV2 ZW50cyBhcmUgc2VudCB0byBpZnJhbWVzIHdoZW4gdGhlIG1haW4gZnJhbWUgZG9jdW1lbnQgZG9l cyBub3QgaGF2ZSBhbnkgdG91Y2ggZXZlbnQgbGlzdGVuZXJzIGluc3RhbGxlZC4KKworICAgICAg ICAqIGZhc3QvZXZlbnRzL3RvdWNoL3Jlc291cmNlczogQWRkZWQuCisgICAgICAgICogZmFzdC9l dmVudHMvdG91Y2gvcmVzb3VyY2VzL3RvdWNoLWluc2lkZS1pZnJhbWUyLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWluc2lkZS1pZnJhbWUtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC90b3VjaC1pbnNpZGUtaWZy YW1lLmh0bWw6IEFkZGVkLgorCiAyMDEwLTAxLTIwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBmYXN0L2ZyYW1lcy9zZXQtdW5sb2FkZWQtZnJh bWUtbG9jYXRpb24uaHRtbCB0aW1lZCBvdXQgb24gUXQgTGludXggUmVsZWFzZSBCdWlsZCBCb3QK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWluc2lkZS1pZnJhbWUt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNo L3RvdWNoLWluc2lkZS1pZnJhbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaW5zaWRlLWlmcmFtZS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGVzdCB0aGF0IHRvdWNoIGV2ZW50cyBhcmUg c2VudCB0byBpZnJhbWVzIHRoYXQgbGlzdGVuIGZvciB0aGVtIGV2ZW4gaWYgdGhlIHBhcmVudCBm cmFtZSBkb2VzIG5vdCBsaXN0ZW4gZm9yIHRoZW0uCisKK1BBU1MKKwoKUHJvcGVydHkgY2hhbmdl cyBvbjogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaW5zaWRlLWlmcmFtZS1l eHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvdG91Y2gtaW5zaWRlLWlmcmFtZS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWlu c2lkZS1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3RvdWNoL3RvdWNoLWluc2lkZS1pZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwz MSBAQAorPGh0bWw+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQoreworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CisK K2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpCisgICAg eworICAgICAgICBldmVudFNlbmRlci5hZGRUb3VjaFBvaW50KDUwLCAxNTApOworICAgICAgICBl dmVudFNlbmRlci50b3VjaFN0YXJ0KCk7CisgICAgfQorfQorCitmdW5jdGlvbiB0ZXN0Q29tcGxl dGUoKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJykuaW5uZXJUZXh0 ID0gJ1BBU1MnOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKzwv c2NyaXB0PgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCk7Ij4KKzxwPlRlc3QgdGhhdCB0b3VjaCBl dmVudHMgYXJlIHNlbnQgdG8gaWZyYW1lcyB0aGF0IGxpc3RlbiBmb3IgdGhlbSBldmVuIGlmIHRo ZSBwYXJlbnQgZnJhbWUgZG9lcyBub3QgbGlzdGVuIGZvciB0aGVtLjwvcD4KKzxkaXYgaWQ9ImNv bnNvbGUiPgorPHA+RkFJTCAtIG5vIHRvdWNoc3RhcnQgcmVjZWl2ZWQhPC9wPgorPC9kaXY+Cis8 aWZyYW1lIHNyYz0iLi9yZXNvdXJjZXMvdG91Y2gtaW5zaWRlLWlmcmFtZTIuaHRtbCIgLz4KKzwv Ym9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZXZl bnRzL3RvdWNoL3RvdWNoLWluc2lkZS1pZnJhbWUuaHRtbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjpl b2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3Vj aC9yZXNvdXJjZXMvdG91Y2gtaW5zaWRlLWlmcmFtZTIuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9yZXNvdXJjZXMvdG91Y2gtaW5zaWRlLWlmcmFtZTIu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNoL3Jlc291 cmNlcy90b3VjaC1pbnNpZGUtaWZyYW1lMi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDgg QEAKKzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSdteWRpdicgc3R5bGU9J3dpZHRoOjEwMHB4O2hl aWdodDoxMDBweDsnPjwvZGl2PgorPHNjcmlwdCB0eXBlPSd0ZXh0L2phdmFzY3JpcHQnPgorZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ215ZGl2JykuYWRkRXZlbnRMaXN0ZW5lcigndG91Y2hzdGFy dCcsIGZ1bmN0aW9uKCkgeyBwYXJlbnQudGVzdENvbXBsZXRlKCk7IH0sIGZhbHNlKTsKKzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvdG91Y2gvcmVzb3VyY2VzL3RvdWNoLWluc2lkZS1pZnJhbWUyLmh0bWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgo=