33873 2010-01-19 16:36:03 -0800 [qt] Make KURL to QUrl conversion faster 2010-01-28 03:54:44 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 34208 1 zecke webkit-unassigned oldest_to_newest 182502 0 zecke 2010-01-19 16:36:03 -0800 Reloading google.com/news with a full font cache (no more calls to font cache) spend about 1.8% of the time in KURL -> QUrl conversion. The two call sites are from the FrameLoaderClientQt asking for the userAgentForUrl and in the ResourceHandleQt.cpp converting the ResourceRequest to a QNetworkRequest and using the URL. 182514 1 46960 zecke 2010-01-19 16:43:14 -0800 Created attachment 46960 Use QString::toUtf8 instead of WebCore::TextCodec Adopt the WebCore::String in a QString and use the Qt QString::toUtf8 method instead of going through WebCore::TextCodec -> QTextCodec and copying the buffer around. 182526 2 zecke 2010-01-19 16:49:38 -0800 Another way to make the KURL to QUrl conversion faster is to avoid going to a QByteArray and using QUrl::fromEncoded all together. We would have to call setPath, setHost, setUser, setPassword and see if that is any faster. 183387 3 46960 eric 2010-01-21 16:52:25 -0800 Comment on attachment 46960 Use QString::toUtf8 instead of WebCore::TextCodec OK. 185416 4 zecke 2010-01-28 03:54:44 -0800 Landed in r53995. Thanks. 46960 2010-01-19 16:43:14 -0800 2010-01-21 16:52:25 -0800 Use QString::toUtf8 instead of WebCore::TextCodec 0002-Qt-Speed-up-KURL-to-QUrl-conversion.patch text/plain 2141 zecke RnJvbSBiOTE0ZjdlZDQ0YTA3NmU1ZWUyYTlkNmI1M2E3NDQ1YjZkNDFiYjU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IE1vbiwgMTggSmFuIDIwMTAgMTQ6MjY6MjUgKzAxMDAKU3ViamVjdDog W1BBVENIIDIvNF0gW1F0XSBTcGVlZCB1cCBLVVJMIHRvIFFVcmwgY29udmVyc2lvbgoKVGhlIFdl YkNvcmU6OlN0cmluZzo6dXRmOCBtZXRob2Qgd2lsbCB1c2UgdGhlIGdlbmVyaWMgV2ViQ29yZTo6 VGV4dENvZGVjCmFuZCB0aGVuIGNhbGwgdGhlIGVuY29kZSBtZXRob2Qgb24gaXQuIEluIFF0V2Vi S2l0IHRoaXMgY2xhc3MgaXMgaW1wbGVtZW50ZWQKYXJvdW5kIHRoZSBRVGV4dENvZGVjIGNsYXNz LiBJbnN0ZWFkIG9mIGdvaW5nIHRoZSBnZW5lcmljIGNvZGVjIHdheSB3ZSB0cmVhdAp0aGUgV2Vi Q29yZTo6U3RyaW5nIGFzIGEgUVN0cmluZyAobm8gY29weWluZykgYW5kIHRoZW4gdXNlIHRoZSBi dWlsdC1pbgpRU3RyaW5nOjp0b1V0ZjggdG8gZG8gdGhlIGNvbnZlcnNpb24uCi0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYkNvcmUv cGxhdGZvcm0vcXQvS1VSTFF0LmNwcCB8ICAgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMjhiODY5Li5mMDI5OTQ0IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEwLTAxLTE4ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZp c2gub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gU3BlZWQgdXAgS1VSTCB0byBRVXJsIGNvbnZlcnNpb24KKyAgICAgICAgCisgICAgICAg IFRoZSBXZWJDb3JlOjpTdHJpbmc6OnV0ZjggbWV0aG9kIHdpbGwgdXNlIHRoZSBnZW5lcmljIFdl YkNvcmU6OlRleHRDb2RlYworICAgICAgICBhbmQgdGhlbiBjYWxsIHRoZSBlbmNvZGUgbWV0aG9k IG9uIGl0LiBJbiBRdFdlYktpdCB0aGlzIGNsYXNzIGlzIGltcGxlbWVudGVkCisgICAgICAgIGFy b3VuZCB0aGUgUVRleHRDb2RlYyBjbGFzcy4gSW5zdGVhZCBvZiBnb2luZyB0aGUgZ2VuZXJpYyBj b2RlYyB3YXkgd2UgdHJlYXQKKyAgICAgICAgdGhlIFdlYkNvcmU6OlN0cmluZyBhcyBhIFFTdHJp bmcgKG5vIGNvcHlpbmcpIGFuZCB0aGVuIHVzZSB0aGUgYnVpbHQtaW4KKyAgICAgICAgUVN0cmlu Zzo6dG9VdGY4IHRvIGRvIHRoZSBjb252ZXJzaW9uLgorCisgICAgICAgICogcGxhdGZvcm0vcXQv S1VSTFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktVUkw6Om9wZXJhdG9yIFFVcmwpOgorCiAy MDEwLTAxLTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4gYW5kIEFkZWxlIFBldGVyc29uLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9x dC9LVVJMUXQuY3BwCmluZGV4IDFmNjIwMDYuLjNiYjNkYjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vcXQvS1VSTFF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5j cHAKQEAgLTg2LDcgKzg2LDggQEAgS1VSTDo6b3BlcmF0b3IgUVVybCgpIGNvbnN0CiAjZWxzZQog ICAgIC8vIFF0IDQuNSBvciBsYXRlcgogICAgIC8vIE5vIG5lZWQgZm9yIHNwZWNpYWwgZW5jb2Rp bmcKLSAgICBRQnl0ZUFycmF5IGJhID0gbV9zdHJpbmcudXRmOCgpLmRhdGEoKTsKKyAgICBRU3Ry aW5nIHN0ciA9IFFTdHJpbmc6OmZyb21SYXdEYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgUUNo YXIqPihtX3N0cmluZy5jaGFyYWN0ZXJzKCkpLCBtX3N0cmluZy5sZW5ndGgoKSk7CisgICAgUUJ5 dGVBcnJheSBiYSA9IHN0ci50b1V0ZjgoKTsKICNlbmRpZgogCiAgICAgUVVybCB1cmwgPSBRVXJs Ojpmcm9tRW5jb2RlZChiYSk7Ci0tIAoxLjYuMy4zCgo=