33866 2010-01-19 13:57:21 -0800 Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function 2010-01-24 19:53:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 27065 1 laszlo.gombos webkit-unassigned barraclough commit-queue eric ggaren oldest_to_newest 182441 0 laszlo.gombos 2010-01-19 13:57:21 -0800 Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION macro. This I think makes the code a bit more readable as it is clear that DEFINE_STUB_FUNCTION(int, op_eq) is needed regardless of the USE(JSVALUE32_64) test. This refactoring fixes a build break for the RVCT tool chain. For the RVCT toolchain (e.g. for Symbian) precompiler macros are not expanded before the code is passed to the assembler. This tool chain limitation and the corresponding workaround (simple perl script as pre-compiler) been documented as part of commit r52970. The current perl script does not take all the C precompiler macros into account, so it expands the DEFINE_STUB_FUNCTION macro twice for DEFINE_STUB_FUNCTION(int, op_eq). 182461 1 46953 laszlo.gombos 2010-01-19 14:31:23 -0800 Created attachment 46953 proposed build fix for RVCT 183391 2 eric 2010-01-21 16:53:20 -0800 Looks sane, but I'll CC the JIT people for a real review. 183552 3 46953 mjs 2010-01-22 02:02:36 -0800 Comment on attachment 46953 proposed build fix for RVCT r=me 184140 4 46953 commit-queue 2010-01-24 19:53:26 -0800 Comment on attachment 46953 proposed build fix for RVCT Clearing flags on attachment: 46953 Committed r53789: <http://trac.webkit.org/changeset/53789> 184141 5 commit-queue 2010-01-24 19:53:32 -0800 All reviewed patches have been landed. Closing bug. 46953 2010-01-19 14:31:23 -0800 2010-01-24 19:53:25 -0800 proposed build fix for RVCT 33866.patch text/plain 2628 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUzNDk1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTkgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yIEpJVFN0dWJzLmNwcCBzbyB0aGF0 IERFRklORV9TVFVCX0ZVTkNUSU9OIGlzIG9ubHkgdXNlZCBvbmNlIGZvciBlYWNoIGZ1bmN0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzg2Ngor CisgICAgICAgIFBsYWNlIHRoZSBndWFyZCBVU0UoSlNWQUxVRTMyXzY0KSBpbnNpZGUgdGhlIGJv ZHkgb2YgdGhlIERFRklORV9TVFVCX0ZVTkNUSU9OCisgICAgICAgIG1hY3JvIGZvciB0aG9zZSBm dW5jdGlvbnMgdGhhdCBhcmUgYWx3YXlzIHByZXNlbnQuCisKKyAgICAgICAgKiBqaXQvSklUU3R1 YnMuY3BwOgorICAgICAgICAoSlNDOjpERUZJTkVfU1RVQl9GVU5DVElPTik6CisKIDIwMTAtMDEt MTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBKSVQgd2l0aCBSVkNULgpJbmRleDogSmF2YVNjcmlw dENvcmUvaml0L0pJVFN0dWJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQv SklUU3R1YnMuY3BwCShyZXZpc2lvbiA1MzQ5NSkKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9KSVRT dHVicy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0MTksOCArMjQxOSw2IEBAIERFRklORV9TVFVC X0ZVTkNUSU9OKEVuY29kZWRKU1ZhbHVlLCBvcF8KICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KG51bWJlcik7CiB9CiAKLSNpZiBVU0UoSlNWQUxVRTMyXzY0KQotCiBERUZJTkVfU1RVQl9GVU5D VElPTihpbnQsIG9wX2VxKQogewogICAgIFNUVUJfSU5JVF9TVEFDS19GUkFNRShzdGFja0ZyYW1l KTsKQEAgLTI0MjgsNiArMjQyNiw3IEBAIERFRklORV9TVFVCX0ZVTkNUSU9OKGludCwgb3BfZXEp CiAgICAgSlNWYWx1ZSBzcmMxID0gc3RhY2tGcmFtZS5hcmdzWzBdLmpzVmFsdWUoKTsKICAgICBK U1ZhbHVlIHNyYzIgPSBzdGFja0ZyYW1lLmFyZ3NbMV0uanNWYWx1ZSgpOwogCisjaWYgVVNFKEpT VkFMVUUzMl82NCkKICAgICBzdGFydDoKICAgICBpZiAoc3JjMi5pc1VuZGVmaW5lZCgpKSB7CiAg ICAgICAgIHJldHVybiBzcmMxLmlzTnVsbCgpIHx8IApAQCAtMjUwOCw4ICsyNTA3LDE4IEBAIERF RklORV9TVFVCX0ZVTkNUSU9OKGludCwgb3BfZXEpCiAgICAgc3JjMSA9IGFzT2JqZWN0KGNlbGwx KS0+dG9QcmltaXRpdmUoc3RhY2tGcmFtZS5jYWxsRnJhbWUpOwogICAgIENIRUNLX0ZPUl9FWENF UFRJT04oKTsKICAgICBnb3RvIHN0YXJ0OworICAgIAorI2Vsc2UgLy8gVVNFKEpTVkFMVUUzMl82 NCkKKyAgICBDYWxsRnJhbWUqIGNhbGxGcmFtZSA9IHN0YWNrRnJhbWUuY2FsbEZyYW1lOworICAg IAorICAgIGJvb2wgcmVzdWx0ID0gSlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGluZShjYWxsRnJh bWUsIHNyYzEsIHNyYzIpOworICAgIENIRUNLX0ZPUl9FWENFUFRJT05fQVRfRU5EKCk7CisgICAg cmV0dXJuIHJlc3VsdDsKKyNlbmRpZiAvLyBVU0UoSlNWQUxVRTMyXzY0KQogfQogCisjaWYgVVNF KEpTVkFMVUUzMl82NCkKKwogREVGSU5FX1NUVUJfRlVOQ1RJT04oaW50LCBvcF9lcV9zdHJpbmdz KQogewogICAgIFNUVUJfSU5JVF9TVEFDS19GUkFNRShzdGFja0ZyYW1lKTsKQEAgLTI1MjIsMjMg KzI1MzEsNyBAQCBERUZJTkVfU1RVQl9GVU5DVElPTihpbnQsIG9wX2VxX3N0cmluZ3MpCiAgICAg cmV0dXJuIHN0cmluZzEtPnZhbHVlKHN0YWNrRnJhbWUuY2FsbEZyYW1lKSA9PSBzdHJpbmcyLT52 YWx1ZShzdGFja0ZyYW1lLmNhbGxGcmFtZSk7CiB9CiAKLSNlbHNlIC8vIFVTRShKU1ZBTFVFMzJf NjQpCi0KLURFRklORV9TVFVCX0ZVTkNUSU9OKGludCwgb3BfZXEpCi17Ci0gICAgU1RVQl9JTklU X1NUQUNLX0ZSQU1FKHN0YWNrRnJhbWUpOwotCi0gICAgSlNWYWx1ZSBzcmMxID0gc3RhY2tGcmFt ZS5hcmdzWzBdLmpzVmFsdWUoKTsKLSAgICBKU1ZhbHVlIHNyYzIgPSBzdGFja0ZyYW1lLmFyZ3Nb MV0uanNWYWx1ZSgpOwotCi0gICAgQ2FsbEZyYW1lKiBjYWxsRnJhbWUgPSBzdGFja0ZyYW1lLmNh bGxGcmFtZTsKLQotICAgIGJvb2wgcmVzdWx0ID0gSlNWYWx1ZTo6ZXF1YWxTbG93Q2FzZUlubGlu ZShjYWxsRnJhbWUsIHNyYzEsIHNyYzIpOwotICAgIENIRUNLX0ZPUl9FWENFUFRJT05fQVRfRU5E KCk7Ci0gICAgcmV0dXJuIHJlc3VsdDsKLX0KLQotI2VuZGlmIC8vIFVTRShKU1ZBTFVFMzJfNjQp CisjZW5kaWYKIAogREVGSU5FX1NUVUJfRlVOQ1RJT04oRW5jb2RlZEpTVmFsdWUsIG9wX2xzaGlm dCkKIHsK