33734 2010-01-15 13:45:49 -0800 check-webkit-style: Suppress the usual tab check for files having the allow-tabs property 2010-02-01 15:51:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 33227 1 cjerdonek webkit-unassigned abarth cjerdonek ddkilzer eric hamaji levin tkent oldest_to_newest 181367 0 cjerdonek 2010-01-15 13:45:49 -0800 This report is an outgrowth of the following report on excluding selected code/files/directories from certain style checks: https://bugs.webkit.org/show_bug.cgi?id=33684 More information on the allow-tabs property is in this e-mail: https://lists.webkit.org/pipermail/webkit-dev/2010-January/011331.html Question: It seems that git might not be able to "see" the allow-tabs property. See, for instance, the "Bugs" section of the man page for git-svn(1): > We ignore all SVN properties except svn:executable. Any unhandled properties are logged to $GIT_DIR/svn/<refname>/unhandled.log (from http://www.kernel.org/pub/software/scm/git/docs/git-svn.html ) Would implementing this enhancement mean that check-webkit-style will not yield correct results unless run from an SVN repository? 181528 1 cjerdonek 2010-01-16 10:56:02 -0800 Adding Kent to the CC since he added the tab check. 181540 2 ddkilzer 2010-01-16 11:56:39 -0800 (In reply to comment #0) > Would implementing this enhancement mean that check-webkit-style will not yield > correct results unless run from an SVN repository? You could always fall back to a server-side check when using a git repository, although it will be slower: $ svn pl http://svn.webkit.org/repository/webkit/trunk/WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl Properties on 'http://svn.webkit.org/repository/webkit/trunk/WebKitTools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl': allow-tabs