33685 2010-01-14 13:33:50 -0800 fast/dom/Window/timer-resume-on-navigation-back.html is flaky 2015-04-14 22:29:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 33292 1 eric ap beidson commit-queue dimich ojan oldest_to_newest 180894 0 eric 2010-01-14 13:33:50 -0800 fast/dom/Window/timer-resume-on-navigation-back.html failed on Snow Leopard Intel Leaks Bot (Debug) http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r53286%20(3434)/fast/dom/Window/timer-resume-on-navigation-back-diffs.txt --- layout-test-results/fast/dom/Window/timer-resume-on-navigation-back-expected.txt 2010-01-14 12:52:22.000000000 -0800 +++ layout-test-results/fast/dom/Window/timer-resume-on-navigation-back-actual.txt 2010-01-14 12:52:22.000000000 -0800 @@ -1,3 +1 @@ -This test verifies that when page is loaded from the page cache on navigation back, the suspended timers are resumed for a duration left when they were suspended. This is a test for https://bugs.webkit.org/show_bug.cgi?id=28683. -The test navigates to a page, starts a timer and then navigates to another page and back. It then measures time when the timer is actually fired and makes sure that it is at least the time set at the beginning. If successful, it outputs 'PASS' below. -PASS + Looks like your classic flakey test. :) Uses setTimeout. don't we already have a back-forward controller? Isn't there some other event we can use to detect if we've gone back-forward yet? If we haven't, can't we re-schedule another timer and not dump yet? 180896 1 eric 2010-01-14 13:36:01 -0800 My comments above seem unclear. What I meant to propose: 1. We continue scheduling a timeout of 100ms. 2. We sign up for some event to detect that we've actively gone backwards. 3. Until we get that event, if our timeout fires, we just keep rescheduling it. 4. Once we've gotten that event and our timeout has fired, then we dump. Maybe someone has a better proposal for how to de-flake this test? 1085395 2 ap 2015-04-14 20:40:10 -0700 Eric analysis is correct (I wish that I searched Bugzilla before I rediscovered the same). 1085396 3 250776 ap 2015-04-14 20:45:32 -0700 Created attachment 250776 proposed fix 1085410 4 250776 beidson 2015-04-14 21:41:58 -0700 Comment on attachment 250776 proposed fix To be fair, when eric made his analysis, I don't think pageshow/hide existed yet. :) 1085411 5 beidson 2015-04-14 21:42:34 -0700 (NM, in 2010 they probably did...?) Anyways, nice change. 1085414 6 250776 commit-queue 2015-04-14 22:29:30 -0700 Comment on attachment 250776 proposed fix Clearing flags on attachment: 250776 Committed r182838: <http://trac.webkit.org/changeset/182838> 1085415 7 commit-queue 2015-04-14 22:29:33 -0700 All reviewed patches have been landed. Closing bug. 250776 2015-04-14 20:45:32 -0700 2015-04-14 22:29:30 -0700 proposed fix timer-resume-on-navigation-back.txt text/plain 1959 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4MjgzMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTE0ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvZG9tL1dpbmRvdy90aW1lci1yZXN1 bWUtb24tbmF2aWdhdGlvbi1iYWNrLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIHRpbWVyIGZpcmVkIGJlZm9yZSBuYXZp Z2F0aW9uLCB0aGUgdGVzdCBwYXNzZWQgd2l0aG91dCBnb2luZyBkb3duIHRoZSBjb2RlCisgICAg ICAgIHBhdGggdGhhdCBpdCB3YXMgc3VwcG9zZWQgdG8gdGVzdC4gSWYgaXQgZmlyZWQgd2hlbiBu YXZpZ2F0aW9uIHdhcyBpbiBwcm92aXNpb25hbAorICAgICAgICBzdGF0ZSwgdGhlbiBkdW1waW5n IHJlc3VsdHMgd2FzIGRlbGF5ZWQgdW50aWwgdGhlIG5hdmlnYXRpb24gd2FzIGZpbmlzaGVkLCBh bmQKKyAgICAgICAgdGh1cyB0aGUgaW50ZXJtZWRpYXRlIHBhZ2UgZ290IGR1bXBlZCwgYW5kIHRo ZSB0ZXN0IGZhaWxlZC4KKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy90aW1lci1yZXN1bWUt b24tbmF2aWdhdGlvbi1iYWNrLmh0bWw6CisKIDIwMTUtMDQtMTQgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSB0ZXN0IExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2RyYWctbGluay5odG1sIHRvIGRyYWctYW5kLWRyb3AtbGluay1pbnRvLWZvY3VzZWQt Y29udGVudGVkaXRhYmxlLmh0bWwKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy90 aW1lci1yZXN1bWUtb24tbmF2aWdhdGlvbi1iYWNrLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVyLXJlc3VtZS1vbi1uYXZpZ2F0aW9uLWJhY2suaHRt bAkocmV2aXNpb24gMTgyNzczKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3RpbWVy LXJlc3VtZS1vbi1uYXZpZ2F0aW9uLWJhY2suaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMiw4ICsy LDIwIEBACiA8c2NyaXB0PgogdmFyIHRpbWVvdXRWYWx1ZSA9IDEwMDsgLy9tcwogCit2YXIgcmVz dG9yZWRGcm9tUGFnZUNhY2hlID0gZmFsc2U7CitvbnBhZ2VzaG93ID0gZnVuY3Rpb24oZXZlbnQp IHsKKyAgICBpZiAoZXZlbnQucGVyc2lzdGVkKQorICAgICAgICByZXN0b3JlZEZyb21QYWdlQ2Fj aGUgPSB0cnVlOworfQorCiB2YXIgdGltZXN0YW1wOwogZnVuY3Rpb24gdmVyaWZ5KCkgeworICAg IGlmICghcmVzdG9yZWRGcm9tUGFnZUNhY2hlKSB7CisgICAgICAvLyBUaGUgdGltZXIgZmlyZWQg dG9vIGVhcmx5LCB3ZSBoYXZlbid0IG5hdmlnYXRlZCB5ZXQuCisgICAgICB3aW5kb3cuc2V0VGlt ZW91dCh2ZXJpZnksIHRpbWVvdXRWYWx1ZSk7CisgICAgICB0aW1lc3RhbXAgPSBuZXcgRGF0ZSgp LmdldFRpbWUoKTsKKyAgICAgIHJldHVybjsKKyAgICB9CiAgICAgdmFyIGFjdHVhbFRpbWVyRGVs YXkgPSAgbmV3IERhdGUoKS5nZXRUaW1lKCkgLSB0aW1lc3RhbXA7CiAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVySFRNTCA9CiAgICAgICAgIGFjdHVhbFRpbWVyRGVs YXkgPj0gdGltZW91dFZhbHVlID8gJ1BBU1MnIDogJ0ZBSUwgd2l0aCAnICsgYWN0dWFsVGltZXJE ZWxheSArICcgbXMgZGVsYXkuJzsK