33625 2010-01-13 14:58:33 -0800 CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within. 2010-01-13 19:30:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 11031 1 carol carol commit-queue darin oldest_to_newest 180419 0 carol 2010-01-13 14:58:33 -0800 The same problem that bug 33600 reported about RenderObject is being inherited by virtue of copy-paste programing here. If stayWithin has a nextSibling() the method returns it instead of null when called on stayWithin's last descendant, hence causing an iteration of the counterTree designed to stay within stayWithin's descendants, iterates to the end of the counterTree. Patch to come soon. 180440 1 46517 carol 2010-01-13 16:00:49 -0800 Created attachment 46517 Proposed patch 180517 2 46517 commit-queue 2010-01-13 19:30:46 -0800 Comment on attachment 46517 Proposed patch Clearing flags on attachment: 46517 Committed r53230: <http://trac.webkit.org/changeset/53230> 180518 3 commit-queue 2010-01-13 19:30:52 -0800 All reviewed patches have been landed. Closing bug. 46517 2010-01-13 16:00:49 -0800 2010-01-13 19:30:46 -0800 Proposed patch patchFor33625-1.patch text/plain 1614 carol SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzIxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTMgIENhcm9sIFN6YWJvIDxjYXJvbC5zemFib0Bub2tp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q291bnRlck5vZGU6Om5leHRJblByZU9yZGVyQWZ0ZXJDaGlsZHJlbihzdGF5V2l0aGluKSBkb2Vz IG5vdCBzdGF5IHdpdGhpbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzNjI1CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlIGZpeCBz aG91bGQgYWZmZWN0IHN0cmljdGx5IHBlcmZvcm1hbmNlLgorCisgICAgICAgICogcmVuZGVyaW5n L0NvdW50ZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvdW50ZXJOb2RlOjpuZXh0SW5Q cmVPcmRlckFmdGVyQ2hpbGRyZW4pOgorCiAyMDEwLTAxLTEzICBKZXJlbXkgT3Jsb3cgIDxqb3Js b3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5k ZXg6IFdlYkNvcmUvcmVuZGVyaW5nL0NvdW50ZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3JlbmRlcmluZy9Db3VudGVyTm9kZS5jcHAJKHJldmlzaW9uIDUzMTgyKQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvQ291bnRlck5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MiwxOCArNTIs MTQgQEAgQ291bnRlck5vZGUqIENvdW50ZXJOb2RlOjpuZXh0SW5QcmVPcmRlcgogICAgIGlmICh0 aGlzID09IHN0YXlXaXRoaW4pCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgQ291bnRlck5vZGUq IG5leHQgPSBtX25leHRTaWJsaW5nOwotICAgIGlmIChuZXh0KQotICAgICAgICByZXR1cm4gbmV4 dDsKLSAgICBuZXh0ID0gbV9wYXJlbnQ7Ci0gICAgd2hpbGUgKG5leHQgJiYgIW5leHQtPm1fbmV4 dFNpYmxpbmcpIHsKLSAgICAgICAgaWYgKG5leHQgPT0gc3RheVdpdGhpbikKKyAgICBjb25zdCBD b3VudGVyTm9kZSogY3VycmVudCA9IHRoaXM7CisgICAgQ291bnRlck5vZGUqIG5leHQ7CisgICAg d2hpbGUgKCEobmV4dCA9IGN1cnJlbnQtPm1fbmV4dFNpYmxpbmcpKSB7CisgICAgICAgIGN1cnJl bnQgPSBjdXJyZW50LT5tX3BhcmVudDsKKyAgICAgICAgaWYgKCFjdXJyZW50IHx8IGN1cnJlbnQg PT0gc3RheVdpdGhpbikKICAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICBuZXh0ID0gbmV4 dC0+bV9wYXJlbnQ7CiAgICAgfQotICAgIGlmIChuZXh0KQotICAgICAgICByZXR1cm4gbmV4dC0+ bV9uZXh0U2libGluZzsKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gbmV4dDsKIH0KIAogQ291 bnRlck5vZGUqIENvdW50ZXJOb2RlOjpuZXh0SW5QcmVPcmRlcihjb25zdCBDb3VudGVyTm9kZSog c3RheVdpdGhpbikgY29uc3QK