33536 2010-01-12 09:43:26 -0800 Web Inspector: Optimize WebInspector.TimelineGrid.prototype.updateDividers 2010-01-12 15:34:35 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 apavlov webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 179856 0 apavlov 2010-01-12 09:43:26 -0800 On pages with really many resources, WebInspector.TimelineGrid.prototype.updateDividers works too slowly (which results in slow feedback on scrolling/adding items and view resizing in the Resources and Timeline panels). 179877 1 46381 apavlov 2010-01-12 10:17:28 -0800 Created attachment 46381 patch 179945 2 46381 commit-queue 2010-01-12 12:56:40 -0800 Comment on attachment 46381 patch Rejecting patch 46381 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11914 test cases. fast/profiler/stop-profiling-after-setTimeout.html -> crashed Exiting early after 1 failures. 7859 tests run. 254.88s total testing time 7858 test cases (99%) succeeded 1 test case (<1%) crashed 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/182685 179988 3 46381 eric 2010-01-12 14:59:02 -0800 Comment on attachment 46381 patch Bug 32643. Stupid flakey tests. 180002 4 46381 commit-queue 2010-01-12 15:34:27 -0800 Comment on attachment 46381 patch Clearing flags on attachment: 46381 Committed r53167: <http://trac.webkit.org/changeset/53167> 180003 5 commit-queue 2010-01-12 15:34:35 -0800 All reviewed patches have been landed. Closing bug. 46381 2010-01-12 10:17:28 -0800 2010-01-12 15:34:27 -0800 patch optimizedividers.patch text/plain 3528 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTM1MTA4OC4uZWU2NzY1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMS0xMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE9wdGltaXplIFdlYkluc3BlY3Rvci5UaW1lbGluZUdyaWQu cHJvdG90eXBlLnVwZGF0ZURpdmlkZXJzKCkKKworICAgICAgICBET00gZWxlbWVudCBwcm9wZXJ0 eSBhY2Nlc3MgYW5kIG1vZGlmaWNhdGlvbiBhcmUgc2xvdyBhbmQgc2hvdWxkIGJlIGRvbmUgYXMg bGF6aWx5IGFzIHBvc3NpYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzM1MzYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxp bmVHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lR3JpZC5wcm90b3R5cGUu dXBkYXRlRGl2aWRlcnMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lR3JpZC5wcm90 b3R5cGUuX3NldERpdmlkZXJBbmRCYXJMZWZ0KToKKwogMjAxMC0wMS0xMiAgRW5yaWNhIENhc3Vj Y2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lR3JpZC5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZUdyaWQuanMKaW5kZXggMjg2 NmVjZC4uZGI5Y2MxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rp bWVsaW5lR3JpZC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVH cmlkLmpzCkBAIC02Miw3ICs2Miw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUdyaWQucHJvdG90 eXBlID0gewogICAgICAgICBpZiAoIWZvcmNlICYmIHRoaXMuX2N1cnJlbnREaXZpZGVyU2xpY2Ug PT09IHNsaWNlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIGlmICghKHR5 cGVvZiBwYWRkaW5nTGVmdCA9PT0gIm51bWJlciIpKQorICAgICAgICBpZiAodHlwZW9mIHBhZGRp bmdMZWZ0ICE9PSAibnVtYmVyIikKICAgICAgICAgICAgIHBhZGRpbmdMZWZ0ID0gMDsKICAgICAg ICAgdGhpcy5fY3VycmVudERpdmlkZXJTbGljZSA9IHNsaWNlOwogCkBAIC03MSw3ICs3MSw4IEBA IFdlYkluc3BlY3Rvci5UaW1lbGluZUdyaWQucHJvdG90eXBlID0gewogICAgICAgICB2YXIgZGl2 aWRlciA9IHRoaXMuX2RpdmlkZXJzRWxlbWVudC5maXJzdENoaWxkOwogICAgICAgICB2YXIgZGl2 aWRlckxhYmVsQmFyID0gdGhpcy5fZGl2aWRlcnNMYWJlbEJhckVsZW1lbnQuZmlyc3RDaGlsZDsK IAotICAgICAgICB2YXIgY2xpZW50V2lkdGggPSB0aGlzLl9kaXZpZGVyc0xhYmVsQmFyRWxlbWVu dC5jbGllbnRXaWR0aCAtIHBhZGRpbmdMZWZ0OworICAgICAgICB2YXIgZGl2aWRlcnNMYWJlbEJh ckVsZW1lbnRDbGllbnRXaWR0aCA9IHRoaXMuX2RpdmlkZXJzTGFiZWxCYXJFbGVtZW50LmNsaWVu dFdpZHRoOworICAgICAgICB2YXIgY2xpZW50V2lkdGggPSBkaXZpZGVyc0xhYmVsQmFyRWxlbWVu dENsaWVudFdpZHRoIC0gcGFkZGluZ0xlZnQ7CiAgICAgICAgIGZvciAodmFyIGkgPSBwYWRkaW5n TGVmdCA/IDAgOiAxOyBpIDw9IGRpdmlkZXJDb3VudDsgKytpKSB7CiAgICAgICAgICAgICBpZiAo IWRpdmlkZXIpIHsKICAgICAgICAgICAgICAgICBkaXZpZGVyID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgiZGl2Iik7CkBAIC04NSw2ICs4Niw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUdyaWQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGRpdmlkZXJMYWJlbEJhci5fbGFiZWxFbGVt ZW50ID0gbGFiZWw7CiAgICAgICAgICAgICAgICAgZGl2aWRlckxhYmVsQmFyLmFwcGVuZENoaWxk KGxhYmVsKTsKICAgICAgICAgICAgICAgICB0aGlzLl9kaXZpZGVyc0xhYmVsQmFyRWxlbWVudC5h cHBlbmRDaGlsZChkaXZpZGVyTGFiZWxCYXIpOworICAgICAgICAgICAgICAgIGRpdmlkZXJzTGFi ZWxCYXJFbGVtZW50Q2xpZW50V2lkdGggPSB0aGlzLl9kaXZpZGVyc0xhYmVsQmFyRWxlbWVudC5j bGllbnRXaWR0aDsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKGkgPT09IGRpdmlk ZXJDb3VudCkKQEAgLTkzLDkgKzk1LDggQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lR3JpZC5wcm90 b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgZGl2aWRlci5yZW1vdmVTdHlsZUNsYXNzKCJsYXN0 Iik7CiAKICAgICAgICAgICAgIHZhciBsZWZ0ID0gcGFkZGluZ0xlZnQgKyBjbGllbnRXaWR0aCAq IChpIC8gZGl2aWRlckNvdW50KTsKLSAgICAgICAgICAgIHZhciBwZXJjZW50TGVmdCA9IDEwMCAq IGxlZnQgLyB0aGlzLl9kaXZpZGVyc0xhYmVsQmFyRWxlbWVudC5jbGllbnRXaWR0aCArICIlIjsK LSAgICAgICAgICAgIGRpdmlkZXIuc3R5bGUubGVmdCA9IHBlcmNlbnRMZWZ0OwotICAgICAgICAg ICAgZGl2aWRlckxhYmVsQmFyLnN0eWxlLmxlZnQgPSBwZXJjZW50TGVmdDsKKyAgICAgICAgICAg IHZhciBwZXJjZW50TGVmdCA9IDEwMCAqIGxlZnQgLyBkaXZpZGVyc0xhYmVsQmFyRWxlbWVudENs aWVudFdpZHRoOworICAgICAgICAgICAgdGhpcy5fc2V0RGl2aWRlckFuZEJhckxlZnQoZGl2aWRl ciwgZGl2aWRlckxhYmVsQmFyLCBwZXJjZW50TGVmdCk7CiAKICAgICAgICAgICAgIGlmICghaXNO YU4oc2xpY2UpKQogICAgICAgICAgICAgICAgIGRpdmlkZXJMYWJlbEJhci5fbGFiZWxFbGVtZW50 LnRleHRDb250ZW50ID0gY2FsY3VsYXRvci5mb3JtYXRWYWx1ZShzbGljZSAqIGkpOwpAQCAtMTE4 LDYgKzExOSwxNSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVHcmlkLnByb3RvdHlwZSA9IHsKICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAorICAgIF9zZXREaXZpZGVyQW5kQmFyTGVmdDog ZnVuY3Rpb24oZGl2aWRlciwgZGl2aWRlckxhYmVsQmFyLCBwZXJjZW50TGVmdCkKKyAgICB7Cisg ICAgICAgIHZhciBwZXJjZW50U3R5bGVMZWZ0ID0gcGFyc2VGbG9hdChkaXZpZGVyLnN0eWxlLmxl ZnQpOworICAgICAgICBpZiAoIWlzTmFOKHBlcmNlbnRTdHlsZUxlZnQpICYmIE1hdGguYWJzKHBl cmNlbnRTdHlsZUxlZnQgLSBwZXJjZW50TGVmdCkgPCAwLjEpCisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIGRpdmlkZXIuc3R5bGUubGVmdCA9IHBlcmNlbnRMZWZ0ICsgIiUiOworICAgICAg ICBkaXZpZGVyTGFiZWxCYXIuc3R5bGUubGVmdCA9IHBlcmNlbnRMZWZ0ICsgIiUiOworICAgIH0s CisKICAgICBhZGRFdmVudERpdmlkZXI6IGZ1bmN0aW9uKGRpdmlkZXIpCiAgICAgewogICAgICAg ICB0aGlzLl9ldmVudERpdmlkZXJzRWxlbWVudC5hcHBlbmRDaGlsZChkaXZpZGVyKTsK