<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33413</bug_id>
          
          <creation_ts>2010-01-08 18:02:20 -0800</creation_ts>
          <short_desc>selection.modify extends too far with &apos;lineboundary&apos;</short_desc>
          <delta_ts>2010-03-15 02:10:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>adele</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>enrica</cc>
    
    <cc>hyatt</cc>
    
    <cc>ishermandom+bugs</cc>
    
    <cc>justin.lebar+bug</cc>
    
    <cc>morrita</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>178910</commentid>
    <comment_count>0</comment_count>
      <attachid>46187</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-01-08 18:02:20 -0800</bug_when>
    <thetext>Created attachment 46187
test case

This was noticed in https://bugzilla.mozilla.org/show_bug.cgi?id=496275, where Gecko is adding DOMSelection.modify to match WebKit. See the test case for the bug. After calling sel.modify(&apos;extend&apos;, &apos;forward&apos;, &apos;lineboundary&apos;) once, subsequent calls should be a noop. Instead, each call extends one more line when there&apos;s line-wrapping involved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179093</commentid>
    <comment_count>1</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-09 18:02:54 -0800</bug_when>
    <thetext>We need to be sure not to change the behavior of key bindings on Mac OS X in unwanted ways. The described behavior sounds like what the Mac OS X Command-Shift-Right-Arrow key does, and the AppKit moveToRightEndOfLineAndModifySelection: method. We invented selection.modify while working on the original Mac OS X version of WebKit it&apos;s highly likely the programmer who created it did intend this behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179094</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-09 18:07:58 -0800</bug_when>
    <thetext>I take it back.

I tested Command-Shift-Right-Arrow in AppKit text editing, and this behavior in WebKit seems to simply be a bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>179095</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-09 18:11:33 -0800</bug_when>
    <thetext>In fact, I suspect this is a relatively recent regression.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>197913</commentid>
    <comment_count>4</comment_count>
      <attachid>50376</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 00:26:56 -0800</bug_when>
    <thetext>Created attachment 50376
patch v0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198169</commentid>
    <comment_count>5</comment_count>
      <attachid>50376</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-03-10 09:10:26 -0800</bug_when>
    <thetext>Comment on attachment 50376
patch v0

&gt; +++ b/WebCore/ChangeLog
&gt; @@ -1,3 +1,27 @@
&gt; +2010-03-10  MORITA Hajime  &lt;morrita@google.com&gt;
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        Selection.modify extends too far with &apos;lineboundary&apos;.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=33413
&gt; +
&gt; +        Selection.modify() with &apos;lineboundary&apos; guranuality implies just
&gt; +        &quot;Go to the end of the line&quot;, unlike selection expansioin with
&gt; +        other type of granularities. This change handled LineGranularity
&gt; +        as special case, to look-up end of line with UPSTREAM affinity. 
&gt; +        Doing this prevents look-up algorithm to go next line.
&gt; +        This change also fixed getInlineBoxAndOffset() that didn&apos;t handle
&gt; +        an edge case for for UPSTREAM.

Nit: you repeat this last line below. Only need to put it in one place. Either place is fine.

&gt; +
&gt; +        Re-baseline: editing/selection/extend-selection-expected.txt
&gt; +
&gt; +        * dom/Position.cpp:
&gt; +        (WebCore::Position::getInlineBoxAndOffset):
&gt; +        Handled an edge case for node lookup with UPSTREAM.
&gt; +        * editing/SelectionController.cpp:
&gt; +        (WebCore::SelectionController::modifyExtendingForward):
&gt; +        Added UPSTREAM tweak for the case for LineGranularity.

Nit: This line is redundant with the change description above.

I&apos;m definitely nit-picking here, but you only need to annotate specific files/methods if there&apos;s something extra worth noting. Or, you can leave the change description minimal and annotate the files/methods instead.

The code changes seem reasonable to me. Does modifyMovingForward also need to be fixed? What about sentenceboundary/paragraphboundary? I&apos;m not really sure what sentenceboundary/paragraphboundary are used for, i.e. do they correspond to a user-action? If they do, it would be good to compare TextEdit and WebKit to see if this needs to be done for those cases as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198196</commentid>
    <comment_count>6</comment_count>
      <attachid>50376</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-03-10 10:26:12 -0800</bug_when>
    <thetext>Comment on attachment 50376
patch v0

+             * So we mimic UPSTREAM affinity to prevent to crossing
+             * line when the offset is at the end of line.

Two comments:
1) We use C++ style comments (&quot;//&quot;) in C++ code.
2) I don&apos;t understand why this says &quot;mimic&quot;. Don&apos;t we just plain use it? And would anything break if you didn&apos;t add &quot;pos.setAffinity(m_selection.affinity());&quot;?

&gt; Or, you can leave the change description minimal and annotate the files/methods instead.

Yes, that&apos;s the preferred way of writing ChangeLogs.

&gt; +        Re-baseline: editing/selection/extend-selection-expected.txt

&quot;Baseline&quot; is a noun, so using it as a verb is a mistake. You could just say &quot;updated results&quot; instead.

&gt; I&apos;m not really sure what sentenceboundary/paragraphboundary are used for, 
&gt; i.e. do they correspond to a user-action?

Without actually checking the code, I suspect that you get paragraphboundary when triple-clicking and dragging, and also when triple-clicking and then extending the selection from keyboard with Cmd+Shift+Right (but when I tested, the results from the latter seemed wrong).

I think this needs another iteration, r- for now. I agree with Ojan&apos;s comments about code changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198286</commentid>
    <comment_count>7</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-03-10 13:06:01 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; &gt; I&apos;m not really sure what sentenceboundary/paragraphboundary are used for, 
&gt; &gt; i.e. do they correspond to a user-action?
&gt; 
&gt; Without actually checking the code, I suspect that you get paragraphboundary
&gt; when triple-clicking and dragging, and also when triple-clicking and then
&gt; extending the selection from keyboard with Cmd+Shift+Right (but when I tested,
&gt; the results from the latter seemed wrong).

I played with this a bit more. ctrl+shift+e extends the selection to the end of the current paragraph and ctrl+shift+a will extend the selection to the beginning of the current paragraph. I tested this in WebKit and TextEdit and the behavior seems to be the same. So, I think this patch is fine as far as paragraphboundary is concerned, which makes sense since upstream/downstream is not really meaningful at a paragraph boundary.

As far as sentenceboundary, I think it probably does not need the same treatment as lineboundary, but I really don&apos;t know what the expected behavior of sentenceboundary is. I&apos;ve sent and email to webkit-dev to try and understand this better.

Also, I tested the modifyMovingForward case (cmd+left and cmd+right). They work in the testcase. It does not need to be modified because VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity does nothing for CharacterGranularity. It&apos;s that function that causes this bug when you have the granularity set to LineGranularity.

I&apos;ve answered my own questions. :) The code seems fine to me, except for ap&apos;s question about whether we really need to set the affinity back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198467</commentid>
    <comment_count>8</comment_count>
      <attachid>50465</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 20:12:48 -0800</bug_when>
    <thetext>Created attachment 50465
v1; took feedbacks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198468</commentid>
    <comment_count>9</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 20:22:26 -0800</bug_when>
    <thetext>Thank you for the review and further experiments! &gt; ojan, ap
I update patch to cleanup changelog/comment mess.
Would you give the review for updated one?

&gt;2) I don&apos;t understand why this says &quot;mimic&quot;. Don&apos;t we just plain use it? And
&gt;would anything break if you didn&apos;t add
&gt;&quot;pos.setAffinity(m_selection.affinity());&quot;?
I agree that isn&apos;t a mimicking stuff.

At first I thought I should keep affinity as before modify() 
and swapping affinity temporally looks like &quot;mimic&quot; for me.
But all tests passed without that line so I removed it,
and now it looks natural for me. 

&gt;Also, I tested the modifyMovingForward case (cmd+left and cmd+right). They work
&gt;in the testcase.
Yes. modify(&apos;move&apos;, ... ) already works as expected.
It seems &apos;move&apos; has its own logic other than &apos;extend&apos; for line-boundary behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198473</commentid>
    <comment_count>10</comment_count>
      <attachid>50465</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-03-10 20:40:47 -0800</bug_when>
    <thetext>Comment on attachment 50465
v1; took feedbacks

&gt; +++ b/WebCore/ChangeLog
&gt; +        Selection.modify() with &apos;lineboundary&apos; guranuality implies just
&gt; +        &quot;Go to the end of the line&quot;, unlike selection expansioin with

Typo: s/expansioin/expansion

&gt; +++ b/WebCore/editing/SelectionController.cpp
&gt; +            // LineBoundary granularity actually emulates
&gt; +            // NSTextView#moveToRightEndOfLineAndModifySelection(),
&gt; +            // which never expands selection across multiple lines.
&gt; +            // So we set UPSTREAM affinity to prevent to crossing
&gt; +            // line when the offset is at the end of line.

Grammar fix:
&gt; +            // which never expands a selection across multiple lines.
&gt; +            // So we set UPSTREAM affinity to prevent crossing the
&gt; +            // line boundary when the offset is at the end of the line.

Otherwise look good to me. I&apos;m not a reviewer though. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198475</commentid>
    <comment_count>11</comment_count>
      <attachid>50469</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 20:54:54 -0800</bug_when>
    <thetext>Created attachment 50469
v2; spelling fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198476</commentid>
    <comment_count>12</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 20:56:12 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; Typo: s/expansioin/expansion
&gt; ...
&gt; Grammar fix:

Oops, I need spell/grammar-checker for my Emacs.
Thank you for pointing them out!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198477</commentid>
    <comment_count>13</comment_count>
      <attachid>50470</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 21:09:11 -0800</bug_when>
    <thetext>Created attachment 50470
v3; more misspelling fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198479</commentid>
    <comment_count>14</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-10 21:12:55 -0800</bug_when>
    <thetext>...and ispell on Emacs found more misspelling :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198667</commentid>
    <comment_count>15</comment_count>
      <attachid>50470</attachid>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2010-03-11 10:13:18 -0800</bug_when>
    <thetext>Comment on attachment 50470
v3; more misspelling fix

&gt; diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
&gt; index 9d47289..d30ce63 100644
&gt; --- a/LayoutTests/ChangeLog
&gt; +++ b/LayoutTests/ChangeLog
&gt; @@ -1,3 +1,15 @@
&gt; +2010-03-10  MORITA Hajime  &lt;morrita@google.com&gt;
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        Selection.modify extends too far with &apos;lineboundary&apos;.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=33413
&gt; +
&gt; +        * editing/selection/extend-selection-expected.txt:
&gt; +        Updated result to correct expectation that described the wrong
&gt; +        behaviour for the selection expansion with &apos;lineboundary&apos;
&gt; +        granularity.
&gt; +
&gt;  2010-03-10  Roland Steiner  &lt;rolandsteiner@chromium.org&gt;
&gt;  
&gt;          Reviewed by David Levin.
&gt; diff --git a/LayoutTests/editing/selection/extend-selection-expected.txt b/LayoutTests/editing/selection/extend-selection-expected.txt
&gt; index 1617e03..0b33cd2 100644
&gt; --- a/LayoutTests/editing/selection/extend-selection-expected.txt
&gt; +++ b/LayoutTests/editing/selection/extend-selection-expected.txt
&gt; @@ -514,14 +514,14 @@ Test 20, RTL:
&gt;    Extending forward: &quot;ABC abc DEF&quot;[(0,0), (0,11)]
&gt;    Extending backward:  &quot;ABC abc DEF&quot;[(0,11), (0,0)]
&gt;  Test 21, LTR:
&gt; -  Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,8), (0,16), (0,26), (0,34), (0,42), (0,50), (0,58), (0,66), (0,74), (0,82), (0,90), (0,98), (0,105)]
&gt; -  Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,105), (0,0)]
&gt; +  Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,8)]
&gt; +  Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,8), (0,0)]
&gt;  Test 21, RTL:
&gt;    Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,7)]
&gt;    Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,7), (0,0)]
&gt;  Test 22, LTR:
&gt; -  Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,8), (0,16), (0,26), (0,34), (0,42), (0,50), (0,58), (0,66), (0,74), (0,82), (0,90), (0,98), (0,105)]
&gt; -  Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,105), (0,0)]
&gt; +  Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,8)]
&gt; +  Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,8), (0,0)]
&gt;  Test 22, RTL:
&gt;    Extending forward: &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,0), (0,7)]
&gt;    Extending backward:  &quot;abcdefg abcdefg abcdefg a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg &quot;[(0,7), (0,0)]
&gt; diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
&gt; index 0a812be..afda4f5 100644
&gt; --- a/WebCore/ChangeLog
&gt; +++ b/WebCore/ChangeLog
&gt; @@ -1,3 +1,25 @@
&gt; +2010-03-10  MORITA Hajime  &lt;morrita@google.com&gt;
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        Selection.modify extends too far with &apos;lineboundary&apos;.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=33413
&gt; +
&gt; +        Selection.modify() with &apos;lineboundary&apos; granularity implies just
&gt; +        &quot;Go to the end of the line&quot;, unlike selection expansion with
&gt; +        other type of granularities. This change handled LineGranularity
&gt; +        as special case, to look-up end of line with UPSTREAM affinity. 
&gt; +        Doing this prevents look-up algorithm to go next line.
&gt; +
&gt; +        Test: editing/selection/extend-selection-expected.txt
&gt; +
&gt; +        * dom/Position.cpp:
&gt; +        (WebCore::Position::getInlineBoxAndOffset):
&gt; +        Handled an edge case for node look-up with UPSTREAM.
&gt; +        * editing/SelectionController.cpp:
&gt; +        (WebCore::SelectionController::modifyExtendingForward):
&gt; +        Added UPSTREAM tweak for the case for LineGranularity.
&gt; +        
&gt;  2010-03-10  Roland Steiner  &lt;rolandsteiner@chromium.org&gt;
&gt;  
&gt;          Unreviewed build fix. Fix variable name change that somehow didn&apos;t
&gt; diff --git a/WebCore/dom/Position.cpp b/WebCore/dom/Position.cpp
&gt; index ef0b3c1..e22dc9e 100644
&gt; --- a/WebCore/dom/Position.cpp
&gt; +++ b/WebCore/dom/Position.cpp
&gt; @@ -1041,6 +1041,9 @@ void Position::getInlineBoxAndOffset(EAffinity affinity, TextDirection primaryDi
&gt;                  return;
&gt;              }
&gt;  
&gt; +            if ((caretOffset == caretMaxOffset) ^ (affinity == DOWNSTREAM))
&gt; +                break;
&gt; +

Why this? affinity is only UPSTREAM or DOWNSTREAM.
You could change the code to be
             if (caretOffset == caretMinOffset)
                  break;
and have only one if statement instead of 2.
   
&gt;              if ((caretOffset == caretMinOffset) ^ (affinity == UPSTREAM))
&gt;                  break;
&gt;  
&gt; diff --git a/WebCore/editing/SelectionController.cpp b/WebCore/editing/SelectionController.cpp
&gt; index c0f03de..f2859fd 100644
&gt; --- a/WebCore/editing/SelectionController.cpp
&gt; +++ b/WebCore/editing/SelectionController.cpp
&gt; @@ -351,7 +351,14 @@ VisiblePosition SelectionController::modifyExtendingForward(TextGranularity gran
&gt;              pos = endOfSentence(endForPlatform());
&gt;              break;
&gt;          case LineBoundary:
&gt; -            pos = logicalEndOfLine(endForPlatform());
&gt; +            // LineBoundary granularity actually emulates
&gt; +            // NSTextView#moveToRightEndOfLineAndModifySelection(),
&gt; +            // which never expands a selection across multiple lines.
&gt; +            // So we set UPSTREAM affinity to prevent crossing the
&gt; +            // line boundary when the offset is at the end of the line.
&gt; +            pos = endForPlatform();
&gt; +            pos.setAffinity(UPSTREAM);
&gt; +            pos = logicalEndOfLine(pos);
&gt;              break;
&gt;          case ParagraphBoundary:
&gt;              pos = endOfParagraph(endForPlatform());</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198673</commentid>
    <comment_count>16</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-03-11 10:33:22 -0800</bug_when>
    <thetext>(In reply to comment #15)
&gt; &gt; +            if ((caretOffset == caretMaxOffset) ^ (affinity == DOWNSTREAM))
&gt; &gt; +                break;
&gt; &gt; +
&gt; 
&gt; Why this? affinity is only UPSTREAM or DOWNSTREAM.
&gt; You could change the code to be
&gt;              if (caretOffset == caretMinOffset)
&gt;                   break;
&gt; and have only one if statement instead of 2.

I think maybe you misread? The comparison above is to caretMaxOffset, not caretMinOffset.

&gt; 
&gt; &gt;              if ((caretOffset == caretMinOffset) ^ (affinity == UPSTREAM))
&gt; &gt;                  break;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198844</commentid>
    <comment_count>17</comment_count>
    <who name="Enrica Casucci">enrica</who>
    <bug_when>2010-03-11 16:49:21 -0800</bug_when>
    <thetext>(In reply to comment #16)
&gt; (In reply to comment #15)
&gt; &gt; &gt; +            if ((caretOffset == caretMaxOffset) ^ (affinity == DOWNSTREAM))
&gt; &gt; &gt; +                break;
&gt; &gt; &gt; +
&gt; &gt; 
&gt; &gt; Why this? affinity is only UPSTREAM or DOWNSTREAM.
&gt; &gt; You could change the code to be
&gt; &gt;              if (caretOffset == caretMinOffset)
&gt; &gt;                   break;
&gt; &gt; and have only one if statement instead of 2.
&gt; 
&gt; I think maybe you misread? The comparison above is to caretMaxOffset, not
&gt; caretMinOffset.
&gt; 
&gt; &gt; 
&gt; &gt; &gt;              if ((caretOffset == caretMinOffset) ^ (affinity == UPSTREAM))
&gt; &gt; &gt;                  break;

My mistake, sorry. I would still prefer to see only one if with an or rather than 2 if statements with a break. Not a big deal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198873</commentid>
    <comment_count>18</comment_count>
      <attachid>50565</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-11 17:57:11 -0800</bug_when>
    <thetext>Created attachment 50565
brought 2 break statements into one</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199199</commentid>
    <comment_count>19</comment_count>
      <attachid>50565</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-03-12 13:55:00 -0800</bug_when>
    <thetext>Comment on attachment 50565
brought 2 break statements into one

Code changes look good to me. I have some nits about the comment though.

+            // LineBoundary granularity actually emulates

&quot;Actually&quot; doesn&apos;t mean anything here, and can be just omitted.

+            // NSTextView#moveToRightEndOfLineAndModifySelection(),

I don&apos;t see such a method in NSTextView. If it were there, it would have been written as &quot;-[NSTextView moveToRightEndOfLineAndModifySelection:]&quot;. But the important thing is that we try to match NSTextView behavior for user actions, not the behavior of some low level method.

+            // which never expands a selection across multiple lines.
+            // So we set UPSTREAM affinity to prevent crossing the
+            // line boundary when the offset is at the end of the line.

I don&apos;t think this comment is necessary. The behavior is covered by a regression test, so it&apos;s unlikely that someone will break it, and if rationale for the change is needed in the future, svn blame can always be consulted.

These test has platform/win results, too, and they also need to be updated. I don&apos;t know why these are different, but the expected results file should be hopefully easy to patch even if you don&apos;t have a Windows development environment.

r=me if this whole comment is removed when landing, and Windows results are updated. Or you can submit an updated patch for double-checking and commit queue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199206</commentid>
    <comment_count>20</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-03-12 14:04:39 -0800</bug_when>
    <thetext>(In reply to comment #19)
&gt; +            // NSTextView#moveToRightEndOfLineAndModifySelection(),
&gt; 
&gt; I don&apos;t see such a method in NSTextView. If it were there, it would have been
&gt; written as &quot;-[NSTextView moveToRightEndOfLineAndModifySelection:]&quot;. But the
&gt; important thing is that we try to match NSTextView behavior for user actions,
&gt; not the behavior of some low level method.

Just for the record, -[NSResponder moveToRightEndOfLineAndModifySelection:] does indeed exist. See NSResponder.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199215</commentid>
    <comment_count>21</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-03-12 14:17:12 -0800</bug_when>
    <thetext>I don&apos;t see it in Leopard version of NSResponder.h or in Leopard Xcode documentation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199227</commentid>
    <comment_count>22</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-03-12 14:45:43 -0800</bug_when>
    <thetext>(In reply to comment #21)
&gt; I don&apos;t see it in Leopard version of NSResponder.h or in Leopard Xcode
&gt; documentation.

It’s new in Snow Leopard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199553</commentid>
    <comment_count>23</comment_count>
      <attachid>50687</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-15 00:00:34 -0700</bug_when>
    <thetext>Created attachment 50687
clenaup comment, update windows result</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199559</commentid>
    <comment_count>24</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-15 00:06:56 -0700</bug_when>
    <thetext>Thank you for reviewing again.
I&apos;ve updated the patch to remove redundant part from the comment,
updating the windows result.
Would you review it?

BTW, The behavior on windows looks a little strange.
I suspect that It is why that test on windows has different expectation.
We might need to tackle it separately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199561</commentid>
    <comment_count>25</comment_count>
      <attachid>50687</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-03-15 00:11:41 -0700</bug_when>
    <thetext>Comment on attachment 50687
clenaup comment, update windows result

&gt; +            // LineBoundary granularity emulates
&gt; +            // [NSTextView moveToRightEndOfLineAndModifySelection:].

You didn&apos;t fully address my comments here - it&apos;s better to talk about user-visible behavior than about low level methods, and the dash sign is an integral part of method name. I still think we&apos;d be better without any comment.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199577</commentid>
    <comment_count>26</comment_count>
      <attachid>50692</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-15 01:42:03 -0700</bug_when>
    <thetext>Created attachment 50692
remove redundant comment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199578</commentid>
    <comment_count>27</comment_count>
      <attachid>50692</attachid>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-03-15 01:46:34 -0700</bug_when>
    <thetext>Comment on attachment 50692
remove redundant comment

&gt; You didn&apos;t fully address my comments here
Oops, I&apos;m sorry about that. Thank you for granting.

&gt; integral part of method name. I still think we&apos;d be better without any comment.
Agreed. So I removed the whole comment at that part.

Would you (or someone) commit-queue:+ when bots get green ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199585</commentid>
    <comment_count>28</comment_count>
      <attachid>50692</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-15 02:10:06 -0700</bug_when>
    <thetext>Comment on attachment 50692
remove redundant comment

Clearing flags on attachment: 50692

Committed r55990: &lt;http://trac.webkit.org/changeset/55990&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199587</commentid>
    <comment_count>29</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-15 02:10:13 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>46187</attachid>
            <date>2010-01-08 18:02:20 -0800</date>
            <delta_ts>2010-01-08 18:02:20 -0800</delta_ts>
            <desc>test case</desc>
            <filename>line-boundarybug.html</filename>
            <type>text/html</type>
            <size>445</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">PGRpdiBpZD13cmFwIGNvbnRlbnRFZGl0YWJsZSBzdHlsZT0iYm9yZGVyOjFweCBzb2xpZDt3aWR0
aDo1MHB4Ij5mb28gYmFyIGJheiBmb28gYmFyIGJheiBmb28gYmFyIGJhejwvZGl2Pgo8c2NyaXB0
Pgp2YXIgbm9kZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd3cmFwJyk7Cm5vZGUuZm9jdXMo
KTsKCnZhciB0ZXh0Tm9kZSA9IG5vZGUuZmlyc3RDaGlsZDsKCnZhciBzZWwgPSB3aW5kb3cuZ2V0
U2VsZWN0aW9uKCk7CnNlbC5zZXRCYXNlQW5kRXh0ZW50KHRleHROb2RlLCAzLCB0ZXh0Tm9kZSwg
Myk7CnNlbC5tb2RpZnkoJ2V4dGVuZCcsICdmb3J3YXJkJywgJ2xpbmVib3VuZGFyeScpOwpzZWwu
bW9kaWZ5KCdleHRlbmQnLCAnZm9yd2FyZCcsICdsaW5lYm91bmRhcnknKTsKc2VsLm1vZGlmeSgn
ZXh0ZW5kJywgJ2ZvcndhcmQnLCAnbGluZWJvdW5kYXJ5Jyk7Cjwvc2NyaXB0Pg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50376</attachid>
            <date>2010-03-10 00:26:56 -0800</date>
            <delta_ts>2010-03-10 20:12:42 -0800</delta_ts>
            <desc>patch v0</desc>
            <filename>bug-33413-20100310172654.patch</filename>
            <type>text/plain</type>
            <size>6061</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAyYzFmY2Q1Li4yM2E3MGRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgUmUtYmFzZWxpbmVkIHRv
IGNvcnJlY3QgZXhwZWN0YXRpb24gdGhhdCBkZXNjcmliZWQgdGhlIHdyb25nCisgICAgICAgIGJl
aGF2aW91ciBmb3IgdGhlIHNlbGVjdGlvbiBleHBhbnNpb24gd2l0aCAnbGluZWJvdW5kYXJ5Jwor
ICAgICAgICBncmFudWFsaXR5LgorCiAyMDEwLTAzLTA4ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0
YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1l
eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0
aW9uLWV4cGVjdGVkLnR4dAppbmRleCAxNjE3ZTAzLi4wYjMzY2QyIDEwMDY0NAotLS0gYS9MYXlv
dXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dAor
KysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4cGVj
dGVkLnR4dApAQCAtNTE0LDE0ICs1MTQsMTQgQEAgVGVzdCAyMCwgUlRMOgogICBFeHRlbmRpbmcg
Zm9yd2FyZDogIkFCQyBhYmMgREVGIlsoMCwwKSwgKDAsMTEpXQogICBFeHRlbmRpbmcgYmFja3dh
cmQ6ICAiQUJDIGFiYyBERUYiWygwLDExKSwgKDAsMCldCiBUZXN0IDIxLCBMVFI6Ci0gIEV4dGVu
ZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnICJbKDAsMCksICgwLDgpLCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAoMCw0MiksICgw
LDUwKSwgKDAsNTgpLCAoMCw2NiksICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgwLDk4KSwgKDAs
MTA1KV0KLSAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDEwNSksICgwLDApXQorICBFeHRlbmRpbmcgZm9y
d2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAi
WygwLDApLCAoMCw4KV0KKyAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0KIFRlc3QgMjEs
IFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGluZyBiYWNrd2Fy
ZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlso
MCw3KSwgKDAsMCldCiBUZXN0IDIyLCBMVFI6Ci0gIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgp
LCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAoMCw0MiksICgwLDUwKSwgKDAsNTgpLCAoMCw2Niks
ICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgwLDk4KSwgKDAsMTA1KV0KLSAgRXh0ZW5kaW5nIGJh
Y2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyAiWygwLDEwNSksICgwLDApXQorICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KV0KKyAgRXh0
ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0KIFRlc3QgMjIsIFJUTDoKICAgRXh0ZW5kaW5nIGZv
cndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
IlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCw3KSwgKDAsMCldCmRpZmYgLS1n
aXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDVjMDgxNzgu
LmEzNzJkZjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDMtMTAgIE1PUklUQSBIYWppbWUgIDxtb3Jy
aXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRzIHRvbyBmYXIgd2l0aCAnbGluZWJvdW5k
YXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMz
NDEzCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSgpIHdpdGggJ2xpbmVib3VuZGFyeScgZ3Vy
YW51YWxpdHkgaW1wbGllcyBqdXN0CisgICAgICAgICJHbyB0byB0aGUgZW5kIG9mIHRoZSBsaW5l
IiwgdW5saWtlIHNlbGVjdGlvbiBleHBhbnNpb2luIHdpdGgKKyAgICAgICAgb3RoZXIgdHlwZSBv
ZiBncmFudWxhcml0aWVzLiBUaGlzIGNoYW5nZSBoYW5kbGVkIExpbmVHcmFudWxhcml0eQorICAg
ICAgICBhcyBzcGVjaWFsIGNhc2UsIHRvIGxvb2stdXAgZW5kIG9mIGxpbmUgd2l0aCBVUFNUUkVB
TSBhZmZpbml0eS4gCisgICAgICAgIERvaW5nIHRoaXMgcHJldmVudHMgbG9vay11cCBhbGdvcml0
aG0gdG8gZ28gbmV4dCBsaW5lLgorICAgICAgICBUaGlzIGNoYW5nZSBhbHNvIGZpeGVkIGdldElu
bGluZUJveEFuZE9mZnNldCgpIHRoYXQgZGlkbid0IGhhbmRsZQorICAgICAgICBhbiBlZGdlIGNh
c2UgZm9yIGZvciBVUFNUUkVBTS4KKworICAgICAgICBSZS1iYXNlbGluZTogZWRpdGluZy9zZWxl
Y3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKworICAgICAgICAqIGRvbS9Qb3Np
dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zm
c2V0KToKKyAgICAgICAgSGFuZGxlZCBhbiBlZGdlIGNhc2UgZm9yIG5vZGUgbG9va3VwIHdpdGgg
VVBTVFJFQU0uCisgICAgICAgICogZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeUV4dGVuZGluZ0Zvcndh
cmQpOgorICAgICAgICBBZGRlZCBVUFNUUkVBTSB0d2VhayBmb3IgdGhlIGNhc2UgZm9yIExpbmVH
cmFudWxhcml0eS4KKyAgICAgICAgCiAyMDEwLTAzLTA4ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0
YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm
IC0tZ2l0IGEvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIvV2ViQ29yZS9kb20vUG9zaXRpb24u
Y3BwCmluZGV4IGVmMGIzYzEuLmUyMmRjOWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1Bvc2l0
aW9uLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKQEAgLTEwNDEsNiArMTA0MSw5
IEBAIHZvaWQgUG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldChFQWZmaW5pdHkgYWZmaW5p
dHksIFRleHREaXJlY3Rpb24gcHJpbWFyeURpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAg
ICAgICAgICAgfQogCisgICAgICAgICAgICBpZiAoKGNhcmV0T2Zmc2V0ID09IGNhcmV0TWF4T2Zm
c2V0KSBeIChhZmZpbml0eSA9PSBET1dOU1RSRUFNKSkKKyAgICAgICAgICAgICAgICBicmVhazsK
KwogICAgICAgICAgICAgaWYgKChjYXJldE9mZnNldCA9PSBjYXJldE1pbk9mZnNldCkgXiAoYWZm
aW5pdHkgPT0gVVBTVFJFQU0pKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCmRpZmYgLS1naXQg
YS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2VkaXRp
bmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKaW5kZXggMjU5ODJkNC4uYzQzMDBhZSAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNv
cmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcApAQCAtMzUwLDcgKzM1MCwxNyBAQCBW
aXNpYmxlUG9zaXRpb24gU2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5RXh0ZW5kaW5nRm9yd2Fy
ZChUZXh0R3JhbnVsYXJpdHkgZ3JhbgogICAgICAgICAgICAgcG9zID0gZW5kT2ZTZW50ZW5jZShl
bmRGb3JQbGF0Zm9ybSgpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIExpbmVC
b3VuZGFyeToKLSAgICAgICAgICAgIHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUoZW5kRm9yUGxhdGZv
cm0oKSk7CisgICAgICAgICAgICAvKiAKKyAgICAgICAgICAgICAqIExpbmVCb3VuZGFyeSBncmFu
dWxhcml0eSBhY3R1YWxseSBlbXVsYXRlcworICAgICAgICAgICAgICogTlNUZXh0VmlldyNtb3Zl
VG9SaWdodEVuZE9mTGluZUFuZE1vZGlmeVNlbGVjdGlvbigpLAorICAgICAgICAgICAgICogd2hp
Y2ggbmV2ZXIgZXhwYW5kcyBzZWxlY3Rpb24gYWNyb3NzIG11bHRpcGxlIGxpbmVzLgorICAgICAg
ICAgICAgICogU28gd2UgbWltaWMgVVBTVFJFQU0gYWZmaW5pdHkgdG8gcHJldmVudCB0byBjcm9z
c2luZworICAgICAgICAgICAgICogbGluZSB3aGVuIHRoZSBvZmZzZXQgaXMgYXQgdGhlIGVuZCBv
ZiBsaW5lLgorICAgICAgICAgICAgICovCisgICAgICAgICAgICBwb3MgPSBlbmRGb3JQbGF0Zm9y
bSgpOworICAgICAgICAgICAgcG9zLnNldEFmZmluaXR5KFVQU1RSRUFNKTsKKyAgICAgICAgICAg
IHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUocG9zKTsKKyAgICAgICAgICAgIHBvcy5zZXRBZmZpbml0
eShtX3NlbGVjdGlvbi5hZmZpbml0eSgpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBj
YXNlIFBhcmFncmFwaEJvdW5kYXJ5OgogICAgICAgICAgICAgcG9zID0gZW5kT2ZQYXJhZ3JhcGgo
ZW5kRm9yUGxhdGZvcm0oKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50465</attachid>
            <date>2010-03-10 20:12:48 -0800</date>
            <delta_ts>2010-03-10 20:54:48 -0800</delta_ts>
            <desc>v1; took feedbacks</desc>
            <filename>bug-33413-20100311131246.patch</filename>
            <type>text/plain</type>
            <size>5938</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li4yOTg1NzUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgVXBkYXRlZCByZXN1bHQg
dG8gY29ycmVjdCBleHBlY3RhdGlvbiB0aGF0IGRlc2NyaWJlZCB0aGUgd3JvbmcKKyAgICAgICAg
YmVoYXZpb3VyIGZvciB0aGUgc2VsZWN0aW9uIGV4cGFuc2lvbiB3aXRoICdsaW5lYm91bmRhcnkn
CisgICAgICAgIGdyYW51YWxpdHkuCisKIDIwMTAtMDMtMTAgIFJvbGFuZCBTdGVpbmVyICA8cm9s
YW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2
aW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2Vs
ZWN0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVu
ZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CmluZGV4IDE2MTdlMDMuLjBiMzNjZDIgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0
ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rp
b24tZXhwZWN0ZWQudHh0CkBAIC01MTQsMTQgKzUxNCwxNCBAQCBUZXN0IDIwLCBSVEw6CiAgIEV4
dGVuZGluZyBmb3J3YXJkOiAiQUJDIGFiYyBERUYiWygwLDApLCAoMCwxMSldCiAgIEV4dGVuZGlu
ZyBiYWNrd2FyZDogICJBQkMgYWJjIERFRiJbKDAsMTEpLCAoMCwwKV0KIFRlc3QgMjEsIExUUjoK
LSAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCksICgwLDE2KSwgKDAsMjYpLCAoMCwzNCksICgw
LDQyKSwgKDAsNTApLCAoMCw1OCksICgwLDY2KSwgKDAsNzQpLCAoMCw4MiksICgwLDkwKSwgKDAs
OTgpLCAoMCwxMDUpXQotICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMTA1KSwgKDAsMCldCisgIEV4dGVu
ZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnICJbKDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCksICgwLDApXQog
VGVzdCAyMSwgUlRMOgogICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw3KV0KICAgRXh0ZW5kaW5n
IGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyAiWygwLDcpLCAoMCwwKV0KIFRlc3QgMjIsIExUUjoKLSAgRXh0ZW5kaW5nIGZvcndhcmQ6
ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCww
KSwgKDAsOCksICgwLDE2KSwgKDAsMjYpLCAoMCwzNCksICgwLDQyKSwgKDAsNTApLCAoMCw1OCks
ICgwLDY2KSwgKDAsNzQpLCAoMCw4MiksICgwLDkwKSwgKDAsOTgpLCAoMCwxMDUpXQotICBFeHRl
bmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnICJbKDAsMTA1KSwgKDAsMCldCisgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgp
XQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCksICgwLDApXQogVGVzdCAyMiwgUlRMOgogICBFeHRl
bmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyAiWygwLDApLCAoMCw3KV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDcpLCAoMCwwKV0K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MGE4MTJiZS4uM2Y0YTNiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wMy0xMCAgTU9SSVRBIEhhamlt
ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBTZWxlY3Rpb24ubW9kaWZ5IGV4dGVuZHMgdG9vIGZhciB3aXRoICds
aW5lYm91bmRhcnknLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MzM0MTMKKworICAgICAgICBTZWxlY3Rpb24ubW9kaWZ5KCkgd2l0aCAnbGluZWJvdW5k
YXJ5JyBndXJhbnVhbGl0eSBpbXBsaWVzIGp1c3QKKyAgICAgICAgIkdvIHRvIHRoZSBlbmQgb2Yg
dGhlIGxpbmUiLCB1bmxpa2Ugc2VsZWN0aW9uIGV4cGFuc2lvaW4gd2l0aAorICAgICAgICBvdGhl
ciB0eXBlIG9mIGdyYW51bGFyaXRpZXMuIFRoaXMgY2hhbmdlIGhhbmRsZWQgTGluZUdyYW51bGFy
aXR5CisgICAgICAgIGFzIHNwZWNpYWwgY2FzZSwgdG8gbG9vay11cCBlbmQgb2YgbGluZSB3aXRo
IFVQU1RSRUFNIGFmZmluaXR5LiAKKyAgICAgICAgRG9pbmcgdGhpcyBwcmV2ZW50cyBsb29rLXVw
IGFsZ29yaXRobSB0byBnbyBuZXh0IGxpbmUuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9zZWxl
Y3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKworICAgICAgICAqIGRvbS9Qb3Np
dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zm
c2V0KToKKyAgICAgICAgSGFuZGxlZCBhbiBlZGdlIGNhc2UgZm9yIG5vZGUgbG9va3VwIHdpdGgg
VVBTVFJFQU0uCisgICAgICAgICogZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeUV4dGVuZGluZ0Zvcndh
cmQpOgorICAgICAgICBBZGRlZCBVUFNUUkVBTSB0d2VhayBmb3IgdGhlIGNhc2UgZm9yIExpbmVH
cmFudWxhcml0eS4KKyAgICAgICAgCiAyMDEwLTAzLTEwICBSb2xhbmQgU3RlaW5lciAgPHJvbGFu
ZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LiBG
aXggdmFyaWFibGUgbmFtZSBjaGFuZ2UgdGhhdCBzb21laG93IGRpZG4ndApkaWZmIC0tZ2l0IGEv
V2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCmluZGV4
IGVmMGIzYzEuLmUyMmRjOWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAor
KysgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKQEAgLTEwNDEsNiArMTA0MSw5IEBAIHZvaWQg
UG9zaXRpb246OmdldElubGluZUJveEFuZE9mZnNldChFQWZmaW5pdHkgYWZmaW5pdHksIFRleHRE
aXJlY3Rpb24gcHJpbWFyeURpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAg
fQogCisgICAgICAgICAgICBpZiAoKGNhcmV0T2Zmc2V0ID09IGNhcmV0TWF4T2Zmc2V0KSBeIChh
ZmZpbml0eSA9PSBET1dOU1RSRUFNKSkKKyAgICAgICAgICAgICAgICBicmVhazsKKwogICAgICAg
ICAgICAgaWYgKChjYXJldE9mZnNldCA9PSBjYXJldE1pbk9mZnNldCkgXiAoYWZmaW5pdHkgPT0g
VVBTVFJFQU0pKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCmRpZmYgLS1naXQgYS9XZWJDb3Jl
L2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0
aW9uQ29udHJvbGxlci5jcHAKaW5kZXggYzBmMDNkZS4uMTY1N2FhNCAxMDA2NDQKLS0tIGEvV2Vi
Q29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvZWRpdGlu
Zy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcApAQCAtMzUxLDcgKzM1MSwxNiBAQCBWaXNpYmxlUG9z
aXRpb24gU2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5RXh0ZW5kaW5nRm9yd2FyZChUZXh0R3Jh
bnVsYXJpdHkgZ3JhbgogICAgICAgICAgICAgcG9zID0gZW5kT2ZTZW50ZW5jZShlbmRGb3JQbGF0
Zm9ybSgpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIExpbmVCb3VuZGFyeToK
LSAgICAgICAgICAgIHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUoZW5kRm9yUGxhdGZvcm0oKSk7Cisg
ICAgICAgICAgICAvLyAKKyAgICAgICAgICAgIC8vIExpbmVCb3VuZGFyeSBncmFudWxhcml0eSBh
Y3R1YWxseSBlbXVsYXRlcworICAgICAgICAgICAgLy8gTlNUZXh0VmlldyNtb3ZlVG9SaWdodEVu
ZE9mTGluZUFuZE1vZGlmeVNlbGVjdGlvbigpLAorICAgICAgICAgICAgLy8gd2hpY2ggbmV2ZXIg
ZXhwYW5kcyBzZWxlY3Rpb24gYWNyb3NzIG11bHRpcGxlIGxpbmVzLgorICAgICAgICAgICAgLy8g
U28gd2Ugc2V0IFVQU1RSRUFNIGFmZmluaXR5IHRvIHByZXZlbnQgdG8gY3Jvc3NpbmcKKyAgICAg
ICAgICAgIC8vIGxpbmUgd2hlbiB0aGUgb2Zmc2V0IGlzIGF0IHRoZSBlbmQgb2YgbGluZS4KKyAg
ICAgICAgICAgIC8vCisgICAgICAgICAgICBwb3MgPSBlbmRGb3JQbGF0Zm9ybSgpOworICAgICAg
ICAgICAgcG9zLnNldEFmZmluaXR5KFVQU1RSRUFNKTsKKyAgICAgICAgICAgIHBvcyA9IGxvZ2lj
YWxFbmRPZkxpbmUocG9zKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFBhcmFn
cmFwaEJvdW5kYXJ5OgogICAgICAgICAgICAgcG9zID0gZW5kT2ZQYXJhZ3JhcGgoZW5kRm9yUGxh
dGZvcm0oKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50469</attachid>
            <date>2010-03-10 20:54:54 -0800</date>
            <delta_ts>2010-03-10 21:09:06 -0800</delta_ts>
            <desc>v2; spelling fix</desc>
            <filename>bug-33413-20100311135452.patch</filename>
            <type>text/plain</type>
            <size>5920</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li4yOTg1NzUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgVXBkYXRlZCByZXN1bHQg
dG8gY29ycmVjdCBleHBlY3RhdGlvbiB0aGF0IGRlc2NyaWJlZCB0aGUgd3JvbmcKKyAgICAgICAg
YmVoYXZpb3VyIGZvciB0aGUgc2VsZWN0aW9uIGV4cGFuc2lvbiB3aXRoICdsaW5lYm91bmRhcnkn
CisgICAgICAgIGdyYW51YWxpdHkuCisKIDIwMTAtMDMtMTAgIFJvbGFuZCBTdGVpbmVyICA8cm9s
YW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2
aW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2Vs
ZWN0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVu
ZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CmluZGV4IDE2MTdlMDMuLjBiMzNjZDIgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0
ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rp
b24tZXhwZWN0ZWQudHh0CkBAIC01MTQsMTQgKzUxNCwxNCBAQCBUZXN0IDIwLCBSVEw6CiAgIEV4
dGVuZGluZyBmb3J3YXJkOiAiQUJDIGFiYyBERUYiWygwLDApLCAoMCwxMSldCiAgIEV4dGVuZGlu
ZyBiYWNrd2FyZDogICJBQkMgYWJjIERFRiJbKDAsMTEpLCAoMCwwKV0KIFRlc3QgMjEsIExUUjoK
LSAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCksICgwLDE2KSwgKDAsMjYpLCAoMCwzNCksICgw
LDQyKSwgKDAsNTApLCAoMCw1OCksICgwLDY2KSwgKDAsNzQpLCAoMCw4MiksICgwLDkwKSwgKDAs
OTgpLCAoMCwxMDUpXQotICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMTA1KSwgKDAsMCldCisgIEV4dGVu
ZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnICJbKDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCksICgwLDApXQog
VGVzdCAyMSwgUlRMOgogICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw3KV0KICAgRXh0ZW5kaW5n
IGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyAiWygwLDcpLCAoMCwwKV0KIFRlc3QgMjIsIExUUjoKLSAgRXh0ZW5kaW5nIGZvcndhcmQ6
ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCww
KSwgKDAsOCksICgwLDE2KSwgKDAsMjYpLCAoMCwzNCksICgwLDQyKSwgKDAsNTApLCAoMCw1OCks
ICgwLDY2KSwgKDAsNzQpLCAoMCw4MiksICgwLDkwKSwgKDAsOTgpLCAoMCwxMDUpXQotICBFeHRl
bmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnICJbKDAsMTA1KSwgKDAsMCldCisgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgp
XQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCksICgwLDApXQogVGVzdCAyMiwgUlRMOgogICBFeHRl
bmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyAiWygwLDApLCAoMCw3KV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDcpLCAoMCwwKV0K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MGE4MTJiZS4uZmNkMzM5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wMy0xMCAgTU9SSVRBIEhhamlt
ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBTZWxlY3Rpb24ubW9kaWZ5IGV4dGVuZHMgdG9vIGZhciB3aXRoICds
aW5lYm91bmRhcnknLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MzM0MTMKKworICAgICAgICBTZWxlY3Rpb24ubW9kaWZ5KCkgd2l0aCAnbGluZWJvdW5k
YXJ5JyBndXJhbnVhbGl0eSBpbXBsaWVzIGp1c3QKKyAgICAgICAgIkdvIHRvIHRoZSBlbmQgb2Yg
dGhlIGxpbmUiLCB1bmxpa2Ugc2VsZWN0aW9uIGV4cGFuc2lvbiB3aXRoCisgICAgICAgIG90aGVy
IHR5cGUgb2YgZ3JhbnVsYXJpdGllcy4gVGhpcyBjaGFuZ2UgaGFuZGxlZCBMaW5lR3JhbnVsYXJp
dHkKKyAgICAgICAgYXMgc3BlY2lhbCBjYXNlLCB0byBsb29rLXVwIGVuZCBvZiBsaW5lIHdpdGgg
VVBTVFJFQU0gYWZmaW5pdHkuIAorICAgICAgICBEb2luZyB0aGlzIHByZXZlbnRzIGxvb2stdXAg
YWxnb3JpdGhtIHRvIGdvIG5leHQgbGluZS4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVj
dGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dAorCisgICAgICAgICogZG9tL1Bvc2l0
aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZz
ZXQpOgorICAgICAgICBIYW5kbGVkIGFuIGVkZ2UgY2FzZSBmb3Igbm9kZSBsb29rdXAgd2l0aCBV
UFNUUkVBTS4KKyAgICAgICAgKiBlZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6U2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5RXh0ZW5kaW5nRm9yd2Fy
ZCk6CisgICAgICAgIEFkZGVkIFVQU1RSRUFNIHR3ZWFrIGZvciB0aGUgY2FzZSBmb3IgTGluZUdy
YW51bGFyaXR5LgorICAgICAgICAKIDIwMTAtMDMtMTAgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5k
c3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguIEZp
eCB2YXJpYWJsZSBuYW1lIGNoYW5nZSB0aGF0IHNvbWVob3cgZGlkbid0CmRpZmYgLS1naXQgYS9X
ZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKaW5kZXgg
ZWYwYjNjMS4uZTIyZGM5ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCisr
KyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtMTA0MSw2ICsxMDQxLDkgQEAgdm9pZCBQ
b3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwgVGV4dERp
cmVjdGlvbiBwcmltYXJ5RGkKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9
CiAKKyAgICAgICAgICAgIGlmICgoY2FyZXRPZmZzZXQgPT0gY2FyZXRNYXhPZmZzZXQpIF4gKGFm
ZmluaXR5ID09IERPV05TVFJFQU0pKQorICAgICAgICAgICAgICAgIGJyZWFrOworCiAgICAgICAg
ICAgICBpZiAoKGNhcmV0T2Zmc2V0ID09IGNhcmV0TWluT2Zmc2V0KSBeIChhZmZpbml0eSA9PSBV
UFNUUkVBTSkpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv
ZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcCBiL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rp
b25Db250cm9sbGVyLmNwcAppbmRleCBjMGYwM2RlLi5mMjg1OWZkIDEwMDY0NAotLS0gYS9XZWJD
b3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9lZGl0aW5n
L1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC0zNTEsNyArMzUxLDE0IEBAIFZpc2libGVQb3Np
dGlvbiBTZWxlY3Rpb25Db250cm9sbGVyOjptb2RpZnlFeHRlbmRpbmdGb3J3YXJkKFRleHRHcmFu
dWxhcml0eSBncmFuCiAgICAgICAgICAgICBwb3MgPSBlbmRPZlNlbnRlbmNlKGVuZEZvclBsYXRm
b3JtKCkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgTGluZUJvdW5kYXJ5Ogot
ICAgICAgICAgICAgcG9zID0gbG9naWNhbEVuZE9mTGluZShlbmRGb3JQbGF0Zm9ybSgpKTsKKyAg
ICAgICAgICAgIC8vIExpbmVCb3VuZGFyeSBncmFudWxhcml0eSBhY3R1YWxseSBlbXVsYXRlcwor
ICAgICAgICAgICAgLy8gTlNUZXh0VmlldyNtb3ZlVG9SaWdodEVuZE9mTGluZUFuZE1vZGlmeVNl
bGVjdGlvbigpLAorICAgICAgICAgICAgLy8gd2hpY2ggbmV2ZXIgZXhwYW5kcyBhIHNlbGVjdGlv
biBhY3Jvc3MgbXVsdGlwbGUgbGluZXMuCisgICAgICAgICAgICAvLyBTbyB3ZSBzZXQgVVBTVFJF
QU0gYWZmaW5pdHkgdG8gcHJldmVudCBjcm9zc2luZyB0aGUKKyAgICAgICAgICAgIC8vIGxpbmUg
Ym91bmRhcnkgd2hlbiB0aGUgb2Zmc2V0IGlzIGF0IHRoZSBlbmQgb2YgdGhlIGxpbmUuCisgICAg
ICAgICAgICBwb3MgPSBlbmRGb3JQbGF0Zm9ybSgpOworICAgICAgICAgICAgcG9zLnNldEFmZmlu
aXR5KFVQU1RSRUFNKTsKKyAgICAgICAgICAgIHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUocG9zKTsK
ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFBhcmFncmFwaEJvdW5kYXJ5OgogICAg
ICAgICAgICAgcG9zID0gZW5kT2ZQYXJhZ3JhcGgoZW5kRm9yUGxhdGZvcm0oKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50470</attachid>
            <date>2010-03-10 21:09:11 -0800</date>
            <delta_ts>2010-03-11 17:57:06 -0800</delta_ts>
            <desc>v3; more misspelling fix</desc>
            <filename>bug-33413-20100311140909.patch</filename>
            <type>text/plain</type>
            <size>5922</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li5kMzBjZTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgVXBkYXRlZCByZXN1bHQg
dG8gY29ycmVjdCBleHBlY3RhdGlvbiB0aGF0IGRlc2NyaWJlZCB0aGUgd3JvbmcKKyAgICAgICAg
YmVoYXZpb3VyIGZvciB0aGUgc2VsZWN0aW9uIGV4cGFuc2lvbiB3aXRoICdsaW5lYm91bmRhcnkn
CisgICAgICAgIGdyYW51bGFyaXR5LgorCiAyMDEwLTAzLTEwICBSb2xhbmQgU3RlaW5lciAgPHJv
bGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExl
dmluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNl
bGVjdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRl
bmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dAppbmRleCAxNjE3ZTAzLi4wYjMzY2QyIDEwMDY0NAot
LS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4cGVj
dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0
aW9uLWV4cGVjdGVkLnR4dApAQCAtNTE0LDE0ICs1MTQsMTQgQEAgVGVzdCAyMCwgUlRMOgogICBF
eHRlbmRpbmcgZm9yd2FyZDogIkFCQyBhYmMgREVGIlsoMCwwKSwgKDAsMTEpXQogICBFeHRlbmRp
bmcgYmFja3dhcmQ6ICAiQUJDIGFiYyBERUYiWygwLDExKSwgKDAsMCldCiBUZXN0IDIxLCBMVFI6
Ci0gIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgpLCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAo
MCw0MiksICgwLDUwKSwgKDAsNTgpLCAoMCw2NiksICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgw
LDk4KSwgKDAsMTA1KV0KLSAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDEwNSksICgwLDApXQorICBFeHRl
bmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyAiWygwLDApLCAoMCw4KV0KKyAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0K
IFRlc3QgMjEsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGlu
ZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgIlsoMCw3KSwgKDAsMCldCiBUZXN0IDIyLCBMVFI6Ci0gIEV4dGVuZGluZyBmb3J3YXJk
OiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAs
MCksICgwLDgpLCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAoMCw0MiksICgwLDUwKSwgKDAsNTgp
LCAoMCw2NiksICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgwLDk4KSwgKDAsMTA1KV0KLSAgRXh0
ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyAiWygwLDEwNSksICgwLDApXQorICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4
KV0KKyAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0KIFRlc3QgMjIsIFJUTDoKICAgRXh0
ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgIlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCw3KSwgKDAsMCld
CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4
IDBhODEyYmUuLmFmZGE0ZjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDMtMTAgIE1PUklUQSBIYWpp
bWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRzIHRvbyBmYXIgd2l0aCAn
bGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTMzNDEzCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSgpIHdpdGggJ2xpbmVib3Vu
ZGFyeScgZ3JhbnVsYXJpdHkgaW1wbGllcyBqdXN0CisgICAgICAgICJHbyB0byB0aGUgZW5kIG9m
IHRoZSBsaW5lIiwgdW5saWtlIHNlbGVjdGlvbiBleHBhbnNpb24gd2l0aAorICAgICAgICBvdGhl
ciB0eXBlIG9mIGdyYW51bGFyaXRpZXMuIFRoaXMgY2hhbmdlIGhhbmRsZWQgTGluZUdyYW51bGFy
aXR5CisgICAgICAgIGFzIHNwZWNpYWwgY2FzZSwgdG8gbG9vay11cCBlbmQgb2YgbGluZSB3aXRo
IFVQU1RSRUFNIGFmZmluaXR5LiAKKyAgICAgICAgRG9pbmcgdGhpcyBwcmV2ZW50cyBsb29rLXVw
IGFsZ29yaXRobSB0byBnbyBuZXh0IGxpbmUuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9zZWxl
Y3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKworICAgICAgICAqIGRvbS9Qb3Np
dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zm
c2V0KToKKyAgICAgICAgSGFuZGxlZCBhbiBlZGdlIGNhc2UgZm9yIG5vZGUgbG9vay11cCB3aXRo
IFVQU1RSRUFNLgorICAgICAgICAqIGVkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpTZWxlY3Rpb25Db250cm9sbGVyOjptb2RpZnlFeHRlbmRpbmdGb3J3
YXJkKToKKyAgICAgICAgQWRkZWQgVVBTVFJFQU0gdHdlYWsgZm9yIHRoZSBjYXNlIGZvciBMaW5l
R3JhbnVsYXJpdHkuCisgICAgICAgIAogMjAxMC0wMy0xMCAgUm9sYW5kIFN0ZWluZXIgIDxyb2xh
bmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4g
Rml4IHZhcmlhYmxlIG5hbWUgY2hhbmdlIHRoYXQgc29tZWhvdyBkaWRuJ3QKZGlmZiAtLWdpdCBh
L1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAppbmRl
eCBlZjBiM2MxLi5lMjJkYzllIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAK
KysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDQxLDYgKzEwNDEsOSBAQCB2b2lk
IFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFmZmluaXR5LCBUZXh0
RGlyZWN0aW9uIHByaW1hcnlEaQogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAg
IH0KIAorICAgICAgICAgICAgaWYgKChjYXJldE9mZnNldCA9PSBjYXJldE1heE9mZnNldCkgXiAo
YWZmaW5pdHkgPT0gRE9XTlNUUkVBTSkpCisgICAgICAgICAgICAgICAgYnJlYWs7CisKICAgICAg
ICAgICAgIGlmICgoY2FyZXRPZmZzZXQgPT0gY2FyZXRNaW5PZmZzZXQpIF4gKGFmZmluaXR5ID09
IFVQU1RSRUFNKSkKICAgICAgICAgICAgICAgICBicmVhazsKIApkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9lZGl0aW5nL1NlbGVj
dGlvbkNvbnRyb2xsZXIuY3BwCmluZGV4IGMwZjAzZGUuLmYyODU5ZmQgMTAwNjQ0Ci0tLSBhL1dl
YkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2VkaXRp
bmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKQEAgLTM1MSw3ICszNTEsMTQgQEAgVmlzaWJsZVBv
c2l0aW9uIFNlbGVjdGlvbkNvbnRyb2xsZXI6Om1vZGlmeUV4dGVuZGluZ0ZvcndhcmQoVGV4dEdy
YW51bGFyaXR5IGdyYW4KICAgICAgICAgICAgIHBvcyA9IGVuZE9mU2VudGVuY2UoZW5kRm9yUGxh
dGZvcm0oKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBMaW5lQm91bmRhcnk6
Ci0gICAgICAgICAgICBwb3MgPSBsb2dpY2FsRW5kT2ZMaW5lKGVuZEZvclBsYXRmb3JtKCkpOwor
ICAgICAgICAgICAgLy8gTGluZUJvdW5kYXJ5IGdyYW51bGFyaXR5IGFjdHVhbGx5IGVtdWxhdGVz
CisgICAgICAgICAgICAvLyBOU1RleHRWaWV3I21vdmVUb1JpZ2h0RW5kT2ZMaW5lQW5kTW9kaWZ5
U2VsZWN0aW9uKCksCisgICAgICAgICAgICAvLyB3aGljaCBuZXZlciBleHBhbmRzIGEgc2VsZWN0
aW9uIGFjcm9zcyBtdWx0aXBsZSBsaW5lcy4KKyAgICAgICAgICAgIC8vIFNvIHdlIHNldCBVUFNU
UkVBTSBhZmZpbml0eSB0byBwcmV2ZW50IGNyb3NzaW5nIHRoZQorICAgICAgICAgICAgLy8gbGlu
ZSBib3VuZGFyeSB3aGVuIHRoZSBvZmZzZXQgaXMgYXQgdGhlIGVuZCBvZiB0aGUgbGluZS4KKyAg
ICAgICAgICAgIHBvcyA9IGVuZEZvclBsYXRmb3JtKCk7CisgICAgICAgICAgICBwb3Muc2V0QWZm
aW5pdHkoVVBTVFJFQU0pOworICAgICAgICAgICAgcG9zID0gbG9naWNhbEVuZE9mTGluZShwb3Mp
OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgUGFyYWdyYXBoQm91bmRhcnk6CiAg
ICAgICAgICAgICBwb3MgPSBlbmRPZlBhcmFncmFwaChlbmRGb3JQbGF0Zm9ybSgpKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50565</attachid>
            <date>2010-03-11 17:57:11 -0800</date>
            <delta_ts>2010-03-15 00:00:27 -0700</delta_ts>
            <desc>brought 2 break statements into one</desc>
            <filename>bug-33413-20100312105709.patch</filename>
            <type>text/plain</type>
            <size>6007</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li5kMzBjZTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgVXBkYXRlZCByZXN1bHQg
dG8gY29ycmVjdCBleHBlY3RhdGlvbiB0aGF0IGRlc2NyaWJlZCB0aGUgd3JvbmcKKyAgICAgICAg
YmVoYXZpb3VyIGZvciB0aGUgc2VsZWN0aW9uIGV4cGFuc2lvbiB3aXRoICdsaW5lYm91bmRhcnkn
CisgICAgICAgIGdyYW51bGFyaXR5LgorCiAyMDEwLTAzLTEwICBSb2xhbmQgU3RlaW5lciAgPHJv
bGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExl
dmluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNl
bGVjdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRl
bmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dAppbmRleCAxNjE3ZTAzLi4wYjMzY2QyIDEwMDY0NAot
LS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4cGVj
dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0
aW9uLWV4cGVjdGVkLnR4dApAQCAtNTE0LDE0ICs1MTQsMTQgQEAgVGVzdCAyMCwgUlRMOgogICBF
eHRlbmRpbmcgZm9yd2FyZDogIkFCQyBhYmMgREVGIlsoMCwwKSwgKDAsMTEpXQogICBFeHRlbmRp
bmcgYmFja3dhcmQ6ICAiQUJDIGFiYyBERUYiWygwLDExKSwgKDAsMCldCiBUZXN0IDIxLCBMVFI6
Ci0gIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgpLCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAo
MCw0MiksICgwLDUwKSwgKDAsNTgpLCAoMCw2NiksICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgw
LDk4KSwgKDAsMTA1KV0KLSAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDEwNSksICgwLDApXQorICBFeHRl
bmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyAiWygwLDApLCAoMCw4KV0KKyAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0K
IFRlc3QgMjEsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGlu
ZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgIlsoMCw3KSwgKDAsMCldCiBUZXN0IDIyLCBMVFI6Ci0gIEV4dGVuZGluZyBmb3J3YXJk
OiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAs
MCksICgwLDgpLCAoMCwxNiksICgwLDI2KSwgKDAsMzQpLCAoMCw0MiksICgwLDUwKSwgKDAsNTgp
LCAoMCw2NiksICgwLDc0KSwgKDAsODIpLCAoMCw5MCksICgwLDk4KSwgKDAsMTA1KV0KLSAgRXh0
ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyAiWygwLDEwNSksICgwLDApXQorICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4
KV0KKyAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDgpLCAoMCwwKV0KIFRlc3QgMjIsIFJUTDoKICAgRXh0
ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgIlsoMCwwKSwgKDAsNyldCiAgIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCw3KSwgKDAsMCld
CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4
IDBhODEyYmUuLmFmZGE0ZjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl
YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDMtMTAgIE1PUklUQSBIYWpp
bWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRzIHRvbyBmYXIgd2l0aCAn
bGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTMzNDEzCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSgpIHdpdGggJ2xpbmVib3Vu
ZGFyeScgZ3JhbnVsYXJpdHkgaW1wbGllcyBqdXN0CisgICAgICAgICJHbyB0byB0aGUgZW5kIG9m
IHRoZSBsaW5lIiwgdW5saWtlIHNlbGVjdGlvbiBleHBhbnNpb24gd2l0aAorICAgICAgICBvdGhl
ciB0eXBlIG9mIGdyYW51bGFyaXRpZXMuIFRoaXMgY2hhbmdlIGhhbmRsZWQgTGluZUdyYW51bGFy
aXR5CisgICAgICAgIGFzIHNwZWNpYWwgY2FzZSwgdG8gbG9vay11cCBlbmQgb2YgbGluZSB3aXRo
IFVQU1RSRUFNIGFmZmluaXR5LiAKKyAgICAgICAgRG9pbmcgdGhpcyBwcmV2ZW50cyBsb29rLXVw
IGFsZ29yaXRobSB0byBnbyBuZXh0IGxpbmUuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9zZWxl
Y3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKworICAgICAgICAqIGRvbS9Qb3Np
dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zm
c2V0KToKKyAgICAgICAgSGFuZGxlZCBhbiBlZGdlIGNhc2UgZm9yIG5vZGUgbG9vay11cCB3aXRo
IFVQU1RSRUFNLgorICAgICAgICAqIGVkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpTZWxlY3Rpb25Db250cm9sbGVyOjptb2RpZnlFeHRlbmRpbmdGb3J3
YXJkKToKKyAgICAgICAgQWRkZWQgVVBTVFJFQU0gdHdlYWsgZm9yIHRoZSBjYXNlIGZvciBMaW5l
R3JhbnVsYXJpdHkuCisgICAgICAgIAogMjAxMC0wMy0xMCAgUm9sYW5kIFN0ZWluZXIgIDxyb2xh
bmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4g
Rml4IHZhcmlhYmxlIG5hbWUgY2hhbmdlIHRoYXQgc29tZWhvdyBkaWRuJ3QKZGlmZiAtLWdpdCBh
L1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAppbmRl
eCBlZjBiM2MxLi5iNDcxYTk5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAK
KysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDQxLDcgKzEwNDEsOCBAQCB2b2lk
IFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFmZmluaXR5LCBUZXh0
RGlyZWN0aW9uIHByaW1hcnlEaQogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAg
IH0KIAotICAgICAgICAgICAgaWYgKChjYXJldE9mZnNldCA9PSBjYXJldE1pbk9mZnNldCkgXiAo
YWZmaW5pdHkgPT0gVVBTVFJFQU0pKQorICAgICAgICAgICAgaWYgKCgoY2FyZXRPZmZzZXQgPT0g
Y2FyZXRNYXhPZmZzZXQpIF4gKGFmZmluaXR5ID09IERPV05TVFJFQU0pKQorICAgICAgICAgICAg
ICAgIHx8ICgoY2FyZXRPZmZzZXQgPT0gY2FyZXRNaW5PZmZzZXQpIF4gKGFmZmluaXR5ID09IFVQ
U1RSRUFNKSkpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgIGNhbmRpZGF0
ZSA9IGJveDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVy
LmNwcCBiL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAppbmRleCBjMGYw
M2RlLi5mMjg1OWZkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJv
bGxlci5jcHAKKysrIGIvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCkBA
IC0zNTEsNyArMzUxLDE0IEBAIFZpc2libGVQb3NpdGlvbiBTZWxlY3Rpb25Db250cm9sbGVyOjpt
b2RpZnlFeHRlbmRpbmdGb3J3YXJkKFRleHRHcmFudWxhcml0eSBncmFuCiAgICAgICAgICAgICBw
b3MgPSBlbmRPZlNlbnRlbmNlKGVuZEZvclBsYXRmb3JtKCkpOwogICAgICAgICAgICAgYnJlYWs7
CiAgICAgICAgIGNhc2UgTGluZUJvdW5kYXJ5OgotICAgICAgICAgICAgcG9zID0gbG9naWNhbEVu
ZE9mTGluZShlbmRGb3JQbGF0Zm9ybSgpKTsKKyAgICAgICAgICAgIC8vIExpbmVCb3VuZGFyeSBn
cmFudWxhcml0eSBhY3R1YWxseSBlbXVsYXRlcworICAgICAgICAgICAgLy8gTlNUZXh0VmlldyNt
b3ZlVG9SaWdodEVuZE9mTGluZUFuZE1vZGlmeVNlbGVjdGlvbigpLAorICAgICAgICAgICAgLy8g
d2hpY2ggbmV2ZXIgZXhwYW5kcyBhIHNlbGVjdGlvbiBhY3Jvc3MgbXVsdGlwbGUgbGluZXMuCisg
ICAgICAgICAgICAvLyBTbyB3ZSBzZXQgVVBTVFJFQU0gYWZmaW5pdHkgdG8gcHJldmVudCBjcm9z
c2luZyB0aGUKKyAgICAgICAgICAgIC8vIGxpbmUgYm91bmRhcnkgd2hlbiB0aGUgb2Zmc2V0IGlz
IGF0IHRoZSBlbmQgb2YgdGhlIGxpbmUuCisgICAgICAgICAgICBwb3MgPSBlbmRGb3JQbGF0Zm9y
bSgpOworICAgICAgICAgICAgcG9zLnNldEFmZmluaXR5KFVQU1RSRUFNKTsKKyAgICAgICAgICAg
IHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUocG9zKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg
ICBjYXNlIFBhcmFncmFwaEJvdW5kYXJ5OgogICAgICAgICAgICAgcG9zID0gZW5kT2ZQYXJhZ3Jh
cGgoZW5kRm9yUGxhdGZvcm0oKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50687</attachid>
            <date>2010-03-15 00:00:34 -0700</date>
            <delta_ts>2010-03-15 01:41:57 -0700</delta_ts>
            <desc>clenaup comment, update windows result</desc>
            <filename>bug-33413-20100315160032.patch</filename>
            <type>text/plain</type>
            <size>8356</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li4xMDM5MmYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v
ZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQ6IAorICAgICAg
ICBVcGRhdGVkIHJlc3VsdCB0byBjb3JyZWN0IGV4cGVjdGF0aW9uIHRoYXQgZGVzY3JpYmVkIHRo
ZSB3cm9uZworICAgICAgICBiZWhhdmlvdXIgZm9yIHRoZSBzZWxlY3Rpb24gZXhwYW5zaW9uIHdp
dGggJ2xpbmVib3VuZGFyeScKKyAgICAgICAgZ3JhbnVsYXJpdHkuCisgICAgICAgIAogMjAxMC0w
My0xMCAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Vk
aXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKaW5kZXgg
MTYxN2UwMy4uMGIzM2NkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp
b24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGlu
Zy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKQEAgLTUxNCwxNCArNTE0
LDE0IEBAIFRlc3QgMjAsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJBQkMgYWJjIERFRiJb
KDAsMCksICgwLDExKV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgIkFCQyBhYmMgREVGIlsoMCwx
MSksICgwLDApXQogVGVzdCAyMSwgTFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwg
KDAsMTYpLCAoMCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAo
MCw3NCksICgwLDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNr
d2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
IlsoMCwxMDUpLCAoMCwwKV0KKyAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCldCisgIEV4dGVu
ZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgIlsoMCw4KSwgKDAsMCldCiBUZXN0IDIxLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3
YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJb
KDAsMCksICgwLDcpXQogICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQogVGVzdCAyMiwg
TFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAoMCwyNiksICgwLDM0
KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgwLDgyKSwgKDAsOTAp
LCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUpLCAoMCwwKV0KKyAg
RXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCldCisgIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCw4KSwgKDAs
MCldCiBUZXN0IDIyLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQogICBFeHRl
bmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rp
b24tZXhwZWN0ZWQudHh0CmluZGV4IDVlNTc4NDMuLmU1ZjNiYzEgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL3BsYXRmb3JtL3dpbi9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4
cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZWRpdGluZy9zZWxlY3Rp
b24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKQEAgLTUxNCwxNCArNTE0LDE0IEBAIFRl
c3QgMjAsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJBQkMgYWJjIERFRiJbKDAsMCksICgw
LDExKV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgIkFCQyBhYmMgREVGIlsoMCwxMSksICgwLDAp
XQogVGVzdCAyMSwgTFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAo
MCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgw
LDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUp
LCAoMCw5OCldCisgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFj
a3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
ICJbKDAsOCldCiBUZXN0IDIxLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQog
ICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQogVGVzdCAyMiwgTFRSOgotICBFeHRlbmRp
bmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAoMCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1
MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgwLDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEw
NSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUpLCAoMCw5OCldCisgIEV4dGVuZGluZyBmb3J3
YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJb
KDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCldCiBUZXN0IDIyLCBSVEw6CiAg
IEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQogICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgw
LDApXQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp
bmRleCAwYTgxMmJlLi5hZmRhNGY1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg
Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEwLTAzLTEwICBNT1JJVEEg
SGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFNlbGVjdGlvbi5tb2RpZnkgZXh0ZW5kcyB0b28gZmFyIHdp
dGggJ2xpbmVib3VuZGFyeScuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0zMzQxMworCisgICAgICAgIFNlbGVjdGlvbi5tb2RpZnkoKSB3aXRoICdsaW5l
Ym91bmRhcnknIGdyYW51bGFyaXR5IGltcGxpZXMganVzdAorICAgICAgICAiR28gdG8gdGhlIGVu
ZCBvZiB0aGUgbGluZSIsIHVubGlrZSBzZWxlY3Rpb24gZXhwYW5zaW9uIHdpdGgKKyAgICAgICAg
b3RoZXIgdHlwZSBvZiBncmFudWxhcml0aWVzLiBUaGlzIGNoYW5nZSBoYW5kbGVkIExpbmVHcmFu
dWxhcml0eQorICAgICAgICBhcyBzcGVjaWFsIGNhc2UsIHRvIGxvb2stdXAgZW5kIG9mIGxpbmUg
d2l0aCBVUFNUUkVBTSBhZmZpbml0eS4gCisgICAgICAgIERvaW5nIHRoaXMgcHJldmVudHMgbG9v
ay11cCBhbGdvcml0aG0gdG8gZ28gbmV4dCBsaW5lLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv
c2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CisKKyAgICAgICAgKiBkb20v
UG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmdldElubGluZUJveEFu
ZE9mZnNldCk6CisgICAgICAgIEhhbmRsZWQgYW4gZWRnZSBjYXNlIGZvciBub2RlIGxvb2stdXAg
d2l0aCBVUFNUUkVBTS4KKyAgICAgICAgKiBlZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5RXh0ZW5kaW5n
Rm9yd2FyZCk6CisgICAgICAgIEFkZGVkIFVQU1RSRUFNIHR3ZWFrIGZvciB0aGUgY2FzZSBmb3Ig
TGluZUdyYW51bGFyaXR5LgorICAgICAgICAKIDIwMTAtMDMtMTAgIFJvbGFuZCBTdGVpbmVyICA8
cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm
aXguIEZpeCB2YXJpYWJsZSBuYW1lIGNoYW5nZSB0aGF0IHNvbWVob3cgZGlkbid0CmRpZmYgLS1n
aXQgYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAK
aW5kZXggZWYwYjNjMS4uYjQ3MWE5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUG9zaXRpb24u
Y3BwCisrKyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtMTA0MSw3ICsxMDQxLDggQEAg
dm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwg
VGV4dERpcmVjdGlvbiBwcmltYXJ5RGkKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg
ICAgICB9CiAKLSAgICAgICAgICAgIGlmICgoY2FyZXRPZmZzZXQgPT0gY2FyZXRNaW5PZmZzZXQp
IF4gKGFmZmluaXR5ID09IFVQU1RSRUFNKSkKKyAgICAgICAgICAgIGlmICgoKGNhcmV0T2Zmc2V0
ID09IGNhcmV0TWF4T2Zmc2V0KSBeIChhZmZpbml0eSA9PSBET1dOU1RSRUFNKSkKKyAgICAgICAg
ICAgICAgICB8fCAoKGNhcmV0T2Zmc2V0ID09IGNhcmV0TWluT2Zmc2V0KSBeIChhZmZpbml0eSA9
PSBVUFNUUkVBTSkpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgICAgICBjYW5k
aWRhdGUgPSBib3g7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJv
bGxlci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKaW5kZXgg
YzBmMDNkZS4uZWMzMGQxZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNv
bnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNw
cApAQCAtMzUxLDcgKzM1MSwxMSBAQCBWaXNpYmxlUG9zaXRpb24gU2VsZWN0aW9uQ29udHJvbGxl
cjo6bW9kaWZ5RXh0ZW5kaW5nRm9yd2FyZChUZXh0R3JhbnVsYXJpdHkgZ3JhbgogICAgICAgICAg
ICAgcG9zID0gZW5kT2ZTZW50ZW5jZShlbmRGb3JQbGF0Zm9ybSgpKTsKICAgICAgICAgICAgIGJy
ZWFrOwogICAgICAgICBjYXNlIExpbmVCb3VuZGFyeToKLSAgICAgICAgICAgIHBvcyA9IGxvZ2lj
YWxFbmRPZkxpbmUoZW5kRm9yUGxhdGZvcm0oKSk7CisgICAgICAgICAgICAvLyBMaW5lQm91bmRh
cnkgZ3JhbnVsYXJpdHkgZW11bGF0ZXMKKyAgICAgICAgICAgIC8vIFtOU1RleHRWaWV3IG1vdmVU
b1JpZ2h0RW5kT2ZMaW5lQW5kTW9kaWZ5U2VsZWN0aW9uOl0uCisgICAgICAgICAgICBwb3MgPSBl
bmRGb3JQbGF0Zm9ybSgpOworICAgICAgICAgICAgcG9zLnNldEFmZmluaXR5KFVQU1RSRUFNKTsK
KyAgICAgICAgICAgIHBvcyA9IGxvZ2ljYWxFbmRPZkxpbmUocG9zKTsKICAgICAgICAgICAgIGJy
ZWFrOwogICAgICAgICBjYXNlIFBhcmFncmFwaEJvdW5kYXJ5OgogICAgICAgICAgICAgcG9zID0g
ZW5kT2ZQYXJhZ3JhcGgoZW5kRm9yUGxhdGZvcm0oKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50692</attachid>
            <date>2010-03-15 01:42:03 -0700</date>
            <delta_ts>2010-03-15 02:10:06 -0700</delta_ts>
            <desc>remove redundant comment</desc>
            <filename>bug-33413-20100315174201.patch</filename>
            <type>text/plain</type>
            <size>8235</size>
            <attacher name="Hajime Morrita">morrita</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5ZDQ3Mjg5Li4xMDM5MmYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt
MTAgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VsZWN0aW9uLm1vZGlmeSBleHRlbmRz
IHRvbyBmYXIgd2l0aCAnbGluZWJvdW5kYXJ5Jy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDEzCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlv
bi9leHRlbmQtc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4v
ZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQ6IAorICAgICAg
ICBVcGRhdGVkIHJlc3VsdCB0byBjb3JyZWN0IGV4cGVjdGF0aW9uIHRoYXQgZGVzY3JpYmVkIHRo
ZSB3cm9uZworICAgICAgICBiZWhhdmlvdXIgZm9yIHRoZSBzZWxlY3Rpb24gZXhwYW5zaW9uIHdp
dGggJ2xpbmVib3VuZGFyeScKKyAgICAgICAgZ3JhbnVsYXJpdHkuCisgICAgICAgIAogMjAxMC0w
My0xMCAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Vk
aXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKaW5kZXgg
MTYxN2UwMy4uMGIzM2NkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rp
b24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGlu
Zy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKQEAgLTUxNCwxNCArNTE0
LDE0IEBAIFRlc3QgMjAsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJBQkMgYWJjIERFRiJb
KDAsMCksICgwLDExKV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgIkFCQyBhYmMgREVGIlsoMCwx
MSksICgwLDApXQogVGVzdCAyMSwgTFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwg
KDAsMTYpLCAoMCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAo
MCw3NCksICgwLDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNr
d2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
IlsoMCwxMDUpLCAoMCwwKV0KKyAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCldCisgIEV4dGVu
ZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgIlsoMCw4KSwgKDAsMCldCiBUZXN0IDIxLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3
YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJb
KDAsMCksICgwLDcpXQogICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQogVGVzdCAyMiwg
TFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAoMCwyNiksICgwLDM0
KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgwLDgyKSwgKDAsOTAp
LCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUpLCAoMCwwKV0KKyAg
RXh0ZW5kaW5nIGZvcndhcmQ6ICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNk
ZWZnIGFiY2RlZmcgIlsoMCwwKSwgKDAsOCldCisgIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNk
ZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCw4KSwgKDAs
MCldCiBUZXN0IDIyLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQogICBFeHRl
bmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2Rl
ZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv
cm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rp
b24tZXhwZWN0ZWQudHh0CmluZGV4IDVlNTc4NDMuLmU1ZjNiYzEgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL3BsYXRmb3JtL3dpbi9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWV4
cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZWRpdGluZy9zZWxlY3Rp
b24vZXh0ZW5kLXNlbGVjdGlvbi1leHBlY3RlZC50eHQKQEAgLTUxNCwxNCArNTE0LDE0IEBAIFRl
c3QgMjAsIFJUTDoKICAgRXh0ZW5kaW5nIGZvcndhcmQ6ICJBQkMgYWJjIERFRiJbKDAsMCksICgw
LDExKV0KICAgRXh0ZW5kaW5nIGJhY2t3YXJkOiAgIkFCQyBhYmMgREVGIlsoMCwxMSksICgwLDAp
XQogVGVzdCAyMSwgTFRSOgotICBFeHRlbmRpbmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAo
MCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgw
LDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEwNSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUp
LCAoMCw5OCldCisgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFj
a3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVm
ZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZn
ICJbKDAsOCldCiBUZXN0IDIxLCBSVEw6CiAgIEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQog
ICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZn
IGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcg
YWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgwLDApXQogVGVzdCAyMiwgTFRSOgotICBFeHRlbmRp
bmcgZm9yd2FyZDogImFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGEgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyAiWygwLDApLCAoMCw4KSwgKDAsMTYpLCAoMCwyNiksICgwLDM0KSwgKDAsNDIpLCAoMCw1
MCksICgwLDU4KSwgKDAsNjYpLCAoMCw3NCksICgwLDgyKSwgKDAsOTApLCAoMCw5OCksICgwLDEw
NSldCi0gIEV4dGVuZGluZyBiYWNrd2FyZDogICJhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgIlsoMCwxMDUpLCAoMCw5OCldCisgIEV4dGVuZGluZyBmb3J3
YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJb
KDAsMCksICgwLDgpXQorICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBh
YmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsOCldCiBUZXN0IDIyLCBSVEw6CiAg
IEV4dGVuZGluZyBmb3J3YXJkOiAiYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJj
ZGVmZyBhYmNkZWZnICJbKDAsMCksICgwLDcpXQogICBFeHRlbmRpbmcgYmFja3dhcmQ6ICAiYWJj
ZGVmZyBhYmNkZWZnIGFiY2RlZmcgYSBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFi
Y2RlZmcgYWJjZGVmZyBhYmNkZWZnIGFiY2RlZmcgYWJjZGVmZyBhYmNkZWZnICJbKDAsNyksICgw
LDApXQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp
bmRleCAwYTgxMmJlLi5hZmRhNGY1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg
Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEwLTAzLTEwICBNT1JJVEEg
SGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFNlbGVjdGlvbi5tb2RpZnkgZXh0ZW5kcyB0b28gZmFyIHdp
dGggJ2xpbmVib3VuZGFyeScuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0zMzQxMworCisgICAgICAgIFNlbGVjdGlvbi5tb2RpZnkoKSB3aXRoICdsaW5l
Ym91bmRhcnknIGdyYW51bGFyaXR5IGltcGxpZXMganVzdAorICAgICAgICAiR28gdG8gdGhlIGVu
ZCBvZiB0aGUgbGluZSIsIHVubGlrZSBzZWxlY3Rpb24gZXhwYW5zaW9uIHdpdGgKKyAgICAgICAg
b3RoZXIgdHlwZSBvZiBncmFudWxhcml0aWVzLiBUaGlzIGNoYW5nZSBoYW5kbGVkIExpbmVHcmFu
dWxhcml0eQorICAgICAgICBhcyBzcGVjaWFsIGNhc2UsIHRvIGxvb2stdXAgZW5kIG9mIGxpbmUg
d2l0aCBVUFNUUkVBTSBhZmZpbml0eS4gCisgICAgICAgIERvaW5nIHRoaXMgcHJldmVudHMgbG9v
ay11cCBhbGdvcml0aG0gdG8gZ28gbmV4dCBsaW5lLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcv
c2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CisKKyAgICAgICAgKiBkb20v
UG9zaXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmdldElubGluZUJveEFu
ZE9mZnNldCk6CisgICAgICAgIEhhbmRsZWQgYW4gZWRnZSBjYXNlIGZvciBub2RlIGxvb2stdXAg
d2l0aCBVUFNUUkVBTS4KKyAgICAgICAgKiBlZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0aW9uQ29udHJvbGxlcjo6bW9kaWZ5RXh0ZW5kaW5n
Rm9yd2FyZCk6CisgICAgICAgIEFkZGVkIFVQU1RSRUFNIHR3ZWFrIGZvciB0aGUgY2FzZSBmb3Ig
TGluZUdyYW51bGFyaXR5LgorICAgICAgICAKIDIwMTAtMDMtMTAgIFJvbGFuZCBTdGVpbmVyICA8
cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBm
aXguIEZpeCB2YXJpYWJsZSBuYW1lIGNoYW5nZSB0aGF0IHNvbWVob3cgZGlkbid0CmRpZmYgLS1n
aXQgYS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAK
aW5kZXggZWYwYjNjMS4uYjQ3MWE5OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vUG9zaXRpb24u
Y3BwCisrKyBiL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtMTA0MSw3ICsxMDQxLDggQEAg
dm9pZCBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZmZpbml0eSBhZmZpbml0eSwg
VGV4dERpcmVjdGlvbiBwcmltYXJ5RGkKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg
ICAgICB9CiAKLSAgICAgICAgICAgIGlmICgoY2FyZXRPZmZzZXQgPT0gY2FyZXRNaW5PZmZzZXQp
IF4gKGFmZmluaXR5ID09IFVQU1RSRUFNKSkKKyAgICAgICAgICAgIGlmICgoKGNhcmV0T2Zmc2V0
ID09IGNhcmV0TWF4T2Zmc2V0KSBeIChhZmZpbml0eSA9PSBET1dOU1RSRUFNKSkKKyAgICAgICAg
ICAgICAgICB8fCAoKGNhcmV0T2Zmc2V0ID09IGNhcmV0TWluT2Zmc2V0KSBeIChhZmZpbml0eSA9
PSBVUFNUUkVBTSkpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgICAgICBjYW5k
aWRhdGUgPSBib3g7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJv
bGxlci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKaW5kZXgg
YzBmMDNkZS4uMzhhNmU3YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNv
bnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNw
cApAQCAtMzUxLDcgKzM1MSw5IEBAIFZpc2libGVQb3NpdGlvbiBTZWxlY3Rpb25Db250cm9sbGVy
Ojptb2RpZnlFeHRlbmRpbmdGb3J3YXJkKFRleHRHcmFudWxhcml0eSBncmFuCiAgICAgICAgICAg
ICBwb3MgPSBlbmRPZlNlbnRlbmNlKGVuZEZvclBsYXRmb3JtKCkpOwogICAgICAgICAgICAgYnJl
YWs7CiAgICAgICAgIGNhc2UgTGluZUJvdW5kYXJ5OgotICAgICAgICAgICAgcG9zID0gbG9naWNh
bEVuZE9mTGluZShlbmRGb3JQbGF0Zm9ybSgpKTsKKyAgICAgICAgICAgIHBvcyA9IGVuZEZvclBs
YXRmb3JtKCk7CisgICAgICAgICAgICBwb3Muc2V0QWZmaW5pdHkoVVBTVFJFQU0pOworICAgICAg
ICAgICAgcG9zID0gbG9naWNhbEVuZE9mTGluZShwb3MpOwogICAgICAgICAgICAgYnJlYWs7CiAg
ICAgICAgIGNhc2UgUGFyYWdyYXBoQm91bmRhcnk6CiAgICAgICAgICAgICBwb3MgPSBlbmRPZlBh
cmFncmFwaChlbmRGb3JQbGF0Zm9ybSgpKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>