33356 2010-01-07 17:06:52 -0800 style-queue should not complain about identifier names with underscores under WebKit/gtk/webkit/ 2010-01-21 11:54:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 gustavo webkit-unassigned cjerdonek commit-queue gustavo hamaji levin mjs oldest_to_newest 178452 0 gustavo 2010-01-07 17:06:52 -0800 Our APIs use GTK+ style naming, so we need to use lower-cased, _-separated names there. An example of this happenning: https://bugs.webkit.org/show_bug.cgi?id=32819#c4 181637 1 46765 abarth 2010-01-17 15:56:29 -0800 Created attachment 46765 Patch 181651 2 46771 abarth 2010-01-17 16:44:23 -0800 Created attachment 46771 Patch 182327 3 levin 2010-01-19 11:06:09 -0800 Looks fine to me, but I'd prefer Hamaji to review (and Chris to comment if he wishes), since they have been a huge amount on this (and there may be a better way that they put in place). 182576 4 cjerdonek 2010-01-19 19:14:19 -0800 I would prefer to keep filename-specific logic out of cpp_style.py, and to do something like this as a configuration in checker.py. I made a bug report about this last week here: https://bugs.webkit.org/show_bug.cgi?id=33684 But because that enhancement isn't implemented yet, I think it's fine for now. I'll go ahead and make a note in that report that this is another use-case for directory-specific exemptions from particular rules. When that's implemented, this change can be refactored. 183267 5 46771 commit-queue 2010-01-21 11:54:24 -0800 Comment on attachment 46771 Patch Clearing flags on attachment: 46771 Committed r53636: <http://trac.webkit.org/changeset/53636> 183268 6 commit-queue 2010-01-21 11:54:30 -0800 All reviewed patches have been landed. Closing bug. 46765 2010-01-17 15:56:29 -0800 2010-01-17 16:44:19 -0800 Patch bug-33356-20100117155627.patch text/plain 2655 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzczKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbc3R5bGUtcXVldWVdIHNob3VsZCBub3QgY29tcGxhaW4gYWJvdXQgaWRlbnRpZmll ciBuYW1lcyB3aXRoIHVuZGVyc2NvcmVzIHVuZGVyIFdlYktpdC9ndGsvd2Via2l0LworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzNTYKKworICAgICAg ICBXaGl0ZSBsaXN0IHVuaXhfaGFja2VyX3N0eWxlIG5hbWVzIGluIFdlYktpdC9ndGsvd2Via2l0 IGJlY2F1c2UgdGhlc2UKKyAgICAgICAgYXJlIHVzZWQgaW4gdGhlIEdUSysgQVBJLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jcHBfc3R5bGUucHk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jcHBfc3R5bGVfdW5pdHRlc3QucHk6CisKIDIwMTAtMDEtMTUg IEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBnZXRfYWNj UGFyZW50IHNob3VsZCB0cnkgdG8gcmV0cmlldmUgcGFyZW50IEFjY2Vzc2liaWxpdHlPYmplY3Qs IGJlZm9yZQpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jcHBfc3R5 bGUucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j cHBfc3R5bGUucHkJKHJldmlzaW9uIDUzMzcyKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jcHBfc3R5bGUucHkJKHdvcmtpbmcgY29weSkKQEAgLTI0OTAsNiArMjQ5MCw3 IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24KICAgICAgICAgaWYg bW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCdfJykgPj0gMDoKICAgICAgICAgICAgICMgVmFyaW91 cyBleGNlcHRpb25zIHRvIHRoZSBydWxlOiBKYXZhU2NyaXB0IG9wIGNvZGVzIGZ1bmN0aW9ucywg Y29uc3RfaXRlcmF0b3IuCiAgICAgICAgICAgICBpZiAobm90IChmaWxlbmFtZS5maW5kKCdKYXZh U2NyaXB0Q29yZScpID49IDAgYW5kIG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnX29wXycpID49 IDApCisgICAgICAgICAgICAgICAgYW5kIG5vdCBmaWxlbmFtZS5maW5kKCdndGsvd2Via2l0Jykg Pj0gMAogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3 aXRoKCd0c3RfJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIg PT0gImNvbnN0X2l0ZXJhdG9yIik6CiAgICAgICAgICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxp bmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5j b3JyZWN0bHkgbmFtZWQuIERvbid0IHVzZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIg bmFtZXMuIikKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0 eWxlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM3MikKKysrIFdlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0zNTQ0LDYgKzM1NDQsOSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgdGhpc19vcF9j b2RlKGludCB2YXIxLCBpbnQgdmFyMiknLCAnJywgJ0phdmFTY3JpcHRDb3JlL2Zvby5jcHAnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRoaXNfb3BfY29kZShpbnQgdmFyMSwgaW50 IHZhcjIpJywgJ3RoaXNfb3BfY29kZScgKyBuYW1lX2Vycm9yX21lc3NhZ2UpCiAKKyAgICAgICAg IyBUaGUgR1RLKyBBUElzIHVzZSBHVEsrIG5hbWluZyBzdHlsZSwgd2hpY2ggaW5jbHVkZXMgbG93 ZXItY2FzZWQsIF8tc2VwYXJhdGVkIHZhbHVlcy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn dm9pZCB0aGlzX2lzX2FfZ3RrX3N0eWxlX25hbWUoaW50IHZhcjEsIGludCB2YXIyKScsICcnLCAn V2ViS2l0L2d0ay93ZWJraXQvZm9vLmNwcCcpCisKICAgICAgICAgIyBUaGVyZSBpcyBhbiBleGNl cHRpb24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0IGJlZ2luIHdpdGggInRzdF8iLgogICAgICAg ICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9RV2ViRnJhbWU6OmFycmF5T2JqZWN0RW51bWVy YWJsZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAK 46771 2010-01-17 16:44:23 -0800 2010-01-21 11:54:24 -0800 Patch bug-33356-20100117164421.patch text/plain 2610 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzc4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbc3R5bGUtcXVldWVdIHNob3VsZCBub3QgY29tcGxhaW4gYWJvdXQgaWRlbnRpZmll ciBuYW1lcyB3aXRoIHVuZGVyc2NvcmVzIHVuZGVyIFdlYktpdC9ndGsvd2Via2l0LworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzNTYKKworICAgICAg ICBXaGl0ZSBsaXN0IHVuaXhfaGFja2VyX3N0eWxlIG5hbWVzIGluIFdlYktpdC9ndGsvd2Via2l0 IGJlY2F1c2UgdGhlc2UKKyAgICAgICAgYXJlIHVzZWQgaW4gdGhlIEdUSysgQVBJLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jcHBfc3R5bGUucHk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jcHBfc3R5bGVfdW5pdHRlc3QucHk6CisKIDIwMTAtMDEtMTcg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3Bw X3N0eWxlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY3BwX3N0eWxlLnB5CShyZXZpc2lvbiA1MzM3OCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNDc2LDYgKzI0 NzYsNyBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uCiAgICAgICAg IGlmIG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnXycpID49IDA6CiAgICAgICAgICAgICAjIFZh cmlvdXMgZXhjZXB0aW9ucyB0byB0aGUgcnVsZTogSmF2YVNjcmlwdCBvcCBjb2RlcyBmdW5jdGlv bnMsIGNvbnN0X2l0ZXJhdG9yLgogICAgICAgICAgICAgaWYgKG5vdCAoZmlsZW5hbWUuZmluZCgn SmF2YVNjcmlwdENvcmUnKSA+PSAwIGFuZCBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJ19vcF8n KSA+PSAwKQorICAgICAgICAgICAgICAgIGFuZCBub3QgZmlsZW5hbWUuZmluZCgnV2ViS2l0L2d0 ay93ZWJraXQvJykgPj0gMAogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRp Zmllci5zdGFydHN3aXRoKCd0c3RfJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVk X2lkZW50aWZpZXIgPT0gImNvbnN0X2l0ZXJhdG9yIik6CiAgICAgICAgICAgICAgICAgZXJyb3Io ZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nJywgNCwgaWRlbnRpZmll ciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVzZSB1bmRlcnNjb3JlcyBpbiB5b3Vy IGlkZW50aWZpZXIgbmFtZXMuIikKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM3 OCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0 ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNTM0LDYgKzM1MzQsOSBAQCBjbGFzcyBXZWJLaXRT dHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3Zv aWQgdGhpc19vcF9jb2RlKGludCB2YXIxLCBpbnQgdmFyMiknLCAnJywgJ0phdmFTY3JpcHRDb3Jl L2Zvby5jcHAnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRoaXNfb3BfY29kZShp bnQgdmFyMSwgaW50IHZhcjIpJywgJ3RoaXNfb3BfY29kZScgKyBuYW1lX2Vycm9yX21lc3NhZ2Up CiAKKyAgICAgICAgIyBUaGUgR1RLKyBBUElzIHVzZSBHVEsrIG5hbWluZyBzdHlsZSwgd2hpY2gg aW5jbHVkZXMgbG93ZXItY2FzZWQsIF8tc2VwYXJhdGVkIHZhbHVlcy4KKyAgICAgICAgc2VsZi5h c3NlcnRfbGludCgndm9pZCB0aGlzX2lzX2FfZ3RrX3N0eWxlX25hbWUoaW50IHZhcjEsIGludCB2 YXIyKScsICcnLCAnV2ViS2l0L2d0ay93ZWJraXQvZm9vLmNwcCcpCisKICAgICAgICAgIyBUaGVy ZSBpcyBhbiBleGNlcHRpb24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0IGJlZ2luIHdpdGggInRz dF8iLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9RV2ViRnJhbWU6OmFycmF5 T2JqZWN0RW51bWVyYWJsZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAK