33295 2010-01-06 20:39:45 -0800 Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red) 2010-04-18 10:44:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 35311 28041 33027 33294 33342 33445 33457 33458 33472 33497 33544 33556 33296 33377 1 eric webkit-unassigned abarth commit-queue gustavo xan.lopez oldest_to_newest 177954 0 eric 2010-01-06 20:39:45 -0800 Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red) The "core builders" are also the builders that will cause bugzilla-tool land-diff (and related commands) to abort a commit unless the user passes --ignore-builders. http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/buildbot.py#L47 It will probably be awhile before the Gtk bots are regularly stable enough for us to do this, but at least having this bug gives me a place to relate flakey test bugs to, and gives the Gtk folks something to shoot for. 213475 1 eric 2010-04-16 16:14:48 -0700 I think it's time to try adding the Gtk bots to the core builders. Someone just needs to write the patch. See http://trac.webkit.org/changeset/57561 for an example from adding Qt. I'll write it next week if no one beats me to it. 213750 2 53627 eric 2010-04-18 05:14:44 -0700 Created attachment 53627 Patch 213751 3 53627 eric 2010-04-18 05:15:33 -0700 Comment on attachment 53627 Patch I expect there is still some de-flaking to do for the Gtk bots. We can flip some of the bots back to non-core if they prove too flaky or folks aren't maintaining them. 213778 4 53627 abarth 2010-04-18 10:28:01 -0700 Comment on attachment 53627 Patch That's exciting 213780 5 53627 commit-queue 2010-04-18 10:43:58 -0700 Comment on attachment 53627 Patch Clearing flags on attachment: 53627 Committed r57795: <http://trac.webkit.org/changeset/57795> 213781 6 commit-queue 2010-04-18 10:44:05 -0700 All reviewed patches have been landed. Closing bug. 53627 2010-04-18 05:14:44 -0700 2010-04-18 10:43:58 -0700 Patch bug-33295-20100418051443.patch text/plain 2433 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjZjY1MTI2Li4wMDc1OWQ1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQt MTggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBHdGsgYm90cyB0byB0aGUgbGlzdCBvZiAi Y29yZSBidWlsZGVycyIgKGJ1aWxkZXJzIHdoaWNoIHN0b3AgdGhlIGNvbW1pdC1xdWV1ZSB3aGVu IHRoZXkgdHVybiByZWQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMzI5NQorCisgICAgICAgIFRoZSBHdGsgYnVpbGRlcnMgaGF2ZSBiZWVuIGdyZWVu IGV2ZXJ5IHRpbWUgSSd2ZSBsb29rZWQKKyAgICAgICAgYXQgdGhlbSBpbiB0aGUgbGFzdCA1IGRh eXMgb3Igc28uICBJdCB3b3VsZCBhcHBlYXIgd2Via2l0CisgICAgICAgIGlzIG5vdyBrZWVwaW5n IHRoZW0gZ3JlZW4gYW5kIHdlIHNob3VsZCB1cGRhdGUgdGhlIGNvcmUKKyAgICAgICAgYnVpbGRl ciBsaXN0IHRvIG1hdGNoIHJlYWxpdHkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvYnVpbGRib3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1aWxkYm90X3VuaXR0ZXN0LnB5OgorCiAyMDEwLTA0LTE4ICBSb2JlcnQgSG9nYW4gIDxy b2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWls ZGJvdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJv dC5weQppbmRleCBiZTg3ODliLi5hMGI3YmRmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90LnB5CkBAIC0zMTgsNiArMzE4LDcgQEAg Y2xhc3MgQnVpbGRCb3Qob2JqZWN0KToKICAgICAgICAgICAgICJUaWdlciIsCiAgICAgICAgICAg ICAiV2luZG93cy4qQnVpbGQiLAogICAgICAgICAgICAgIldpbmRvd3MuKkRlYnVnLipUZXN0IiwK KyAgICAgICAgICAgICJHVEsiLAogICAgICAgICAgICAgIlF0IiwKICAgICAgICAgICAgICJDaHJv bWl1bSIsCiAgICAgICAgIF0KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9idWlsZGJvdF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdF91bml0dGVzdC5weQppbmRleCBhZjkzYmViLi5m NzY1ZjZlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3RfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1aWxkYm90X3VuaXR0ZXN0LnB5CkBAIC0yNzIsNiArMjcyLDcgQEAgY2xh c3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICJUaWdlciIs CiAgICAgICAgICAgICAiV2luZG93cy4qQnVpbGQiLAogICAgICAgICAgICAgIldpbmRvd3MuKkRl YnVnLipUZXN0IiwKKyAgICAgICAgICAgICJHVEsiLAogICAgICAgICAgICAgIlF0IiwKICAgICAg ICAgICAgICJDaHJvbWl1bSIsCiAgICAgICAgIF0KQEAgLTI4Niw2ICsyODcsMTAgQEAgY2xhc3Mg QnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgIHsnbmFtZSc6IHUn V2luZG93cyBSZWxlYXNlIChCdWlsZCknLCB9LAogICAgICAgICAgICAgeyduYW1lJzogdSdXaW5k b3dzIERlYnVnIChCdWlsZCknLCB9LAogICAgICAgICAgICAgeyduYW1lJzogdSdXaW5kb3dzIERl YnVnIChUZXN0cyknLCB9LAorICAgICAgICAgICAgeyduYW1lJzogdSdHVEsgTGludXggMzItYml0 IFJlbGVhc2UnLCB9LAorICAgICAgICAgICAgeyduYW1lJzogdSdHVEsgTGludXggMzItYml0IERl YnVnJywgfSwKKyAgICAgICAgICAgIHsnbmFtZSc6IHUnR1RLIExpbnV4IDY0LWJpdCBEZWJ1Zycs IH0sCisgICAgICAgICAgICB7J25hbWUnOiB1J0dUSyBMaW51eCA2NC1iaXQgUmVsZWFzZScsIH0s CiAgICAgICAgICAgICB7J25hbWUnOiB1J1F0IExpbnV4IFJlbGVhc2UnLCB9LAogICAgICAgICAg ICAgeyduYW1lJzogdSdRdCBMaW51eCBSZWxlYXNlIG1pbmltYWwnLCB9LAogICAgICAgICAgICAg eyduYW1lJzogdSdRdCBMaW51eCBBUk12NSBSZWxlYXNlJywgfSwK