33256 2010-01-06 09:33:48 -0800 REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot 2010-01-29 13:56:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 33279 P1 Normal --- 1 eric webkit-unassigned abecsi ap aroben atwilson levin mrowe ojan ukai webkit.review.bot oldest_to_newest 177615 0 eric 2010-01-06 09:33:48 -0800 REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot The buildbot seems to think that r52854 was at fault, but I don't believe it: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52854%20(9006)/results.html http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52854%20(9007)/results.html http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52854%20(9008)/results.html http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52854%20(9009)/results.html Maybe the builds are failing to update on the test machine? 177616 1 eric 2010-01-06 09:35:03 -0800 CCing Mark in case he knows of something going wrong with the bots. 177618 2 eric 2010-01-06 09:36:16 -0800 Andrew added the test 4 months ago. 177637 3 levin 2010-01-06 10:35:06 -0800 It looks like it only happens on release builds. It happens for shared-worker-constructor.html on leopard and dedicated-worker-constructor.html on snow leopard -- both release builds. I'll see if I can repro this. 177639 4 atwilson 2010-01-06 10:37:55 -0800 I'm guessing that the console error triggering this (Unexpected response code:HTML) is coming from the *previous* test (websocket-event-target.html). (dedicated-worker-lifecycle.html is disabled on leopard which is why we get the error on different tests on different builds). 177640 5 eric 2010-01-06 10:42:03 -0800 http://trac.webkit.org/changeset/49488 added websocket-event-target.html (3 months ago). I suspect there was some recent change to trigger this since it seems to be failing consistently. 177642 6 eric 2010-01-06 10:44:13 -0800 I wonder if the previous change http://trac.webkit.org/changeset/52853 could be related. That at least changed run-webkit-tests... 177653 7 levin 2010-01-06 11:06:27 -0800 I'm currently unable to repro this locally (when running all tests using a retail build after sync'ing to the latest revision). 177723 8 45985 abecsi 2010-01-06 13:18:56 -0800 Created attachment 45985 Set isHttpdOpen to 0 if pidfile does not exist for some reason. This could maybe fix the test. It at least fixes: "http/tests/appcache .(48)Address already in use: make_sock: could not bind to address 127.0.0.1:8000 no listening sockets available, shutting down Unable to open logs" Which the log of the Leopard bot shows. I do not understand how the pidfile could dissapear, but it more logical to set isHttpdOpen to 0. 177726 9 eric 2010-01-06 13:21:46 -0800 I am not well enough versed in run-webkit-tests to know if this is correct. Mark Rowe is probably your best bet for review. It's possible that Adam Roben (because he's also hacked on RWT) or Alexey (because he's done so much httpd related testing) might know this code. 177727 10 webkit.review.bot 2010-01-06 13:22:17 -0800 style-queue ran check-webkit-style on attachment 45985 without any errors. 177761 11 eric 2010-01-06 14:11:32 -0800 The commit-queue isn't much use to us for regression fixes. It blocks itself while the bots are red so it doesn't ever make a red tree redder. I should make it smarter to be able to ignore the bot status when landing a REGRESSION fix. Maybe. 177762 12 eric 2010-01-06 14:11:44 -0800 I'll land this by hand. 177763 13 45985 eric 2010-01-06 14:12:55 -0800 Comment on attachment 45985 Set isHttpdOpen to 0 if pidfile does not exist for some reason. Clearing flags on attachment: 45985 Committed r52869: <http://trac.webkit.org/changeset/52869> 177765 14 eric 2010-01-06 14:13:03 -0800 All reviewed patches have been landed. Closing bug. 177786 15 eric 2010-01-06 14:41:52 -0800 This does not seem to have fixed the problem: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52870%20(9022)/results.html 177807 16 eric 2010-01-06 15:25:50 -0800 Looks like: http/tests/appcache .(48)Address already in use: make_sock: could not bind to address 127.0.0.1:8000 no listening sockets available, shutting down is still occuring in http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/9022/steps/layout-test/logs/stdio which corresponds to r52870. I'm not sure what to do other than to roll out the original change. It seems futile to try and debug this on the bots. 177815 17 eric 2010-01-06 15:37:35 -0800 I saw this failure trying to run-webkit-tests locally: Timed out waiting for httpd to start at WebKitTools/Scripts/run-webkit-tests line 1425, <IN> line 37668. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--quiet']" exit_code: 60 177819 18 eric 2010-01-06 15:49:12 -0800 I think that run-webkit-tests is not terminating the httpd processes correctly. So even once I roll this out, I'm not sure it will fix the bots as they may have rogue httpd processes running. 177826 19 eric 2010-01-06 15:56:24 -0800 Committed r52876: <http://trac.webkit.org/changeset/52876> 177841 20 eric 2010-01-06 16:14:19 -0800 This does not seem to be my day. The rollout did not fix the SL bot: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r52876%20(3931)/results.html The Leopard bot is still building. The first revision we saw this was r52854 http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/3919 but it is my suspicion that the revision was unrelated. 177852 21 eric 2010-01-06 16:28:03 -0800 Despite this rollout not fixing the bots, my local run-webkit-tests httpd failure is now gone, so it is my suspicion that this change was at least related to my local failure if not the bot errors. Leopard completed and is also failing: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52876%20(9024)/results.html Time for further debugging. I guess we should just skip this test if we can't figure out what is wrong here. I don't see any commits which could be related to this failure within 10 hours of when it first occurred. I stopped searching after that point. 177855 22 eric 2010-01-06 16:32:53 -0800 Andrew Wilson is right. The log must be coming from the previous test as it would come from this line of code: http://trac.webkit.org/browser/trunk/WebCore/websockets/WebSocketHandshake.cpp#L234 177857 23 eric 2010-01-06 16:37:59 -0800 I'm going to skip the websockets test to make the tree green. Ukai or Alexey or someone working on web-sockets can revisit the test at a later date. 177858 24 eric 2010-01-06 16:39:13 -0800 http://trac.webkit.org/browser/trunk/LayoutTests/fast/websockets/script-tests/websocket-event-target.js is the test in question. 177859 25 eric 2010-01-06 16:43:54 -0800 Like Dave Levin, I have not been able to reproduce the failure locally. 177865 26 eric 2010-01-06 16:48:24 -0800 Committed r52883: <http://trac.webkit.org/changeset/52883> 177866 27 eric 2010-01-06 16:50:51 -0800 The story continues. It seems that this test stopped consistently failing after: http://build.webkit.org/changes/5099 It is still skipped and should probably remain skipped until someone with WebSockets experience can offer a guess as to what's going on here. 177867 28 eric 2010-01-06 16:51:36 -0800 http://build.webkit.org/changes/5099 corresponds to http://trac.webkit.org/changeset/52877 in case buildbot's little mind forgets. 177878 29 eric 2010-01-06 17:08:39 -0800 Alexey asked that I file a new bug. I've done so. bug 33279. *** This bug has been marked as a duplicate of bug 33279 *** 45985 2010-01-06 13:18:56 -0800 2010-01-06 14:12:55 -0800 Set isHttpdOpen to 0 if pidfile does not exist for some reason. patch.diff text/plain 1117 abecsi ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5NjcxMTFjLi45NDljMWYzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTAtMDEt MDYgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IGlzSHR0cGRPcGVuIHRvIDAg aWYgcGlkZmlsZSBkb2VzIG5vdCBleGlzdCBmb3Igc29tZSByZWFzb24uCisgICAgICAgIFNwZWN1 bGF0aXZlIGZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMz MjU2LgorCisgICAgICAgICogU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzOgorCisyMDEwLTAxLTA2 ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAaW5mLnUtc3plZ2VkLmh1PgorCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgogCiAgICAgICAgIENoYW5nZSBoYXJkY29kZWQgL3RtcCBpbiBy dW4td2Via2l0LXRlc3RzIHRvIEZpbGU6OlNwZWMtPnRtcGRpcigpLApkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9y dW4td2Via2l0LXRlc3RzCmluZGV4IDQwNDFiZjguLmIzZWEyNzQgMTAwNzU1Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3J1bi13ZWJraXQtdGVzdHMKQEAgLTE0MzQsNyArMTQzNCwxMSBAQCBzdWIgY2xvc2VIVFRQRCgp CiAgICAgY2xvc2UgSFRUUERJTjsKICAgICBjbG9zZSBIVFRQRE9VVDsKIAotICAgIHJldHVybiB1 bmxlc3MgLWYgJGh0dHBkUGlkRmlsZTsKKyAgICBpZiAoISAtZiAkaHR0cGRQaWRGaWxlKSB7Cisg ICAgICAgICRpc0h0dHBkT3BlbiA9IDA7CisgICAgICAgIHJtZGlyICRodHRwZFBpZERpcjsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIG15ICRodHRwZFBpZCA9IGBjYXQgIiRodHRwZFBp ZEZpbGUiYDsKICAgICBraWxsIDE1LCAkaHR0cGRQaWQ7Cg==