33227 2010-01-05 12:21:31 -0800 check-webkit-style should warn about tabs in any file 2010-02-01 15:51:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 33734 1 eric webkit-unassigned abarth cjerdonek hamaji levin tkent oldest_to_newest 177298 0 eric 2010-01-05 12:21:31 -0800 check-webkit-style should warn about tabs in any file At least I think this should be check-webkit-style's job. https://bugs.webkit.org/show_bug.cgi?id=33221#c3 177521 1 ap 2010-01-05 18:47:23 -0800 I don't see any reason to forbid tabs in regression tests (not to mention make files). 177524 2 abarth 2010-01-05 18:58:55 -0800 We should use the same rules as the pre-commit hook. 177525 3 levin 2010-01-05 19:05:04 -0800 (In reply to comment #1) > I don't see any reason to forbid tabs in regression tests (not to mention make > files). Agreed. fwiw, I purposely got regression tests (directories) omitted when I reviewed the change that checks for TABs. 177555 4 tkent 2010-01-06 01:56:37 -0800 I think we may have a whitelist for tab checking. For example, we may forbid tabs in LayoutTests/.../script-tests/*.js 177582 5 eric 2010-01-06 06:31:44 -0800 the pre-commit hook warns unless you set the svn property "allow-tabs". check-webkit-style should do the same. svn patches from svn-create-patch include properties on new files. For existing files we can teach scm.py how to expose the current properties on a file.