33090 2009-12-31 19:37:12 -0800 AX: any DIV with an aria role should not be ignored 2010-01-04 14:47:01 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach abarth commit-queue eric webkit.review.bot oldest_to_newest 176252 0 cfleizach 2009-12-31 19:37:12 -0800 a DIV with an aria role should not be ignored by accessibility 176257 1 45727 cfleizach 2009-12-31 20:59:50 -0800 Created attachment 45727 patch 176259 2 webkit.review.bot 2009-12-31 21:01:40 -0800 style-queue ran check-webkit-style on attachment 45727 without any errors. 176735 3 45727 commit-queue 2010-01-04 10:15:18 -0800 Comment on attachment 45727 patch Rejecting patch 45727 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11862 test cases. svg/W3C-SVG-1.1/animate-elem-30-t.svg -> crashed Exiting early after 1 failures. 9854 tests run. 475.20s total testing time 9853 test cases (99%) succeeded 1 test case (<1%) crashed 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/161591 176736 4 cfleizach 2010-01-04 10:17:31 -0800 seems unlikely this patch was the culprit svg/W3C-SVG-1.1/animate-elem-30-t.svg -> crashed 176753 5 cfleizach 2010-01-04 10:55:19 -0800 http://trac.webkit.org/changeset/52748 176827 6 eric 2010-01-04 13:14:51 -0800 Looks like http://trac.webkit.org/changeset/52746 had landed and the bots were behind. Due to bug 30098 we didn't notice the bots were behind when running the commit-queue. I'll move bug 30098 further up my priority list. :( Sorry for the trouble. 176888 7 abarth 2010-01-04 14:47:01 -0800 > I'll move bug 30098 further up my priority list. :( I just posted a patch to fix that bug. 45727 2009-12-31 20:59:50 -0800 2010-01-04 10:15:18 -0800 patch patch.txt text/plain 4321 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMzEgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogYW55IERJViB3aXRoIGFuIGFyaWEgcm9sZSBzaG91bGQgbm90IGJlIGlnbm9yZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMDkwCisKKyAg ICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kaXZzLW5vdC1pZ25v cmVkLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojph Y2Nlc3NpYmlsaXR5SXNJZ25vcmVkKToKKwogMjAwOS0xMi0zMSAgQ2hyaXN0aWFuIER5d2FuICA8 Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5v cm9uaGEgU2lsdmEuCkluZGV4OiBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA1MjY4NSkKKysrIFdlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTUwMiw2ICsxNTAyLDkgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY2Nl c3NpYgogICAgIGlmIChpc0NvbnRyb2woKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAor ICAgIGlmIChhcmlhUm9sZSAhPSBVbmtub3duUm9sZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIAogICAgIC8vIGRvbid0IGlnbm9yZSBsYWJlbHMsIGJlY2F1c2UgdGhleSBzZXJ2ZSBhcyBU aXRsZVVJRWxlbWVudHMKICAgICBOb2RlKiBub2RlID0gbV9yZW5kZXJlci0+bm9kZSgpOwogICAg IGlmIChub2RlICYmIG5vZGUtPmhhc1RhZ05hbWUobGFiZWxUYWcpKQpAQCAtMTU0NSw5ICsxNTQ4 LDYgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY2Nlc3NpYgogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgfQogICAgIAotICAgIGlmIChhcmlhUm9sZSAhPSBVbmtub3duUm9s ZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIAogICAgIC8vIG1ha2UgYSBwbGF0Zm9ybS1z cGVjaWZpYyBkZWNpc2lvbgogICAgIGlmIChpc0F0dGFjaG1lbnQoKSkKICAgICAgICAgcmV0dXJu IGFjY2Vzc2liaWxpdHlJZ25vcmVBdHRhY2htZW50KCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MjY4 NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDA5LTEyLTMxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVg6IGFueSBE SVYgd2l0aCBhbiBhcmlhIHJvbGUgc2hvdWxkIG5vdCBiZSBpZ25vcmVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzA5MAorCisgICAgICAgICogcGxh dGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kaXZzLW5vdC1pZ25vcmVkLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kaXZz LW5vdC1pZ25vcmVkLmh0bWw6IEFkZGVkLgorCiAyMDA5LTEyLTMxICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRl eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kaXZzLW5vdC1p Z25vcmVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvYWNjZXNzaWJpbGl0eS9hcmlhLWRpdnMtbm90LWlnbm9yZWQtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1k aXZzLW5vdC1pZ25vcmVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBA QAordGV4dAorCitUaGlzIHRlc3RzIHRoYXQgYSBkaXYgZWxlbWVudCB3aXRoIG5vdGhpbmcgaW4s IGJ1dCBvbmUgdGhhdCBoYXMgYW4gQVJJQSByb2xlLCB3aWxsIG5vdCBiZSBpZ25vcmVkIGJ5IGFj Y2Vzc2liaWxpdHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGJvZHku Y2hpbGRBdEluZGV4KDEpLnJvbGUgaXMgJ0FYUm9sZTogQVhHcm91cCcKK1BBU1MgYm9keS5jaGls ZEF0SW5kZXgoMSkuc3Vicm9sZSBpcyAnQVhTdWJyb2xlOiBBWEFwcGxpY2F0aW9uTG9nJworUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtZGl2cy1ub3QtaWdub3Jl ZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmls aXR5L2FyaWEtZGl2cy1ub3QtaWdub3JlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kaXZzLW5vdC1pZ25vcmVkLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzUgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8v SUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hl ZXQiIGhyZWY9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4K KzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7Cis8L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisKKzxoMz50ZXh0PC9oMz4KKzxkaXYg Y2xhc3M9InRleHQiIHJvbGU9ImxvZyIgYXJpYS1saXZlPSJwb2xpdGUiIGlkPSJ2aXNpYmxlVGV4 dCI+PC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGEg ZGl2IGVsZW1lbnQgd2l0aCBub3RoaW5nIGluLCBidXQgb25lIHRoYXQgaGFzIGFuIEFSSUEgcm9s ZSwgd2lsbCBub3QgYmUgaWdub3JlZCBieSBhY2Nlc3NpYmlsaXR5LiIpOworCisgICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworCisgICAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImJvZHkiKS5mb2N1cygpOworICAgICAgICAgIHZhciBib2R5ID0gYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisgICAgICAgICAgc2hvdWxkQmUoImJv ZHkuY2hpbGRBdEluZGV4KDEpLnJvbGUiLCAiJ0FYUm9sZTogQVhHcm91cCciKTsKKyAgICAgICAg ICBzaG91bGRCZSgiYm9keS5jaGlsZEF0SW5kZXgoMSkuc3Vicm9sZSIsICInQVhTdWJyb2xlOiBB WEFwcGxpY2F0aW9uTG9nJyIpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRy dWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==