33056 2009-12-30 09:37:16 -0800 Implement NO_RETURN for MSVC 2010-04-09 01:36:46 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 32939 1 paroga webkit-unassigned aroben commit-queue darin eric laszlo.gombos sfalken webkit.review.bot oldest_to_newest 175946 0 paroga 2009-12-30 09:37:16 -0800 Implement the NO_RETURN macro also for MSVC. From http://gcc.gnu.org/onlinedocs/gcc-3.3.1/gcc/Function-Attributes.html: It does not make sense for a noreturn function to have a return type other than void. I found two files who use the NO_RETURN macro in a wrong way (FastMalloc.cpp and jsc.cpp). 175949 1 45669 paroga 2009-12-30 09:41:17 -0800 Created attachment 45669 Implement NO_RETURN for MSVC 175954 2 webkit.review.bot 2009-12-30 09:47:32 -0800 style-queue ran check-webkit-style on attachment 45669 without any errors. 175958 3 45670 paroga 2009-12-30 09:54:59 -0800 Created attachment 45670 Fix use of NO_RETURN in FastMalloc.cpp 175959 4 webkit.review.bot 2009-12-30 09:59:11 -0800 Attachment 45670 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:1380: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 176083 5 45670 mrowe 2009-12-30 16:34:24 -0800 Comment on attachment 45670 Fix use of NO_RETURN in FastMalloc.cpp Given that the function is not intended to return I’m not sure why we’d want to remove the annotation that indicates that. Anyway, this will break the Mac build (and possibly others): JavaScriptCore/wtf/FastMalloc.cpp:1431: warning: function might be possible candidate for attribute ‘noreturn’ 176137 6 paroga 2009-12-31 00:04:46 -0800 (In reply to comment #5) > (From update of attachment 45670 [details]) > Given that the function is not intended to return I’m not sure why we’d want to > remove the annotation that indicates that. Anyway, this will break the Mac > build (and possibly others): > JavaScriptCore/wtf/FastMalloc.cpp:1431: warning: function might be possible > candidate for attribute ‘noreturn’ When you implement NO_RETURN for MSVC then it will throw an warning, because noreturn functions must have a void return type. A solution might be that we disable "warning C4646: function declared with __declspec(noreturn) has non-void return type", but then is the problem with the compiler for WinCE. It seams that it ignores the noreturn and throws always an error! The other possible solution is, that we don't implement NO_RETURN for MSVC and copy the hack from FastMalloc.cpp to jsc.cpp (see bug 32939). I think that this will win, because GCC is the better/prefered compiler. ;-) 176141 7 paroga 2009-12-31 00:16:53 -0800 (In reply to comment #6) > The other possible solution is, that we don't implement NO_RETURN for MSVC and > copy the hack from FastMalloc.cpp to jsc.cpp (see bug 32939). I think that this > will win, because GCC is the better/prefered compiler. ;-) But then the Win32 compiler will throw "warning C4702: unreachable code". So mit current solution is #if COMPILER(MSVC) && PLATFORM(WINCE) :-( 176483 8 eric 2010-01-03 18:07:17 -0800 Some one who knows how MSVC works would have to review the first patch. 176702 9 45669 aroben 2010-01-04 08:03:46 -0800 Comment on attachment 45669 Implement NO_RETURN for MSVC r=me 176715 10 45669 commit-queue 2010-01-04 09:06:39 -0800 Comment on attachment 45669 Implement NO_RETURN for MSVC Clearing flags on attachment: 45669 Committed r52741: <http://trac.webkit.org/changeset/52741> 176716 11 commit-queue 2010-01-04 09:06:46 -0800 All reviewed patches have been landed. Closing bug. 176717 12 darin 2010-01-04 09:09:56 -0800 So it does not break the build to define NO_RETURN but leave FastMalloc.cpp alone? If it does then these should not have been independently reviewed patches! 176722 13 aroben 2010-01-04 09:24:31 -0800 (In reply to comment #12) > So it does not break the build to define NO_RETURN but leave FastMalloc.cpp > alone? If it does then these should not have been independently reviewed > patches! It does break it. I'm rolling out r52741. 176724 14 aroben 2010-01-04 09:29:42 -0800 Committed r52744: <http://trac.webkit.org/changeset/52744> 176725 15 aroben 2010-01-04 09:31:47 -0800 Re-opening the bug since the patch was rolled out. 176727 16 45669 aroben 2010-01-04 09:32:37 -0800 Comment on attachment 45669 Implement NO_RETURN for MSVC r- since this can't land until FastMalloc.cpp is changed. 176834 17 eric 2010-01-04 13:20:33 -0800 Sorry. The commit-queue only knows how to test on Mac Leopard (WebKit's seemingly primary platform) for now. 177092 18 paroga 2010-01-05 01:51:43 -0800 Sorry for the buildbreak! That wasn't my intention. Sorry! Here is a small sum up: If you implement the __declspec(noreturn) MSVC will complain on functions with returntyp other than void (e.g. functionQuit). If you remove the NO_RETURN macro from such functions the GCC will throw "warning: function might be possible candidate for attribute ‘noreturn’". If you use exit() not at the end of a function MSVC on Win32 will throw "warning C4702: unreachable code", but on WinCE it complains about a missing return statement if exit() is the last statement. It's always fun to compile with MSVC, because it has different behaviour on every platform! Does it make sense to implement the NO_RETURN macro for MSVC? In the moment only functionQuit in jsc.cpp (bug 32939), is a blocker to compile jsc directly from trunk. 177162 19 darin 2010-01-05 08:29:42 -0800 You can come up with whatever solution you like, as long as you don’t lower the warning settings or break the build. We could have multiple NO_RETURN macros to work around the differences in various versions of MSVC. We could have ifdefs at various call sites. I don’t see this as an urgent issue, but it’s fine to try to get it working. 210248 20 52875 paroga 2010-04-08 09:37:06 -0700 Created attachment 52875 New patch Maybe someone has a better name than NO_VALUE_RETURN ;-) 210249 21 webkit.review.bot 2010-04-08 09:38:37 -0700 Attachment 52875 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:1434: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 210307 22 52875 darin 2010-04-08 12:11:56 -0700 Comment on attachment 52875 New patch I think NO_RETURN_WITH_VALUE would be better if only because it doesn't make it seem like the word "no" goes with the word "value". Could you do it with that different name? 210309 23 52885 paroga 2010-04-08 12:14:39 -0700 Created attachment 52885 The patch (now with NO_RETURN_WITH_VALUE) (In reply to comment #22) > (From update of attachment 52875 [details]) > I think NO_RETURN_WITH_VALUE would be better if only because it doesn't make it > seem like the word "no" goes with the word "value". Could you do it with that > different name? Done! 210312 24 webkit.review.bot 2010-04-08 12:18:45 -0700 Attachment 52885 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:1434: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 210633 25 52885 commit-queue 2010-04-09 01:36:39 -0700 Comment on attachment 52885 The patch (now with NO_RETURN_WITH_VALUE) Clearing flags on attachment: 52885 Committed r57318: <http://trac.webkit.org/changeset/57318> 210634 26 commit-queue 2010-04-09 01:36:46 -0700 All reviewed patches have been landed. Closing bug. 45669 2009-12-30 09:41:17 -0800 2010-04-08 09:37:06 -0700 Implement NO_RETURN for MSVC NO_RETURN.patch text/plain 953 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNjYzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTItMzAgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IE5PX1JFVFVSTiBmb3IgQ09NUElMRVIo TVNWQykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MzA1NgorCisgICAgICAgICogd3RmL0Fsd2F5c0lubGluZS5oOgorCiAyMDA5LTEyLTI5ICBMYXN6 bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJ bmxpbmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgJ KHJldmlzaW9uIDUyNjYwKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw4IEBACiAjaWZuZGVmIE5PX1JFVFVSTgogI2lmIENP TVBJTEVSKEdDQykKICNkZWZpbmUgTk9fUkVUVVJOIF9fYXR0cmlidXRlKChfX25vcmV0dXJuX18p KQorI2VsaWYgQ09NUElMRVIoTVNWQykKKyNkZWZpbmUgTk9fUkVUVVJOIF9fZGVjbHNwZWMobm9y ZXR1cm4pCiAjZWxzZQogI2RlZmluZSBOT19SRVRVUk4KICNlbmRpZgo= 45670 2009-12-30 09:54:59 -0800 2010-04-08 09:37:06 -0700 Fix use of NO_RETURN in FastMalloc.cpp FastMalloc.patch text/plain 1442 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyNjY0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMzAgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTk9fUkVUVVJOIG1ha2VzIG9ubHkgc2Vuc2Ugb24gZnVu Y3Rpb24gd2l0aCB2b2lkIHJldHVybiB0eXBlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwNTYKKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNw cDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCk6 IGFsd2F5cyByZXR1cm4gMAorCiAyMDA5LTEyLTI5ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lh ay4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyNjYwKQorKysg SmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzc3 LDcgKzEzNzcsNyBAQCBjbGFzcyBUQ01hbGxvY19QYWdlSGVhcCB7CiAjZW5kaWYKIAogI2lmIFVT RV9CQUNLR1JPVU5EX1RIUkVBRF9UT19TQ0FWRU5HRV9NRU1PUlkKLSAgc3RhdGljIE5PX1JFVFVS TiB2b2lkKiBydW5TY2F2ZW5nZXJUaHJlYWQodm9pZCopOworICBzdGF0aWMgdm9pZCogcnVuU2Nh dmVuZ2VyVGhyZWFkKHZvaWQqKTsKIAogICBOT19SRVRVUk4gdm9pZCBzY2F2ZW5nZXJUaHJlYWQo KTsKIApAQCAtMTQzMSwxMCArMTQzMSw3IEBAIHZvaWQgVENNYWxsb2NfUGFnZUhlYXA6OmluaXQo KQogdm9pZCogVENNYWxsb2NfUGFnZUhlYXA6OnJ1blNjYXZlbmdlclRocmVhZCh2b2lkKiBjb250 ZXh0KQogewogICBzdGF0aWNfY2FzdDxUQ01hbGxvY19QYWdlSGVhcCo+KGNvbnRleHQpLT5zY2F2 ZW5nZXJUaHJlYWQoKTsKLSNpZiBDT01QSUxFUihNU1ZDKQotICAvLyBXaXRob3V0IHRoaXMsIFZp c3VhbCBTdHVkaW8gd2lsbCBjb21wbGFpbiB0aGF0IHRoaXMgbWV0aG9kIGRvZXMgbm90IHJldHVy biBhIHZhbHVlLgogICByZXR1cm4gMDsKLSNlbmRpZgogfQogCiB2b2lkIFRDTWFsbG9jX1BhZ2VI ZWFwOjpzY2F2ZW5nZSgpIAo= 52875 2010-04-08 09:37:06 -0700 2010-04-08 12:14:39 -0700 New patch bug-33056.patch text/plain 2727 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3MjgzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IE5PX1JFVFVSTiBmb3IgQ09NUElMRVIo TVNWQykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MzA1NiAKKworICAgICAgICBBZGRlZCBOT19WQUxVRV9SRVRVUk4gZm9yIGZ1bmN0aW9ucyB3aXRo IG5vbi12b2lkIHJldHVybiB0eXBlLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKiB3 dGYvQWx3YXlzSW5saW5lLmg6CisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorCiAyMDEw LTA0LTA4ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9qc2MuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDU3MjgzKQor KysgSmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzksNyArNzksNyBA QCBzdGF0aWMgSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUnVuCiBzdGF0aWMgSlNWYWx1 ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uTG9hZChFeGVjU3RhdGUqLCBKU09iamVjdCosIEpTVmFs dWUsIGNvbnN0IEFyZ0xpc3QmKTsKIHN0YXRpYyBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rp b25DaGVja1N5bnRheChFeGVjU3RhdGUqLCBKU09iamVjdCosIEpTVmFsdWUsIGNvbnN0IEFyZ0xp c3QmKTsKIHN0YXRpYyBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25SZWFkbGluZShFeGVj U3RhdGUqLCBKU09iamVjdCosIEpTVmFsdWUsIGNvbnN0IEFyZ0xpc3QmKTsKLXN0YXRpYyBOT19S RVRVUk4gSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUXVpdChFeGVjU3RhdGUqLCBKU09i amVjdCosIEpTVmFsdWUsIGNvbnN0IEFyZ0xpc3QmKTsKK3N0YXRpYyBOT19WQUxVRV9SRVRVUk4g SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUXVpdChFeGVjU3RhdGUqLCBKU09iamVjdCos IEpTVmFsdWUsIGNvbnN0IEFyZ0xpc3QmKTsKIAogI2lmIEVOQUJMRShTQU1QTElOR19GTEFHUykK IHN0YXRpYyBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25TZXRTYW1wbGluZ0ZsYWdzKEV4 ZWNTdGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSwgY29uc3QgQXJnTGlzdCYpOwpJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD b3JlL3d0Zi9BbHdheXNJbmxpbmUuaAkocmV2aXNpb24gNTcyODMpCisrKyBKYXZhU2NyaXB0Q29y ZS93dGYvQWx3YXlzSW5saW5lLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDkgKzU5LDE3IEBACiAj aWZuZGVmIE5PX1JFVFVSTgogI2lmIENPTVBJTEVSKEdDQykKICNkZWZpbmUgTk9fUkVUVVJOIF9f YXR0cmlidXRlKChfX25vcmV0dXJuX18pKQotI2VsaWYgQ09NUElMRVIoUlZDVCkKKyNlbGlmIENP TVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJWQ1QpCiAjZGVmaW5lIE5PX1JFVFVSTiBfX2RlY2xz cGVjKG5vcmV0dXJuKQogI2Vsc2UKICNkZWZpbmUgTk9fUkVUVVJOCiAjZW5kaWYKICNlbmRpZgor CisjaWZuZGVmIE5PX1ZBTFVFX1JFVFVSTgorI2lmICFDT01QSUxFUihNU1ZDKQorI2RlZmluZSBO T19WQUxVRV9SRVRVUk4gTk9fUkVUVVJOCisjZWxzZQorI2RlZmluZSBOT19WQUxVRV9SRVRVUk4K KyNlbmRpZgorI2VuZGlmCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCShyZXZpc2lv biA1NzI4MykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTQzMSw3ICsxNDMxLDcgQEAgY2xhc3MgVENNYWxsb2NfUGFnZUhlYXAgewogICBB TFdBWVNfSU5MSU5FIGJvb2wgc2hvdWxkU2NhdmVuZ2UoKSBjb25zdDsKIAogI2lmICFIQVZFKERJ U1BBVENIX0gpCi0gIHN0YXRpYyBOT19SRVRVUk4gdm9pZCogcnVuU2NhdmVuZ2VyVGhyZWFkKHZv aWQqKTsKKyAgc3RhdGljIE5PX1ZBTFVFX1JFVFVSTiB2b2lkKiBydW5TY2F2ZW5nZXJUaHJlYWQo dm9pZCopOwogICBOT19SRVRVUk4gdm9pZCBzY2F2ZW5nZXJUaHJlYWQoKTsKIAogICAvLyBLZWVw cyB0cmFjayBvZiB3aGV0aGVyIHRoZSBiYWNrZ3JvdW5kIHRocmVhZCBpcyBhY3RpdmVseSBzY2F2 ZW5naW5nIG1lbW9yeSBldmVyeSBrU2NhdmVuZ2VEZWxheUluU2Vjb25kcywgb3IK 52885 2010-04-08 12:14:39 -0700 2010-04-09 01:36:38 -0700 The patch (now with NO_RETURN_WITH_VALUE) bug-33056.patch text/plain 2757 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3MjgzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IE5PX1JFVFVSTiBmb3IgQ09NUElMRVIo TVNWQykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MzA1NiAKKworICAgICAgICBBZGRlZCBOT19SRVRVUk5fV0lUSF9WQUxVRSBmb3IgZnVuY3Rpb25z IHdpdGggbm9uLXZvaWQgcmV0dXJuIHR5cGUuCisKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAg ICAqIHd0Zi9BbHdheXNJbmxpbmUuaDoKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisK IDIwMTAtMDQtMDggIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2pz Yy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gNTcy ODMpCisrKyBKYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3 OSw3IEBAIHN0YXRpYyBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25SdW4KIHN0YXRpYyBK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25Mb2FkKEV4ZWNTdGF0ZSosIEpTT2JqZWN0Kiwg SlNWYWx1ZSwgY29uc3QgQXJnTGlzdCYpOwogc3RhdGljIEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBm dW5jdGlvbkNoZWNrU3ludGF4KEV4ZWNTdGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSwgY29uc3Qg QXJnTGlzdCYpOwogc3RhdGljIEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblJlYWRsaW5l KEV4ZWNTdGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSwgY29uc3QgQXJnTGlzdCYpOwotc3RhdGlj IE5PX1JFVFVSTiBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25RdWl0KEV4ZWNTdGF0ZSos IEpTT2JqZWN0KiwgSlNWYWx1ZSwgY29uc3QgQXJnTGlzdCYpOworc3RhdGljIE5PX1JFVFVSTl9X SVRIX1ZBTFVFIEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblF1aXQoRXhlY1N0YXRlKiwg SlNPYmplY3QqLCBKU1ZhbHVlLCBjb25zdCBBcmdMaXN0Jik7CiAKICNpZiBFTkFCTEUoU0FNUExJ TkdfRkxBR1MpCiBzdGF0aWMgSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uU2V0U2FtcGxp bmdGbGFncyhFeGVjU3RhdGUqLCBKU09iamVjdCosIEpTVmFsdWUsIGNvbnN0IEFyZ0xpc3QmKTsK SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgJKHJldmlzaW9uIDU3MjgzKQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01OSw5ICs1 OSwxNyBAQAogI2lmbmRlZiBOT19SRVRVUk4KICNpZiBDT01QSUxFUihHQ0MpCiAjZGVmaW5lIE5P X1JFVFVSTiBfX2F0dHJpYnV0ZSgoX19ub3JldHVybl9fKSkKLSNlbGlmIENPTVBJTEVSKFJWQ1Qp CisjZWxpZiBDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihSVkNUKQogI2RlZmluZSBOT19SRVRV Uk4gX19kZWNsc3BlYyhub3JldHVybikKICNlbHNlCiAjZGVmaW5lIE5PX1JFVFVSTgogI2VuZGlm CiAjZW5kaWYKKworI2lmbmRlZiBOT19SRVRVUk5fV0lUSF9WQUxVRQorI2lmICFDT01QSUxFUihN U1ZDKQorI2RlZmluZSBOT19SRVRVUk5fV0lUSF9WQUxVRSBOT19SRVRVUk4KKyNlbHNlCisjZGVm aW5lIE5PX1JFVFVSTl9XSVRIX1ZBTFVFCisjZW5kaWYKKyNlbmRpZgpJbmRleDogSmF2YVNjcmlw dENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0 Zi9GYXN0TWFsbG9jLmNwcAkocmV2aXNpb24gNTcyODMpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYv RmFzdE1hbGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MzEsNyArMTQzMSw3IEBAIGNsYXNz IFRDTWFsbG9jX1BhZ2VIZWFwIHsKICAgQUxXQVlTX0lOTElORSBib29sIHNob3VsZFNjYXZlbmdl KCkgY29uc3Q7CiAKICNpZiAhSEFWRShESVNQQVRDSF9IKQotICBzdGF0aWMgTk9fUkVUVVJOIHZv aWQqIHJ1blNjYXZlbmdlclRocmVhZCh2b2lkKik7CisgIHN0YXRpYyBOT19SRVRVUk5fV0lUSF9W QUxVRSB2b2lkKiBydW5TY2F2ZW5nZXJUaHJlYWQodm9pZCopOwogICBOT19SRVRVUk4gdm9pZCBz Y2F2ZW5nZXJUaHJlYWQoKTsKIAogICAvLyBLZWVwcyB0cmFjayBvZiB3aGV0aGVyIHRoZSBiYWNr Z3JvdW5kIHRocmVhZCBpcyBhY3RpdmVseSBzY2F2ZW5naW5nIG1lbW9yeSBldmVyeSBrU2NhdmVu Z2VEZWxheUluU2Vjb25kcywgb3IK