32973 2009-12-27 16:00:29 -0800 check-webkit-style: Make a single module that runs the style package unit tests 2010-01-07 03:51:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32971 1 cjerdonek cjerdonek abarth cjerdonek commit-queue eric hamaji levin webkit.review.bot oldest_to_newest 175105 0 cjerdonek 2009-12-27 16:00:29 -0800 The file can be located at modules/style/unittest.py. run-webkit-unittests should then be modified to import only this file. This will make run-webkit-unittests easier to maintain as the style "package" changes. 175344 1 cjerdonek 2009-12-28 17:49:37 -0800 Removed brackets from bug title. 178064 2 cjerdonek 2010-01-07 01:25:13 -0800 This is so that test-webkitpy doesn't have to know the structure of the style package, and vice versa -- the style package doesn't have to worry about updating outside files like test-webkitpy. 178065 3 46031 cjerdonek 2010-01-07 01:26:38 -0800 Created attachment 46031 Proposed patch 178066 4 webkit.review.bot 2010-01-07 01:29:14 -0800 style-queue ran check-webkit-style on attachment 46031 without any errors. 178069 5 46031 abarth 2010-01-07 01:39:44 -0800 Comment on attachment 46031 Proposed patch Thanks for teach me Python. We should do the same with steps and commands. 178082 6 cjerdonek 2010-01-07 01:56:36 -0800 (In reply to comment #5) > (From update of attachment 46031 [details]) > Thanks for teach me Python. We should do the same with steps and commands. Thanks, Adam! 178126 7 46031 commit-queue 2010-01-07 03:50:56 -0800 Comment on attachment 46031 Proposed patch Clearing flags on attachment: 46031 Committed r52916: <http://trac.webkit.org/changeset/52916> 178127 8 commit-queue 2010-01-07 03:51:03 -0800 All reviewed patches have been landed. Closing bug. 46031 2010-01-07 01:26:38 -0800 2010-01-07 03:50:55 -0800 Proposed patch patch-tools9-1.txt text/plain 3707 cjerdonek SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyOTA4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMDcgIENocmlzIEplcmRvbmVrICA8 Y2hyaXMuamVyZG9uZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENyZWF0ZWQgYSBtb2R1bGUgdGhhdCBydW5zIHRoZSBzdHlsZSBw YWNrYWdlIHVuaXQgdGVzdHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMyOTczCisKKyAgICAgICAgKiBTY3JpcHRzL3Rlc3Qtd2Via2l0cHk6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS91bml0dGVzdHMucHk6IEFkZGVkLgorCiAy MDEwLTAxLTA3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtp dHB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRweQkocmV2 aXNpb24gNTI5MDYpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkJKHdvcmtp bmcgY29weSkKQEAgLTQwLDE1ICs0MCwxMyBAQCBmcm9tIHdlYmtpdHB5LmNvbW1hbmRzLnF1ZXJp ZXNfdW5pdHRlc3QgCiBmcm9tIHdlYmtpdHB5LmNvbW1hbmRzLnF1ZXVlc191bml0dGVzdCBpbXBv cnQgKgogZnJvbSB3ZWJraXRweS5jb21taXR0ZXJzX3VuaXR0ZXN0IGltcG9ydCAqCiBmcm9tIHdl YmtpdHB5LmNyZWRlbnRpYWxzX3VuaXR0ZXN0IGltcG9ydCAqCi1mcm9tIHdlYmtpdHB5LnN0eWxl LmNwcF9zdHlsZV91bml0dGVzdCBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS5kaWZmX3BhcnNlcl91 bml0dGVzdCBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS5leGVjdXRpdmVfdW5pdHRlc3QgaW1wb3J0 ICoKIGZyb20gd2Via2l0cHkubXVsdGljb21tYW5kdG9vbF91bml0dGVzdCBpbXBvcnQgKgogZnJv bSB3ZWJraXRweS5xdWV1ZWVuZ2luZV91bml0dGVzdCBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS5z dGVwcy5zdGVwc191bml0dGVzdCBpbXBvcnQgKgogZnJvbSB3ZWJraXRweS5zdGVwcy51cGRhdGVj aGFuZ2Vsb2dzd2l0aHJldmlld191bml0dGVzdHMgaW1wb3J0ICoKLWZyb20gd2Via2l0cHkuc3R5 bGUuY2hlY2tlcl91bml0dGVzdCBpbXBvcnQgKgotZnJvbSB3ZWJraXRweS5zdHlsZS50ZXh0X3N0 eWxlX3VuaXR0ZXN0IGltcG9ydCAqCitmcm9tIHdlYmtpdHB5LnN0eWxlLnVuaXR0ZXN0cyBpbXBv cnQgKiAjIGZvciBjaGVjay13ZWJraXQtc3R5bGUKIGZyb20gd2Via2l0cHkud2Via2l0X2xvZ2dp bmdfdW5pdHRlc3QgaW1wb3J0ICoKIGZyb20gd2Via2l0cHkud2Via2l0cG9ydF91bml0dGVzdCBp bXBvcnQgKgogCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL3VuaXR0 ZXN0cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L3VuaXR0ZXN0cy5weQkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvdW5pdHRlc3RzLnB5CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQwIEBACisjIS91 c3IvYmluL2VudiBweXRob24KKyMKKyMgQ29weXJpZ2h0IChDKSAyMDEwIENocmlzIEplcmRvbmVr IChjaHJpcy5qZXJkb25la0BnbWFpbC5jb20pCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMg YXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11 c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgICAgKiBSZWRpc3RyaWJ1 dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCisjIGNvcHlyaWdo dCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92 aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisjICAgICAqIE5laXRoZXIgdGhlIG5hbWUg b2YgQXBwbGUgQ29tcHV0ZXIsIEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKKyMgaXRz IGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMg ZGVyaXZlZAorIyBmcm9tIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0 dGVuIHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENP UFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJF U1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBU TywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1Mg Rk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBT SEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9S IEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlks IE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQg VE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0Yg VVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VW RVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBD T05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VO Q0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4KKworIiIiUnVucyBzdHlsZSBwYWNrYWdlIHVuaXQgdGVzdHMuIiIiCisKKyMgVGhp cyBtb2R1bGUgaXMgaW1wb3J0ZWQgYnkgdGVzdC13ZWJraXRweS4KKworaW1wb3J0IHN5cworaW1w b3J0IHVuaXR0ZXN0CisKK2Zyb20gY2hlY2tlcl91bml0dGVzdCBpbXBvcnQgKgorZnJvbSBjcHBf c3R5bGVfdW5pdHRlc3QgaW1wb3J0ICoKK2Zyb20gdGV4dF9zdHlsZV91bml0dGVzdCBpbXBvcnQg Kgo=