32915 2009-12-23 21:31:37 -0800 valueAsDate setter Part 2: ISODateTime -> String conversion 2009-12-29 08:54:04 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED WONTFIX http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasdate P2 Normal --- 32901 32697 1 tkent webkit-unassigned dglazkov webkit.review.bot oldest_to_newest 174725 0 tkent 2009-12-23 21:31:37 -0800 In order to implement HTMLInputElement::setValueAsDate, we need to implement 1. millisecond double value to ISODateTime conversion 2. ISODateTime to String conversion This bug handles the step 2 above. 174727 1 45462 tkent 2009-12-23 21:40:16 -0800 Created attachment 45462 Proposed patch This patch depends on the patch in Bug#32901. 174728 2 webkit.review.bot 2009-12-23 21:44:04 -0800 Attachment 45462 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/143618 174729 3 webkit.review.bot 2009-12-23 21:45:13 -0800 style-queue ran check-webkit-style on attachment 45462 without any errors. 174731 4 tkent 2009-12-23 21:48:05 -0800 (In reply to comment #2) > Attachment 45462 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/143618 It's expected. This patch depends on a uncommitted patch. 174947 5 webkit.review.bot 2009-12-26 06:15:34 -0800 Attachment 45462 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/145780 175202 6 45462 mjs 2009-12-28 02:12:59 -0800 Comment on attachment 45462 Proposed patch This patch lacks tests. Perhaps it is only testable in combination with part 1, in which case I'd rather see the two combined into one patch with tests included. 175577 7 tkent 2009-12-29 08:54:04 -0800 Deprecated by Bug#33021. 45462 2009-12-23 21:40:16 -0800 2009-12-28 02:12:59 -0800 Proposed patch 0001-tostring-1.patch text/plain 6546 tkent RnJvbSAzZDBiMGYyNjdhNTEzYzFhZjgzNTg0MjBmZDA4Y2ZkMzAwMzcxMDk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl OiBUaHUsIDI0IERlYyAyMDA5IDE0OjA0OjM2ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gdG9zdHJp bmctMQoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxOSArKysrKysrKysr KwogV2ViQ29yZS9odG1sL0lTT0RhdGVUaW1lLmNwcCB8ICAgNzAgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrCiBXZWJDb3JlL2h0bWwvSVNPRGF0ZVRpbWUuaCAgIHwg ICAxOCArKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDcgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IGI0YzQzZjAuLmVhNzE0MWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDktMTItMjQg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBJU09EYXRlVGltZTo6dG9TdHJp bmcoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMy OTE1CisKKyAgICAgICAgVGhlIHRvU3RyaW5nKCkgbWV0aG9kIGhhdmUgZmxhZ3MgdG8gc3BlY2lm eSBzZWNvbmQvbWlsbGlzZWNvbmQKKyAgICAgICAgc3VwcHJlc3Npb24gYW5kIHRoZSB0aW1lem9u ZSBvZmZzZXQgZm9yIHRoZSBkYXRldGltZSB0eXBlLgorICAgICAgICBUaGUgbWV0aG9kIHdpbGwg YmUgdXNlZCBieSBIVE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZUFzRGF0ZSgpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZSBtZXRob2QgaXMgbm90IHVzZWQgeWV0LgorCisgICAg ICAgICogaHRtbC9JU09EYXRlVGltZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJU09EYXRlVGlt ZTo6dG9TdHJpbmdGb3JUaW1lKTogQWRkZWQuIEEgaGVscGVyIGZvciB0b1N0cmluZygpLgorICAg ICAgICAoV2ViQ29yZTo6SVNPRGF0ZVRpbWU6OnRvU3RyaW5nKTogQWRkZWQuCisgICAgICAgICog aHRtbC9JU09EYXRlVGltZS5oOiBEZWNsYXJlIHRoZW0uCisgICAgICAgIChXZWJDb3JlOjpJU09E YXRlVGltZTo6U2Vjb25kRm9ybWF0KTogU2Vjb25kL21pbGxpc2Vjb25kIGZvcm1hdHRpbmcgZmxh Zy4KKwogMjAwOS0xMi0yMyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0 bWwvSVNPRGF0ZVRpbWUuY3BwIGIvV2ViQ29yZS9odG1sL0lTT0RhdGVUaW1lLmNwcAppbmRleCBj NjM5YmQ5Li5mYTQ1NTBhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSVNPRGF0ZVRpbWUuY3Bw CisrKyBiL1dlYkNvcmUvaHRtbC9JU09EYXRlVGltZS5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJJU09EYXRlVGltZS5oIgogCisjaW5jbHVkZSAi UGxhdGZvcm1TdHJpbmcuaCIKICNpbmNsdWRlIDxsaW1pdHMuaD4KICNpbmNsdWRlIDx3dGYvQVND SUlDVHlwZS5oPgogI2luY2x1ZGUgPHd0Zi9EYXRlTWF0aC5oPgpAQCAtNTk4LDQgKzU5OSw3MyBA QCBkb3VibGUgSVNPRGF0ZVRpbWU6Om1pbGxpc2Vjb25kc1NpbmNlRXBvY2goKSBjb25zdAogICAg IHJldHVybiBpbnZhbGlkTWlsbGlzZWNvbmRzKCk7CiB9CiAKK1N0cmluZyBJU09EYXRlVGltZTo6 dG9TdHJpbmdGb3JUaW1lKFNlY29uZEZvcm1hdCBmb3JtYXQpIGNvbnN0Cit7CisgICAgQVNTRVJU KG1fdHlwZSA9PSBEYXRlVGltZSB8fCBtX3R5cGUgPT0gRGF0ZVRpbWVMb2NhbCB8fCBtX3R5cGUg PT0gVGltZSk7CisgICAgU2Vjb25kRm9ybWF0IGVmZmVjdGl2ZUZvcm1hdCA9IGZvcm1hdDsKKyAg ICBpZiAoZm9ybWF0ID09IE5vbmUpIHsKKyAgICAgICAgaWYgKG1fbWlsbGlzZWNvbmQpCisgICAg ICAgICAgICBlZmZlY3RpdmVGb3JtYXQgPSBNaWxsaXNlY29uZDsKKyAgICAgICAgZWxzZSBpZiAo bV9zZWNvbmQpCisgICAgICAgICAgICBlZmZlY3RpdmVGb3JtYXQgPSBTZWNvbmQ7CisgICAgfSBl bHNlIGlmIChmb3JtYXQgPT0gU2Vjb25kKSB7CisgICAgICAgIGlmIChtX21pbGxpc2Vjb25kKQor ICAgICAgICAgICAgZWZmZWN0aXZlRm9ybWF0ID0gTWlsbGlzZWNvbmQ7CisgICAgfQorICAgIHN3 aXRjaCAoZWZmZWN0aXZlRm9ybWF0KSB7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgICAgIC8vIEZhbGxiYWNrIHRvIE5vbmUuCisgICAgY2FzZSBOb25l OgorICAgICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIiUwMmQ6JTAyZCIsIG1faG91ciwgbV9t aW51dGUpOworICAgIGNhc2UgU2Vjb25kOgorICAgICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQo IiUwMmQ6JTAyZDolMDJkIiwgbV9ob3VyLCBtX21pbnV0ZSwgbV9zZWNvbmQpOworICAgIGNhc2Ug TWlsbGlzZWNvbmQ6CisgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJTAyZDolMDJkOiUw MmQuJTAzZCIsIG1faG91ciwgbV9taW51dGUsIG1fc2Vjb25kLCBtX21pbGxpc2Vjb25kKTsKKyAg ICB9Cit9CisKK1N0cmluZyBJU09EYXRlVGltZTo6dG9TdHJpbmcoU2Vjb25kRm9ybWF0IGZvcm1h dCwgaW50IHR6T2Zmc2V0U2Vjb25kcykgY29uc3QKK3sKKyAgICBzd2l0Y2ggKG1fdHlwZSkgewor ICAgIGNhc2UgRGF0ZToKKyAgICAgICAgcmV0dXJuIFN0cmluZzo6Zm9ybWF0KCIlMDRkLSUwMmQt JTAyZCIsIG1feWVhciwgbV9tb250aCArIDEsIG1fbW9udGhEYXkpOworICAgIGNhc2UgRGF0ZVRp bWU6IHsKKyAgICAgICAgQVNTRVJUKCEodHpPZmZzZXRTZWNvbmRzICUgNjApICYmIGFicyh0ek9m ZnNldFNlY29uZHMpIDwgMjQgKiA2MCAqIDYwKTsKKyAgICAgICAgaWYgKCF0ek9mZnNldFNlY29u ZHMpIHsKKyAgICAgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJTA0ZC0lMDJkLSUwMmRU IiwgbV95ZWFyLCBtX21vbnRoICsgMSwgbV9tb250aERheSkKKyAgICAgICAgICAgICAgICArIHRv U3RyaW5nRm9yVGltZShmb3JtYXQpICsgU3RyaW5nKCJaIik7CisgICAgICAgIH0KKyAgICAgICAg Ly8gQ3JlYXRlcyBhIERhdGVUaW1lTG9jYWwgSVNPRGF0ZVRpbWUgd2l0aCBtaWxsaXNlY29uZHMg b2YKKyAgICAgICAgLy8gdGhpcyArIHR6T2Zmc2V0U2Vjb25kcywgdGhlbiBjb25jYXRlbmF0ZSB0 aGUgdG9TdHJpbmcoKSBmb3IgaXQgYW5kCisgICAgICAgIC8vIGEgdGltZXpvbmUgb2Zmc2V0IHN0 cmluZy4KKyAgICAgICAgSVNPRGF0ZVRpbWUgc2hpZnRlZDsKKyAgICAgICAgZG91YmxlIG1zID0g bWlsbGlzZWNvbmRzU2luY2VFcG9jaCgpICsgdHpPZmZzZXRTZWNvbmRzICogMTAwMC4wOworICAg ICAgICBpZiAoIXNoaWZ0ZWQuc2V0TWlsbGlzZWNvbmRzU2luY2VFcG9jaEZvckRhdGVUaW1lTG9j YWwobXMpKSB7CisgICAgICAgICAgICAvLyBJdCBjYW4gZmFpbCBpZiB0aGlzIElTT0RhdGVUaW1l IHJlcHJlc2VudHMgMTU4Mi0xMC0xNSBhbmQgdGhlCisgICAgICAgICAgICAvLyB0ek9mZnNldFNl Y29uZHMgaXMgbmVnYXRpdmUuIEluIHRoYXQgY2FzZSwgdGhlIGZ1bmN0aW9uIHJldHVybnMKKyAg ICAgICAgICAgIC8vIGEgc3RyaW5nIGluIHRoZSBVVEMgZm9ybWF0LgorICAgICAgICAgICAgcmV0 dXJuIHRvU3RyaW5nKGZvcm1hdCwgMCk7CisgICAgICAgIH0KKyAgICAgICAgaW50IHR6T2Zmc2V0 TWludXRlcyA9IGFicyh0ek9mZnNldFNlY29uZHMpIC8gNjA7CisgICAgICAgIHJldHVybiBzaGlm dGVkLnRvU3RyaW5nKGZvcm1hdCkKKyAgICAgICAgICAgICsgU3RyaW5nOjpmb3JtYXQodHpPZmZz ZXRTZWNvbmRzIDwgMCA/ICItJTAyZDolMDJkIiA6ICIrJTAyZDolMDJkIiwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdHpPZmZzZXRNaW51dGVzIC8gNjAsIHR6T2Zmc2V0TWludXRlcyAl IDYwKTsKKyAgICB9CisgICAgY2FzZSBEYXRlVGltZUxvY2FsOgorICAgICAgICByZXR1cm4gU3Ry aW5nOjpmb3JtYXQoIiUwNGQtJTAyZC0lMDJkVCIsIG1feWVhciwgbV9tb250aCArIDEsIG1fbW9u dGhEYXkpCisgICAgICAgICAgICArIHRvU3RyaW5nRm9yVGltZShmb3JtYXQpOworICAgIGNhc2Ug TW9udGg6CisgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJTA0ZC0lMDJkIiwgbV95ZWFy LCBtX21vbnRoICsgMSk7CisgICAgY2FzZSBUaW1lOgorICAgICAgICByZXR1cm4gdG9TdHJpbmdG b3JUaW1lKGZvcm1hdCk7CisgICAgY2FzZSBXZWVrOgorICAgICAgICByZXR1cm4gU3RyaW5nOjpm b3JtYXQoIiUwNGQtVyUwMmQiLCBtX3llYXIsIG1fd2Vlayk7CisgICAgZGVmYXVsdDoKKyAgICAg ICAgYnJlYWs7CisgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBT dHJpbmcoIihJbnZhbGlkIElTT0RhdGVUaW1lKSIpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSVNPRGF0ZVRpbWUuaCBiL1dlYkNvcmUvaHRt bC9JU09EYXRlVGltZS5oCmluZGV4IDE3YWE2NmYuLmNjM2Y3ZWUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9JU09EYXRlVGltZS5oCisrKyBiL1dlYkNvcmUvaHRtbC9JU09EYXRlVGltZS5oCkBA IC0zNiw2ICszNiw4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgU3RyaW5nOwor CiAvLyBBbiBJU09EYXRlVGltZSBpbnN0YW5jZSByZXByZXNlbnRzIG9uZSBvZiB0aGUgZm9sbG93 aW5nIGRhdGUgYW5kIHRpbWUgY29tYmluYXRpb25zOgogLy8gKiB5ZWFyLW1vbnRoCiAvLyAqIHll YXItbW9udGgtZGF5CkBAIC02Niw2ICs2OCwyMCBAQCBwdWJsaWM6CiAgICAgaW50IGZ1bGxZZWFy KCkgY29uc3QgeyByZXR1cm4gbV95ZWFyOyB9CiAgICAgaW50IHdlZWsoKSBjb25zdCB7IHJldHVy biBtX3dlZWs7IH0KIAorICAgIGVudW0gU2Vjb25kRm9ybWF0IHsKKyAgICAgICAgTm9uZSwgLy8g U3VwcHJlc3MgdGhlIHNlY29uZCBwYXJ0IGFuZCB0aGUgbWlsbGlzZWNvbmQgcGFydCBpZiB0aGV5 IGFyZSAwLgorICAgICAgICBTZWNvbmQsIC8vIEFsd2F5cyBzaG93IHRoZSBzZWNvbmQgcGFydCwg YW5kIHN1cHByZXNzIHRoZSBtaWxsaXNlY29uZCBwYXJ0IGlmIGl0IGlzIDAuCisgICAgICAgIE1p bGxpc2Vjb25kIC8vIEFsd2F5cyBzaG93IHRoZSBzZWNvbmQgcGFydCBhbmQgdGhlIG1pbGxpc2Vj b25kIHBhcnQuCisgICAgfTsKKyAgICAvLyBSZXR1cm5zIGFuIElTTyA4NjAxIHJlcHJlc2VudGF0 aW9uIGZvciB0aGlzIGluc3RhbmNlLgorICAgIC8vIFRoZSBmb3JtYXQgYXJndW1lbnQgaXMgdmFs aWQgZm9yIERhdGVUaW1lLCBEYXRlVGltZUxvY2FsLCBhbmQgVGltZSB0eXBlcy4KKyAgICAvLyBU aGUgdHpPZmZzZXRTZWNvbmRzIGFyZ3VtZW50IGlzIHZhbGlkIGZvciBEYXRlVGltZSB0eXBlLiBJ dAorICAgIC8vIG11c3QgYmUgYSBtdWx0aXBsZSBvZiA2MCwgYW5kIG11c3QgYmUgaW4gYSByYW5n ZSBvZiAtMjM6NTk6MDAKKyAgICAvLyB0byArMjM6NTk6MDAuIElmIHlvdSBuZWVkIGEgc3RyaW5n IGZvciB0aGlzIGluc3RhbmNlIGluIEpTVCwKKyAgICAvLyB5b3Ugc2hvdWxkIHNwZWNpZnkgMzI0 MDAgKDkgKiA2MCAqIDYwKS4gSWYgeW91IG5lZWQgYSBzdHJpbmcgaW4KKyAgICAvLyBQU1QsIHlv dSBzaG91bGQgc3BlY2lmeSAtMjg4MDAgKC04ICogNjAgKiA2MCkuCisgICAgU3RyaW5nIHRvU3Ry aW5nKFNlY29uZEZvcm1hdCBmb3JtYXQgPSBOb25lLCBpbnQgdHpPZmZzZXRTZWNvbmRzID0gMCkg Y29uc3Q7CisKICAgICAvLyBUaGUgZm9sbG93aW5nIHNpeCBmdW5jdGlvbnMgcGFyc2UgdGhlIGlu cHV0IGBzcmMnIHdob3NlIGxlbmd0aCBpcwogICAgIC8vIGBsZW5ndGgnLCBhbmQgdXBkYXRlcyBz b21lIGZpZWxkcyBvZiB0aGlzIGluc3RhbmNlLiBUaGUgcGFyc2luZyBzdGFydHMgYXQKICAgICAv LyBzcmNbc3RhcnRdIGFuZCBleGFtaW5lcyBjaGFyYWN0ZXJzIGJlZm9yZSBzcmNbbGVuZ3RoXS4K QEAgLTExNyw2ICsxMzMsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGlubGluZSBkb3VibGUgaW52 YWxpZE1pbGxpc2Vjb25kcygpIHsgcmV0dXJuIHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91YmxlPjo6 cXVpZXRfTmFOKCk7IH0KIAogcHJpdmF0ZToKKyAgICAvLyBIZWxwZXIgZm9yIHRvU3RyaW5nKCku CisgICAgU3RyaW5nIHRvU3RyaW5nRm9yVGltZShTZWNvbmRGb3JtYXQgZm9ybWF0KSBjb25zdDsK ICAgICAvLyBSZXR1cm5zIHRoZSBtYXhpbXVtIHdlZWsgbnVtYmVyIGluIHRoaXMgSVNPRGF0ZVRp bWUncyB5ZWFyLgogICAgIC8vIFRoZSByZXN1bHQgaXMgZWl0aGVyIG9mIDUyIGFuZCA1My4KICAg ICBpbnQgbWF4V2Vla051bWJlckluWWVhcigpIGNvbnN0OwotLSAKMS42LjMuMwoK