32858 2009-12-22 01:12:37 -0800 check-webkit-style should not warn about NULL usage in g_object_{get,set} 2009-12-22 13:19:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned commit-queue eric hamaji levin webkit.review.bot oldest_to_newest 174222 0 pnormand 2009-12-22 01:12:37 -0800 If those 2 functions are called with 0 instead of NULL the compiler warns: warning: missing sentinel in function call 174231 1 45375 pnormand 2009-12-22 01:41:20 -0800 Created attachment 45375 proposed patch 174232 2 webkit.review.bot 2009-12-22 01:43:18 -0800 style-queue ran check-webkit-style on attachment 45375 without any errors. 174351 3 45375 abarth 2009-12-22 13:09:25 -0800 Comment on attachment 45375 proposed patch Thanks for quashing this false positive. 174356 4 45375 commit-queue 2009-12-22 13:18:57 -0800 Comment on attachment 45375 proposed patch Clearing flags on attachment: 45375 Committed r52496: <http://trac.webkit.org/changeset/52496> 174357 5 commit-queue 2009-12-22 13:19:02 -0800 All reviewed patches have been landed. Closing bug. 45375 2009-12-22 01:41:20 -0800 2009-12-22 13:18:57 -0800 proposed patch proposed-patch.patch text/plain 2488 pnormand RnJvbSBkYjVjYTI5YTVjZDdiN2UzZjgxYjRmYzUzMDA1N2I4NTExMzA1Y2ZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDIyIERlYyAyMDA5IDEwOjQwOjU5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NwcF9zdHlsZS5weSAgICAgICAgICB8ICAgIDUgKysrKysKIFdlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkgfCAgICA4ICsrKysrKysrCiAzIGZpbGVz IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDc4YmE4 ZDMuLmVkOWU0YTMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMi0yMiAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBub3Qgd2Fy biBhYm91dCBOVUxMIHVzYWdlIGluIGdfb2JqZWN0X3tnZXQsc2V0fQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI4NTgKKworICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGUucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9z dHlsZV91bml0dGVzdC5weToKKwogMjAwOS0xMi0yMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKaW5kZXggYzM1NTAwMS4uNzM2MWYyNSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CkBAIC0yMTAzLDYgKzIxMDMsMTEg QEAgZGVmIGNoZWNrX2Zvcl9udWxsKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIs IGVycm9yKToKICAgICAgICAgcmV0dXJuCiAKICAgICBsaW5lID0gY2xlYW5fbGluZXMuZWxpZGVk W2xpbmVfbnVtYmVyXQorCisgICAgIyBEb24ndCB3YXJuIGFib3V0IE5VTEwgdXNhZ2UgaW4gZ19v YmplY3Rfe2dldCxzZXR9KCkuIFNlZSBCdWcgMzI4NTgKKyAgICBpZiBzZWFyY2gocidcYmdfb2Jq ZWN0X1tzZ11ldFxiJywgbGluZSk6CisgICAgICAgIHJldHVybgorCiAgICAgaWYgc2VhcmNoKHIn XGJOVUxMXGInLCBsaW5lKToKICAgICAgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCAn cmVhZGFiaWxpdHkvbnVsbCcsIDUsICdVc2UgMCBpbnN0ZWFkIG9mIE5VTEwuJykKICAgICAgICAg cmV0dXJuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxl X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0 dGVzdC5weQppbmRleCA1ZTAzZGY1Li4yNTU4ZjE4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKQEAgLTM0OTQsNiArMzQ5NCwxNCBA QCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAn JywKICAgICAgICAgICAgICdmb28ubScpCiAKKyAgICAgICAgIyBNYWtlIHN1cmUgdGhhdCB0aGUg TlVMTCBjaGVjayBkb2VzIG5vdCBhcHBseSB0byBnX29iamVjdF97c2V0LGdldH0KKyAgICAgICAg c2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdnX29iamVjdF9nZXQoZm9vLCAicHJvcCIs ICZiYXIsIE5VTEwpOycsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgKKyAgICAgICAgICAgICdnX29iamVjdF9zZXQoZm9vLCAicHJvcCIsIGJhciwgTlVMTCk7JywK KyAgICAgICAgICAgICcnKQorCiAgICAgICAgICMgMi4gQysrIGFuZCBDIGJvb2wgdmFsdWVzIHNo b3VsZCBiZSB3cml0dGVuIGFzIHRydWUgYW5kCiAgICAgICAgICMgICAgZmFsc2UuIE9iamVjdGl2 ZS1DIEJPT0wgdmFsdWVzIHNob3VsZCBiZSB3cml0dGVuIGFzIFlFUyBhbmQgTk8uCiAgICAgICAg ICMgRklYTUU6IEltcGxlbWVudCB0aGlzLgotLSAKMS42LjMuMw==