32725 2009-12-18 10:56:21 -0800 webkit-patch needs a module which supports better ChangeLog parsing 2010-04-01 23:16:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 26533 26755 1 eric webkit-unassigned webkit.review.bot oldest_to_newest 173222 0 eric 2009-12-18 10:56:21 -0800 bugzilla-tool needs a module which supports better ChangeLog parsing It's not actually specific to bugzilla-tool. There are numerous times when we want to be able to parse ChangeLogs to get information from them, or to edit them, etc. I'll attach a work in progress patch I wrote. 173233 1 45164 eric 2009-12-18 11:35:31 -0800 Created attachment 45164 Work in progress 173235 2 45164 eric 2009-12-18 11:36:28 -0800 Comment on attachment 45164 Work in progress Forgot to pass --no-review, sorry. 173236 3 webkit.review.bot 2009-12-18 11:36:37 -0800 style-queue ran check-webkit-style on attachment 45164 without any errors. 207696 4 eric 2010-04-01 23:16:47 -0700 A variant of this has since landed. 45164 2009-12-18 11:35:31 -0800 2009-12-18 11:36:27 -0800 Work in progress bug-32725-20091218133529.patch text/plain 7686 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jaGFuZ2Vsb2dzLnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxvZ3MucHkKaW5kZXggYTQwN2QyMy4u ODBjODViZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxv Z3MucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxvZ3MucHkKQEAg LTI4LDYgKzI4LDggQEAKICMKICMgV2ViS2l0J3MgUHl0aG9uIG1vZHVsZSBmb3IgcGFyc2luZyBh bmQgbW9kaWZ5aW5nIENoYW5nZUxvZyBmaWxlcwogCitmcm9tIF9fZnV0dXJlX18gaW1wb3J0IHdp dGhfc3RhdGVtZW50CisKIGltcG9ydCBmaWxlaW5wdXQgIyBpbnBsYWNlIGZpbGUgZWRpdGluZyBm b3Igc2V0X3Jldmlld2VyX2luX2NoYW5nZWxvZwogaW1wb3J0IHJlCiAKQEAgLTM3LDcgKzM5LDI3 IEBAIGRlZiB2aWV3X3NvdXJjZV91cmwocmV2aXNpb25fbnVtYmVyKToKICAgICByZXR1cm4gImh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LyVzIiAlIHJldmlzaW9uX251bWJlcgogCiAK LWNsYXNzIENoYW5nZUxvZzoKK2NsYXNzIENoYW5nZUxvZ0VudHJ5KG9iamVjdCk6CisgICAgZGVm IF9faW5pdF9fKHNlbGYsIGNvbnRlbnRzLCBmaWxlX25hbWU9Tm9uZSwgc3RhcnRfbGluZT1Ob25l LCBlbmRfbGluZT1Ob25lKToKKyAgICAgICAgc2VsZi5jb250ZW50cyA9IGNvbnRlbnRzCisgICAg ICAgIHNlbGYuc3RhcnRfbGluZSA9IHN0YXJ0X2xpbmUKKyAgICAgICAgc2VsZi5lbmRfbGluZSA9 IGVuZF9saW5lCisgICAgICAgIHNlbGYuZmlsZV9uYW1lID0gZmlsZV9uYW1lCisgICAgICAgIHNl bGYuX3BhcnNlX2Zyb21fY29udGVudHMoc2VsZi5jb250ZW50cykKKworICAgIGRlZiBfcGFyc2Vf ZnJvbV9jb250ZW50cyhzZWxmLCBjb250ZW50cyk6CisgICAgICAgIHNlbGYuZGF0ZV9zdHJpbmcg PSBOb25lCisgICAgICAgIHNlbGYuYXV0aG9yX25hbWUgPSBOb25lCisgICAgICAgIHNlbGYuYXV0 aG9yX2VtYWlsID0gTm9uZQorICAgICAgICBzZWxmLnJldmlld2VyID0gTm9uZQorICAgICAgICBz ZWxmLmZpbGVfcGF0aHMgPSBOb25lCisgICAgICAgIHNlbGYuYnVnX3VybCA9IE5vbmUKKworICAg IGRlZiBfX3N0cl9fKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5jb250ZW50cworCisKK2Ns YXNzIENoYW5nZUxvZyhvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwYXRoKToKICAg ICAgICAgc2VsZi5wYXRoID0gcGF0aAogCkBAIC00NiwyOCArNjgsMzUgQEAgY2xhc3MgQ2hhbmdl TG9nOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICArICdccysoLispXHMrJyAjIENv bnN1bWUgdGhlIG5hbWUuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICsgJzwoW148 Pl0rKT4kJykgIyBBbmQgZmluYWxseSB0aGUgZW1haWwgYWRkcmVzcy4KIAotICAgIEBzdGF0aWNt ZXRob2QKLSAgICBkZWYgX3BhcnNlX2xhdGVzdF9lbnRyeV9mcm9tX2ZpbGUoY2hhbmdlbG9nX2Zp bGUpOgotICAgICAgICBlbnRyeV9saW5lcyA9IFtdCi0gICAgICAgICMgVGhlIGZpcnN0IGxpbmUg c2hvdWxkIGJlIGEgZGF0ZSBsaW5lLgotICAgICAgICBmaXJzdF9saW5lID0gY2hhbmdlbG9nX2Zp bGUucmVhZGxpbmUoKQotICAgICAgICBpZiBub3QgQ2hhbmdlTG9nLmRhdGVfbGluZV9yZWdleHAu bWF0Y2goZmlyc3RfbGluZSk6Ci0gICAgICAgICAgICByZXR1cm4gTm9uZQotICAgICAgICBlbnRy eV9saW5lcy5hcHBlbmQoZmlyc3RfbGluZSkKLQotICAgICAgICBmb3IgbGluZSBpbiBjaGFuZ2Vs b2dfZmlsZToKLSAgICAgICAgICAgICMgSWYgd2UndmUgaGl0IHRoZSBuZXh0IGVudHJ5LCByZXR1 cm4uCi0gICAgICAgICAgICBpZiBDaGFuZ2VMb2cuZGF0ZV9saW5lX3JlZ2V4cC5tYXRjaChsaW5l KToKLSAgICAgICAgICAgICAgICByZXR1cm4gJycuam9pbihlbnRyeV9saW5lc1s6LTFdKSAjIFJl bW92ZSB0aGUgZXh0cmEgbmV3bGluZSBhdCB0aGUgZW5kCi0gICAgICAgICAgICBlbnRyeV9saW5l cy5hcHBlbmQobGluZSkKLSAgICAgICAgcmV0dXJuIE5vbmUgIyBXZSBuZXZlciBmb3VuZCBhIGRh dGUgbGluZSEKKyAgICBkZWYgZW50cmllcyhzZWxmLCBvdmVycmlkZV9maWxlPU5vbmUpOgorICAg ICAgICAjIGNoYW5nZWxvZ19maWxlIGFsbG93cyBmb3IgZWFzeSB0ZXN0aW5nCisgICAgICAgIGlm IG92ZXJyaWRlX2ZpbGU6CisgICAgICAgICAgICBjaGFuZ2Vsb2dfZmlsZSA9IG92ZXJyaWRlX2Zp bGUKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIGNoYW5nZWxvZ19maWxlID0gb3BlbihzZWxm LnBhdGgpCiAKLSAgICBkZWYgbGF0ZXN0X2VudHJ5KHNlbGYpOgotICAgICAgICBjaGFuZ2Vsb2df ZmlsZSA9IG9wZW4oc2VsZi5wYXRoKQogICAgICAgICB0cnk6Ci0gICAgICAgICAgICByZXR1cm4g c2VsZi5fcGFyc2VfbGF0ZXN0X2VudHJ5X2Zyb21fZmlsZShjaGFuZ2Vsb2dfZmlsZSkKKyAgICAg ICAgICAgICMgVGhlIGZpcnN0IGxpbmUgc2hvdWxkIGJlIGEgZGF0ZSBsaW5lLgorICAgICAgICAg ICAgZmlyc3RfbGluZSA9IGNoYW5nZWxvZ19maWxlLnJlYWRsaW5lKCkKKyAgICAgICAgICAgIGlm IG5vdCBDaGFuZ2VMb2cuZGF0ZV9saW5lX3JlZ2V4cC5tYXRjaChmaXJzdF9saW5lKToKKyAgICAg ICAgICAgICAgICByZXR1cm4KKworICAgICAgICAgICAgZW50cnlfbGluZXMgPSBbZmlyc3RfbGlu ZV0KKyAgICAgICAgICAgIGZvciBsaW5lIGluIGNoYW5nZWxvZ19maWxlOgorICAgICAgICAgICAg ICAgICMgSWYgd2UndmUgaGl0IHRoZSBuZXh0IGVudHJ5LCByZXR1cm4gaXQgYW5kIHN0YXJ0IG92 ZXIuCisgICAgICAgICAgICAgICAgaWYgQ2hhbmdlTG9nLmRhdGVfbGluZV9yZWdleHAubWF0Y2go bGluZSk6CisgICAgICAgICAgICAgICAgICAgIHlpZWxkIENoYW5nZUxvZ0VudHJ5KCcnLmpvaW4o ZW50cnlfbGluZXNbOi0xXSkpICMgUmV0dXJuIGFuIGVudHJ5LCByZW1vdmluZyB0aGUgZXh0cmEg XG4gYmV0d2VlbiBlbnRyaWVzLgorICAgICAgICAgICAgICAgICAgICBlbnRyeV9saW5lcyA9IFtd CisgICAgICAgICAgICAgICAgZW50cnlfbGluZXMuYXBwZW5kKGxpbmUpCisKKyAgICAgICAgICAg ICMgV2UgY291bGQgYXR0ZW1wdCB0byBpZ25vcmUgdGhlICJyb2xsZWQgb3ZlciIgbWVzc2FnZXMg YXQgdGhlIGVuZCBvZiBzb21lIENoYW5nZUxvZyBmaWxlcy4KKyAgICAgICAgICAgIHlpZWxkIENo YW5nZUxvZ0VudHJ5KCcnLmpvaW4oZW50cnlfbGluZXMpKQogICAgICAgICBmaW5hbGx5OgotICAg ICAgICAgICAgY2hhbmdlbG9nX2ZpbGUuY2xvc2UoKQorICAgICAgICAgICAgaWYgbm90IG92ZXJy aWRlX2ZpbGU6CisgICAgICAgICAgICAgICAgY2hhbmdlbG9nX2ZpbGUuY2xvc2UoKQorCisgICAg ZGVmIGxhdGVzdF9lbnRyeShzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYuZW50cmllcygpLm5l eHQoKQogCiAgICAgZGVmIHVwZGF0ZV9mb3JfcmV2ZXJ0KHNlbGYsIHJldmlzaW9uKToKICAgICAg ICAgcmV2aWV3ZWRfYnlfcmVnZXhwID0gcmUuY29tcGlsZSgnUmV2aWV3ZWQgYnkgTk9CT0RZIFwo T09QUyFcKVwuJykKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jaGFu Z2Vsb2dzX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxv Z3NfdW5pdHRlc3QucHkKaW5kZXggZGQxNGNiNy4uNWExNzBiZSAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxvZ3NfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NoYW5nZWxvZ3NfdW5pdHRlc3QucHkKQEAgLTUwLDcgKzUw LDcgQEAgY2xhc3MgQ2hhbmdlTG9nc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogJycnCiAKICAg ICAjIE1vcmUgZXhhbXBsZSB0ZXh0IHRoYW4gd2UgbmVlZC4gIEV2ZW50dWFsbHkgd2UgbmVlZCB0 byBzdXBwb3J0IHBhcnNpbmcgdGhpcyBhbGwgYW5kIHdyaXRlIHRlc3RzIGZvciB0aGUgcGFyc2lu Zy4KLSAgICBfZXhhbXBsZV9jaGFuZ2Vsb2cgPSAnJycyMDA5LTA4LTE3ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CisgICAgX2V4YW1wbGVfZW50cnkyID0gIiIiMjAwOS0wOC0x NyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8v d2Via2l0Lm9yZy9iLzI4MzkzPiBjaGVjay13ZWJraXQtc3R5bGU6IGFkZCBjaGVjayBmb3IgdXNl IG9mIHN0ZDo6bWF4KCkvc3RkOjptaW4oKSBpbnN0ZWFkIG9mIE1BWCgpL01JTigpCiAKQEAgLTY0 LDE1ICs2NCwxNSBAQCBjbGFzcyBDaGFuZ2VMb2dzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAg ICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weTogQWRkZWQgdW5p dCB0ZXN0cy4KICAgICAgICAgKHRlc3RfbWF4X21hY3JvKTogQWRkZWQuCiAgICAgICAgICh0ZXN0 X21pbl9tYWNybyk6IEFkZGVkLgotCi0yMDA5LTA4LTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CisiIiIKKyAgICBfZXhhbXBsZV9lbnRyeTMgPSAiIiIyMDA5LTA4LTE2ICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQmFja2VkIG91dCBy NDczNDMgd2hpY2ggd2FzIG1pc3Rha2VubHkgY29tbWl0dGVkCiAKICAgICAgICAgKiBTY3JpcHRz L2J1Z3ppbGxhLXRvb2w6CiAgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL3NjbS5weToKLQotMjAw OS0wNi0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisiIiIKKyAgICBfZXhhbXBs ZV9lbnRyeTQgPSAiIiIyMDA5LTA2LTE4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4K IAogICAgICAgICBSdWJiZXIgc3RhbXBlZCBieSBNYXJrIFJvd2UuCiAKQEAgLTgwLDE1ICs4MCwz MyBAQCBjbGFzcyBDaGFuZ2VMb2dzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICgt W0R1bXBSZW5kZXJUcmVlV2luZG93IGNsb3NlXSk6IFJlc29sdmVkIGNyYXNoZXMgc2VlbiBkdXJp bmcgcmVncmVzc2lvbgogICAgICAgICB0ZXN0cy4gVGhlIGNsb3NlIG1ldGhvZCBjYW4gYmUgY2Fs bGVkIG9uIGEgd2luZG93IHRoYXQncyBhbHJlYWR5IGNsb3NlZAogICAgICAgICBzbyB3ZSBjYW4n dCBhc3NlcnQgaGVyZS4KKyIiIgorICAgIF9yb2xsb3Zlcl90YWcgPSAiPT0gUm9sbGVkIG92ZXIg dG8gQ2hhbmdlTG9nLTIwMDktMDYtMTYgPT1cbiIKIAotPT0gUm9sbGVkIG92ZXIgdG8gQ2hhbmdl TG9nLTIwMDktMDYtMTYgPT0KLScnJworICAgIF9leGFtcGxlX2NoYW5nZWxvZyA9ICJcbiIuam9p bihbCisgICAgICAgIF9leGFtcGxlX2VudHJ5LAorICAgICAgICBfZXhhbXBsZV9lbnRyeTIsCisg ICAgICAgIF9leGFtcGxlX2VudHJ5MywKKyAgICAgICAgX2V4YW1wbGVfZW50cnk0LAorICAgICAg ICBfcm9sbG92ZXJfdGFnLAorICAgIF0pCiAKICAgICBkZWYgdGVzdF9sYXRlc3RfZW50cnlfcGFy c2Uoc2VsZik6Ci0gICAgICAgIGNoYW5nZWxvZ19jb250ZW50cyA9ICIlc1xuJXMiICUgKHNlbGYu X2V4YW1wbGVfZW50cnksIHNlbGYuX2V4YW1wbGVfY2hhbmdlbG9nKQotICAgICAgICBjaGFuZ2Vs b2dfZmlsZSA9IFN0cmluZ0lPKGNoYW5nZWxvZ19jb250ZW50cykKLSAgICAgICAgbGF0ZXN0X2Vu dHJ5ID0gQ2hhbmdlTG9nLl9wYXJzZV9sYXRlc3RfZW50cnlfZnJvbV9maWxlKGNoYW5nZWxvZ19m aWxlKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhzZWxmLl9leGFtcGxlX2VudHJ5LCBsYXRl c3RfZW50cnkpCisgICAgICAgIGNoYW5nZWxvZ19maWxlID0gU3RyaW5nSU8oc2VsZi5fZXhhbXBs ZV9jaGFuZ2Vsb2cpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHNlbGYuX2V4YW1wbGVfZW50 cnksIENoYW5nZUxvZygiL2RvZXNfbm90X2V4aXN0IikuZW50cmllcyhjaGFuZ2Vsb2dfZmlsZSku bmV4dCgpLmNvbnRlbnRzKQorCisgICAgZGVmIHRlc3RfZW50cnlfcGFyc2Uoc2VsZik6CisgICAg ICAgIGVudHJ5ID0gQ2hhbmdlTG9nRW50cnkoc2VsZi5fZXhhbXBsZV9lbnRyeSkKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMoZW50cnkuZGF0ZV9zdHJpbmcsICIyMDA5LTA4LTE3IikKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbHMoZW50cnkuYXV0aG9yX25hbWUsICJQZXRlciBLYXN0aW5nIikK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZW50cnkuYXV0aG9yX2VtYWlsLCAicGthc3RpbmdA Z29vZ2xlLmNvbSIpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGVudHJ5LnJldmlld2VyX25h bWUsICJTdGV2ZSBGYWxrZW5idXJnIikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZW50cnku ZmlsZV9wYXRocywgWworICAgICAgICAgICAgIkR1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVy VHJlZS52Y3Byb2oiLAorICAgICAgICAgICAgIkR1bXBSZW5kZXJUcmVlL3dpbi9JbWFnZURpZmYu dmNwcm9qIiwKKyAgICAgICAgICAgICJEdW1wUmVuZGVyVHJlZS93aW4vVGVzdE5ldHNjYXBlUGx1 Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi52Y3Byb2oiCisgICAgICAgIF0pCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKGVudHJ5LmJ1Z191cmwsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjczMjMiKQogCiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBfd3JpdGVf dG1wX2ZpbGVfd2l0aF9jb250ZW50cyhjb250ZW50cyk6CkBAIC0xMDUsMTQgKzEyMywxNCBAQCBj bGFzcyBDaGFuZ2VMb2dzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGZpbGUuY2xv c2UoKQogICAgICAgICByZXR1cm4gY29udGVudHMKIAotICAgIF9uZXdfZW50cnlfYm9pbGVycGxh dGUgPSAnJycyMDA5LTA4LTE5ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKyAgICBf bmV3X2VudHJ5X2JvaWxlcnBsYXRlID0gIiIiMjAwOS0wOC0xOSAgRXJpYyBTZWlkZWwgIDxlcmlj QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKICAg ICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKIAogICAg ICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoKLScnJworIiIiCiAKICAgICBkZWYgdGVzdF9z ZXRfcmV2aWV3ZXIoc2VsZik6CiAgICAgICAgIGNoYW5nZWxvZ19jb250ZW50cyA9ICIlc1xuJXMi ICUgKHNlbGYuX25ld19lbnRyeV9ib2lsZXJwbGF0ZSwgc2VsZi5fZXhhbXBsZV9jaGFuZ2Vsb2cp CkBAIC0xMzksNyArMTU3LDcgQEAgY2xhc3MgQ2hhbmdlTG9nc1Rlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICAgICBjaGFuZ2Vsb2cudXBkYXRlX2Zvcl9yZXZlcnQoMTIzNDUpCiAgICAgICAg IGFjdHVhbF9lbnRyeSA9IGNoYW5nZWxvZy5sYXRlc3RfZW50cnkoKQogICAgICAgICBvcy5yZW1v dmUoY2hhbmdlbG9nX3BhdGgpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGFjdHVhbF9lbnRy eSwgc2VsZi5fZXhwZWN0ZWRfcmV2ZXJ0X2VudHJ5KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFs cyhhY3R1YWxfZW50cnkuY29udGVudHMsIHNlbGYuX2V4cGVjdGVkX3JldmVydF9lbnRyeSkKIAog aWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5tYWluKCkK